All of lore.kernel.org
 help / color / mirror / Atom feed
From: James Clark <james.clark@arm.com>
To: Arnaldo Carvalho de Melo <acme@kernel.org>,
	Mathieu Poirier <mathieu.poirier@linaro.org>
Cc: coresight@lists.linaro.org, al.grant@arm.com,
	branislav.rankov@arm.com, denik@chromium.org,
	suzuki.poulose@arm.com, Mike Leach <mike.leach@linaro.org>,
	Leo Yan <leo.yan@linaro.org>, Mark Rutland <mark.rutland@arm.com>,
	Alexander Shishkin <alexander.shishkin@linux.intel.com>,
	Jiri Olsa <jolsa@redhat.com>, Namhyung Kim <namhyung@kernel.org>,
	John Garry <john.garry@huawei.com>, Will Deacon <will@kernel.org>,
	linux-arm-kernel@lists.infradead.org,
	linux-perf-users@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH v2 0/2] perf cs-etm: Set time on synthesised samples to preserve ordering
Date: Mon, 19 Apr 2021 11:18:31 +0300	[thread overview]
Message-ID: <c3a75731-15b4-e052-1840-a881b05862df@arm.com> (raw)
In-Reply-To: <YHmqZKGMFydbsvEy@kernel.org>



On 16/04/2021 18:16, Arnaldo Carvalho de Melo wrote:
> Em Fri, Apr 16, 2021 at 09:07:09AM -0600, Mathieu Poirier escreveu:
>> Hi James,
>>
>> On Fri, Apr 16, 2021 at 01:56:30PM +0300, James Clark wrote:
>>> Changes since v1:
>>>  * Improved variable name from etm_timestamp -> cs_timestamp
>>>  * Fixed ordering of Signed-off-by
>>>
>>
>> You forgot to add the RB and AB you received.  Since Arnaldo is responsible for
>> the perf tools subsystem, please send another revision.
>  
> 
> 
> Yep, please collect Reported-by and Acked-by as you go sending new
> versions of a patchset, the last one I don't have a problem collecting
> myself, but if you have to resend, please collect the feedback tags.
> 
> - Arnaldo
> 

Ok thanks, I will keep that in mind for the future. I wasn't sure if they still
applied or not as it was a new version.

Thanks
James

>> Thanks,
>> Mathieu
>>
>>> James Clark (2):
>>>   perf cs-etm: Refactor timestamp variable names
>>>   perf cs-etm: Set time on synthesised samples to preserve ordering
>>>
>>>  .../perf/util/cs-etm-decoder/cs-etm-decoder.c | 18 +++----
>>>  tools/perf/util/cs-etm.c                      | 52 ++++++++++---------
>>>  tools/perf/util/cs-etm.h                      |  4 +-
>>>  3 files changed, 39 insertions(+), 35 deletions(-)
>>>
>>> -- 
>>> 2.28.0
>>>
> 

WARNING: multiple messages have this Message-ID (diff)
From: James Clark <james.clark@arm.com>
To: Arnaldo Carvalho de Melo <acme@kernel.org>,
	Mathieu Poirier <mathieu.poirier@linaro.org>
Cc: coresight@lists.linaro.org, al.grant@arm.com,
	branislav.rankov@arm.com, denik@chromium.org,
	suzuki.poulose@arm.com, Mike Leach <mike.leach@linaro.org>,
	Leo Yan <leo.yan@linaro.org>, Mark Rutland <mark.rutland@arm.com>,
	Alexander Shishkin <alexander.shishkin@linux.intel.com>,
	Jiri Olsa <jolsa@redhat.com>, Namhyung Kim <namhyung@kernel.org>,
	John Garry <john.garry@huawei.com>, Will Deacon <will@kernel.org>,
	linux-arm-kernel@lists.infradead.org,
	linux-perf-users@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH v2 0/2] perf cs-etm: Set time on synthesised samples to preserve ordering
Date: Mon, 19 Apr 2021 11:18:31 +0300	[thread overview]
Message-ID: <c3a75731-15b4-e052-1840-a881b05862df@arm.com> (raw)
In-Reply-To: <YHmqZKGMFydbsvEy@kernel.org>



On 16/04/2021 18:16, Arnaldo Carvalho de Melo wrote:
> Em Fri, Apr 16, 2021 at 09:07:09AM -0600, Mathieu Poirier escreveu:
>> Hi James,
>>
>> On Fri, Apr 16, 2021 at 01:56:30PM +0300, James Clark wrote:
>>> Changes since v1:
>>>  * Improved variable name from etm_timestamp -> cs_timestamp
>>>  * Fixed ordering of Signed-off-by
>>>
>>
>> You forgot to add the RB and AB you received.  Since Arnaldo is responsible for
>> the perf tools subsystem, please send another revision.
>  
> 
> 
> Yep, please collect Reported-by and Acked-by as you go sending new
> versions of a patchset, the last one I don't have a problem collecting
> myself, but if you have to resend, please collect the feedback tags.
> 
> - Arnaldo
> 

Ok thanks, I will keep that in mind for the future. I wasn't sure if they still
applied or not as it was a new version.

Thanks
James

>> Thanks,
>> Mathieu
>>
>>> James Clark (2):
>>>   perf cs-etm: Refactor timestamp variable names
>>>   perf cs-etm: Set time on synthesised samples to preserve ordering
>>>
>>>  .../perf/util/cs-etm-decoder/cs-etm-decoder.c | 18 +++----
>>>  tools/perf/util/cs-etm.c                      | 52 ++++++++++---------
>>>  tools/perf/util/cs-etm.h                      |  4 +-
>>>  3 files changed, 39 insertions(+), 35 deletions(-)
>>>
>>> -- 
>>> 2.28.0
>>>
> 

_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel

  reply	other threads:[~2021-04-19  8:18 UTC|newest]

Thread overview: 12+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-04-16 10:56 [PATCH v2 0/2] perf cs-etm: Set time on synthesised samples to preserve ordering James Clark
2021-04-16 10:56 ` James Clark
2021-04-16 10:56 ` [PATCH v2 2/2] " James Clark
2021-04-16 10:56   ` James Clark
2021-04-16 10:56 ` [PATCH v2 1/2] perf cs-etm: Refactor timestamp variable names James Clark
2021-04-16 10:56   ` James Clark
2021-04-16 15:07 ` [PATCH v2 0/2] perf cs-etm: Set time on synthesised samples to preserve ordering Mathieu Poirier
2021-04-16 15:07   ` Mathieu Poirier
2021-04-16 15:16   ` Arnaldo Carvalho de Melo
2021-04-16 15:16     ` Arnaldo Carvalho de Melo
2021-04-19  8:18     ` James Clark [this message]
2021-04-19  8:18       ` James Clark

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=c3a75731-15b4-e052-1840-a881b05862df@arm.com \
    --to=james.clark@arm.com \
    --cc=acme@kernel.org \
    --cc=al.grant@arm.com \
    --cc=alexander.shishkin@linux.intel.com \
    --cc=branislav.rankov@arm.com \
    --cc=coresight@lists.linaro.org \
    --cc=denik@chromium.org \
    --cc=john.garry@huawei.com \
    --cc=jolsa@redhat.com \
    --cc=leo.yan@linaro.org \
    --cc=linux-arm-kernel@lists.infradead.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-perf-users@vger.kernel.org \
    --cc=mark.rutland@arm.com \
    --cc=mathieu.poirier@linaro.org \
    --cc=mike.leach@linaro.org \
    --cc=namhyung@kernel.org \
    --cc=suzuki.poulose@arm.com \
    --cc=will@kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.