All of lore.kernel.org
 help / color / mirror / Atom feed
From: Markus Elfring <Markus.Elfring@web.de>
To: iommu@lists.linux-foundation.org,
	linux-arm-kernel@lists.infradead.org,
	linux-rockchip@lists.infradead.org,
	"Heiko Stübner" <heiko@sntech.de>, "Jörg Rödel" <joro@8bytes.org>
Cc: LKML <linux-kernel@vger.kernel.org>,
	kernel-janitors@vger.kernel.org,
	"Rafael J. Wysocki" <rafael@kernel.org>,
	Aditya Pakki <pakki001@umn.edu>, Kangjie Lu <kjlu@umn.edu>,
	Navid Emamdoost <emamd001@umn.edu>,
	Stephen McCamant <smccaman@umn.edu>
Subject: iommu/rockchip: Checking a device_link_add() call in rk_iommu_add_device()
Date: Fri, 18 Oct 2019 09:00:14 +0200	[thread overview]
Message-ID: <c4a1fdd2-4383-dd0f-1d4b-f27ab62b383e@web.de> (raw)

Hello,

I tried another script for the semantic patch language out.
This source code analysis approach points out that the implementation
of the function “rk_iommu_add_device” contains still
an unchecked call of the function “device_link_add”.
https://git.kernel.org/pub/scm/linux/kernel/git/next/linux-next.git/tree/drivers/iommu/rockchip-iommu.c?id=3ef845da3c3b180ddd386e228ac3228d84a522d3#n1075
https://elixir.bootlin.com/linux/v5.4-rc2/source/drivers/iommu/rockchip-iommu.c#L1071

How do you think about to improve it?

Which error code would you like to return for a failed
device link addition at this place?

Regards,
Markus

WARNING: multiple messages have this Message-ID (diff)
From: Markus Elfring <Markus.Elfring@web.de>
To: iommu@lists.linux-foundation.org,
	linux-arm-kernel@lists.infradead.org,
	linux-rockchip@lists.infradead.org,
	"Heiko Stübner" <heiko@sntech.de>, "Jörg Rödel" <joro@8bytes.org>
Cc: "Rafael J. Wysocki" <rafael@kernel.org>,
	kernel-janitors@vger.kernel.org,
	Stephen McCamant <smccaman@umn.edu>, Kangjie Lu <kjlu@umn.edu>,
	LKML <linux-kernel@vger.kernel.org>,
	Navid Emamdoost <emamd001@umn.edu>,
	Aditya Pakki <pakki001@umn.edu>
Subject: iommu/rockchip: Checking a device_link_add() call in rk_iommu_add_device()
Date: Fri, 18 Oct 2019 07:00:14 +0000	[thread overview]
Message-ID: <c4a1fdd2-4383-dd0f-1d4b-f27ab62b383e@web.de> (raw)

Hello,

I tried another script for the semantic patch language out.
This source code analysis approach points out that the implementation
of the function “rk_iommu_add_device” contains still
an unchecked call of the function “device_link_add”.
https://git.kernel.org/pub/scm/linux/kernel/git/next/linux-next.git/tree/drivers/iommu/rockchip-iommu.c?id=3ef845da3c3b180ddd386e228ac3228d84a522d3#n1075
https://elixir.bootlin.com/linux/v5.4-rc2/source/drivers/iommu/rockchip-iommu.c#L1071

How do you think about to improve it?

Which error code would you like to return for a failed
device link addition at this place?

Regards,
Markus

WARNING: multiple messages have this Message-ID (diff)
From: Markus Elfring <Markus.Elfring-S0/GAf8tV78@public.gmane.org>
To: iommu-cunTk1MwBs9QetFLy7KEm3xJsTq8ys+cHZ5vskTnxNA@public.gmane.org,
	linux-arm-kernel-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r@public.gmane.org,
	linux-rockchip-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r@public.gmane.org,
	"Heiko Stübner" <heiko-4mtYJXux2i+zQB+pC5nmwQ@public.gmane.org>,
	"Jörg Rödel" <joro-zLv9SwRftAIdnm+yROfE0A@public.gmane.org>
Cc: "Rafael J. Wysocki"
	<rafael-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org>,
	kernel-janitors-u79uwXL29TY76Z2rM5mHXA@public.gmane.org,
	Stephen McCamant <smccaman-OJFnDUYgAso@public.gmane.org>,
	Kangjie Lu <kjlu-OJFnDUYgAso@public.gmane.org>,
	LKML <linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org>,
	Navid Emamdoost <emamd001-OJFnDUYgAso@public.gmane.org>,
	Aditya Pakki <pakki001-OJFnDUYgAso@public.gmane.org>
Subject: iommu/rockchip: Checking a device_link_add() call in rk_iommu_add_device()
Date: Fri, 18 Oct 2019 09:00:14 +0200	[thread overview]
Message-ID: <c4a1fdd2-4383-dd0f-1d4b-f27ab62b383e@web.de> (raw)

Hello,

I tried another script for the semantic patch language out.
This source code analysis approach points out that the implementation
of the function “rk_iommu_add_device” contains still
an unchecked call of the function “device_link_add”.
https://git.kernel.org/pub/scm/linux/kernel/git/next/linux-next.git/tree/drivers/iommu/rockchip-iommu.c?id=3ef845da3c3b180ddd386e228ac3228d84a522d3#n1075
https://elixir.bootlin.com/linux/v5.4-rc2/source/drivers/iommu/rockchip-iommu.c#L1071

How do you think about to improve it?

Which error code would you like to return for a failed
device link addition at this place?

Regards,
Markus

_______________________________________________
Linux-rockchip mailing list
Linux-rockchip@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-rockchip

WARNING: multiple messages have this Message-ID (diff)
From: Markus Elfring <Markus.Elfring@web.de>
To: iommu@lists.linux-foundation.org,
	linux-arm-kernel@lists.infradead.org,
	linux-rockchip@lists.infradead.org,
	"Heiko Stübner" <heiko@sntech.de>, "Jörg Rödel" <joro@8bytes.org>
Cc: "Rafael J. Wysocki" <rafael@kernel.org>,
	kernel-janitors@vger.kernel.org,
	Stephen McCamant <smccaman@umn.edu>, Kangjie Lu <kjlu@umn.edu>,
	LKML <linux-kernel@vger.kernel.org>,
	Navid Emamdoost <emamd001@umn.edu>,
	Aditya Pakki <pakki001@umn.edu>
Subject: iommu/rockchip: Checking a device_link_add() call in rk_iommu_add_device()
Date: Fri, 18 Oct 2019 09:00:14 +0200	[thread overview]
Message-ID: <c4a1fdd2-4383-dd0f-1d4b-f27ab62b383e@web.de> (raw)

Hello,

I tried another script for the semantic patch language out.
This source code analysis approach points out that the implementation
of the function “rk_iommu_add_device” contains still
an unchecked call of the function “device_link_add”.
https://git.kernel.org/pub/scm/linux/kernel/git/next/linux-next.git/tree/drivers/iommu/rockchip-iommu.c?id=3ef845da3c3b180ddd386e228ac3228d84a522d3#n1075
https://elixir.bootlin.com/linux/v5.4-rc2/source/drivers/iommu/rockchip-iommu.c#L1071

How do you think about to improve it?

Which error code would you like to return for a failed
device link addition at this place?

Regards,
Markus
_______________________________________________
iommu mailing list
iommu@lists.linux-foundation.org
https://lists.linuxfoundation.org/mailman/listinfo/iommu

WARNING: multiple messages have this Message-ID (diff)
From: Markus Elfring <Markus.Elfring@web.de>
To: iommu@lists.linux-foundation.org,
	linux-arm-kernel@lists.infradead.org,
	linux-rockchip@lists.infradead.org,
	"Heiko Stübner" <heiko@sntech.de>, "Jörg Rödel" <joro@8bytes.org>
Cc: "Rafael J. Wysocki" <rafael@kernel.org>,
	kernel-janitors@vger.kernel.org,
	Stephen McCamant <smccaman@umn.edu>, Kangjie Lu <kjlu@umn.edu>,
	LKML <linux-kernel@vger.kernel.org>,
	Navid Emamdoost <emamd001@umn.edu>,
	Aditya Pakki <pakki001@umn.edu>
Subject: iommu/rockchip: Checking a device_link_add() call in rk_iommu_add_device()
Date: Fri, 18 Oct 2019 09:00:14 +0200	[thread overview]
Message-ID: <c4a1fdd2-4383-dd0f-1d4b-f27ab62b383e@web.de> (raw)

Hello,

I tried another script for the semantic patch language out.
This source code analysis approach points out that the implementation
of the function “rk_iommu_add_device” contains still
an unchecked call of the function “device_link_add”.
https://git.kernel.org/pub/scm/linux/kernel/git/next/linux-next.git/tree/drivers/iommu/rockchip-iommu.c?id=3ef845da3c3b180ddd386e228ac3228d84a522d3#n1075
https://elixir.bootlin.com/linux/v5.4-rc2/source/drivers/iommu/rockchip-iommu.c#L1071

How do you think about to improve it?

Which error code would you like to return for a failed
device link addition at this place?

Regards,
Markus

_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel

             reply	other threads:[~2019-10-18  7:00 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-10-18  7:00 Markus Elfring [this message]
2019-10-18  7:00 ` iommu/rockchip: Checking a device_link_add() call in rk_iommu_add_device() Markus Elfring
2019-10-18  7:00 ` Markus Elfring
2019-10-18  7:00 ` Markus Elfring
2019-10-18  7:00 ` Markus Elfring

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=c4a1fdd2-4383-dd0f-1d4b-f27ab62b383e@web.de \
    --to=markus.elfring@web.de \
    --cc=emamd001@umn.edu \
    --cc=heiko@sntech.de \
    --cc=iommu@lists.linux-foundation.org \
    --cc=joro@8bytes.org \
    --cc=kernel-janitors@vger.kernel.org \
    --cc=kjlu@umn.edu \
    --cc=linux-arm-kernel@lists.infradead.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-rockchip@lists.infradead.org \
    --cc=pakki001@umn.edu \
    --cc=rafael@kernel.org \
    --cc=smccaman@umn.edu \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.