From: Josua Mayer <josua@solid-run.com> To: Andrew Lunn <andrew@lunn.ch>, Gregory Clement <gregory.clement@bootlin.com>, Sebastian Hesselbarth <sebastian.hesselbarth@gmail.com>, Rob Herring <robh+dt@kernel.org>, Krzysztof Kozlowski <krzysztof.kozlowski+dt@linaro.org>, Conor Dooley <conor+dt@kernel.org> Cc: Yazan Shhady <yazan.shhady@solid-run.com>, "linux-arm-kernel@lists.infradead.org" <linux-arm-kernel@lists.infradead.org>, "devicetree@vger.kernel.org" <devicetree@vger.kernel.org>, "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org> Subject: Re: [PATCH 1/2] dt-bindings: arm64: marvell: add solidrun cn9130 clearfog boards Date: Thu, 28 Mar 2024 16:22:01 +0000 [thread overview] Message-ID: <c4c4b7c7-fe89-4671-97c3-36c8bb416af1@solid-run.com> (raw) In-Reply-To: <20240321-cn9130-som-v1-1-711127a409ae@solid-run.com> Hi all, Am 21.03.24 um 22:47 schrieb Josua Mayer: > Add bindings for SolidRun Clearfog boards, using a new SoM based on > CN9130 SoC. > The carrier boards are identical to the older Armada 388 based Clearfog > boards. For consistency the carrier part of compatible strings are > copied, including the established "-a1" suffix. > > Signed-off-by: Josua Mayer <josua@solid-run.com> > --- > .../devicetree/bindings/arm/marvell/armada-7k-8k.yaml | 12 ++++++++++++ > 1 file changed, 12 insertions(+) > > diff --git a/Documentation/devicetree/bindings/arm/marvell/armada-7k-8k.yaml b/Documentation/devicetree/bindings/arm/marvell/armada-7k-8k.yaml > index 16d2e132d3d1..36bdfd1bedd9 100644 > --- a/Documentation/devicetree/bindings/arm/marvell/armada-7k-8k.yaml > +++ b/Documentation/devicetree/bindings/arm/marvell/armada-7k-8k.yaml > @@ -82,4 +82,16 @@ properties: > - const: marvell,armada-ap807-quad > - const: marvell,armada-ap807 > > + - description: > + SolidRun CN9130 clearfog family single-board computers > + items: vvv > + - enum: > + - solidrun,clearfog-base-a1 > + - solidrun,clearfog-pro-a1 > + - const: solidrun,clearfog-a1 ^^^ After some thought, this no longer makes any sense to me. Even identical carrier board combined with different SoC will have different characteristics. Any reason to repeat armada 388 board compatibles? Otherwise I may choose only solidrun,cn9130-clearfog-base/pro. > + - const: solidrun,cn9130-sr-som > + - const: marvell,cn9130 > + - const: marvell,armada-ap807-quad > + - const: marvell,armada-ap807 > + > additionalProperties: true >
WARNING: multiple messages have this Message-ID (diff)
From: Josua Mayer <josua@solid-run.com> To: Andrew Lunn <andrew@lunn.ch>, Gregory Clement <gregory.clement@bootlin.com>, Sebastian Hesselbarth <sebastian.hesselbarth@gmail.com>, Rob Herring <robh+dt@kernel.org>, Krzysztof Kozlowski <krzysztof.kozlowski+dt@linaro.org>, Conor Dooley <conor+dt@kernel.org> Cc: Yazan Shhady <yazan.shhady@solid-run.com>, "linux-arm-kernel@lists.infradead.org" <linux-arm-kernel@lists.infradead.org>, "devicetree@vger.kernel.org" <devicetree@vger.kernel.org>, "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org> Subject: Re: [PATCH 1/2] dt-bindings: arm64: marvell: add solidrun cn9130 clearfog boards Date: Thu, 28 Mar 2024 16:22:01 +0000 [thread overview] Message-ID: <c4c4b7c7-fe89-4671-97c3-36c8bb416af1@solid-run.com> (raw) In-Reply-To: <20240321-cn9130-som-v1-1-711127a409ae@solid-run.com> Hi all, Am 21.03.24 um 22:47 schrieb Josua Mayer: > Add bindings for SolidRun Clearfog boards, using a new SoM based on > CN9130 SoC. > The carrier boards are identical to the older Armada 388 based Clearfog > boards. For consistency the carrier part of compatible strings are > copied, including the established "-a1" suffix. > > Signed-off-by: Josua Mayer <josua@solid-run.com> > --- > .../devicetree/bindings/arm/marvell/armada-7k-8k.yaml | 12 ++++++++++++ > 1 file changed, 12 insertions(+) > > diff --git a/Documentation/devicetree/bindings/arm/marvell/armada-7k-8k.yaml b/Documentation/devicetree/bindings/arm/marvell/armada-7k-8k.yaml > index 16d2e132d3d1..36bdfd1bedd9 100644 > --- a/Documentation/devicetree/bindings/arm/marvell/armada-7k-8k.yaml > +++ b/Documentation/devicetree/bindings/arm/marvell/armada-7k-8k.yaml > @@ -82,4 +82,16 @@ properties: > - const: marvell,armada-ap807-quad > - const: marvell,armada-ap807 > > + - description: > + SolidRun CN9130 clearfog family single-board computers > + items: vvv > + - enum: > + - solidrun,clearfog-base-a1 > + - solidrun,clearfog-pro-a1 > + - const: solidrun,clearfog-a1 ^^^ After some thought, this no longer makes any sense to me. Even identical carrier board combined with different SoC will have different characteristics. Any reason to repeat armada 388 board compatibles? Otherwise I may choose only solidrun,cn9130-clearfog-base/pro. > + - const: solidrun,cn9130-sr-som > + - const: marvell,cn9130 > + - const: marvell,armada-ap807-quad > + - const: marvell,armada-ap807 > + > additionalProperties: true > _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
next prev parent reply other threads:[~2024-03-28 16:22 UTC|newest] Thread overview: 48+ messages / expand[flat|nested] mbox.gz Atom feed top 2024-03-21 21:47 [PATCH 0/2] arm64: dts: add description for solidrun cn9130 som and clearfog boards Josua Mayer 2024-03-21 21:47 ` Josua Mayer 2024-03-21 21:47 ` [PATCH 1/2] dt-bindings: arm64: marvell: add solidrun cn9130 " Josua Mayer 2024-03-21 21:47 ` Josua Mayer 2024-03-22 2:16 ` Rob Herring 2024-03-22 2:16 ` Rob Herring 2024-03-22 10:08 ` Josua Mayer 2024-03-22 10:08 ` Josua Mayer 2024-03-25 19:34 ` Krzysztof Kozlowski 2024-03-25 19:34 ` Krzysztof Kozlowski 2024-03-25 20:12 ` Josua Mayer 2024-03-25 20:12 ` Josua Mayer 2024-03-26 6:41 ` Krzysztof Kozlowski 2024-03-26 6:41 ` Krzysztof Kozlowski 2024-03-26 19:26 ` Josua Mayer 2024-03-26 19:26 ` Josua Mayer 2024-03-27 10:19 ` Krzysztof Kozlowski 2024-03-27 10:19 ` Krzysztof Kozlowski 2024-03-27 10:55 ` Josua Mayer 2024-03-27 10:55 ` Josua Mayer 2024-03-28 9:14 ` Krzysztof Kozlowski 2024-03-28 9:14 ` Krzysztof Kozlowski 2024-03-28 9:33 ` Josua Mayer 2024-03-28 9:33 ` Josua Mayer 2024-03-28 9:41 ` Krzysztof Kozlowski 2024-03-28 9:41 ` Krzysztof Kozlowski 2024-03-28 9:46 ` Josua Mayer 2024-03-28 9:46 ` Josua Mayer 2024-03-28 16:22 ` Josua Mayer [this message] 2024-03-28 16:22 ` Josua Mayer 2024-03-21 21:47 ` [PATCH 2/2] arm64: dts: add description for solidrun cn9130 som and " Josua Mayer 2024-03-21 21:47 ` Josua Mayer 2024-03-21 21:59 ` Andrew Lunn 2024-03-21 21:59 ` Andrew Lunn 2024-03-22 9:54 ` Josua Mayer 2024-03-22 9:54 ` Josua Mayer 2024-03-22 13:11 ` Andrew Lunn 2024-03-22 13:11 ` Andrew Lunn 2024-03-22 15:38 ` Josua Mayer 2024-03-22 15:38 ` Josua Mayer 2024-03-22 15:49 ` Andrew Lunn 2024-03-22 15:49 ` Andrew Lunn 2024-03-22 15:58 ` Josua Mayer 2024-03-22 15:58 ` Josua Mayer 2024-03-22 18:14 ` Josua Mayer 2024-03-22 18:14 ` Josua Mayer 2024-03-22 18:27 ` Andrew Lunn 2024-03-22 18:27 ` Andrew Lunn
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=c4c4b7c7-fe89-4671-97c3-36c8bb416af1@solid-run.com \ --to=josua@solid-run.com \ --cc=andrew@lunn.ch \ --cc=conor+dt@kernel.org \ --cc=devicetree@vger.kernel.org \ --cc=gregory.clement@bootlin.com \ --cc=krzysztof.kozlowski+dt@linaro.org \ --cc=linux-arm-kernel@lists.infradead.org \ --cc=linux-kernel@vger.kernel.org \ --cc=robh+dt@kernel.org \ --cc=sebastian.hesselbarth@gmail.com \ --cc=yazan.shhady@solid-run.com \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: linkBe sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.