[PATCH/RFC 0/2] media: adv748x: Fix decimal unit addresses

[PATCH/RFC 0/2] media: adv748x: Fix decimal unit addresses

[Geert Uytterhoeven]

	Hi Rob et al.

Recent dtc assumes unit addresses are always hexadecimal (without
prefix), while the bases of reg property values depend on their
prefixes, and thus can be either decimal or hexadecimal.

This leads to (with W=1):

    Warning (graph_port): video-receiver@70/port@10: graph node unit address error, expected "a"
    Warning (graph_port): video-receiver@70/port@11: graph node unit address error, expected "b"

In this particular case, the unit addresses are (assumed hexadecimal) 10
resp. 11, while the reg properties are decimal 10 resp. 11, and thus
don't match.

This RFC patch series corrects the unit addresses to match the reg
address values for the DT bindings for adi,adv748x and its users.
There's at least one other violator (port@10 in
arch/arm/boot/dts/vf610-zii-dev-rev-c.dts), which I didn't fix.

However, ePAPR v1.1 states:

    The unit-address component of the name is specific to the bus type
    on which the node sits. It consists of one or more ASCII characters
    from the set of characters in Table 2-1. The unit-address must match
    the first address specified in the reg property of the node. If the
    node has no reg property, the @ and unit-address must be omitted and
    the node-name alone differentiates the node from other nodes at the
    same level in the tree. The binding for a particular bus may specify
    additional, more specific requirements for the format of reg and the
    unit-address.

i.e. nothing about an hexadecimal address requirement?

Should this series be applied, or should the warnings be ignored, until
dtc is fixed?

Thanks for your comments!

Geert Uytterhoeven (2):
  media: dt-bindings: adv748x: Fix decimal unit addresses
  arm64: dts: renesas: salvator-common: Fix adv7482 decimal unit
    addresses

 Documentation/devicetree/bindings/media/i2c/adv748x.txt | 4 ++--
 arch/arm64/boot/dts/renesas/salvator-common.dtsi        | 4 ++--
 2 files changed, 4 insertions(+), 4 deletions(-)

-- 
2.7.4

Gr{oetje,eeting}s,

						Geert

--
Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@linux-m68k.org

In personal conversations with technical people, I call myself a hacker. But
when I'm talking to journalists I just say "programmer" or something like that.
							    -- Linus Torvalds

[PATCH/RFC 1/2] media: dt-bindings: adv748x: Fix decimal unit addresses

[Geert Uytterhoeven]

With recent dtc and W=1:

    Warning (graph_port): video-receiver@70/port@10: graph node unit address error, expected "a"
    Warning (graph_port): video-receiver@70/port@11: graph node unit address error, expected "b"

Unit addresses are always hexadecimal (without prefix), while the bases
of reg property values depend on their prefixes.

Fixes: e69595170b1cad85 ("media: adv748x: Add adv7481, adv7482 bindings")
Signed-off-by: Geert Uytterhoeven <geert+renesas@glider.be>
---
 Documentation/devicetree/bindings/media/i2c/adv748x.txt | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/Documentation/devicetree/bindings/media/i2c/adv748x.txt b/Documentation/devicetree/bindings/media/i2c/adv748x.txt
index 21ffb5ed818302ff..54d1d3bc186949fa 100644
--- a/Documentation/devicetree/bindings/media/i2c/adv748x.txt
+++ b/Documentation/devicetree/bindings/media/i2c/adv748x.txt
@@ -73,7 +73,7 @@ Example:
 			};
 		};
 
-		port@10 {
+		port@a {
 			reg = <10>;
 
 			adv7482_txa: endpoint {
@@ -83,7 +83,7 @@ Example:
 			};
 		};
 
-		port@11 {
+		port@b {
 			reg = <11>;
 
 			adv7482_txb: endpoint {
-- 
2.7.4

Re: [PATCH/RFC 1/2] media: dt-bindings: adv748x: Fix decimal unit addresses

[Rob Herring]

On Thu, Jun 14, 2018 at 03:48:07PM +0200, Geert Uytterhoeven wrote:
> With recent dtc and W=1:
> 
>     Warning (graph_port): video-receiver@70/port@10: graph node unit address error, expected "a"
>     Warning (graph_port): video-receiver@70/port@11: graph node unit address error, expected "b"
> 
> Unit addresses are always hexadecimal (without prefix), while the bases
> of reg property values depend on their prefixes.
> 
> Fixes: e69595170b1cad85 ("media: adv748x: Add adv7481, adv7482 bindings")
> Signed-off-by: Geert Uytterhoeven <geert+renesas@glider.be>
> ---
>  Documentation/devicetree/bindings/media/i2c/adv748x.txt | 4 ++--
>  1 file changed, 2 insertions(+), 2 deletions(-)

Reviewed-by: Rob Herring <robh@kernel.org>

Re: [PATCH/RFC 1/2] media: dt-bindings: adv748x: Fix decimal unit addresses

[Kieran Bingham]

Hi Geert,

On 14/06/18 14:48, Geert Uytterhoeven wrote:
> With recent dtc and W=1:
> 
>     Warning (graph_port): video-receiver@70/port@10: graph node unit address error, expected "a"
>     Warning (graph_port): video-receiver@70/port@11: graph node unit address error, expected "b"
> 
> Unit addresses are always hexadecimal (without prefix), while the bases
> of reg property values depend on their prefixes.
> 
> Fixes: e69595170b1cad85 ("media: adv748x: Add adv7481, adv7482 bindings")
> Signed-off-by: Geert Uytterhoeven <geert+renesas@glider.be>
> ---
>  Documentation/devicetree/bindings/media/i2c/adv748x.txt | 4 ++--
>  1 file changed, 2 insertions(+), 2 deletions(-)
> 
> diff --git a/Documentation/devicetree/bindings/media/i2c/adv748x.txt b/Documentation/devicetree/bindings/media/i2c/adv748x.txt
> index 21ffb5ed818302ff..54d1d3bc186949fa 100644
> --- a/Documentation/devicetree/bindings/media/i2c/adv748x.txt
> +++ b/Documentation/devicetree/bindings/media/i2c/adv748x.txt
> @@ -73,7 +73,7 @@ Example:
>  			};
>  		};
>  
> -		port@10 {
> +		port@a {
>  			reg = <10>;
>  
>  			adv7482_txa: endpoint {
> @@ -83,7 +83,7 @@ Example:
>  			};
>  		};
>  
> -		port@11 {
> +		port@b {
>  			reg = <11>;
>  
>  			adv7482_txb: endpoint {
> 

Just looking back through these patches, to make sure they get integrated.

Having read yours and Robs responses, I do agree that this is a correct fix.

Reviewed-by: Kieran Bingham <kieran.bingham+renesas@ideasonboard.com>

[PATCH/RFC 2/2] arm64: dts: renesas: salvator-common: Fix adv7482 decimal unit addresses

[Geert Uytterhoeven]

With recent dtc and W=1:

    ...salvator-x.dtb: Warning (graph_port): /soc/i2c@e66d8000/video-receiver@70/port@10: graph node unit address error, expected "a"
    ...salvator-x.dtb: Warning (graph_port): /soc/i2c@e66d8000/video-receiver@70/port@11: graph node unit address error, expected "b"

Unit addresses are always hexadecimal (without prefix), while the bases
of reg property values depend on their prefixes.

Fixes: 908001d778eba06e ("arm64: dts: renesas: salvator-common: Add ADV7482 support")
Signed-off-by: Geert Uytterhoeven <geert+renesas@glider.be>
---
 arch/arm64/boot/dts/renesas/salvator-common.dtsi | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/arch/arm64/boot/dts/renesas/salvator-common.dtsi b/arch/arm64/boot/dts/renesas/salvator-common.dtsi
index 320250d708c3bbab..47088206cc052a15 100644
--- a/arch/arm64/boot/dts/renesas/salvator-common.dtsi
+++ b/arch/arm64/boot/dts/renesas/salvator-common.dtsi
@@ -437,7 +437,7 @@
 			};
 		};
 
-		port@10 {
+		port@a {
 			reg = <10>;
 
 			adv7482_txa: endpoint {
@@ -447,7 +447,7 @@
 			};
 		};
 
-		port@11 {
+		port@b {
 			reg = <11>;
 
 			adv7482_txb: endpoint {
-- 
2.7.4

Re: [PATCH/RFC 2/2] arm64: dts: renesas: salvator-common: Fix adv7482 decimal unit addresses

[Kieran Bingham]

Hi Geert,

On 14/06/18 14:48, Geert Uytterhoeven wrote:
> With recent dtc and W=1:
> 
>      ...salvator-x.dtb: Warning (graph_port): /soc/i2c@e66d8000/video-receiver@70/port@10: graph node unit address error, expected "a"
>      ...salvator-x.dtb: Warning (graph_port): /soc/i2c@e66d8000/video-receiver@70/port@11: graph node unit address error, expected "b"
> 
> Unit addresses are always hexadecimal (without prefix), while the bases
> of reg property values depend on their prefixes.
> 
> Fixes: 908001d778eba06e ("arm64: dts: renesas: salvator-common: Add ADV7482 support")
> Signed-off-by: Geert Uytterhoeven <geert+renesas@glider.be>
> ---
>   arch/arm64/boot/dts/renesas/salvator-common.dtsi | 4 ++--
>   1 file changed, 2 insertions(+), 2 deletions(-)
> 
> diff --git a/arch/arm64/boot/dts/renesas/salvator-common.dtsi b/arch/arm64/boot/dts/renesas/salvator-common.dtsi
> index 320250d708c3bbab..47088206cc052a15 100644
> --- a/arch/arm64/boot/dts/renesas/salvator-common.dtsi
> +++ b/arch/arm64/boot/dts/renesas/salvator-common.dtsi
> @@ -437,7 +437,7 @@
>   			};
>   		};
>   
> -		port@10 {
> +		port@a {
>   			reg = <10>;

This looks a bit ugly with the different mappings;
If we must move to 'port@a', I think reg needs to be <0xa>, to avoid 
confusion. (but I personally prefer port@10, reg = <10> here)


--
Kieran


>   
>   			adv7482_txa: endpoint {
> @@ -447,7 +447,7 @@
>   			};
>   		};
>   
> -		port@11 {
> +		port@b {
>   			reg = <11>;
>   
>   			adv7482_txb: endpoint {
> 

Re: [PATCH/RFC 2/2] arm64: dts: renesas: salvator-common: Fix adv7482 decimal unit addresses

[Rob Herring]

On Thu, Jun 14, 2018 at 03:48:08PM +0200, Geert Uytterhoeven wrote:
> With recent dtc and W=1:
> 
>     ...salvator-x.dtb: Warning (graph_port): /soc/i2c@e66d8000/video-receiver@70/port@10: graph node unit address error, expected "a"
>     ...salvator-x.dtb: Warning (graph_port): /soc/i2c@e66d8000/video-receiver@70/port@11: graph node unit address error, expected "b"
> 
> Unit addresses are always hexadecimal (without prefix), while the bases
> of reg property values depend on their prefixes.
> 
> Fixes: 908001d778eba06e ("arm64: dts: renesas: salvator-common: Add ADV7482 support")
> Signed-off-by: Geert Uytterhoeven <geert+renesas@glider.be>
> ---
>  arch/arm64/boot/dts/renesas/salvator-common.dtsi | 4 ++--
>  1 file changed, 2 insertions(+), 2 deletions(-)

Reviewed-by: Rob Herring <robh@kernel.org>

Re: [PATCH/RFC 2/2] arm64: dts: renesas: salvator-common: Fix adv7482 decimal unit addresses

[Simon Horman]

On Tue, Jun 26, 2018 at 01:57:47PM -0600, Rob Herring wrote:
> On Thu, Jun 14, 2018 at 03:48:08PM +0200, Geert Uytterhoeven wrote:
> > With recent dtc and W=1:
> > 
> >     ...salvator-x.dtb: Warning (graph_port): /soc/i2c@e66d8000/video-receiver@70/port@10: graph node unit address error, expected "a"
> >     ...salvator-x.dtb: Warning (graph_port): /soc/i2c@e66d8000/video-receiver@70/port@11: graph node unit address error, expected "b"
> > 
> > Unit addresses are always hexadecimal (without prefix), while the bases
> > of reg property values depend on their prefixes.
> > 
> > Fixes: 908001d778eba06e ("arm64: dts: renesas: salvator-common: Add ADV7482 support")
> > Signed-off-by: Geert Uytterhoeven <geert+renesas@glider.be>
> > ---
> >  arch/arm64/boot/dts/renesas/salvator-common.dtsi | 4 ++--
> >  1 file changed, 2 insertions(+), 2 deletions(-)
> 
> Reviewed-by: Rob Herring <robh@kernel.org>

Geert, shall I apply this?

Re: [PATCH/RFC 2/2] arm64: dts: renesas: salvator-common: Fix adv7482 decimal unit addresses

[Geert Uytterhoeven]

Hi Simon,

On Wed, Jun 27, 2018 at 5:10 PM Simon Horman <horms@verge.net.au> wrote:
> On Tue, Jun 26, 2018 at 01:57:47PM -0600, Rob Herring wrote:
> > On Thu, Jun 14, 2018 at 03:48:08PM +0200, Geert Uytterhoeven wrote:
> > > With recent dtc and W=1:
> > >
> > >     ...salvator-x.dtb: Warning (graph_port): /soc/i2c@e66d8000/video-receiver@70/port@10: graph node unit address error, expected "a"
> > >     ...salvator-x.dtb: Warning (graph_port): /soc/i2c@e66d8000/video-receiver@70/port@11: graph node unit address error, expected "b"
> > >
> > > Unit addresses are always hexadecimal (without prefix), while the bases
> > > of reg property values depend on their prefixes.
> > >
> > > Fixes: 908001d778eba06e ("arm64: dts: renesas: salvator-common: Add ADV7482 support")
> > > Signed-off-by: Geert Uytterhoeven <geert+renesas@glider.be>
> > > ---
> > >  arch/arm64/boot/dts/renesas/salvator-common.dtsi | 4 ++--
> > >  1 file changed, 2 insertions(+), 2 deletions(-)
> >
> > Reviewed-by: Rob Herring <robh@kernel.org>
>
> Geert, shall I apply this?

I'd say yes. Thanks!

Gr{oetje,eeting}s,

                        Geert

-- 
Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@linux-m68k.org

In personal conversations with technical people, I call myself a hacker. But
when I'm talking to journalists I just say "programmer" or something like that.
                                -- Linus Torvalds

Re: [PATCH/RFC 2/2] arm64: dts: renesas: salvator-common: Fix adv7482 decimal unit addresses

[Kieran Bingham]

On 27/06/18 17:40, Geert Uytterhoeven wrote:
> Hi Simon,
> 
> On Wed, Jun 27, 2018 at 5:10 PM Simon Horman <horms@verge.net.au> wrote:
>> On Tue, Jun 26, 2018 at 01:57:47PM -0600, Rob Herring wrote:
>>> On Thu, Jun 14, 2018 at 03:48:08PM +0200, Geert Uytterhoeven wrote:
>>>> With recent dtc and W=1:
>>>>
>>>>     ...salvator-x.dtb: Warning (graph_port): /soc/i2c@e66d8000/video-receiver@70/port@10: graph node unit address error, expected "a"
>>>>     ...salvator-x.dtb: Warning (graph_port): /soc/i2c@e66d8000/video-receiver@70/port@11: graph node unit address error, expected "b"
>>>>
>>>> Unit addresses are always hexadecimal (without prefix), while the bases
>>>> of reg property values depend on their prefixes.
>>>>
>>>> Fixes: 908001d778eba06e ("arm64: dts: renesas: salvator-common: Add ADV7482 support")
>>>> Signed-off-by: Geert Uytterhoeven <geert+renesas@glider.be>
>>>> ---
>>>>  arch/arm64/boot/dts/renesas/salvator-common.dtsi | 4 ++--
>>>>  1 file changed, 2 insertions(+), 2 deletions(-)
>>>
>>> Reviewed-by: Rob Herring <robh@kernel.org>
>>
>> Geert, shall I apply this?
> 
> I'd say yes. Thanks!

I'm happy to throw an

Acked-by: Kieran Bingham <kieran.bingham+renesas@ideasonboard.com>

on the patch - but I had a pending question regarding the reg = <10> part.

Shouldn't the reg become hex "reg = <0xa>" to be consistent?

Either way - if there's precedent - take that route and I'm happy.

--
Regards

Kieran


> 
> Gr{oetje,eeting}s,
> 
>                         Geert
> 

Re: [PATCH/RFC 2/2] arm64: dts: renesas: salvator-common: Fix adv7482 decimal unit addresses

[Simon Horman]

On Wed, Jun 27, 2018 at 05:45:34PM +0100, Kieran Bingham wrote:
> On 27/06/18 17:40, Geert Uytterhoeven wrote:
> > Hi Simon,
> > 
> > On Wed, Jun 27, 2018 at 5:10 PM Simon Horman <horms@verge.net.au> wrote:
> >> On Tue, Jun 26, 2018 at 01:57:47PM -0600, Rob Herring wrote:
> >>> On Thu, Jun 14, 2018 at 03:48:08PM +0200, Geert Uytterhoeven wrote:
> >>>> With recent dtc and W=1:
> >>>>
> >>>>     ...salvator-x.dtb: Warning (graph_port): /soc/i2c@e66d8000/video-receiver@70/port@10: graph node unit address error, expected "a"
> >>>>     ...salvator-x.dtb: Warning (graph_port): /soc/i2c@e66d8000/video-receiver@70/port@11: graph node unit address error, expected "b"
> >>>>
> >>>> Unit addresses are always hexadecimal (without prefix), while the bases
> >>>> of reg property values depend on their prefixes.
> >>>>
> >>>> Fixes: 908001d778eba06e ("arm64: dts: renesas: salvator-common: Add ADV7482 support")
> >>>> Signed-off-by: Geert Uytterhoeven <geert+renesas@glider.be>
> >>>> ---
> >>>>  arch/arm64/boot/dts/renesas/salvator-common.dtsi | 4 ++--
> >>>>  1 file changed, 2 insertions(+), 2 deletions(-)
> >>>
> >>> Reviewed-by: Rob Herring <robh@kernel.org>
> >>
> >> Geert, shall I apply this?
> > 
> > I'd say yes. Thanks!
> 
> I'm happy to throw an
> 
> Acked-by: Kieran Bingham <kieran.bingham+renesas@ideasonboard.com>
> 
> on the patch - but I had a pending question regarding the reg = <10> part.
> 
> Shouldn't the reg become hex "reg = <0xa>" to be consistent?
> 
> Either way - if there's precedent - take that route and I'm happy.

Consistency seems good to me, Geert?

Re: [PATCH/RFC 2/2] arm64: dts: renesas: salvator-common: Fix adv7482 decimal unit addresses

[Geert Uytterhoeven]

Hi Simon,

On Thu, Jun 28, 2018 at 10:48 AM Simon Horman <horms@verge.net.au> wrote:
> On Wed, Jun 27, 2018 at 05:45:34PM +0100, Kieran Bingham wrote:
> > On 27/06/18 17:40, Geert Uytterhoeven wrote:
> > > On Wed, Jun 27, 2018 at 5:10 PM Simon Horman <horms@verge.net.au> wrote:
> > >> On Tue, Jun 26, 2018 at 01:57:47PM -0600, Rob Herring wrote:
> > >>> On Thu, Jun 14, 2018 at 03:48:08PM +0200, Geert Uytterhoeven wrote:
> > >>>> With recent dtc and W=1:
> > >>>>
> > >>>>     ...salvator-x.dtb: Warning (graph_port): /soc/i2c@e66d8000/video-receiver@70/port@10: graph node unit address error, expected "a"
> > >>>>     ...salvator-x.dtb: Warning (graph_port): /soc/i2c@e66d8000/video-receiver@70/port@11: graph node unit address error, expected "b"
> > >>>>
> > >>>> Unit addresses are always hexadecimal (without prefix), while the bases
> > >>>> of reg property values depend on their prefixes.
> > >>>>
> > >>>> Fixes: 908001d778eba06e ("arm64: dts: renesas: salvator-common: Add ADV7482 support")
> > >>>> Signed-off-by: Geert Uytterhoeven <geert+renesas@glider.be>
> > >>>> ---
> > >>>>  arch/arm64/boot/dts/renesas/salvator-common.dtsi | 4 ++--
> > >>>>  1 file changed, 2 insertions(+), 2 deletions(-)
> > >>>
> > >>> Reviewed-by: Rob Herring <robh@kernel.org>
> > >>
> > >> Geert, shall I apply this?
> > >
> > > I'd say yes. Thanks!
> >
> > I'm happy to throw an
> >
> > Acked-by: Kieran Bingham <kieran.bingham+renesas@ideasonboard.com>
> >
> > on the patch - but I had a pending question regarding the reg = <10> part.
> >
> > Shouldn't the reg become hex "reg = <0xa>" to be consistent?
> >
> > Either way - if there's precedent - take that route and I'm happy.
>
> Consistency seems good to me, Geert?

Typically we use decimal for "small" and hex for "large" numbers.
So far this was mostly relevant for the size parts of "reg"
properties, as the address
parts are usually large (if part of the main memory space).

These are different, as they are not memory-mapped addresses.
If you want to see 0xa and 0xb in the reg properties, I can respin.

Gr{oetje,eeting}s,

                        Geert

-- 
Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@linux-m68k.org

In personal conversations with technical people, I call myself a hacker. But
when I'm talking to journalists I just say "programmer" or something like that.
                                -- Linus Torvalds

Re: [PATCH/RFC 2/2] arm64: dts: renesas: salvator-common: Fix adv7482 decimal unit addresses

[Simon Horman]

On Thu, Jun 28, 2018 at 10:52:17AM +0200, Geert Uytterhoeven wrote:
> Hi Simon,
> 
> On Thu, Jun 28, 2018 at 10:48 AM Simon Horman <horms@verge.net.au> wrote:
> > On Wed, Jun 27, 2018 at 05:45:34PM +0100, Kieran Bingham wrote:
> > > On 27/06/18 17:40, Geert Uytterhoeven wrote:
> > > > On Wed, Jun 27, 2018 at 5:10 PM Simon Horman <horms@verge.net.au> wrote:
> > > >> On Tue, Jun 26, 2018 at 01:57:47PM -0600, Rob Herring wrote:
> > > >>> On Thu, Jun 14, 2018 at 03:48:08PM +0200, Geert Uytterhoeven wrote:
> > > >>>> With recent dtc and W=1:
> > > >>>>
> > > >>>>     ...salvator-x.dtb: Warning (graph_port): /soc/i2c@e66d8000/video-receiver@70/port@10: graph node unit address error, expected "a"
> > > >>>>     ...salvator-x.dtb: Warning (graph_port): /soc/i2c@e66d8000/video-receiver@70/port@11: graph node unit address error, expected "b"
> > > >>>>
> > > >>>> Unit addresses are always hexadecimal (without prefix), while the bases
> > > >>>> of reg property values depend on their prefixes.
> > > >>>>
> > > >>>> Fixes: 908001d778eba06e ("arm64: dts: renesas: salvator-common: Add ADV7482 support")
> > > >>>> Signed-off-by: Geert Uytterhoeven <geert+renesas@glider.be>
> > > >>>> ---
> > > >>>>  arch/arm64/boot/dts/renesas/salvator-common.dtsi | 4 ++--
> > > >>>>  1 file changed, 2 insertions(+), 2 deletions(-)
> > > >>>
> > > >>> Reviewed-by: Rob Herring <robh@kernel.org>
> > > >>
> > > >> Geert, shall I apply this?
> > > >
> > > > I'd say yes. Thanks!
> > >
> > > I'm happy to throw an
> > >
> > > Acked-by: Kieran Bingham <kieran.bingham+renesas@ideasonboard.com>
> > >
> > > on the patch - but I had a pending question regarding the reg = <10> part.
> > >
> > > Shouldn't the reg become hex "reg = <0xa>" to be consistent?
> > >
> > > Either way - if there's precedent - take that route and I'm happy.
> >
> > Consistency seems good to me, Geert?
> 
> Typically we use decimal for "small" and hex for "large" numbers.
> So far this was mostly relevant for the size parts of "reg"
> properties, as the address
> parts are usually large (if part of the main memory space).
> 
> These are different, as they are not memory-mapped addresses.
> If you want to see 0xa and 0xb in the reg properties, I can respin.

I'll take this as is. We can decide how we want to address this,
in a consistent manner, without too many puns, later.

Re: [PATCH/RFC 0/2] media: adv748x: Fix decimal unit addresses

[Kieran Bingham]

Hi Geert,

On 14/06/18 14:48, Geert Uytterhoeven wrote:
> 	Hi Rob et al.
> 
> Recent dtc assumes unit addresses are always hexadecimal (without
> prefix), while the bases of reg property values depend on their
> prefixes, and thus can be either decimal or hexadecimal.
> 
> This leads to (with W=1):
> 
>      Warning (graph_port): video-receiver@70/port@10: graph node unit address error, expected "a"
>      Warning (graph_port): video-receiver@70/port@11: graph node unit address error, expected "b"
> 
> In this particular case, the unit addresses are (assumed hexadecimal) 10
> resp. 11, while the reg properties are decimal 10 resp. 11, and thus
> don't match.
> 
> This RFC patch series corrects the unit addresses to match the reg
> address values for the DT bindings for adi,adv748x and its users.
> There's at least one other violator (port@10 in
> arch/arm/boot/dts/vf610-zii-dev-rev-c.dts), which I didn't fix.
> 
> However, ePAPR v1.1 states:
> 
>      The unit-address component of the name is specific to the bus type
>      on which the node sits. It consists of one or more ASCII characters
>      from the set of characters in Table 2-1. The unit-address must match
>      the first address specified in the reg property of the node. If the
>      node has no reg property, the @ and unit-address must be omitted and
>      the node-name alone differentiates the node from other nodes at the
>      same level in the tree. The binding for a particular bus may specify
>      additional, more specific requirements for the format of reg and the
>      unit-address.
> 
> i.e. nothing about an hexadecimal address requirement?
> 
> Should this series be applied, or should the warnings be ignored, until
> dtc is fixed?

IMO - the ports are human readable indexes, and not hexadecimal. I'd be 
loathed to see these become hex. .. especially if not prefixed by a 0x...

Otherwise, is '10', Ten, or Sixteen? IMO - no 0x = decimal only.

That said - I look up and see "video-receiver@70", which is of course 
the hexadecimal I2C address :(

--

Kieran


> Thanks for your comments!
> 
> Geert Uytterhoeven (2):
>    media: dt-bindings: adv748x: Fix decimal unit addresses
>    arm64: dts: renesas: salvator-common: Fix adv7482 decimal unit
>      addresses
> 
>   Documentation/devicetree/bindings/media/i2c/adv748x.txt | 4 ++--
>   arch/arm64/boot/dts/renesas/salvator-common.dtsi        | 4 ++--
>   2 files changed, 4 insertions(+), 4 deletions(-)
> 


-- 
Regards
--
Kieran

Re: [PATCH/RFC 0/2] media: adv748x: Fix decimal unit addresses

[Rob Herring]

On Thu, Jun 14, 2018 at 04:50:49PM +0100, Kieran Bingham wrote:
> Hi Geert,
> 
> On 14/06/18 14:48, Geert Uytterhoeven wrote:
> > 	Hi Rob et al.
> > 
> > Recent dtc assumes unit addresses are always hexadecimal (without
> > prefix), while the bases of reg property values depend on their
> > prefixes, and thus can be either decimal or hexadecimal.
> > 
> > This leads to (with W=1):
> > 
> >      Warning (graph_port): video-receiver@70/port@10: graph node unit address error, expected "a"
> >      Warning (graph_port): video-receiver@70/port@11: graph node unit address error, expected "b"
> > 
> > In this particular case, the unit addresses are (assumed hexadecimal) 10
> > resp. 11, while the reg properties are decimal 10 resp. 11, and thus
> > don't match.
> > 
> > This RFC patch series corrects the unit addresses to match the reg
> > address values for the DT bindings for adi,adv748x and its users.
> > There's at least one other violator (port@10 in
> > arch/arm/boot/dts/vf610-zii-dev-rev-c.dts), which I didn't fix.
> > 
> > However, ePAPR v1.1 states:
> > 
> >      The unit-address component of the name is specific to the bus type
> >      on which the node sits. It consists of one or more ASCII characters
> >      from the set of characters in Table 2-1. The unit-address must match
> >      the first address specified in the reg property of the node. If the
> >      node has no reg property, the @ and unit-address must be omitted and
> >      the node-name alone differentiates the node from other nodes at the
> >      same level in the tree. The binding for a particular bus may specify
> >      additional, more specific requirements for the format of reg and the
> >      unit-address.
> > 
> > i.e. nothing about an hexadecimal address requirement?

No, because unit-addresses are bus specific, so in theory a bus could 
use decimal. However, it's pretty well established practice to use hex.

> > Should this series be applied, or should the warnings be ignored, until
> > dtc is fixed?
> 
> IMO - the ports are human readable indexes, and not hexadecimal. I'd be
> loathed to see these become hex. .. especially if not prefixed by a 0x...

I read hex. :)

> Otherwise, is '10', Ten, or Sixteen? IMO - no 0x = decimal only.

It's hex because *everywhere* else is hex. Having a mixture would just 
invite more confusion and errors (especially because dtc only checks 
cases it knows the bus type).

For OF graph, I'm not that worried about it because 99% of the users 
have 10 or less ports/endpoints.

> That said - I look up and see "video-receiver@70", which is of course the
> hexadecimal I2C address :(

It is bad enough that I2C addresses get expressed in both 7 and 8-bits 
(shifted up 1), using decimal there would be really fun.

Rob