From: Greg Ungerer <gerg@linux-m68k.org>
To: Finn Thain <fthain@telegraphics.com.au>,
"David S. Miller" <davem@davemloft.net>
Cc: netdev@vger.kernel.org, linux-m68k@vger.kernel.org,
linux-kernel@vger.kernel.org,
Geert Uytterhoeven <geert@linux-m68k.org>
Subject: Re: [PATCH net 1/4] net/8390: Remove redundant make dependencies
Date: Mon, 19 Feb 2018 12:47:09 +1000 [thread overview]
Message-ID: <c7a53542-3098-9932-ef92-92f16b39dc91@linux-m68k.org> (raw)
In-Reply-To: <ad208b917b7eb0e581ca46246253692db71484cb.1519007130.git.fthain@telegraphics.com.au>
Hi Finn,
On 19/02/18 12:39, Finn Thain wrote:
> The hydra, zorro8390 and mcf8390 drivers all #include "lib8390.c" and
> have no need for 8390.o. modinfo confirms no dependency on 8390.ko.
> Drop the redundant dependency from the Makefile. objdump confirms
> that this patch has no effect on the module binaries.
>
> The superfluous additions of 8390.o were introduced in
> commit 644570b83026 ("8390: Move the 8390 related drivers").
>
> Cc: Greg Ungerer <gerg@linux-m68k.org>
Looks right for mcf8390.c.
Acked-by: Greg Ungerer <gerg@linux-m68k.org>
Regards
Greg
> Cc: Geert Uytterhoeven <geert@linux-m68k.org>
> Signed-off-by: Finn Thain <fthain@telegraphics.com.au>
> Acked-by: Geert Uytterhoeven <geert@linux-m68k.org>
> ---
> drivers/net/ethernet/8390/Makefile | 6 +++---
> 1 file changed, 3 insertions(+), 3 deletions(-)
>
> diff --git a/drivers/net/ethernet/8390/Makefile b/drivers/net/ethernet/8390/Makefile
> index f975c2fc88a3..1d650e66cc6e 100644
> --- a/drivers/net/ethernet/8390/Makefile
> +++ b/drivers/net/ethernet/8390/Makefile
> @@ -7,8 +7,8 @@ obj-$(CONFIG_MAC8390) += mac8390.o
> obj-$(CONFIG_APNE) += apne.o 8390.o
> obj-$(CONFIG_ARM_ETHERH) += etherh.o
> obj-$(CONFIG_AX88796) += ax88796.o
> -obj-$(CONFIG_HYDRA) += hydra.o 8390.o
> -obj-$(CONFIG_MCF8390) += mcf8390.o 8390.o
> +obj-$(CONFIG_HYDRA) += hydra.o
> +obj-$(CONFIG_MCF8390) += mcf8390.o
> obj-$(CONFIG_NE2000) += ne.o 8390p.o
> obj-$(CONFIG_NE2K_PCI) += ne2k-pci.o 8390.o
> obj-$(CONFIG_PCMCIA_AXNET) += axnet_cs.o 8390.o
> @@ -16,4 +16,4 @@ obj-$(CONFIG_PCMCIA_PCNET) += pcnet_cs.o 8390.o
> obj-$(CONFIG_STNIC) += stnic.o 8390.o
> obj-$(CONFIG_ULTRA) += smc-ultra.o 8390.o
> obj-$(CONFIG_WD80x3) += wd.o 8390.o
> -obj-$(CONFIG_ZORRO8390) += zorro8390.o 8390.o
> +obj-$(CONFIG_ZORRO8390) += zorro8390.o
>
WARNING: multiple messages have this Message-ID (diff)
From: Greg Ungerer <gerg@linux-m68k.org>
To: Finn Thain <fthain@telegraphics.com.au>,
"David S. Miller" <davem@davemloft.net>
Cc: netdev@vger.kernel.org, linux-m68k@lists.linux-m68k.org,
linux-kernel@vger.kernel.org,
Geert Uytterhoeven <geert@linux-m68k.org>
Subject: Re: [PATCH net 1/4] net/8390: Remove redundant make dependencies
Date: Mon, 19 Feb 2018 12:47:09 +1000 [thread overview]
Message-ID: <c7a53542-3098-9932-ef92-92f16b39dc91@linux-m68k.org> (raw)
In-Reply-To: <ad208b917b7eb0e581ca46246253692db71484cb.1519007130.git.fthain@telegraphics.com.au>
Hi Finn,
On 19/02/18 12:39, Finn Thain wrote:
> The hydra, zorro8390 and mcf8390 drivers all #include "lib8390.c" and
> have no need for 8390.o. modinfo confirms no dependency on 8390.ko.
> Drop the redundant dependency from the Makefile. objdump confirms
> that this patch has no effect on the module binaries.
>
> The superfluous additions of 8390.o were introduced in
> commit 644570b83026 ("8390: Move the 8390 related drivers").
>
> Cc: Greg Ungerer <gerg@linux-m68k.org>
Looks right for mcf8390.c.
Acked-by: Greg Ungerer <gerg@linux-m68k.org>
Regards
Greg
> Cc: Geert Uytterhoeven <geert@linux-m68k.org>
> Signed-off-by: Finn Thain <fthain@telegraphics.com.au>
> Acked-by: Geert Uytterhoeven <geert@linux-m68k.org>
> ---
> drivers/net/ethernet/8390/Makefile | 6 +++---
> 1 file changed, 3 insertions(+), 3 deletions(-)
>
> diff --git a/drivers/net/ethernet/8390/Makefile b/drivers/net/ethernet/8390/Makefile
> index f975c2fc88a3..1d650e66cc6e 100644
> --- a/drivers/net/ethernet/8390/Makefile
> +++ b/drivers/net/ethernet/8390/Makefile
> @@ -7,8 +7,8 @@ obj-$(CONFIG_MAC8390) += mac8390.o
> obj-$(CONFIG_APNE) += apne.o 8390.o
> obj-$(CONFIG_ARM_ETHERH) += etherh.o
> obj-$(CONFIG_AX88796) += ax88796.o
> -obj-$(CONFIG_HYDRA) += hydra.o 8390.o
> -obj-$(CONFIG_MCF8390) += mcf8390.o 8390.o
> +obj-$(CONFIG_HYDRA) += hydra.o
> +obj-$(CONFIG_MCF8390) += mcf8390.o
> obj-$(CONFIG_NE2000) += ne.o 8390p.o
> obj-$(CONFIG_NE2K_PCI) += ne2k-pci.o 8390.o
> obj-$(CONFIG_PCMCIA_AXNET) += axnet_cs.o 8390.o
> @@ -16,4 +16,4 @@ obj-$(CONFIG_PCMCIA_PCNET) += pcnet_cs.o 8390.o
> obj-$(CONFIG_STNIC) += stnic.o 8390.o
> obj-$(CONFIG_ULTRA) += smc-ultra.o 8390.o
> obj-$(CONFIG_WD80x3) += wd.o 8390.o
> -obj-$(CONFIG_ZORRO8390) += zorro8390.o 8390.o
> +obj-$(CONFIG_ZORRO8390) += zorro8390.o
>
next prev parent reply other threads:[~2018-02-19 2:58 UTC|newest]
Thread overview: 31+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-02-19 2:39 [PATCH net 0/4] Fixes, cleanup and modernization for 8390 ethernet drivers Finn Thain
2018-02-19 2:39 ` Finn Thain
2018-02-19 2:39 ` [PATCH net 2/4] net/8390: Fix msg_enable patch snafu Finn Thain
2018-02-19 2:39 ` Finn Thain
2018-02-19 2:39 ` Finn Thain
2018-02-19 19:11 ` David Miller
2018-02-19 19:11 ` David Miller
2018-02-19 19:11 ` David Miller
2018-02-19 22:01 ` Finn Thain
2018-02-19 22:01 ` Finn Thain
2018-02-19 22:01 ` Finn Thain
2018-02-19 23:43 ` David Miller
2018-02-19 23:43 ` David Miller
2018-02-19 23:43 ` David Miller
2018-02-20 0:42 ` Finn Thain
2018-02-20 0:42 ` Finn Thain
2018-02-20 0:42 ` Finn Thain
2018-02-20 4:15 ` David Miller
2018-02-20 4:15 ` David Miller
2018-02-20 4:15 ` David Miller
2018-02-21 19:14 ` David Miller
2018-02-21 19:14 ` David Miller
2018-02-21 19:14 ` David Miller
2018-02-19 2:39 ` [PATCH net 3/4] net/mac8390: Convert to nubus_driver Finn Thain
2018-02-19 2:39 ` Finn Thain
2018-02-19 2:39 ` [PATCH net 1/4] net/8390: Remove redundant make dependencies Finn Thain
2018-02-19 2:39 ` Finn Thain
2018-02-19 2:47 ` Greg Ungerer [this message]
2018-02-19 2:47 ` Greg Ungerer
2018-02-19 2:39 ` [PATCH net 4/4] net/mac8390: Fix log messages Finn Thain
2018-02-19 2:39 ` Finn Thain
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=c7a53542-3098-9932-ef92-92f16b39dc91@linux-m68k.org \
--to=gerg@linux-m68k.org \
--cc=davem@davemloft.net \
--cc=fthain@telegraphics.com.au \
--cc=geert@linux-m68k.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-m68k@vger.kernel.org \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.