* [PATCH] serial: Add additional depencies for PL010 and PL011 drivers
@ 2021-06-24 11:56 Michal Simek
2021-06-26 18:32 ` Simon Glass
0 siblings, 1 reply; 2+ messages in thread
From: Michal Simek @ 2021-06-24 11:56 UTC (permalink / raw)
To: u-boot, git
Cc: AKASHI Takahiro, Mark Kettenis, Peng Fan, Sean Anderson,
Simon Glass, Stefan Roese, Vabhav Sharma, Weijie Gao
Both of these drivers are implemented with and without DM that's why more
symbols should be handled.
The most problematic one is enabling DEBUG_UART_PL011 based on
PL01X_SERIAL(DM based) because debug console has type selection based on
it.
enum pl01x_type type = CONFIG_IS_ENABLED(DEBUG_UART_PL011) ?
TYPE_PL011 : TYPE_PL010;
Without it pl01x_generic_setbrg() is configuring different registers.
Fixes: 4cc24aeaf420 ("serial: Add missing Kconfig dependencies for debug consoles")
Signed-off-by: Michal Simek <michal.simek@xilinx.com>
---
drivers/serial/Kconfig | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/drivers/serial/Kconfig b/drivers/serial/Kconfig
index 6d1c4530ddf5..9f82467c4e3c 100644
--- a/drivers/serial/Kconfig
+++ b/drivers/serial/Kconfig
@@ -332,7 +332,7 @@ config DEBUG_UART_APBUART
config DEBUG_UART_PL010
bool "pl010"
- depends on PL01X_SERIAL
+ depends on PL01X_SERIAL || PL010_SERIAL
help
Select this to enable a debug UART using the pl01x driver with the
PL010 UART type. You will need to provide parameters to make this
@@ -341,7 +341,7 @@ config DEBUG_UART_PL010
config DEBUG_UART_PL011
bool "pl011"
- depends on PL011_SERIAL
+ depends on PL01X_SERIAL || PL011_SERIAL
help
Select this to enable a debug UART using the pl01x driver with the
PL011 UART type. You will need to provide parameters to make this
--
2.32.0
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH] serial: Add additional depencies for PL010 and PL011 drivers
2021-06-24 11:56 [PATCH] serial: Add additional depencies for PL010 and PL011 drivers Michal Simek
@ 2021-06-26 18:32 ` Simon Glass
0 siblings, 0 replies; 2+ messages in thread
From: Simon Glass @ 2021-06-26 18:32 UTC (permalink / raw)
To: Michal Simek
Cc: U-Boot Mailing List, git, AKASHI Takahiro, Mark Kettenis,
Peng Fan, Sean Anderson, Stefan Roese, Vabhav Sharma, Weijie Gao
On Thu, 24 Jun 2021 at 05:57, Michal Simek <michal.simek@xilinx.com> wrote:
>
> Both of these drivers are implemented with and without DM that's why more
> symbols should be handled.
> The most problematic one is enabling DEBUG_UART_PL011 based on
> PL01X_SERIAL(DM based) because debug console has type selection based on
> it.
> enum pl01x_type type = CONFIG_IS_ENABLED(DEBUG_UART_PL011) ?
> TYPE_PL011 : TYPE_PL010;
>
> Without it pl01x_generic_setbrg() is configuring different registers.
>
> Fixes: 4cc24aeaf420 ("serial: Add missing Kconfig dependencies for debug consoles")
> Signed-off-by: Michal Simek <michal.simek@xilinx.com>
> ---
>
> drivers/serial/Kconfig | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
Reviewed-by: Simon Glass <sjg@chromium.org>
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2021-06-26 18:35 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2021-06-24 11:56 [PATCH] serial: Add additional depencies for PL010 and PL011 drivers Michal Simek
2021-06-26 18:32 ` Simon Glass
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.