[MPTCP] Re: [PATCH net] mptcp: fix DSS map generation on fin retransmission

[MPTCP] Re: [PATCH net] mptcp: fix DSS map generation on fin retransmission

[Matthieu Baerts]

[-- Attachment #1: Type: text/plain, Size: 1347 bytes --]

Hi Paolo, Mat, Christoph

On 30/06/2020 20:28, Mat Martineau wrote:
> On Fri, 26 Jun 2020, Paolo Abeni wrote:
> 
>> The RFC 8684 mandates that no-data DATA FIN packets should carry
>> a DSS with 0 sequence number and data len equal to 1. Currently,
>> on FIN retransmission we re-use the existing mapping; if the previous
>> fin transmission was part of a partially acked data packet, we could
>> end-up writing in the egress packet a non-compliant DSS.
>>
>> The above will be detected by a "Bad mapping" warning on the receiver
>> side.
>>
>> This change addresses the issue explicitly checking for 0 len packet
>> when adding the DATA_FIN option.
>>
>> Fixes: 6d0060f600ad ("mptcp: Write MPTCP DSS headers to outgoing data 
>> packets")
>> Signed-off-by: Paolo Abeni <pabeni(a)redhat.com>
> 
> Thanks Paolo, looks good.
> 
> Reviewed-by: Mat Martineau <mathew.j.martineau(a)linux.intel.com>

Thank you for the patch, the validation and the reviews!

@Christoph: it seems "Reviewed-and-tested-by" tag is not recognised by 
Patchwork so I split them :)

I added this patch at the end:

- aea4d1ebbc5f: mptcp: fix DSS map generation on fin retransmission
- d8ab2db3ac90..3813e7acdac2: result

Tests and export are in progress.

Cheers,
Matt
-- 
Tessares | Belgium | Hybrid Access Solutions
www.tessares.net

[MPTCP] Re: [PATCH net] mptcp: fix DSS map generation on fin retransmission

[David Miller]

[-- Attachment #1: Type: text/plain, Size: 1056 bytes --]

From: Paolo Abeni <pabeni(a)redhat.com>
Date: Fri,  3 Jul 2020 18:06:04 +0200

> The RFC 8684 mandates that no-data DATA FIN packets should carry
> a DSS with 0 sequence number and data len equal to 1. Currently,
> on FIN retransmission we re-use the existing mapping; if the previous
> fin transmission was part of a partially acked data packet, we could
> end-up writing in the egress packet a non-compliant DSS.
> 
> The above will be detected by a "Bad mapping" warning on the receiver
> side.
> 
> This change addresses the issue explicitly checking for 0 len packet
> when adding the DATA_FIN option.
> 
> Fixes: 6d0060f600ad ("mptcp: Write MPTCP DSS headers to outgoing data packets")
> Reported-by: syzbot+42a07faa5923cfaeb9c9(a)syzkaller.appspotmail.com
> Tested-by: Christoph Paasch <cpaasch(a)apple.com>
> Reviewed-by: Christoph Paasch <cpaasch(a)apple.com>
> Reviewed-by: Mat Martineau <mathew.j.martineau(a)linux.intel.com>
> Signed-off-by: Paolo Abeni <pabeni(a)redhat.com>

Applied and queued up for -stable, thank you.

[MPTCP] Re: [PATCH net] mptcp: fix DSS map generation on fin retransmission

[Mat Martineau]

[-- Attachment #1: Type: text/plain, Size: 2038 bytes --]

On Fri, 26 Jun 2020, Paolo Abeni wrote:

> The RFC 8684 mandates that no-data DATA FIN packets should carry
> a DSS with 0 sequence number and data len equal to 1. Currently,
> on FIN retransmission we re-use the existing mapping; if the previous
> fin transmission was part of a partially acked data packet, we could
> end-up writing in the egress packet a non-compliant DSS.
>
> The above will be detected by a "Bad mapping" warning on the receiver
> side.
>
> This change addresses the issue explicitly checking for 0 len packet
> when adding the DATA_FIN option.
>
> Fixes: 6d0060f600ad ("mptcp: Write MPTCP DSS headers to outgoing data packets")
> Signed-off-by: Paolo Abeni <pabeni(a)redhat.com>
> ---
> net/mptcp/options.c | 6 +++---
> 1 file changed, 3 insertions(+), 3 deletions(-)
> ---
> this should go on "top" of export branch, just before the "DO NOT MERGE"
> changes.
> Hopefully should not conflict with others
>
> diff --git a/net/mptcp/options.c b/net/mptcp/options.c
> index f464f8669dfc..46470194b8ca 100644
> --- a/net/mptcp/options.c
> +++ b/net/mptcp/options.c
> @@ -451,9 +451,9 @@ static bool mptcp_established_options_mp(struct sock *sk, struct sk_buff *skb,
> }
>
> static void mptcp_write_data_fin(struct mptcp_subflow_context *subflow,
> -				 struct mptcp_ext *ext)
> +				 struct sk_buff *skb, struct mptcp_ext *ext)
> {
> -	if (!ext->use_map) {
> +	if (!ext->use_map || !skb->len) {
> 		/* RFC6824 requires a DSS mapping with specific values
> 		 * if DATA_FIN is set but no data payload is mapped
> 		 */
> @@ -505,7 +505,7 @@ static bool mptcp_established_options_dss(struct sock *sk, struct sk_buff *skb,
> 			opts->ext_copy = *mpext;
>
> 		if (skb && tcp_fin && subflow->data_fin_tx_enable)
> -			mptcp_write_data_fin(subflow, &opts->ext_copy);
> +			mptcp_write_data_fin(subflow, skb, &opts->ext_copy);
> 		ret = true;
> 	}
>

Thanks Paolo, looks good.

Reviewed-by: Mat Martineau <mathew.j.martineau(a)linux.intel.com>


--
Mat Martineau
Intel

[MPTCP] Re: [PATCH net] mptcp: fix DSS map generation on fin retransmission

[Christoph Paasch]

[-- Attachment #1: Type: text/plain, Size: 2312 bytes --]

On 06/26/20 - 11:10, Paolo Abeni wrote:
> The RFC 8684 mandates that no-data DATA FIN packets should carry
> a DSS with 0 sequence number and data len equal to 1. Currently,
> on FIN retransmission we re-use the existing mapping; if the previous
> fin transmission was part of a partially acked data packet, we could
> end-up writing in the egress packet a non-compliant DSS.
> 
> The above will be detected by a "Bad mapping" warning on the receiver
> side.
> 
> This change addresses the issue explicitly checking for 0 len packet
> when adding the DATA_FIN option.
> 
> Fixes: 6d0060f600ad ("mptcp: Write MPTCP DSS headers to outgoing data packets")
> Signed-off-by: Paolo Abeni <pabeni(a)redhat.com>
> ---
>  net/mptcp/options.c | 6 +++---
>  1 file changed, 3 insertions(+), 3 deletions(-)
> ---


Nice!

We can add the syzbot-tag as well:


Reported-by: syzbot+42a07faa5923cfaeb9c9(a)syzkaller.appspotmail.com
Reviewed-and-tested-by: Christoph Paasch <cpaasch(a)apple.com>


Christoph


> this should go on "top" of export branch, just before the "DO NOT MERGE"
> changes.
> Hopefully should not conflict with others
> 
> diff --git a/net/mptcp/options.c b/net/mptcp/options.c
> index f464f8669dfc..46470194b8ca 100644
> --- a/net/mptcp/options.c
> +++ b/net/mptcp/options.c
> @@ -451,9 +451,9 @@ static bool mptcp_established_options_mp(struct sock *sk, struct sk_buff *skb,
>  }
>  
>  static void mptcp_write_data_fin(struct mptcp_subflow_context *subflow,
> -				 struct mptcp_ext *ext)
> +				 struct sk_buff *skb, struct mptcp_ext *ext)
>  {
> -	if (!ext->use_map) {
> +	if (!ext->use_map || !skb->len) {
>  		/* RFC6824 requires a DSS mapping with specific values
>  		 * if DATA_FIN is set but no data payload is mapped
>  		 */
> @@ -505,7 +505,7 @@ static bool mptcp_established_options_dss(struct sock *sk, struct sk_buff *skb,
>  			opts->ext_copy = *mpext;
>  
>  		if (skb && tcp_fin && subflow->data_fin_tx_enable)
> -			mptcp_write_data_fin(subflow, &opts->ext_copy);
> +			mptcp_write_data_fin(subflow, skb, &opts->ext_copy);
>  		ret = true;
>  	}
>  
> -- 
> 2.26.2
> _______________________________________________
> mptcp mailing list -- mptcp(a)lists.01.org
> To unsubscribe send an email to mptcp-leave(a)lists.01.org