All of lore.kernel.org
 help / color / mirror / Atom feed
From: Bean <bean123ch@gmail.com>
To: The development of GRUB 2 <grub-devel@gnu.org>
Subject: Re: Migrating to GRUB 2 in Debian (Re: Interesting GSoC project ideas for 09)
Date: Sun, 15 Mar 2009 13:52:05 +0800	[thread overview]
Message-ID: <ca0f59980903142252i772f8725x2f39df8ea997d977@mail.gmail.com> (raw)
In-Reply-To: <200903150610.40823.okuji@enbug.org>

On Sun, Mar 15, 2009 at 5:10 AM, Yoshinori K. Okuji <okuji@enbug.org> wrote:
> On Friday 13 March 2009 21:23:19 phcoder wrote:
>> Look at load_env/save_env commands and grub-editenv util
>
> Thanks. Now I really regret that I didn't find those additions earlier.
>
> I do not like this implementation for the following reasons:
>
> - The saved file is not plain text, unlike GRUB Legacy. This is a bad choice.
> Please let me know the reason why it must be binary, if any.

Hi,

As the command need to write to disk using blocklist information,
which is not always correct (such as tail packing, sparse block), I
use a magic header for verification. The length field is used to
indicate the length of the block. because the command can't expand
file, otherwise it would need to update fs information, which is too
much for grub.

> - The command names are ugly. Why didn't anybody follow Pavel's advise
> using "env"?
>
> - The utility name is also ugly. I like Pavel's suggestion "grub-env".
>
> If nobody stops me, I will rewrite it in one week, without caring about
> backward compatibility.

I have no objection for the rename, although there should be two env
commands, one to load and one to save.

-- 
Bean



  reply	other threads:[~2009-03-15  5:52 UTC|newest]

Thread overview: 23+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2009-02-25  9:21 Interesting GSoC project ideas for 09 "C. Bergström"
2009-02-25 11:59 ` phcoder
2009-02-27 21:08   ` Robert Millan
2009-02-28 11:54     ` phcoder
2009-03-01  4:28       ` Pavel Roskin
2009-03-01 17:15         ` phcoder
2009-03-04 21:02           ` Robert Millan
2009-03-04 20:59         ` Migrating to GRUB 2 in Debian (Re: Interesting GSoC project ideas for 09) Robert Millan
2009-03-13 11:50           ` Yoshinori K. Okuji
2009-03-13 12:23             ` phcoder
2009-03-14 21:10               ` Yoshinori K. Okuji
2009-03-15  5:52                 ` Bean [this message]
2009-03-22  7:01                   ` Yoshinori K. Okuji
2009-03-22 10:48                     ` phcoder
2009-03-22 13:11                       ` Yoshinori K. Okuji
2009-03-22 13:23                         ` phcoder
2009-03-22 14:02                           ` Yoshinori K. Okuji
2009-03-22 12:29                     ` Robert Millan
2009-03-22 12:50                       ` Yoshinori K. Okuji
2009-03-28 20:02                         ` Yoshinori K. Okuji
2009-03-02  7:52       ` Interesting GSoC project ideas for 09 liu Aleaxander
2009-03-01 14:55   ` liu Aleaxander
2009-03-01 15:30     ` phcoder

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=ca0f59980903142252i772f8725x2f39df8ea997d977@mail.gmail.com \
    --to=bean123ch@gmail.com \
    --cc=grub-devel@gnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.