All of lore.kernel.org
 help / color / mirror / Atom feed
From: Timur Tabi <timur@codeaurora.org>
To: Florian Fainelli <f.fainelli@gmail.com>,
	linux-arm-kernel@lists.infradead.org
Cc: tchalamarla@cavium.com, rrichter@cavium.com, opendmb@gmail.com,
	Catalin Marinas <catalin.marinas@arm.com>,
	Will Deacon <will.deacon@arm.com>,
	Mark Rutland <mark.rutland@arm.com>,
	open list <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH] arm64: Make L1_CACHE_SHIFT configurable
Date: Mon, 12 Feb 2018 17:52:24 -0600	[thread overview]
Message-ID: <ca6c47f9-86df-bcdb-bbe1-eac9db68ec33@codeaurora.org> (raw)
In-Reply-To: <1518479125-14428-1-git-send-email-f.fainelli@gmail.com>

On 02/12/2018 05:45 PM, Florian Fainelli wrote:
> +config ARM64_L1_CACHE_SHIFT
> +	int
> +	default 7 if ARM64_L1_CACHE_SHIFT_7
> +	default 6

Shouldn't this be the other way around?  Everyone is used to 7 now, so 
you're changing the default back to 6.  I would think that it should be 
7 by default, and platforms like Brahma-B53 should force it to 6.

-- 
Qualcomm Datacenter Technologies, Inc. as an affiliate of Qualcomm
Technologies, Inc.  Qualcomm Technologies, Inc. is a member of the
Code Aurora Forum, a Linux Foundation Collaborative Project.

WARNING: multiple messages have this Message-ID (diff)
From: timur@codeaurora.org (Timur Tabi)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH] arm64: Make L1_CACHE_SHIFT configurable
Date: Mon, 12 Feb 2018 17:52:24 -0600	[thread overview]
Message-ID: <ca6c47f9-86df-bcdb-bbe1-eac9db68ec33@codeaurora.org> (raw)
In-Reply-To: <1518479125-14428-1-git-send-email-f.fainelli@gmail.com>

On 02/12/2018 05:45 PM, Florian Fainelli wrote:
> +config ARM64_L1_CACHE_SHIFT
> +	int
> +	default 7 if ARM64_L1_CACHE_SHIFT_7
> +	default 6

Shouldn't this be the other way around?  Everyone is used to 7 now, so 
you're changing the default back to 6.  I would think that it should be 
7 by default, and platforms like Brahma-B53 should force it to 6.

-- 
Qualcomm Datacenter Technologies, Inc. as an affiliate of Qualcomm
Technologies, Inc.  Qualcomm Technologies, Inc. is a member of the
Code Aurora Forum, a Linux Foundation Collaborative Project.

  reply	other threads:[~2018-02-12 23:52 UTC|newest]

Thread overview: 14+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-02-12 23:45 [PATCH] arm64: Make L1_CACHE_SHIFT configurable Florian Fainelli
2018-02-12 23:45 ` Florian Fainelli
2018-02-12 23:52 ` Timur Tabi [this message]
2018-02-12 23:52   ` Timur Tabi
2018-02-12 23:57   ` Florian Fainelli
2018-02-12 23:57     ` Florian Fainelli
2018-02-13  0:10     ` Timur Tabi
2018-02-13  0:10       ` Timur Tabi
2018-02-13  0:17       ` Florian Fainelli
2018-02-13  0:17         ` Florian Fainelli
2018-02-19 23:46         ` Jon Masters
2018-02-19 23:46           ` Jon Masters
2018-02-13 11:57 ` Catalin Marinas
2018-02-13 11:57   ` Catalin Marinas

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=ca6c47f9-86df-bcdb-bbe1-eac9db68ec33@codeaurora.org \
    --to=timur@codeaurora.org \
    --cc=catalin.marinas@arm.com \
    --cc=f.fainelli@gmail.com \
    --cc=linux-arm-kernel@lists.infradead.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=mark.rutland@arm.com \
    --cc=opendmb@gmail.com \
    --cc=rrichter@cavium.com \
    --cc=tchalamarla@cavium.com \
    --cc=will.deacon@arm.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.