* [PATCH] orinoco: fix repeated words in comments
@ 2022-09-15 3:02 Jilin Yuan
2022-09-15 3:54 ` Jeff Johnson
0 siblings, 1 reply; 3+ messages in thread
From: Jilin Yuan @ 2022-09-15 3:02 UTC (permalink / raw)
To: davem, edumazet, kuba, pabeni
Cc: linux-wireless, netdev, linux-kernel, Jilin Yuan
Delete the redundant word 'this'.
Signed-off-by: Jilin Yuan <yuanjilin@cdjrlc.com>
---
drivers/net/wireless/intersil/orinoco/main.h | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/net/wireless/intersil/orinoco/main.h b/drivers/net/wireless/intersil/orinoco/main.h
index 5a8fec26136e..852e1643dad2 100644
--- a/drivers/net/wireless/intersil/orinoco/main.h
+++ b/drivers/net/wireless/intersil/orinoco/main.h
@@ -12,7 +12,7 @@
/* Compile time configuration and compatibility stuff */
/********************************************************************/
-/* We do this this way to avoid ifdefs in the actual code */
+/* We do this way to avoid ifdefs in the actual code */
#ifdef WIRELESS_SPY
#define SPY_NUMBER(priv) (priv->spy_data.spy_number)
#else
--
2.36.1
^ permalink raw reply related [flat|nested] 3+ messages in thread
* Re: [PATCH] orinoco: fix repeated words in comments
2022-09-15 3:02 [PATCH] orinoco: fix repeated words in comments Jilin Yuan
@ 2022-09-15 3:54 ` Jeff Johnson
2022-09-15 5:13 ` Jeff Johnson
0 siblings, 1 reply; 3+ messages in thread
From: Jeff Johnson @ 2022-09-15 3:54 UTC (permalink / raw)
To: Jilin Yuan, davem, edumazet, kuba, pabeni
Cc: linux-wireless, netdev, linux-kernel
On 9/14/2022 8:02 PM, Jilin Yuan wrote:
> Delete the redundant word 'this'.
>
> Signed-off-by: Jilin Yuan <yuanjilin@cdjrlc.com>
> ---
> drivers/net/wireless/intersil/orinoco/main.h | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/net/wireless/intersil/orinoco/main.h b/drivers/net/wireless/intersil/orinoco/main.h
> index 5a8fec26136e..852e1643dad2 100644
> --- a/drivers/net/wireless/intersil/orinoco/main.h
> +++ b/drivers/net/wireless/intersil/orinoco/main.h
> @@ -12,7 +12,7 @@
> /* Compile time configuration and compatibility stuff */
> /********************************************************************/
>
> -/* We do this this way to avoid ifdefs in the actual code */
> +/* We do this way to avoid ifdefs in the actual code */
In this case the two instances of "this" are not a repetition, they are
different parts of speech.
The existing sentence is correct English; the modified sentence is not.
If the repeated word really bothers you then insert "in": We do this in
this way...
> #ifdef WIRELESS_SPY
> #define SPY_NUMBER(priv) (priv->spy_data.spy_number)
> #else
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH] orinoco: fix repeated words in comments
2022-09-15 3:54 ` Jeff Johnson
@ 2022-09-15 5:13 ` Jeff Johnson
0 siblings, 0 replies; 3+ messages in thread
From: Jeff Johnson @ 2022-09-15 5:13 UTC (permalink / raw)
To: Jilin Yuan, davem, edumazet, kuba, pabeni
Cc: linux-wireless, netdev, linux-kernel
On 9/14/2022 8:54 PM, Jeff Johnson wrote:
> On 9/14/2022 8:02 PM, Jilin Yuan wrote:
>> Delete the redundant word 'this'.
>>
>> Signed-off-by: Jilin Yuan <yuanjilin@cdjrlc.com>
>> ---
>> drivers/net/wireless/intersil/orinoco/main.h | 2 +-
>> 1 file changed, 1 insertion(+), 1 deletion(-)
>>
>> diff --git a/drivers/net/wireless/intersil/orinoco/main.h
>> b/drivers/net/wireless/intersil/orinoco/main.h
>> index 5a8fec26136e..852e1643dad2 100644
>> --- a/drivers/net/wireless/intersil/orinoco/main.h
>> +++ b/drivers/net/wireless/intersil/orinoco/main.h
>> @@ -12,7 +12,7 @@
>> /* Compile time configuration and compatibility stuff */
>> /********************************************************************/
>> -/* We do this this way to avoid ifdefs in the actual code */
>> +/* We do this way to avoid ifdefs in the actual code */
>
> In this case the two instances of "this" are not a repetition, they are
> different parts of speech.
>
> The existing sentence is correct English; the modified sentence is not.
>
> If the repeated word really bothers you then insert "in": We do this in
> this way...
>
>
>> #ifdef WIRELESS_SPY
>> #define SPY_NUMBER(priv) (priv->spy_data.spy_number)
>> #else
>
In addition the patch subject of all files in drivers/net/wireless
should now begin with "wifi: "
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2022-09-15 5:14 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2022-09-15 3:02 [PATCH] orinoco: fix repeated words in comments Jilin Yuan
2022-09-15 3:54 ` Jeff Johnson
2022-09-15 5:13 ` Jeff Johnson
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.