* [Buildroot] [PATCH 2/3] package/kvazaar: needs C++ compiler
2017-07-04 23:08 [Buildroot] [PATCH 1/3] package/kvazaar: add host-pkgconf dependency Romain Naour
@ 2017-07-04 23:08 ` Romain Naour
2017-07-04 23:11 ` Arnout Vandecappelle
2017-07-04 23:08 ` [Buildroot] [PATCH 3/3] package/kvazaar: needs BR2_TOOLCHAIN_HAS_SYNC_4 Romain Naour
` (2 subsequent siblings)
3 siblings, 1 reply; 7+ messages in thread
From: Romain Naour @ 2017-07-04 23:08 UTC (permalink / raw)
To: buildroot
Even if there is only one CPP file src/extras/crypto.cpp which should
be disabled by --without-cryptopp, kvazaar fail to build the shared
library libkvazaar.so when no C++ compiler is available.
checking whether we are using the GNU C++ compiler... no
Fixes:
[microblazel] http://autobuild.buildroot.net/results/5d1/5d140ed95e292f73b6770a5e5be717df844e4830
[arm] http://autobuild.buildroot.net/results/c55/c55b973502b9b88643ae9fca11447b547148275d
Signed-off-by: Romain Naour <romain.naour@smile.fr>
---
package/kvazaar/Config.in | 5 +++--
1 file changed, 3 insertions(+), 2 deletions(-)
diff --git a/package/kvazaar/Config.in b/package/kvazaar/Config.in
index 06ab9ac..de2c6c9 100644
--- a/package/kvazaar/Config.in
+++ b/package/kvazaar/Config.in
@@ -1,10 +1,11 @@
config BR2_PACKAGE_KVAZAAR
bool "kvazaar"
+ depends on BR2_INSTALL_LIBSTDCPP
depends on BR2_TOOLCHAIN_HAS_THREADS
help
An open-source HEVC encoder licensed under LGPLv2.1
https://github.com/ultravideo/kvazaar
-comment "kvazaar needs a toolchain w/ threads"
- depends on !BR2_TOOLCHAIN_HAS_THREADS
+comment "kvazaar needs a toolchain w/ C++, threads"
+ depends on !BR2_INSTALL_LIBSTDCPP || !BR2_TOOLCHAIN_HAS_THREADS
--
2.9.4
^ permalink raw reply related [flat|nested] 7+ messages in thread
* [Buildroot] [PATCH 2/3] package/kvazaar: needs C++ compiler
2017-07-04 23:08 ` [Buildroot] [PATCH 2/3] package/kvazaar: needs C++ compiler Romain Naour
@ 2017-07-04 23:11 ` Arnout Vandecappelle
0 siblings, 0 replies; 7+ messages in thread
From: Arnout Vandecappelle @ 2017-07-04 23:11 UTC (permalink / raw)
To: buildroot
On 05-07-17 01:08, Romain Naour wrote:
> Even if there is only one CPP file src/extras/crypto.cpp which should
> be disabled by --without-cryptopp, kvazaar fail to build the shared
> library libkvazaar.so when no C++ compiler is available.
>
> checking whether we are using the GNU C++ compiler... no
>
> Fixes:
> [microblazel] http://autobuild.buildroot.net/results/5d1/5d140ed95e292f73b6770a5e5be717df844e4830
> [arm] http://autobuild.buildroot.net/results/c55/c55b973502b9b88643ae9fca11447b547148275d
>
> Signed-off-by: Romain Naour <romain.naour@smile.fr>
Reviewed-by: Arnout Vandecappelle (Essensium/Mind) <arnout@mind.be>
Regards,
Arnout
> ---
> package/kvazaar/Config.in | 5 +++--
> 1 file changed, 3 insertions(+), 2 deletions(-)
>
> diff --git a/package/kvazaar/Config.in b/package/kvazaar/Config.in
> index 06ab9ac..de2c6c9 100644
> --- a/package/kvazaar/Config.in
> +++ b/package/kvazaar/Config.in
> @@ -1,10 +1,11 @@
> config BR2_PACKAGE_KVAZAAR
> bool "kvazaar"
> + depends on BR2_INSTALL_LIBSTDCPP
> depends on BR2_TOOLCHAIN_HAS_THREADS
> help
> An open-source HEVC encoder licensed under LGPLv2.1
>
> https://github.com/ultravideo/kvazaar
>
> -comment "kvazaar needs a toolchain w/ threads"
> - depends on !BR2_TOOLCHAIN_HAS_THREADS
> +comment "kvazaar needs a toolchain w/ C++, threads"
> + depends on !BR2_INSTALL_LIBSTDCPP || !BR2_TOOLCHAIN_HAS_THREADS
>
--
Arnout Vandecappelle arnout at mind be
Senior Embedded Software Architect +32-16-286500
Essensium/Mind http://www.mind.be
G.Geenslaan 9, 3001 Leuven, Belgium BE 872 984 063 RPR Leuven
LinkedIn profile: http://www.linkedin.com/in/arnoutvandecappelle
GPG fingerprint: 7493 020B C7E3 8618 8DEC 222C 82EB F404 F9AC 0DDF
^ permalink raw reply [flat|nested] 7+ messages in thread
* [Buildroot] [PATCH 3/3] package/kvazaar: needs BR2_TOOLCHAIN_HAS_SYNC_4
2017-07-04 23:08 [Buildroot] [PATCH 1/3] package/kvazaar: add host-pkgconf dependency Romain Naour
2017-07-04 23:08 ` [Buildroot] [PATCH 2/3] package/kvazaar: needs C++ compiler Romain Naour
@ 2017-07-04 23:08 ` Romain Naour
2017-07-04 23:11 ` Arnout Vandecappelle
2017-07-04 23:11 ` [Buildroot] [PATCH 1/3] package/kvazaar: add host-pkgconf dependency Arnout Vandecappelle
2017-07-04 23:20 ` Thomas Petazzoni
3 siblings, 1 reply; 7+ messages in thread
From: Romain Naour @ 2017-07-04 23:08 UTC (permalink / raw)
To: buildroot
./.libs/libkvazaar.so: undefined reference to `__sync_add_and_fetch_4'
Fixes:
http://autobuild.buildroot.net/results/b39/b39a82a2e4106c5ec55c288415e73043a872a0b1
Signed-off-by: Romain Naour <romain.naour@smile.fr>
---
package/kvazaar/Config.in | 2 ++
1 file changed, 2 insertions(+)
diff --git a/package/kvazaar/Config.in b/package/kvazaar/Config.in
index de2c6c9..fb97369 100644
--- a/package/kvazaar/Config.in
+++ b/package/kvazaar/Config.in
@@ -2,10 +2,12 @@ config BR2_PACKAGE_KVAZAAR
bool "kvazaar"
depends on BR2_INSTALL_LIBSTDCPP
depends on BR2_TOOLCHAIN_HAS_THREADS
+ depends on BR2_TOOLCHAIN_HAS_SYNC_4
help
An open-source HEVC encoder licensed under LGPLv2.1
https://github.com/ultravideo/kvazaar
comment "kvazaar needs a toolchain w/ C++, threads"
+ depends on BR2_TOOLCHAIN_HAS_SYNC_4
depends on !BR2_INSTALL_LIBSTDCPP || !BR2_TOOLCHAIN_HAS_THREADS
--
2.9.4
^ permalink raw reply related [flat|nested] 7+ messages in thread
* [Buildroot] [PATCH 1/3] package/kvazaar: add host-pkgconf dependency
2017-07-04 23:08 [Buildroot] [PATCH 1/3] package/kvazaar: add host-pkgconf dependency Romain Naour
2017-07-04 23:08 ` [Buildroot] [PATCH 2/3] package/kvazaar: needs C++ compiler Romain Naour
2017-07-04 23:08 ` [Buildroot] [PATCH 3/3] package/kvazaar: needs BR2_TOOLCHAIN_HAS_SYNC_4 Romain Naour
@ 2017-07-04 23:11 ` Arnout Vandecappelle
2017-07-04 23:20 ` Thomas Petazzoni
3 siblings, 0 replies; 7+ messages in thread
From: Arnout Vandecappelle @ 2017-07-04 23:11 UTC (permalink / raw)
To: buildroot
On 05-07-17 01:08, Romain Naour wrote:
> The build system use PKG_CHECK_MODULES.
>
> checking pkg-config is at least version 0.9.0... ./configure: line 16886: output/host/usr/bin/pkg-config: No such file or directory
> no
>
> Signed-off-by: Romain Naour <romain.naour@smile.fr>
Reviewed-by: Arnout Vandecappelle (Essensium/Mind) <arnout@mind.be>
Regards,
Arnout
> ---
> package/kvazaar/kvazaar.mk | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/package/kvazaar/kvazaar.mk b/package/kvazaar/kvazaar.mk
> index 30b8bda..f9149a7 100644
> --- a/package/kvazaar/kvazaar.mk
> +++ b/package/kvazaar/kvazaar.mk
> @@ -10,6 +10,7 @@ KVAZAAR_LICENSE = LGPL-2.1+
> KVAZAAR_LICENSE_FILES = COPYING
> KVAZAAR_AUTORECONF = YES
> KVAZAAR_INSTALL_STAGING = YES
> +KVAZAAR_DEPENDENCIES = host-pkgconf
> KVAZAAR_CONF_OPTS = --without-cryptopp
>
> $(eval $(autotools-package))
>
--
Arnout Vandecappelle arnout at mind be
Senior Embedded Software Architect +32-16-286500
Essensium/Mind http://www.mind.be
G.Geenslaan 9, 3001 Leuven, Belgium BE 872 984 063 RPR Leuven
LinkedIn profile: http://www.linkedin.com/in/arnoutvandecappelle
GPG fingerprint: 7493 020B C7E3 8618 8DEC 222C 82EB F404 F9AC 0DDF
^ permalink raw reply [flat|nested] 7+ messages in thread
* [Buildroot] [PATCH 1/3] package/kvazaar: add host-pkgconf dependency
2017-07-04 23:08 [Buildroot] [PATCH 1/3] package/kvazaar: add host-pkgconf dependency Romain Naour
` (2 preceding siblings ...)
2017-07-04 23:11 ` [Buildroot] [PATCH 1/3] package/kvazaar: add host-pkgconf dependency Arnout Vandecappelle
@ 2017-07-04 23:20 ` Thomas Petazzoni
3 siblings, 0 replies; 7+ messages in thread
From: Thomas Petazzoni @ 2017-07-04 23:20 UTC (permalink / raw)
To: buildroot
Hello,
On Wed, 5 Jul 2017 01:08:55 +0200, Romain Naour wrote:
> The build system use PKG_CHECK_MODULES.
>
> checking pkg-config is at least version 0.9.0... ./configure: line 16886: output/host/usr/bin/pkg-config: No such file or directory
> no
>
> Signed-off-by: Romain Naour <romain.naour@smile.fr>
> ---
> package/kvazaar/kvazaar.mk | 1 +
> 1 file changed, 1 insertion(+)
All three patches applied to master. Thanks!
Thomas
--
Thomas Petazzoni, CTO, Free Electrons
Embedded Linux, Kernel and Android engineering
http://free-electrons.com
^ permalink raw reply [flat|nested] 7+ messages in thread