* [PATCH v2] staging: rtl8723bs: os_dep: simplify the return statement.
@ 2021-10-10 5:06 Saurav Girepunje
2021-10-10 7:24 ` Fabio M. De Francesco
` (4 more replies)
0 siblings, 5 replies; 11+ messages in thread
From: Saurav Girepunje @ 2021-10-10 5:06 UTC (permalink / raw)
To: gregkh, fabioaiuto83, ross.schm.dev, marcocesati,
saurav.girepunje, insafonov, linux-staging, linux-kernel
Cc: saurav.girepunje
Remove the unneeded and redundant check of variable on goto out.
Simplify the return using multiple goto label to avoid
unneeded check.
Signed-off-by: Saurav Girepunje <saurav.girepunje@gmail.com>
---
ChangeLog V2:
-Add goto out after the memcpy for no error case return with
ret only. Free is not required on no error case.
ChangeLog V1:
-Remove the unneeded and redundant check of variable on
goto out.
-Simplify the return using multiple goto label to avoid
unneeded check.
.../staging/rtl8723bs/os_dep/ioctl_cfg80211.c | 22 +++++++++----------
1 file changed, 10 insertions(+), 12 deletions(-)
diff --git a/drivers/staging/rtl8723bs/os_dep/ioctl_cfg80211.c b/drivers/staging/rtl8723bs/os_dep/ioctl_cfg80211.c
index 0868f56e2979..ae9579dc0848 100644
--- a/drivers/staging/rtl8723bs/os_dep/ioctl_cfg80211.c
+++ b/drivers/staging/rtl8723bs/os_dep/ioctl_cfg80211.c
@@ -2312,7 +2312,7 @@ static int rtw_cfg80211_add_monitor_if(struct adapter *padapter, char *name, str
mon_wdev = rtw_zmalloc(sizeof(struct wireless_dev));
if (!mon_wdev) {
ret = -ENOMEM;
- goto out;
+ goto err_zmalloc;
}
mon_wdev->wiphy = padapter->rtw_wdev->wiphy;
@@ -2322,23 +2322,21 @@ static int rtw_cfg80211_add_monitor_if(struct adapter *padapter, char *name, str
ret = cfg80211_register_netdevice(mon_ndev);
if (ret) {
- goto out;
+ goto err_register;
}
*ndev = pwdev_priv->pmon_ndev = mon_ndev;
memcpy(pwdev_priv->ifname_mon, name, IFNAMSIZ+1);
+ goto out;
-out:
- if (ret && mon_wdev) {
- kfree(mon_wdev);
- mon_wdev = NULL;
- }
-
- if (ret && mon_ndev) {
- free_netdev(mon_ndev);
- *ndev = mon_ndev = NULL;
- }
+err_register:
+ kfree(mon_wdev);
+ mon_wdev = NULL;
+err_zmalloc:
+ free_netdev(mon_ndev);
+ *ndev = mon_ndev = NULL;
+out:
return ret;
}
--
2.32.0
^ permalink raw reply related [flat|nested] 11+ messages in thread
* Re: [PATCH v2] staging: rtl8723bs: os_dep: simplify the return statement.
2021-10-10 5:06 [PATCH v2] staging: rtl8723bs: os_dep: simplify the return statement Saurav Girepunje
@ 2021-10-10 7:24 ` Fabio M. De Francesco
2021-10-11 18:10 ` Saurav Girepunje
2021-10-10 8:56 ` Pavel Skripkin
` (3 subsequent siblings)
4 siblings, 1 reply; 11+ messages in thread
From: Fabio M. De Francesco @ 2021-10-10 7:24 UTC (permalink / raw)
To: gregkh, saurav.girepunje, Saurav Girepunje
Cc: fabioaiuto83, ross.schm.dev, marcocesati, insafonov,
linux-staging, linux-kernel, saurav.girepunje
On Sunday, October 10, 2021 7:06:05 AM CEST Saurav Girepunje wrote:
> Remove the unneeded and redundant check of variable on goto out.
> Simplify the return using multiple goto label to avoid
> unneeded check.
>
> Signed-off-by: Saurav Girepunje <saurav.girepunje@gmail.com>
> ---
>
> ChangeLog V2:
> -Add goto out after the memcpy for no error case return with
> ret only. Free is not required on no error case.
>
> ChangeLog V1:
> -Remove the unneeded and redundant check of variable on
> goto out.
> -Simplify the return using multiple goto label to avoid
> unneeded check.
>
> .../staging/rtl8723bs/os_dep/ioctl_cfg80211.c | 22 +++++++++----------
> 1 file changed, 10 insertions(+), 12 deletions(-)
>
> diff --git a/drivers/staging/rtl8723bs/os_dep/ioctl_cfg80211.c b/drivers/
staging/rtl8723bs/os_dep/ioctl_cfg80211.c
> index 0868f56e2979..ae9579dc0848 100644
> --- a/drivers/staging/rtl8723bs/os_dep/ioctl_cfg80211.c
> +++ b/drivers/staging/rtl8723bs/os_dep/ioctl_cfg80211.c
> @@ -2312,7 +2312,7 @@ static int rtw_cfg80211_add_monitor_if(struct adapter
*padapter, char *name, str
> mon_wdev = rtw_zmalloc(sizeof(struct wireless_dev));
> if (!mon_wdev) {
> ret = -ENOMEM;
> - goto out;
> + goto err_zmalloc;
> }
>
> mon_wdev->wiphy = padapter->rtw_wdev->wiphy;
> @@ -2322,23 +2322,21 @@ static int rtw_cfg80211_add_monitor_if(struct
adapter *padapter, char *name, str
>
> ret = cfg80211_register_netdevice(mon_ndev);
> if (ret) {
> - goto out;
> + goto err_register;
> }
>
> *ndev = pwdev_priv->pmon_ndev = mon_ndev;
> memcpy(pwdev_priv->ifname_mon, name, IFNAMSIZ+1);
> + goto out;
I think this is the right thing to do in order to remove the bug you
introduced in v1. Well done.
>
> -out:
> - if (ret && mon_wdev) {
> - kfree(mon_wdev);
> - mon_wdev = NULL;
> - }
> -
> - if (ret && mon_ndev) {
> - free_netdev(mon_ndev);
> - *ndev = mon_ndev = NULL;
> - }
> +err_register:
> + kfree(mon_wdev);
> + mon_wdev = NULL;
>
> +err_zmalloc:
> + free_netdev(mon_ndev);
> + *ndev = mon_ndev = NULL;
Not sure about what the Linux coding guidelines say, but I think that
assigning NULL to local (on stack) pointers (mon_wdev, mon_ndev) at this
point is unnecessary. There is no risk of reusing them after the "out"
labelled block, because at function exit they are destroyed when the stack is
unwound.
If you decide to remove these assignments, take care to leave "*ndev = NULL;"
as-is (why?).
Aside from this minor objection...
Acked-by: Fabio M. De Francesco <fmdefrancesco@gmail.com>
Thanks,
Fabio
> +out:
> return ret;
> }
>
> --
> 2.32.0
>
>
>
^ permalink raw reply [flat|nested] 11+ messages in thread
* Re: [PATCH v2] staging: rtl8723bs: os_dep: simplify the return statement.
2021-10-10 5:06 [PATCH v2] staging: rtl8723bs: os_dep: simplify the return statement Saurav Girepunje
2021-10-10 7:24 ` Fabio M. De Francesco
@ 2021-10-10 8:56 ` Pavel Skripkin
2021-10-10 12:59 ` Greg KH
` (2 subsequent siblings)
4 siblings, 0 replies; 11+ messages in thread
From: Pavel Skripkin @ 2021-10-10 8:56 UTC (permalink / raw)
To: Saurav Girepunje, gregkh, fabioaiuto83, ross.schm.dev,
marcocesati, insafonov, linux-staging, linux-kernel
Cc: saurav.girepunje
On 10/10/21 08:06, Saurav Girepunje wrote:
> Remove the unneeded and redundant check of variable on goto out.
> Simplify the return using multiple goto label to avoid
> unneeded check.
>
> Signed-off-by: Saurav Girepunje <saurav.girepunje@gmail.com>
[code snip]
> ret = cfg80211_register_netdevice(mon_ndev);
> if (ret) {
> - goto out;
> + goto err_register;
> }
>
> *ndev = pwdev_priv->pmon_ndev = mon_ndev;
> memcpy(pwdev_priv->ifname_mon, name, IFNAMSIZ+1);
> + goto out;
>
This looks confusing for readers. This is success path and ret is
guaranteed to be 0 at this point, so isn't `return 0;` enough here?
Thanks
> +out:
> return ret;
> }
>
With regards,
Pavel Skripkin
^ permalink raw reply [flat|nested] 11+ messages in thread
* Re: [PATCH v2] staging: rtl8723bs: os_dep: simplify the return statement.
2021-10-10 5:06 [PATCH v2] staging: rtl8723bs: os_dep: simplify the return statement Saurav Girepunje
2021-10-10 7:24 ` Fabio M. De Francesco
2021-10-10 8:56 ` Pavel Skripkin
@ 2021-10-10 12:59 ` Greg KH
2021-10-11 8:54 ` Fabio M. De Francesco
2021-10-11 12:30 ` Dan Carpenter
4 siblings, 0 replies; 11+ messages in thread
From: Greg KH @ 2021-10-10 12:59 UTC (permalink / raw)
To: Saurav Girepunje
Cc: fabioaiuto83, ross.schm.dev, marcocesati, insafonov,
linux-staging, linux-kernel, saurav.girepunje
On Sun, Oct 10, 2021 at 10:36:05AM +0530, Saurav Girepunje wrote:
> Remove the unneeded and redundant check of variable on goto out.
> Simplify the return using multiple goto label to avoid
> unneeded check.
>
> Signed-off-by: Saurav Girepunje <saurav.girepunje@gmail.com>
> ---
>
> ChangeLog V2:
> -Add goto out after the memcpy for no error case return with
> ret only. Free is not required on no error case.
>
> ChangeLog V1:
> -Remove the unneeded and redundant check of variable on
> goto out.
> -Simplify the return using multiple goto label to avoid
> unneeded check.
>
> .../staging/rtl8723bs/os_dep/ioctl_cfg80211.c | 22 +++++++++----------
> 1 file changed, 10 insertions(+), 12 deletions(-)
>
> diff --git a/drivers/staging/rtl8723bs/os_dep/ioctl_cfg80211.c b/drivers/staging/rtl8723bs/os_dep/ioctl_cfg80211.c
> index 0868f56e2979..ae9579dc0848 100644
> --- a/drivers/staging/rtl8723bs/os_dep/ioctl_cfg80211.c
> +++ b/drivers/staging/rtl8723bs/os_dep/ioctl_cfg80211.c
> @@ -2312,7 +2312,7 @@ static int rtw_cfg80211_add_monitor_if(struct adapter *padapter, char *name, str
> mon_wdev = rtw_zmalloc(sizeof(struct wireless_dev));
> if (!mon_wdev) {
> ret = -ENOMEM;
> - goto out;
> + goto err_zmalloc;
> }
>
> mon_wdev->wiphy = padapter->rtw_wdev->wiphy;
> @@ -2322,23 +2322,21 @@ static int rtw_cfg80211_add_monitor_if(struct adapter *padapter, char *name, str
>
> ret = cfg80211_register_netdevice(mon_ndev);
> if (ret) {
> - goto out;
> + goto err_register;
> }
>
> *ndev = pwdev_priv->pmon_ndev = mon_ndev;
> memcpy(pwdev_priv->ifname_mon, name, IFNAMSIZ+1);
> + goto out;
>
> -out:
> - if (ret && mon_wdev) {
> - kfree(mon_wdev);
> - mon_wdev = NULL;
> - }
> -
> - if (ret && mon_ndev) {
> - free_netdev(mon_ndev);
> - *ndev = mon_ndev = NULL;
> - }
> +err_register:
> + kfree(mon_wdev);
> + mon_wdev = NULL;
There is no need to set a local variable like this to NULL.
thanks,
greg k-h
^ permalink raw reply [flat|nested] 11+ messages in thread
* Re: [PATCH v2] staging: rtl8723bs: os_dep: simplify the return statement.
2021-10-10 5:06 [PATCH v2] staging: rtl8723bs: os_dep: simplify the return statement Saurav Girepunje
` (2 preceding siblings ...)
2021-10-10 12:59 ` Greg KH
@ 2021-10-11 8:54 ` Fabio M. De Francesco
2021-10-11 12:33 ` Fabio M. De Francesco
2021-10-11 17:32 ` Saurav Girepunje
2021-10-11 12:30 ` Dan Carpenter
4 siblings, 2 replies; 11+ messages in thread
From: Fabio M. De Francesco @ 2021-10-11 8:54 UTC (permalink / raw)
To: gregkh, fabioaiuto83, ross.schm.dev, marcocesati,
saurav.girepunje, insafonov, linux-staging, linux-kernel,
Saurav Girepunje
Cc: saurav.girepunje
On Sunday, October 10, 2021 7:06:05 AM CEST Saurav Girepunje wrote:
> Remove the unneeded and redundant check of variable on goto out.
> Simplify the return using multiple goto label to avoid
> unneeded check.
>
> Signed-off-by: Saurav Girepunje <saurav.girepunje@gmail.com>
> ---
>
> ChangeLog V2:
> -Add goto out after the memcpy for no error case return with
> ret only. Free is not required on no error case.
Please write versions logs that reflect clearly and unequivocally what you
changed between revisions and why. Subjects, Commit messages (Changelogs),
and Versions logs are the "specifics" of your work. There must be no
inconsistencies between these and the code or the history of the changes of
the code.
You may think that I'm pedantic, but since I acked your patch, I don't want
to be misunderstood to be a promoter of approximate or clearly incorrect
messages.
"Free is not required on no error case" conveys the message that you have
changed something that is not required but that is still potentially allowed.
This is not the case because the problem that you fix with v2 is _not_
something that is merely not required and unnecessary. You have fixed a bug
that is introduced in v1. Introducing bugs is not allowed. If you do
something that is not allowed you cannot simply say that it is not required.
>
> ChangeLog V1:
> -Remove the unneeded and redundant check of variable on
> goto out.
> -Simplify the return using multiple goto label to avoid
> unneeded check.
>
> .../staging/rtl8723bs/os_dep/ioctl_cfg80211.c | 22 +++++++++----------
> 1 file changed, 10 insertions(+), 12 deletions(-)
>
> diff --git a/drivers/staging/rtl8723bs/os_dep/ioctl_cfg80211.c b/drivers/
staging/rtl8723bs/os_dep/ioctl_cfg80211.c
> index 0868f56e2979..ae9579dc0848 100644
> --- a/drivers/staging/rtl8723bs/os_dep/ioctl_cfg80211.c
> +++ b/drivers/staging/rtl8723bs/os_dep/ioctl_cfg80211.c
> @@ -2312,7 +2312,7 @@ static int rtw_cfg80211_add_monitor_if(struct adapter
*padapter, char *name, str
> mon_wdev = rtw_zmalloc(sizeof(struct wireless_dev));
> if (!mon_wdev) {
> ret = -ENOMEM;
> - goto out;
> + goto err_zmalloc;
> }
>
> mon_wdev->wiphy = padapter->rtw_wdev->wiphy;
> @@ -2322,23 +2322,21 @@ static int rtw_cfg80211_add_monitor_if(struct
adapter *padapter, char *name, str
>
> ret = cfg80211_register_netdevice(mon_ndev);
> if (ret) {
> - goto out;
> + goto err_register;
> }
>
> *ndev = pwdev_priv->pmon_ndev = mon_ndev;
> memcpy(pwdev_priv->ifname_mon, name, IFNAMSIZ+1);
> + goto out;
>
> -out:
> - if (ret && mon_wdev) {
> - kfree(mon_wdev);
> - mon_wdev = NULL;
> - }
> -
> - if (ret && mon_ndev) {
> - free_netdev(mon_ndev);
> - *ndev = mon_ndev = NULL;
> - }
> +err_register:
> + kfree(mon_wdev);
> + mon_wdev = NULL;
Probably you have already read a message by Greg Kroah-Hartman that confirms
what I wrote in another message: "There is no need to set a local variable
like this to NULL.".
So please submit a v3. With the two changes requested above, my "acked-by"
tag is confirmed again.
Thanks,
Fabio
>
> +err_zmalloc:
> + free_netdev(mon_ndev);
> + *ndev = mon_ndev = NULL;
> +out:
> return ret;
> }
>
> --
> 2.32.0
>
>
>
^ permalink raw reply [flat|nested] 11+ messages in thread
* Re: [PATCH v2] staging: rtl8723bs: os_dep: simplify the return statement.
2021-10-10 5:06 [PATCH v2] staging: rtl8723bs: os_dep: simplify the return statement Saurav Girepunje
` (3 preceding siblings ...)
2021-10-11 8:54 ` Fabio M. De Francesco
@ 2021-10-11 12:30 ` Dan Carpenter
2021-10-11 18:28 ` Saurav Girepunje
4 siblings, 1 reply; 11+ messages in thread
From: Dan Carpenter @ 2021-10-11 12:30 UTC (permalink / raw)
To: Saurav Girepunje
Cc: gregkh, fabioaiuto83, ross.schm.dev, marcocesati, insafonov,
linux-staging, linux-kernel, saurav.girepunje
On Sun, Oct 10, 2021 at 10:36:05AM +0530, Saurav Girepunje wrote:
> Remove the unneeded and redundant check of variable on goto out.
> Simplify the return using multiple goto label to avoid
> unneeded check.
>
> Signed-off-by: Saurav Girepunje <saurav.girepunje@gmail.com>
No, sorry but the goto bunny hops, the pointless do-nothing gotos, and
the come from labels are all terrible.
regards,
dan carpenter
^ permalink raw reply [flat|nested] 11+ messages in thread
* Re: [PATCH v2] staging: rtl8723bs: os_dep: simplify the return statement.
2021-10-11 8:54 ` Fabio M. De Francesco
@ 2021-10-11 12:33 ` Fabio M. De Francesco
2021-10-11 18:36 ` Saurav Girepunje
2021-10-11 17:32 ` Saurav Girepunje
1 sibling, 1 reply; 11+ messages in thread
From: Fabio M. De Francesco @ 2021-10-11 12:33 UTC (permalink / raw)
To: gregkh, fabioaiuto83, ross.schm.dev, marcocesati,
saurav.girepunje, insafonov, linux-staging, linux-kernel,
Saurav Girepunje
Cc: saurav.girepunje
On Monday, October 11, 2021 10:54:11 AM CEST Fabio M. De Francesco wrote:
> On Sunday, October 10, 2021 7:06:05 AM CEST Saurav Girepunje wrote:
> > Remove the unneeded and redundant check of variable on goto out.
> > Simplify the return using multiple goto label to avoid
> > unneeded check.
> >
> > Signed-off-by: Saurav Girepunje <saurav.girepunje@gmail.com>
> > ---
> >
> > ChangeLog V2:
> > -Add goto out after the memcpy for no error case return with
> > ret only. Free is not required on no error case.
>
> Please write versions logs that reflect clearly and unequivocally what you
> changed between revisions and why. Subjects, Commit messages (Changelogs),
> and Versions logs are the "specifics" of your work. There must be no
> inconsistencies between these and the code or the history of the changes of
> the code.
>
> You may think that I'm pedantic, but since I acked your patch, I don't want
> to be misunderstood to be a promoter of approximate or clearly incorrect
> messages.
>
> "Free is not required on no error case" conveys the message that you have
> changed something that is not required but that is still potentially
allowed.
>
> This is not the case because the problem that you fix with v2 is _not_
> something that is merely not required and unnecessary. You have fixed a bug
> that is introduced in v1. Introducing bugs is not allowed. If you do
> something that is not allowed you cannot simply say that it is not
required.
>
> >
> > ChangeLog V1:
> > -Remove the unneeded and redundant check of variable on
> > goto out.
> > -Simplify the return using multiple goto label to avoid
> > unneeded check.
> >
> > .../staging/rtl8723bs/os_dep/ioctl_cfg80211.c | 22 +++++++++----------
> > 1 file changed, 10 insertions(+), 12 deletions(-)
> >
> > diff --git a/drivers/staging/rtl8723bs/os_dep/ioctl_cfg80211.c b/drivers/
> staging/rtl8723bs/os_dep/ioctl_cfg80211.c
> > index 0868f56e2979..ae9579dc0848 100644
> > --- a/drivers/staging/rtl8723bs/os_dep/ioctl_cfg80211.c
> > +++ b/drivers/staging/rtl8723bs/os_dep/ioctl_cfg80211.c
> > @@ -2312,7 +2312,7 @@ static int rtw_cfg80211_add_monitor_if(struct
adapter
> *padapter, char *name, str
> > mon_wdev = rtw_zmalloc(sizeof(struct wireless_dev));
> > if (!mon_wdev) {
> > ret = -ENOMEM;
> > - goto out;
> > + goto err_zmalloc;
> > }
> >
> > mon_wdev->wiphy = padapter->rtw_wdev->wiphy;
> > @@ -2322,23 +2322,21 @@ static int rtw_cfg80211_add_monitor_if(struct
> adapter *padapter, char *name, str
> >
> > ret = cfg80211_register_netdevice(mon_ndev);
> > if (ret) {
> > - goto out;
> > + goto err_register;
> > }
> >
> > *ndev = pwdev_priv->pmon_ndev = mon_ndev;
> > memcpy(pwdev_priv->ifname_mon, name, IFNAMSIZ+1);
> > + goto out;
As Pavel noticed, probably you'd better return 'ret' here. The logic does not
change, but I guess that this is what Linux developers usually do.
From a review by Dan Carpenter of one of your other patches: "[] Do nothing
labels only hurt readability and introduce "forgot to set the error code
bugs.".
Thanks,
Fabio
> >
> > -out:
> > - if (ret && mon_wdev) {
> > - kfree(mon_wdev);
> > - mon_wdev = NULL;
> > - }
> > -
> > - if (ret && mon_ndev) {
> > - free_netdev(mon_ndev);
> > - *ndev = mon_ndev = NULL;
> > - }
> > +err_register:
> > + kfree(mon_wdev);
> > + mon_wdev = NULL;
>
> Probably you have already read a message by Greg Kroah-Hartman that
confirms
> what I wrote in another message: "There is no need to set a local variable
> like this to NULL.".
>
> So please submit a v3. With the two changes requested above, my "acked-by"
> tag is confirmed again.
>
> Thanks,
>
> Fabio
>
> >
> > +err_zmalloc:
> > + free_netdev(mon_ndev);
> > + *ndev = mon_ndev = NULL;
> > +out:
> > return ret;
> > }
> >
> > --
> > 2.32.0
> >
> >
> >
>
>
>
>
>
^ permalink raw reply [flat|nested] 11+ messages in thread
* Re: [PATCH v2] staging: rtl8723bs: os_dep: simplify the return statement.
2021-10-11 8:54 ` Fabio M. De Francesco
2021-10-11 12:33 ` Fabio M. De Francesco
@ 2021-10-11 17:32 ` Saurav Girepunje
1 sibling, 0 replies; 11+ messages in thread
From: Saurav Girepunje @ 2021-10-11 17:32 UTC (permalink / raw)
To: Fabio M. De Francesco, gregkh, fabioaiuto83, ross.schm.dev,
marcocesati, insafonov, linux-staging, linux-kernel
Cc: saurav.girepunje
On 11/10/21 2:24 pm, Fabio M. De Francesco wrote:
> On Sunday, October 10, 2021 7:06:05 AM CEST Saurav Girepunje wrote:
>> Remove the unneeded and redundant check of variable on goto out.
>> Simplify the return using multiple goto label to avoid
>> unneeded check.
>>
>> Signed-off-by: Saurav Girepunje <saurav.girepunje@gmail.com>
>> ---
>>
>> ChangeLog V2:
>> -Add goto out after the memcpy for no error case return with
>> ret only. Free is not required on no error case.
>
> Please write versions logs that reflect clearly and unequivocally what you
> changed between revisions and why. Subjects, Commit messages (Changelogs),
> and Versions logs are the "specifics" of your work. There must be no
> inconsistencies between these and the code or the history of the changes of
> the code.
>
> You may think that I'm pedantic, but since I acked your patch, I don't want
> to be misunderstood to be a promoter of approximate or clearly incorrect
> messages> "Free is not required on no error case" conveys the message that you have
> changed something that is not required but that is still potentially allowed.
>
> This is not the case because the problem that you fix with v2 is _not_
> something that is merely not required and unnecessary. You have fixed a bug
> that is introduced in v1. Introducing bugs is not allowed. If you do
> something that is not allowed you cannot simply say that it is not required.
>
My intension was to mention changes done on V2 with respect to V1.
I will try to be more clear on changelog messages.
>>
>> ChangeLog V1:
>> -Remove the unneeded and redundant check of variable on
>> goto out.
>> -Simplify the return using multiple goto label to avoid
>> unneeded check.
>>
>> .../staging/rtl8723bs/os_dep/ioctl_cfg80211.c | 22 +++++++++----------
>> 1 file changed, 10 insertions(+), 12 deletions(-)
>>
>> diff --git a/drivers/staging/rtl8723bs/os_dep/ioctl_cfg80211.c b/drivers/
> staging/rtl8723bs/os_dep/ioctl_cfg80211.c
>> index 0868f56e2979..ae9579dc0848 100644
>> --- a/drivers/staging/rtl8723bs/os_dep/ioctl_cfg80211.c
>> +++ b/drivers/staging/rtl8723bs/os_dep/ioctl_cfg80211.c
>> @@ -2312,7 +2312,7 @@ static int rtw_cfg80211_add_monitor_if(struct adapter
> *padapter, char *name, str
>> mon_wdev = rtw_zmalloc(sizeof(struct wireless_dev));
>> if (!mon_wdev) {
>> ret = -ENOMEM;
>> - goto out;
>> + goto err_zmalloc;
>> }
>>
>> mon_wdev->wiphy = padapter->rtw_wdev->wiphy;
>> @@ -2322,23 +2322,21 @@ static int rtw_cfg80211_add_monitor_if(struct
> adapter *padapter, char *name, str
>>
>> ret = cfg80211_register_netdevice(mon_ndev);
>> if (ret) {
>> - goto out;
>> + goto err_register;
>> }
>>
>> *ndev = pwdev_priv->pmon_ndev = mon_ndev;
>> memcpy(pwdev_priv->ifname_mon, name, IFNAMSIZ+1);
>> + goto out;
>>
>> -out:
>> - if (ret && mon_wdev) {
>> - kfree(mon_wdev);
>> - mon_wdev = NULL;
>> - }
>> -
>> - if (ret && mon_ndev) {
>> - free_netdev(mon_ndev);
>> - *ndev = mon_ndev = NULL;
>> - }
>> +err_register:
>> + kfree(mon_wdev);
>> + mon_wdev = NULL;
>
> Probably you have already read a message by Greg Kroah-Hartman that confirms
> what I wrote in another message: "There is no need to set a local variable
> like this to NULL.".
>
Yes, Agree this is another improvement possible on this function.
> So please submit a v3. With the two changes requested above, my "acked-by"
> tag is confirmed again.
>
> Thanks,
>
> Fabio
>
I will submit a v3.
>>
>> +err_zmalloc:
>> + free_netdev(mon_ndev);
>> + *ndev = mon_ndev = NULL;
>> +out:
>> return ret;
>> }
>>
>> --
>> 2.32.0
>>
>>
>>
>
>
>
>
^ permalink raw reply [flat|nested] 11+ messages in thread
* Re: [PATCH v2] staging: rtl8723bs: os_dep: simplify the return statement.
2021-10-10 7:24 ` Fabio M. De Francesco
@ 2021-10-11 18:10 ` Saurav Girepunje
0 siblings, 0 replies; 11+ messages in thread
From: Saurav Girepunje @ 2021-10-11 18:10 UTC (permalink / raw)
To: Fabio M. De Francesco, gregkh
Cc: fabioaiuto83, ross.schm.dev, marcocesati, insafonov,
linux-staging, linux-kernel, saurav.girepunje
On 10/10/21 12:54 pm, Fabio M. De Francesco wrote:
> On Sunday, October 10, 2021 7:06:05 AM CEST Saurav Girepunje wrote:
>> Remove the unneeded and redundant check of variable on goto out.
>> Simplify the return using multiple goto label to avoid
>> unneeded check.
>>
>> Signed-off-by: Saurav Girepunje <saurav.girepunje@gmail.com>
>> ---
>>
>> ChangeLog V2:
>> -Add goto out after the memcpy for no error case return with
>> ret only. Free is not required on no error case.
>>
>> ChangeLog V1:
>> -Remove the unneeded and redundant check of variable on
>> goto out.
>> -Simplify the return using multiple goto label to avoid
>> unneeded check.
>>
>> .../staging/rtl8723bs/os_dep/ioctl_cfg80211.c | 22 +++++++++----------
>> 1 file changed, 10 insertions(+), 12 deletions(-)
>>
>> diff --git a/drivers/staging/rtl8723bs/os_dep/ioctl_cfg80211.c b/drivers/
> staging/rtl8723bs/os_dep/ioctl_cfg80211.c
>> index 0868f56e2979..ae9579dc0848 100644
>> --- a/drivers/staging/rtl8723bs/os_dep/ioctl_cfg80211.c
>> +++ b/drivers/staging/rtl8723bs/os_dep/ioctl_cfg80211.c
>> @@ -2312,7 +2312,7 @@ static int rtw_cfg80211_add_monitor_if(struct adapter
> *padapter, char *name, str
>> mon_wdev = rtw_zmalloc(sizeof(struct wireless_dev));
>> if (!mon_wdev) {
>> ret = -ENOMEM;
>> - goto out;
>> + goto err_zmalloc;
>> }
>>
>> mon_wdev->wiphy = padapter->rtw_wdev->wiphy;
>> @@ -2322,23 +2322,21 @@ static int rtw_cfg80211_add_monitor_if(struct
> adapter *padapter, char *name, str
>>
>> ret = cfg80211_register_netdevice(mon_ndev);
>> if (ret) {
>> - goto out;
>> + goto err_register;
>> }
>>
>> *ndev = pwdev_priv->pmon_ndev = mon_ndev;
>> memcpy(pwdev_priv->ifname_mon, name, IFNAMSIZ+1);
>> + goto out;
>
> I think this is the right thing to do in order to remove the bug you
> introduced in v1. Well done.
>
Most of the people suggesting to use return 0 from here instead of goto.
I will send another patch.
>>
>> -out:
>> - if (ret && mon_wdev) {
>> - kfree(mon_wdev);
>> - mon_wdev = NULL;
>> - }
>> -
>> - if (ret && mon_ndev) {
>> - free_netdev(mon_ndev);
>> - *ndev = mon_ndev = NULL;
>> - }
>> +err_register:
>> + kfree(mon_wdev);
>> + mon_wdev = NULL;
>>
>> +err_zmalloc:
>> + free_netdev(mon_ndev);
>> + *ndev = mon_ndev = NULL;
>
> Not sure about what the Linux coding guidelines say, but I think that
> assigning NULL to local (on stack) pointers (mon_wdev, mon_ndev) at this
> point is unnecessary. There is no risk of reusing them after the "out"
> labelled block, because at function exit they are destroyed when the stack is
> unwound.
>
> If you decide to remove these assignments, take care to leave "*ndev = NULL;"
> as-is (why?).
>
Yes, This is also improvement needed on this function.
> Aside from this minor objection...
>
> Acked-by: Fabio M. De Francesco <fmdefrancesco@gmail.com>
>
> Thanks,
>
> Fabio
>
>> +out:
>> return ret;
>> }
>>
>> --
>> 2.32.0
>>
>>
>>
>
>
>
>
Regards,
Saurav
^ permalink raw reply [flat|nested] 11+ messages in thread
* Re: [PATCH v2] staging: rtl8723bs: os_dep: simplify the return statement.
2021-10-11 12:30 ` Dan Carpenter
@ 2021-10-11 18:28 ` Saurav Girepunje
0 siblings, 0 replies; 11+ messages in thread
From: Saurav Girepunje @ 2021-10-11 18:28 UTC (permalink / raw)
To: Dan Carpenter
Cc: gregkh, fabioaiuto83, ross.schm.dev, marcocesati, insafonov,
linux-staging, linux-kernel, saurav.girepunje
On 11/10/21 6:00 pm, Dan Carpenter wrote:
> On Sun, Oct 10, 2021 at 10:36:05AM +0530, Saurav Girepunje wrote:
>> Remove the unneeded and redundant check of variable on goto out.
>> Simplify the return using multiple goto label to avoid
>> unneeded check.
>>
>> Signed-off-by: Saurav Girepunje <saurav.girepunje@gmail.com>
>
> No, sorry but the goto bunny hops, the pointless do-nothing gotos, and
> the come from labels are all terrible.
>
> regards,
> dan carpenter
>
Thanks dan for your input.
Regards,
Saurav
^ permalink raw reply [flat|nested] 11+ messages in thread
* Re: [PATCH v2] staging: rtl8723bs: os_dep: simplify the return statement.
2021-10-11 12:33 ` Fabio M. De Francesco
@ 2021-10-11 18:36 ` Saurav Girepunje
0 siblings, 0 replies; 11+ messages in thread
From: Saurav Girepunje @ 2021-10-11 18:36 UTC (permalink / raw)
To: Fabio M. De Francesco, gregkh, fabioaiuto83, ross.schm.dev,
marcocesati, insafonov, linux-staging, linux-kernel
Cc: saurav.girepunje
On 11/10/21 6:03 pm, Fabio M. De Francesco wrote:
> On Monday, October 11, 2021 10:54:11 AM CEST Fabio M. De Francesco wrote:
>> On Sunday, October 10, 2021 7:06:05 AM CEST Saurav Girepunje wrote:
>>> Remove the unneeded and redundant check of variable on goto out.
>>> Simplify the return using multiple goto label to avoid
>>> unneeded check.
>>>
>>> Signed-off-by: Saurav Girepunje <saurav.girepunje@gmail.com>
>>> ---
>>>
>>> ChangeLog V2:
>>> -Add goto out after the memcpy for no error case return with
>>> ret only. Free is not required on no error case.
>>
>> Please write versions logs that reflect clearly and unequivocally what you
>> changed between revisions and why. Subjects, Commit messages (Changelogs),
>> and Versions logs are the "specifics" of your work. There must be no
>> inconsistencies between these and the code or the history of the changes of
>> the code.
>>
>> You may think that I'm pedantic, but since I acked your patch, I don't want
>> to be misunderstood to be a promoter of approximate or clearly incorrect
>> messages.
>>
>> "Free is not required on no error case" conveys the message that you have
>> changed something that is not required but that is still potentially
> allowed.
>>
>> This is not the case because the problem that you fix with v2 is _not_
>> something that is merely not required and unnecessary. You have fixed a bug
>> that is introduced in v1. Introducing bugs is not allowed. If you do
>> something that is not allowed you cannot simply say that it is not
> required.
>>
>>>
>>> ChangeLog V1:
>>> -Remove the unneeded and redundant check of variable on
>>> goto out.
>>> -Simplify the return using multiple goto label to avoid
>>> unneeded check.
>>>
>>> .../staging/rtl8723bs/os_dep/ioctl_cfg80211.c | 22 +++++++++----------
>>> 1 file changed, 10 insertions(+), 12 deletions(-)
>>>
>>> diff --git a/drivers/staging/rtl8723bs/os_dep/ioctl_cfg80211.c b/drivers/
>> staging/rtl8723bs/os_dep/ioctl_cfg80211.c
>>> index 0868f56e2979..ae9579dc0848 100644
>>> --- a/drivers/staging/rtl8723bs/os_dep/ioctl_cfg80211.c
>>> +++ b/drivers/staging/rtl8723bs/os_dep/ioctl_cfg80211.c
>>> @@ -2312,7 +2312,7 @@ static int rtw_cfg80211_add_monitor_if(struct
> adapter
>> *padapter, char *name, str
>>> mon_wdev = rtw_zmalloc(sizeof(struct wireless_dev));
>>> if (!mon_wdev) {
>>> ret = -ENOMEM;
>>> - goto out;
>>> + goto err_zmalloc;
>>> }
>>>
>>> mon_wdev->wiphy = padapter->rtw_wdev->wiphy;
>>> @@ -2322,23 +2322,21 @@ static int rtw_cfg80211_add_monitor_if(struct
>> adapter *padapter, char *name, str
>>>
>>> ret = cfg80211_register_netdevice(mon_ndev);
>>> if (ret) {
>>> - goto out;
>>> + goto err_register;
>>> }
>>>
>>> *ndev = pwdev_priv->pmon_ndev = mon_ndev;
>>> memcpy(pwdev_priv->ifname_mon, name, IFNAMSIZ+1);
>>> + goto out;
>
> As Pavel noticed, probably you'd better return 'ret' here. The logic does not
> change, but I guess that this is what Linux developers usually do.
>
Yes, Logic does not change. However I was also not sure which one is more preferable
therefore asked for input on v1 whether to use goto or simply return value from here.
It seems return from here is better choice for readability point of view.
> From a review by Dan Carpenter of one of your other patches: "[] Do nothing
> labels only hurt readability and introduce "forgot to set the error code
> bugs.".
>
> Thanks,
>
> Fabio
>
>>>
>>> -out:
>>> - if (ret && mon_wdev) {
>>> - kfree(mon_wdev);
>>> - mon_wdev = NULL;
>>> - }
>>> -
>>> - if (ret && mon_ndev) {
>>> - free_netdev(mon_ndev);
>>> - *ndev = mon_ndev = NULL;
>>> - }
>>> +err_register:
>>> + kfree(mon_wdev);
>>> + mon_wdev = NULL;
>>
>> Probably you have already read a message by Greg Kroah-Hartman that
> confirms
>> what I wrote in another message: "There is no need to set a local variable
>> like this to NULL.".
>>
>> So please submit a v3. With the two changes requested above, my "acked-by"
>> tag is confirmed again.
>>
>> Thanks,
>>
>> Fabio
>>
>>>
>>> +err_zmalloc:
>>> + free_netdev(mon_ndev);
>>> + *ndev = mon_ndev = NULL;
>>> +out:
>>> return ret;
>>> }
>>>
>>> --
>>> 2.32.0
>>>
>>>
>>>
>>
>>
>>
>>
>>
>
>
>
>
Regards,
Saurav
^ permalink raw reply [flat|nested] 11+ messages in thread
end of thread, other threads:[~2021-10-11 18:36 UTC | newest]
Thread overview: 11+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2021-10-10 5:06 [PATCH v2] staging: rtl8723bs: os_dep: simplify the return statement Saurav Girepunje
2021-10-10 7:24 ` Fabio M. De Francesco
2021-10-11 18:10 ` Saurav Girepunje
2021-10-10 8:56 ` Pavel Skripkin
2021-10-10 12:59 ` Greg KH
2021-10-11 8:54 ` Fabio M. De Francesco
2021-10-11 12:33 ` Fabio M. De Francesco
2021-10-11 18:36 ` Saurav Girepunje
2021-10-11 17:32 ` Saurav Girepunje
2021-10-11 12:30 ` Dan Carpenter
2021-10-11 18:28 ` Saurav Girepunje
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.