From: Richard Genoud <richard.genoud@gmail.com> To: Kangjie Lu <kjlu@umn.edu> Cc: pakki001@umn.edu, Greg Kroah-Hartman <gregkh@linuxfoundation.org>, Jiri Slaby <jslaby@suse.com>, Nicolas Ferre <nicolas.ferre@microchip.com>, Alexandre Belloni <alexandre.belloni@bootlin.com>, Ludovic Desroches <ludovic.desroches@microchip.com>, linux-serial@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH] tty: atmel_serial: fix a NULL pointer dereference Date: Mon, 18 Mar 2019 08:28:26 +0100 [thread overview] Message-ID: <cb9a62d2-1d91-a9d6-22ed-1e19ca1d96c7@sorico.fr> (raw) In-Reply-To: <20190315171606.6282-1-kjlu@umn.edu> Le 15/03/2019 à 18:16, Kangjie Lu a écrit : > In case dmaengine_prep_dma_cyclic fails, the fix returns a proper > error code to avoid NULL pointer dereference. > > Signed-off-by: Kangjie Lu <kjlu@umn.edu> > Fixes: 34df42f59a60 ("serial: at91: add rx dma support") Acked-by: Richard Genoud <richard.genoud@gmail.com> > > --- > V2: simplified the patch as suggested by > Richard Genoud <richard.genoud@gmail.com> > --- > drivers/tty/serial/atmel_serial.c | 4 ++++ > 1 file changed, 4 insertions(+) > > diff --git a/drivers/tty/serial/atmel_serial.c b/drivers/tty/serial/atmel_serial.c > index 05147fe24343..41b728d223d1 100644 > --- a/drivers/tty/serial/atmel_serial.c > +++ b/drivers/tty/serial/atmel_serial.c > @@ -1288,6 +1288,10 @@ static int atmel_prepare_rx_dma(struct uart_port *port) > sg_dma_len(&atmel_port->sg_rx)/2, > DMA_DEV_TO_MEM, > DMA_PREP_INTERRUPT); > + if (!desc) { > + dev_err(port->dev, "Preparing DMA cyclic failed\n"); > + goto chan_err; > + } > desc->callback = atmel_complete_rx_dma; > desc->callback_param = port; > atmel_port->desc_rx = desc; > Thanks ! Richard
WARNING: multiple messages have this Message-ID (diff)
From: Richard Genoud <richard.genoud@gmail.com> To: Kangjie Lu <kjlu@umn.edu> Cc: Alexandre Belloni <alexandre.belloni@bootlin.com>, Greg Kroah-Hartman <gregkh@linuxfoundation.org>, pakki001@umn.edu, linux-kernel@vger.kernel.org, Ludovic Desroches <ludovic.desroches@microchip.com>, linux-serial@vger.kernel.org, Jiri Slaby <jslaby@suse.com>, linux-arm-kernel@lists.infradead.org Subject: Re: [PATCH] tty: atmel_serial: fix a NULL pointer dereference Date: Mon, 18 Mar 2019 08:28:26 +0100 [thread overview] Message-ID: <cb9a62d2-1d91-a9d6-22ed-1e19ca1d96c7@sorico.fr> (raw) In-Reply-To: <20190315171606.6282-1-kjlu@umn.edu> Le 15/03/2019 à 18:16, Kangjie Lu a écrit : > In case dmaengine_prep_dma_cyclic fails, the fix returns a proper > error code to avoid NULL pointer dereference. > > Signed-off-by: Kangjie Lu <kjlu@umn.edu> > Fixes: 34df42f59a60 ("serial: at91: add rx dma support") Acked-by: Richard Genoud <richard.genoud@gmail.com> > > --- > V2: simplified the patch as suggested by > Richard Genoud <richard.genoud@gmail.com> > --- > drivers/tty/serial/atmel_serial.c | 4 ++++ > 1 file changed, 4 insertions(+) > > diff --git a/drivers/tty/serial/atmel_serial.c b/drivers/tty/serial/atmel_serial.c > index 05147fe24343..41b728d223d1 100644 > --- a/drivers/tty/serial/atmel_serial.c > +++ b/drivers/tty/serial/atmel_serial.c > @@ -1288,6 +1288,10 @@ static int atmel_prepare_rx_dma(struct uart_port *port) > sg_dma_len(&atmel_port->sg_rx)/2, > DMA_DEV_TO_MEM, > DMA_PREP_INTERRUPT); > + if (!desc) { > + dev_err(port->dev, "Preparing DMA cyclic failed\n"); > + goto chan_err; > + } > desc->callback = atmel_complete_rx_dma; > desc->callback_param = port; > atmel_port->desc_rx = desc; > Thanks ! Richard _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
next prev parent reply other threads:[~2019-03-18 7:28 UTC|newest] Thread overview: 20+ messages / expand[flat|nested] mbox.gz Atom feed top 2019-03-14 5:56 [PATCH] pci: pcie-rcar: fix a potential NULL pointer dereference Kangjie Lu 2019-03-14 7:30 ` Geert Uytterhoeven 2019-03-14 8:07 ` [PATCH v2] " Kangjie Lu 2019-03-14 8:10 ` Geert Uytterhoeven 2019-03-15 7:27 ` [PATCH v2] tty: atmel_serial: fix a " Kangjie Lu 2019-03-15 7:27 ` Kangjie Lu 2019-03-15 8:22 ` Richard Genoud 2019-03-15 8:22 ` Richard Genoud 2019-03-15 17:16 ` [PATCH] " Kangjie Lu 2019-03-15 17:16 ` Kangjie Lu 2019-03-18 7:28 ` Richard Genoud [this message] 2019-03-18 7:28 ` Richard Genoud 2019-03-15 7:29 ` [PATCH v2] pci: pcie-rcar: fix a potential " Kangjie Lu 2019-03-15 10:07 ` Ulrich Hecht 2019-03-15 11:54 ` Simon Horman 2019-03-29 16:22 ` Lorenzo Pieralisi 2019-03-14 7:17 [PATCH] tty: atmel_serial: fix a " Kangjie Lu 2019-03-14 7:17 ` Kangjie Lu 2019-03-14 8:25 ` Richard Genoud 2019-03-14 8:25 ` Richard Genoud
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=cb9a62d2-1d91-a9d6-22ed-1e19ca1d96c7@sorico.fr \ --to=richard.genoud@gmail.com \ --cc=alexandre.belloni@bootlin.com \ --cc=gregkh@linuxfoundation.org \ --cc=jslaby@suse.com \ --cc=kjlu@umn.edu \ --cc=linux-arm-kernel@lists.infradead.org \ --cc=linux-kernel@vger.kernel.org \ --cc=linux-serial@vger.kernel.org \ --cc=ludovic.desroches@microchip.com \ --cc=nicolas.ferre@microchip.com \ --cc=pakki001@umn.edu \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: linkBe sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.