From: Lyude Paul <lyude@redhat.com>
To: "Ville Syrjälä" <ville.syrjala@linux.intel.com>
Cc: intel-gfx@lists.freedesktop.org, dri-devel@lists.freedesktop.org,
Thomas Zimmermann <tzimmermann@suse.de>,
David Airlie <airlied@linux.ie>,
open list <linux-kernel@vger.kernel.org>,
Maxime Ripard <mripard@kernel.org>
Subject: Re: [Intel-gfx] [PATCH 2/2] drm/dp: Drop open-coded drm_dp_is_branch() in drm_dp_read_downstream_info()
Date: Fri, 07 May 2021 17:28:03 -0400 [thread overview]
Message-ID: <cbbd22463a3af9efa7f12dc90b74231dc0ae5771.camel@redhat.com> (raw)
In-Reply-To: <YI9otSh/ftvLqMxb@intel.com>
On Mon, 2021-05-03 at 06:06 +0300, Ville Syrjälä wrote:
> On Fri, Apr 30, 2021 at 06:34:28PM -0400, Lyude Paul wrote:
> > Noticed this while fixing another issue in drm_dp_read_downstream_info(),
> > the open coded DP_DOWNSTREAMPORT_PRESENT check here just duplicates what
> > we
> > already do in drm_dp_is_branch(), so just get rid of it.
> >
> > Signed-off-by: Lyude Paul <lyude@redhat.com>
> > ---
> > drivers/gpu/drm/drm_dp_helper.c | 4 +---
> > 1 file changed, 1 insertion(+), 3 deletions(-)
> >
> > diff --git a/drivers/gpu/drm/drm_dp_helper.c
> > b/drivers/gpu/drm/drm_dp_helper.c
> > index 27c8c5bdf7d9..0f84df8798ab 100644
> > --- a/drivers/gpu/drm/drm_dp_helper.c
> > +++ b/drivers/gpu/drm/drm_dp_helper.c
> > @@ -677,9 +677,7 @@ int drm_dp_read_downstream_info(struct drm_dp_aux
> > *aux,
> > memset(downstream_ports, 0, DP_MAX_DOWNSTREAM_PORTS);
> >
> > /* No downstream info to read */
> > - if (!drm_dp_is_branch(dpcd) ||
> > - dpcd[DP_DPCD_REV] < DP_DPCD_REV_10 ||
> > - !(dpcd[DP_DOWNSTREAMPORT_PRESENT] & DP_DWN_STRM_PORT_PRESENT))
> > + if (!drm_dp_is_branch(dpcd) || dpcd[DP_DPCD_REV] < DP_DPCD_REV_10)
>
> BTW that DPCD_REV check looks rather wrong.
>
> Reviewed-by: Ville Syrjälä <ville.syrjala@linux.intel.com>
I'll send out a separate fix for this in just a moment, thanks for pointing it
out!
>
> > return 0;
> >
> > /* Some branches advertise having 0 downstream ports, despite also
> > advertising they have a
> > --
> > 2.30.2
> >
> > _______________________________________________
> > Intel-gfx mailing list
> > Intel-gfx@lists.freedesktop.org
> > https://lists.freedesktop.org/mailman/listinfo/intel-gfx
>
--
Cheers,
Lyude Paul (she/her)
Software Engineer at Red Hat
WARNING: multiple messages have this Message-ID (diff)
From: Lyude Paul <lyude@redhat.com>
To: "Ville Syrjälä" <ville.syrjala@linux.intel.com>
Cc: David Airlie <airlied@linux.ie>,
intel-gfx@lists.freedesktop.org,
open list <linux-kernel@vger.kernel.org>,
dri-devel@lists.freedesktop.org,
Thomas Zimmermann <tzimmermann@suse.de>
Subject: Re: [Intel-gfx] [PATCH 2/2] drm/dp: Drop open-coded drm_dp_is_branch() in drm_dp_read_downstream_info()
Date: Fri, 07 May 2021 17:28:03 -0400 [thread overview]
Message-ID: <cbbd22463a3af9efa7f12dc90b74231dc0ae5771.camel@redhat.com> (raw)
In-Reply-To: <YI9otSh/ftvLqMxb@intel.com>
On Mon, 2021-05-03 at 06:06 +0300, Ville Syrjälä wrote:
> On Fri, Apr 30, 2021 at 06:34:28PM -0400, Lyude Paul wrote:
> > Noticed this while fixing another issue in drm_dp_read_downstream_info(),
> > the open coded DP_DOWNSTREAMPORT_PRESENT check here just duplicates what
> > we
> > already do in drm_dp_is_branch(), so just get rid of it.
> >
> > Signed-off-by: Lyude Paul <lyude@redhat.com>
> > ---
> > drivers/gpu/drm/drm_dp_helper.c | 4 +---
> > 1 file changed, 1 insertion(+), 3 deletions(-)
> >
> > diff --git a/drivers/gpu/drm/drm_dp_helper.c
> > b/drivers/gpu/drm/drm_dp_helper.c
> > index 27c8c5bdf7d9..0f84df8798ab 100644
> > --- a/drivers/gpu/drm/drm_dp_helper.c
> > +++ b/drivers/gpu/drm/drm_dp_helper.c
> > @@ -677,9 +677,7 @@ int drm_dp_read_downstream_info(struct drm_dp_aux
> > *aux,
> > memset(downstream_ports, 0, DP_MAX_DOWNSTREAM_PORTS);
> >
> > /* No downstream info to read */
> > - if (!drm_dp_is_branch(dpcd) ||
> > - dpcd[DP_DPCD_REV] < DP_DPCD_REV_10 ||
> > - !(dpcd[DP_DOWNSTREAMPORT_PRESENT] & DP_DWN_STRM_PORT_PRESENT))
> > + if (!drm_dp_is_branch(dpcd) || dpcd[DP_DPCD_REV] < DP_DPCD_REV_10)
>
> BTW that DPCD_REV check looks rather wrong.
>
> Reviewed-by: Ville Syrjälä <ville.syrjala@linux.intel.com>
I'll send out a separate fix for this in just a moment, thanks for pointing it
out!
>
> > return 0;
> >
> > /* Some branches advertise having 0 downstream ports, despite also
> > advertising they have a
> > --
> > 2.30.2
> >
> > _______________________________________________
> > Intel-gfx mailing list
> > Intel-gfx@lists.freedesktop.org
> > https://lists.freedesktop.org/mailman/listinfo/intel-gfx
>
--
Cheers,
Lyude Paul (she/her)
Software Engineer at Red Hat
WARNING: multiple messages have this Message-ID (diff)
From: Lyude Paul <lyude@redhat.com>
To: "Ville Syrjälä" <ville.syrjala@linux.intel.com>
Cc: David Airlie <airlied@linux.ie>,
intel-gfx@lists.freedesktop.org,
open list <linux-kernel@vger.kernel.org>,
Maxime Ripard <mripard@kernel.org>,
dri-devel@lists.freedesktop.org,
Thomas Zimmermann <tzimmermann@suse.de>
Subject: Re: [Intel-gfx] [PATCH 2/2] drm/dp: Drop open-coded drm_dp_is_branch() in drm_dp_read_downstream_info()
Date: Fri, 07 May 2021 17:28:03 -0400 [thread overview]
Message-ID: <cbbd22463a3af9efa7f12dc90b74231dc0ae5771.camel@redhat.com> (raw)
In-Reply-To: <YI9otSh/ftvLqMxb@intel.com>
On Mon, 2021-05-03 at 06:06 +0300, Ville Syrjälä wrote:
> On Fri, Apr 30, 2021 at 06:34:28PM -0400, Lyude Paul wrote:
> > Noticed this while fixing another issue in drm_dp_read_downstream_info(),
> > the open coded DP_DOWNSTREAMPORT_PRESENT check here just duplicates what
> > we
> > already do in drm_dp_is_branch(), so just get rid of it.
> >
> > Signed-off-by: Lyude Paul <lyude@redhat.com>
> > ---
> > drivers/gpu/drm/drm_dp_helper.c | 4 +---
> > 1 file changed, 1 insertion(+), 3 deletions(-)
> >
> > diff --git a/drivers/gpu/drm/drm_dp_helper.c
> > b/drivers/gpu/drm/drm_dp_helper.c
> > index 27c8c5bdf7d9..0f84df8798ab 100644
> > --- a/drivers/gpu/drm/drm_dp_helper.c
> > +++ b/drivers/gpu/drm/drm_dp_helper.c
> > @@ -677,9 +677,7 @@ int drm_dp_read_downstream_info(struct drm_dp_aux
> > *aux,
> > memset(downstream_ports, 0, DP_MAX_DOWNSTREAM_PORTS);
> >
> > /* No downstream info to read */
> > - if (!drm_dp_is_branch(dpcd) ||
> > - dpcd[DP_DPCD_REV] < DP_DPCD_REV_10 ||
> > - !(dpcd[DP_DOWNSTREAMPORT_PRESENT] & DP_DWN_STRM_PORT_PRESENT))
> > + if (!drm_dp_is_branch(dpcd) || dpcd[DP_DPCD_REV] < DP_DPCD_REV_10)
>
> BTW that DPCD_REV check looks rather wrong.
>
> Reviewed-by: Ville Syrjälä <ville.syrjala@linux.intel.com>
I'll send out a separate fix for this in just a moment, thanks for pointing it
out!
>
> > return 0;
> >
> > /* Some branches advertise having 0 downstream ports, despite also
> > advertising they have a
> > --
> > 2.30.2
> >
> > _______________________________________________
> > Intel-gfx mailing list
> > Intel-gfx@lists.freedesktop.org
> > https://lists.freedesktop.org/mailman/listinfo/intel-gfx
>
--
Cheers,
Lyude Paul (she/her)
Software Engineer at Red Hat
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
next prev parent reply other threads:[~2021-05-07 21:28 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-04-30 22:34 [PATCH 1/2] drm/dp: Handle zeroed port counts in drm_dp_read_downstream_info() Lyude Paul
2021-04-30 22:34 ` [Intel-gfx] " Lyude Paul
2021-04-30 22:34 ` Lyude Paul
2021-04-30 22:34 ` [PATCH 2/2] drm/dp: Drop open-coded drm_dp_is_branch() " Lyude Paul
2021-04-30 22:34 ` [Intel-gfx] " Lyude Paul
2021-04-30 22:34 ` Lyude Paul
2021-05-03 3:06 ` [Intel-gfx] " Ville Syrjälä
2021-05-03 3:06 ` Ville Syrjälä
2021-05-03 3:06 ` Ville Syrjälä
2021-05-07 21:28 ` Lyude Paul [this message]
2021-05-07 21:28 ` Lyude Paul
2021-05-07 21:28 ` Lyude Paul
2021-05-03 3:13 ` [PATCH 1/2] drm/dp: Handle zeroed port counts " Ville Syrjälä
2021-05-03 3:13 ` [Intel-gfx] " Ville Syrjälä
2021-05-03 3:13 ` Ville Syrjälä
2021-05-03 14:26 ` [Intel-gfx] ✓ Fi.CI.BAT: success for series starting with [1/2] " Patchwork
2021-05-03 16:54 ` [Intel-gfx] ✓ Fi.CI.IGT: " Patchwork
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=cbbd22463a3af9efa7f12dc90b74231dc0ae5771.camel@redhat.com \
--to=lyude@redhat.com \
--cc=airlied@linux.ie \
--cc=dri-devel@lists.freedesktop.org \
--cc=intel-gfx@lists.freedesktop.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mripard@kernel.org \
--cc=tzimmermann@suse.de \
--cc=ville.syrjala@linux.intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.