All of lore.kernel.org
 help / color / mirror / Atom feed
From: Wesley Cheng <quic_wcheng@quicinc.com>
To: Pierre-Louis Bossart <pierre-louis.bossart@linux.intel.com>,
	<srinivas.kandagatla@linaro.org>, <mathias.nyman@intel.com>,
	<perex@perex.cz>, <broonie@kernel.org>, <lgirdwood@gmail.com>,
	<andersson@kernel.org>, <krzysztof.kozlowski+dt@linaro.org>,
	<gregkh@linuxfoundation.org>, <Thinh.Nguyen@synopsys.com>,
	<bgoswami@quicinc.com>, <tiwai@suse.com>, <robh+dt@kernel.org>,
	<agross@kernel.org>
Cc: <devicetree@vger.kernel.org>, <alsa-devel@alsa-project.org>,
	<linux-arm-msm@vger.kernel.org>, <linux-usb@vger.kernel.org>,
	<linux-kernel@vger.kernel.org>, <quic_jackp@quicinc.com>,
	<quic_plai@quicinc.com>
Subject: Re: [RFC PATCH 09/14] sound: usb: Introduce QC USB SND offloading support
Date: Thu, 5 Jan 2023 17:06:00 -0800	[thread overview]
Message-ID: <cc40d2e2-3384-cd64-f53c-a0811b53d781@quicinc.com> (raw)
In-Reply-To: <07443b54-2973-7990-e749-66dd7fb4e499@linux.intel.com>

Hi Pierre,

On 1/4/2023 3:51 PM, Pierre-Louis Bossart wrote:
> 
> 
> On 12/23/22 17:31, Wesley Cheng wrote:
>> Several Qualcomm SoCs have a dedicated audio DSP, which has the ability to
>> support USB sound devices.  This vendor driver will implement the required
>> handshaking with the DSP, in order to pass along required resources that
>> will be utilized by the DSP's USB SW.  The communication channel used for
>> this handshaking will be using the QMI protocol.  Required resources
>> include:
>> - Allocated secondary event ring address
>> - EP transfer ring address
>> - Interrupter number
>>
>> The above information will allow for the audio DSP to execute USB transfers
>> over the USB bus.  It will also be able to support devices that have an
>> implicit feedback and sync endpoint as well.  Offloading these data
>> transfers will allow the main/applications processor to enter lower CPU
>> power modes, and sustain a longer duration in those modes.
> 
> Are you suggesting that the entire feedback loop be handled in the DSP?
> It's not clear what "Offloading these data transfers" refers to, the
> data part or the feedback path?
> 

Yes, as mentioned in the cover letter response, we'll handle the 
feedback endpoints. (feedback eps are part of the audio data interface)

> Comments are almost inexistent in this patch so it's hard to figure out
> what it really does.
> 

OK, will add some more comments.

Thanks
Wesley Cheng

WARNING: multiple messages have this Message-ID (diff)
From: Wesley Cheng <quic_wcheng@quicinc.com>
To: Pierre-Louis Bossart <pierre-louis.bossart@linux.intel.com>,
	<srinivas.kandagatla@linaro.org>, <mathias.nyman@intel.com>,
	<perex@perex.cz>, <broonie@kernel.org>, <lgirdwood@gmail.com>,
	<andersson@kernel.org>, <krzysztof.kozlowski+dt@linaro.org>,
	<gregkh@linuxfoundation.org>, <Thinh.Nguyen@synopsys.com>,
	<bgoswami@quicinc.com>, <tiwai@suse.com>, <robh+dt@kernel.org>,
	<agross@kernel.org>
Cc: devicetree@vger.kernel.org, alsa-devel@alsa-project.org,
	linux-arm-msm@vger.kernel.org, linux-usb@vger.kernel.org,
	linux-kernel@vger.kernel.org, quic_jackp@quicinc.com,
	quic_plai@quicinc.com
Subject: Re: [RFC PATCH 09/14] sound: usb: Introduce QC USB SND offloading support
Date: Thu, 5 Jan 2023 17:06:00 -0800	[thread overview]
Message-ID: <cc40d2e2-3384-cd64-f53c-a0811b53d781@quicinc.com> (raw)
In-Reply-To: <07443b54-2973-7990-e749-66dd7fb4e499@linux.intel.com>

Hi Pierre,

On 1/4/2023 3:51 PM, Pierre-Louis Bossart wrote:
> 
> 
> On 12/23/22 17:31, Wesley Cheng wrote:
>> Several Qualcomm SoCs have a dedicated audio DSP, which has the ability to
>> support USB sound devices.  This vendor driver will implement the required
>> handshaking with the DSP, in order to pass along required resources that
>> will be utilized by the DSP's USB SW.  The communication channel used for
>> this handshaking will be using the QMI protocol.  Required resources
>> include:
>> - Allocated secondary event ring address
>> - EP transfer ring address
>> - Interrupter number
>>
>> The above information will allow for the audio DSP to execute USB transfers
>> over the USB bus.  It will also be able to support devices that have an
>> implicit feedback and sync endpoint as well.  Offloading these data
>> transfers will allow the main/applications processor to enter lower CPU
>> power modes, and sustain a longer duration in those modes.
> 
> Are you suggesting that the entire feedback loop be handled in the DSP?
> It's not clear what "Offloading these data transfers" refers to, the
> data part or the feedback path?
> 

Yes, as mentioned in the cover letter response, we'll handle the 
feedback endpoints. (feedback eps are part of the audio data interface)

> Comments are almost inexistent in this patch so it's hard to figure out
> what it really does.
> 

OK, will add some more comments.

Thanks
Wesley Cheng

  reply	other threads:[~2023-01-06  1:07 UTC|newest]

Thread overview: 171+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-12-23 23:31 [RFC PATCH 00/14] Introduce QC USB SND audio offloading support Wesley Cheng
2022-12-23 23:31 ` Wesley Cheng
2022-12-23 23:31 ` [RFC PATCH 01/14] ASoC: Add SOC USB APIs for adding an USB backend Wesley Cheng
2022-12-23 23:31   ` Wesley Cheng
2022-12-24  6:48   ` Greg KH
2022-12-24  6:48     ` Greg KH
2022-12-23 23:31 ` [RFC PATCH 02/14] ASoC: qcom: qdsp6: Introduce USB AFE port to q6dsp Wesley Cheng
2022-12-23 23:31   ` Wesley Cheng
2022-12-24  1:37   ` kernel test robot
2023-01-04 23:33   ` Pierre-Louis Bossart
2023-01-06  1:05     ` Wesley Cheng
2023-01-06  1:05       ` Wesley Cheng
2023-01-06 16:09       ` Pierre-Louis Bossart
2023-01-07  0:51         ` Wesley Cheng
2023-01-07  0:51           ` Wesley Cheng
2023-01-05 18:09   ` Krzysztof Kozlowski
2023-01-05 18:09     ` Krzysztof Kozlowski
2023-01-06  1:32     ` Wesley Cheng
2023-01-06  1:32       ` Wesley Cheng
2022-12-23 23:31 ` [RFC PATCH 03/14] ASoC: qcom: Add USB backend ASoC driver for Q6 Wesley Cheng
2022-12-23 23:31   ` Wesley Cheng
2022-12-24  2:17   ` kernel test robot
2022-12-24  2:17   ` kernel test robot
2022-12-24  9:02   ` Greg KH
2022-12-24  9:02     ` Greg KH
2022-12-27 13:04     ` Mark Brown
2022-12-27 13:04       ` Mark Brown
2022-12-27 13:45       ` Greg KH
2022-12-27 13:45         ` Greg KH
2022-12-27 14:02         ` Takashi Iwai
2022-12-27 14:02           ` Takashi Iwai
2022-12-27 14:11           ` Mark Brown
2022-12-27 14:11             ` Mark Brown
2022-12-27 15:11         ` Mark Brown
2022-12-27 15:11           ` Mark Brown
2022-12-27 21:06           ` Wesley Cheng
2022-12-27 21:06             ` Wesley Cheng
2022-12-27 21:07     ` Wesley Cheng
2022-12-27 21:07       ` Wesley Cheng
2023-01-04 23:41   ` Pierre-Louis Bossart
2023-01-06  1:05     ` Wesley Cheng
2023-01-06  1:05       ` Wesley Cheng
2023-01-06 16:16       ` Pierre-Louis Bossart
2022-12-23 23:31 ` [RFC PATCH 04/14] sound: usb: card: Introduce USB SND vendor op callbacks Wesley Cheng
2022-12-23 23:31   ` Wesley Cheng
2022-12-24 11:03   ` Dmitry Baryshkov
2022-12-24 11:03     ` Dmitry Baryshkov
2022-12-27 21:07     ` Wesley Cheng
2022-12-27 21:07       ` Wesley Cheng
2022-12-27 21:33       ` Dmitry Baryshkov
2022-12-27 21:33         ` Dmitry Baryshkov
2022-12-29 13:49   ` Oliver Neukum
2022-12-29 13:49     ` Oliver Neukum
2022-12-29 14:20     ` Takashi Iwai
2022-12-29 14:20       ` Takashi Iwai
2022-12-30  7:10       ` Wesley Cheng
2022-12-30  7:10         ` Wesley Cheng
2023-01-03 12:20         ` Oliver Neukum
2023-01-03 12:20           ` Oliver Neukum
2023-01-03 12:49           ` Takashi Iwai
2023-01-03 12:49             ` Takashi Iwai
2023-01-03 23:45             ` Wesley Cheng
2023-01-03 23:45               ` Wesley Cheng
2022-12-23 23:31 ` [RFC PATCH 05/14] sound: usb: Export USB SND APIs for modules Wesley Cheng
2022-12-23 23:31   ` Wesley Cheng
2022-12-24  6:48   ` Greg KH
2022-12-24  6:48     ` Greg KH
2022-12-23 23:31 ` [RFC PATCH 06/14] usb: core: hcd: Introduce USB HCD APIs for interrupter management Wesley Cheng
2022-12-23 23:31   ` Wesley Cheng
2022-12-24  8:54   ` Greg KH
2022-12-24  8:54     ` Greg KH
2022-12-27 21:13     ` Wesley Cheng
2022-12-27 21:13       ` Wesley Cheng
2022-12-24 15:29   ` Alan Stern
2022-12-24 15:29     ` Alan Stern
2022-12-27 21:07     ` Wesley Cheng
2022-12-27 21:07       ` Wesley Cheng
2022-12-28  8:59       ` Oliver Neukum
2022-12-28  8:59         ` Oliver Neukum
2022-12-28 15:16         ` Alan Stern
2022-12-28 15:16           ` Alan Stern
2022-12-28 20:31           ` Wesley Cheng
2022-12-28 20:31             ` Wesley Cheng
2022-12-29  1:41             ` Alan Stern
2022-12-29  1:41               ` Alan Stern
2022-12-23 23:31 ` [RFC PATCH 07/14] usb: host: xhci: Add XHCI secondary interrupter support Wesley Cheng
2022-12-23 23:31   ` Wesley Cheng
2022-12-24  5:59   ` kernel test robot
2022-12-24  8:55   ` Greg KH
2022-12-24  8:55     ` Greg KH
2022-12-28 15:47   ` Mathias Nyman
2022-12-28 15:47     ` Mathias Nyman
2022-12-29 21:14     ` Wesley Cheng
2022-12-29 21:14       ` Wesley Cheng
2023-01-02 16:38       ` Mathias Nyman
2023-01-02 16:38         ` Mathias Nyman
2023-01-09 20:24         ` Wesley Cheng
2023-01-09 20:24           ` Wesley Cheng
2023-01-10 19:47           ` Mathias Nyman
2023-01-10 19:47             ` Mathias Nyman
2023-01-10 20:03             ` Wesley Cheng
2023-01-10 20:03               ` Wesley Cheng
2023-01-11  3:11               ` Wesley Cheng
2023-01-11  3:11                 ` Wesley Cheng
2023-01-12  9:24                 ` Mathias Nyman
2023-01-12  9:24                   ` Mathias Nyman
2023-01-13  0:34                   ` Wesley Cheng
2023-01-13  0:34                     ` Wesley Cheng
2022-12-23 23:31 ` [RFC PATCH 08/14] usb: dwc3: Add DT parameter to specify maximum number of interrupters Wesley Cheng
2022-12-23 23:31   ` Wesley Cheng
2022-12-24 11:13   ` Dmitry Baryshkov
2022-12-24 11:13     ` Dmitry Baryshkov
2022-12-26 12:28     ` Krzysztof Kozlowski
2022-12-26 12:28       ` Krzysztof Kozlowski
2022-12-27 21:06     ` Wesley Cheng
2022-12-27 21:06       ` Wesley Cheng
2022-12-23 23:31 ` [RFC PATCH 09/14] sound: usb: Introduce QC USB SND offloading support Wesley Cheng
2022-12-23 23:31   ` Wesley Cheng
2022-12-24  2:27   ` kernel test robot
2023-01-02 17:28   ` Takashi Iwai
2023-01-02 17:28     ` Takashi Iwai
2023-01-04 22:38     ` Wesley Cheng
2023-01-04 22:38       ` Wesley Cheng
2023-01-04 23:51   ` Pierre-Louis Bossart
2023-01-06  1:06     ` Wesley Cheng [this message]
2023-01-06  1:06       ` Wesley Cheng
2022-12-23 23:31 ` [RFC PATCH 10/14] sound: usb: card: Check for support for requested audio format Wesley Cheng
2022-12-23 23:31   ` Wesley Cheng
2022-12-24  8:59   ` Greg KH
2022-12-24  8:59     ` Greg KH
2022-12-27 21:07     ` Wesley Cheng
2022-12-27 21:07       ` Wesley Cheng
2022-12-27 20:31   ` kernel test robot
2022-12-23 23:31 ` [RFC PATCH 11/14] sound: soc: soc-usb: Add PCM format check API for USB backend Wesley Cheng
2022-12-23 23:31   ` Wesley Cheng
2022-12-24  2:17   ` kernel test robot
2022-12-24  2:17   ` kernel test robot
2022-12-23 23:31 ` [RFC PATCH 12/14] sound: soc: qcom: qusb6: Ensure PCM format is supported by USB audio device Wesley Cheng
2022-12-23 23:31   ` Wesley Cheng
2022-12-24  8:19   ` Sergey Shtylyov
2022-12-24  8:19     ` Sergey Shtylyov
2022-12-24  8:50     ` Wesley Cheng
2022-12-24  8:50       ` Wesley Cheng
2023-01-03 17:44   ` Mark Brown
2023-01-03 17:44     ` Mark Brown
2022-12-23 23:31 ` [RFC PATCH 13/14] ASoC: dt-bindings: Add Q6USB backend bindings Wesley Cheng
2022-12-23 23:31   ` Wesley Cheng
2022-12-26 12:25   ` Krzysztof Kozlowski
2022-12-26 12:25     ` Krzysztof Kozlowski
2022-12-23 23:32 ` [RFC PATCH 14/14] ASoC: dt-bindings: Update example for enabling USB offload on SM8250 Wesley Cheng
2022-12-23 23:32   ` Wesley Cheng
2022-12-26 12:27   ` Krzysztof Kozlowski
2022-12-26 12:27     ` Krzysztof Kozlowski
2023-01-03 17:46     ` Mark Brown
2023-01-03 17:46       ` Mark Brown
2023-01-05 18:09       ` Krzysztof Kozlowski
2023-01-05 18:09         ` Krzysztof Kozlowski
2023-01-04  0:46   ` Rob Herring
2023-01-04  0:46     ` Rob Herring
2022-12-24  6:45 ` [RFC PATCH 00/14] Introduce QC USB SND audio offloading support Greg KH
2022-12-24  6:45   ` Greg KH
2022-12-24  8:49   ` Wesley Cheng
2022-12-24  8:49     ` Wesley Cheng
2022-12-27 14:36   ` Mark Brown
2022-12-27 14:36     ` Mark Brown
2023-01-04 23:19 ` Pierre-Louis Bossart
2023-01-06  1:05   ` Wesley Cheng
2023-01-06  1:05     ` Wesley Cheng
2023-01-06 15:57     ` Pierre-Louis Bossart
2023-01-07  0:46       ` Wesley Cheng
2023-01-07  0:46         ` Wesley Cheng

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=cc40d2e2-3384-cd64-f53c-a0811b53d781@quicinc.com \
    --to=quic_wcheng@quicinc.com \
    --cc=Thinh.Nguyen@synopsys.com \
    --cc=agross@kernel.org \
    --cc=alsa-devel@alsa-project.org \
    --cc=andersson@kernel.org \
    --cc=bgoswami@quicinc.com \
    --cc=broonie@kernel.org \
    --cc=devicetree@vger.kernel.org \
    --cc=gregkh@linuxfoundation.org \
    --cc=krzysztof.kozlowski+dt@linaro.org \
    --cc=lgirdwood@gmail.com \
    --cc=linux-arm-msm@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-usb@vger.kernel.org \
    --cc=mathias.nyman@intel.com \
    --cc=perex@perex.cz \
    --cc=pierre-louis.bossart@linux.intel.com \
    --cc=quic_jackp@quicinc.com \
    --cc=quic_plai@quicinc.com \
    --cc=robh+dt@kernel.org \
    --cc=srinivas.kandagatla@linaro.org \
    --cc=tiwai@suse.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.