From: Robin Murphy <robin.murphy@arm.com>
To: Christoph Hellwig <hch@infradead.org>
Cc: joro@8bytes.org, will@kernel.org, linux-kernel@vger.kernel.org,
willy@infradead.org, linux-mm@kvack.org,
iommu@lists.linux-foundation.org
Subject: Re: [PATCH v2 05/11] iommu/iova: Squash flush_cb abstraction
Date: Fri, 17 Dec 2021 12:08:25 +0000 [thread overview]
Message-ID: <cc7d6f7f-1077-9ad0-69e5-a4851229fd37@arm.com> (raw)
In-Reply-To: <Ybryoh61+htoulPN@infradead.org>
On 2021-12-16 08:02, Christoph Hellwig wrote:
>> @@ -147,7 +142,7 @@ struct iova *reserve_iova(struct iova_domain *iovad, unsigned long pfn_lo,
>> unsigned long pfn_hi);
>> void init_iova_domain(struct iova_domain *iovad, unsigned long granule,
>> unsigned long start_pfn);
>> -int init_iova_flush_queue(struct iova_domain *iovad, iova_flush_cb flush_cb);
>> +int init_iova_flush_queue(struct iova_domain *iovad, struct iommu_domain *fq_domain);
>
> Overly long line here.
Fear not, it disappears again in the final patch. In cases like this I
much prefer to minimise the amount of churn within the series, to keep
the patches focused on the meaningful changes.
> Otherwise looks good:
>
> Reviewed-by: Christoph Hellwig <hch@lst.de>
Thanks for the reviews!
Robin.
WARNING: multiple messages have this Message-ID (diff)
From: Robin Murphy <robin.murphy@arm.com>
To: Christoph Hellwig <hch@infradead.org>
Cc: linux-kernel@vger.kernel.org, willy@infradead.org,
linux-mm@kvack.org, iommu@lists.linux-foundation.org,
will@kernel.org
Subject: Re: [PATCH v2 05/11] iommu/iova: Squash flush_cb abstraction
Date: Fri, 17 Dec 2021 12:08:25 +0000 [thread overview]
Message-ID: <cc7d6f7f-1077-9ad0-69e5-a4851229fd37@arm.com> (raw)
In-Reply-To: <Ybryoh61+htoulPN@infradead.org>
On 2021-12-16 08:02, Christoph Hellwig wrote:
>> @@ -147,7 +142,7 @@ struct iova *reserve_iova(struct iova_domain *iovad, unsigned long pfn_lo,
>> unsigned long pfn_hi);
>> void init_iova_domain(struct iova_domain *iovad, unsigned long granule,
>> unsigned long start_pfn);
>> -int init_iova_flush_queue(struct iova_domain *iovad, iova_flush_cb flush_cb);
>> +int init_iova_flush_queue(struct iova_domain *iovad, struct iommu_domain *fq_domain);
>
> Overly long line here.
Fear not, it disappears again in the final patch. In cases like this I
much prefer to minimise the amount of churn within the series, to keep
the patches focused on the meaningful changes.
> Otherwise looks good:
>
> Reviewed-by: Christoph Hellwig <hch@lst.de>
Thanks for the reviews!
Robin.
_______________________________________________
iommu mailing list
iommu@lists.linux-foundation.org
https://lists.linuxfoundation.org/mailman/listinfo/iommu
next prev parent reply other threads:[~2021-12-17 12:08 UTC|newest]
Thread overview: 66+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-12-10 17:54 [PATCH v2 00/11] iommu: refactor flush queues into iommu-dma Robin Murphy
2021-12-10 17:54 ` Robin Murphy
2021-12-10 17:54 ` [PATCH v2 01/11] iommu/iova: Fix race between FQ timeout and teardown Robin Murphy
2021-12-10 17:54 ` Robin Murphy
2021-12-10 18:04 ` John Garry
2021-12-10 18:04 ` John Garry via iommu
2021-12-10 18:13 ` Robin Murphy
2021-12-10 18:13 ` Robin Murphy
2021-12-10 19:19 ` John Garry
2021-12-10 19:19 ` John Garry via iommu
2021-12-10 17:54 ` [PATCH v2 02/11] gpu: host1x: Add missing DMA API include Robin Murphy
2021-12-10 17:54 ` Robin Murphy
2021-12-10 17:54 ` Robin Murphy
2021-12-16 8:53 ` Thierry Reding
2021-12-16 8:53 ` Thierry Reding
2021-12-16 8:53 ` Thierry Reding
2021-12-10 17:54 ` [PATCH v2 03/11] drm/tegra: vic: Fix DMA API misuse Robin Murphy
2021-12-10 17:54 ` Robin Murphy
2021-12-10 17:54 ` Robin Murphy
2021-12-16 8:01 ` Christoph Hellwig
2021-12-16 8:01 ` Christoph Hellwig
2021-12-16 8:55 ` Thierry Reding
2021-12-16 8:55 ` Thierry Reding
2021-12-16 8:55 ` Thierry Reding
2021-12-10 17:54 ` [PATCH v2 04/11] iommu/iova: Squash entry_dtor abstraction Robin Murphy
2021-12-10 17:54 ` Robin Murphy
2021-12-14 16:39 ` John Garry
2021-12-14 16:39 ` John Garry via iommu
2021-12-16 8:02 ` Christoph Hellwig
2021-12-16 8:02 ` Christoph Hellwig
2021-12-10 17:54 ` [PATCH v2 05/11] iommu/iova: Squash flush_cb abstraction Robin Murphy
2021-12-10 17:54 ` Robin Murphy
2021-12-14 16:39 ` John Garry
2021-12-14 16:39 ` John Garry via iommu
2021-12-16 8:02 ` Christoph Hellwig
2021-12-16 8:02 ` Christoph Hellwig
2021-12-17 12:08 ` Robin Murphy [this message]
2021-12-17 12:08 ` Robin Murphy
2021-12-10 17:54 ` [PATCH v2 06/11] iommu/amd: Simplify pagetable freeing Robin Murphy
2021-12-10 17:54 ` Robin Murphy
2021-12-10 17:54 ` [PATCH v2 07/11] iommu/amd: Use put_pages_list Robin Murphy
2021-12-10 17:54 ` Robin Murphy
2021-12-10 17:54 ` [PATCH v2 08/11] iommu/vt-d: " Robin Murphy
2021-12-10 17:54 ` Robin Murphy
2021-12-10 17:54 ` [PATCH v2 09/11] iommu/iova: Consolidate flush queue code Robin Murphy
2021-12-10 17:54 ` Robin Murphy
2021-12-14 16:39 ` John Garry
2021-12-14 16:39 ` John Garry via iommu
2021-12-10 17:54 ` [PATCH v2 10/11] iommu/iova: Move flush queue code to iommu-dma Robin Murphy
2021-12-10 17:54 ` Robin Murphy
2021-12-14 16:40 ` John Garry
2021-12-14 16:40 ` John Garry via iommu
2021-12-14 17:18 ` John Garry
2021-12-14 17:18 ` John Garry via iommu
2021-12-14 17:50 ` Robin Murphy
2021-12-14 17:50 ` Robin Murphy
2021-12-10 17:54 ` [PATCH v2 11/11] iommu: Move flush queue data into iommu_dma_cookie Robin Murphy
2021-12-10 17:54 ` Robin Murphy
2021-12-10 23:30 ` kernel test robot
2021-12-10 23:30 ` kernel test robot
2021-12-10 23:30 ` kernel test robot
2021-12-10 23:50 ` kernel test robot
2021-12-10 23:50 ` kernel test robot
2021-12-10 23:50 ` kernel test robot
2021-12-14 17:16 ` John Garry
2021-12-14 17:16 ` John Garry via iommu
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=cc7d6f7f-1077-9ad0-69e5-a4851229fd37@arm.com \
--to=robin.murphy@arm.com \
--cc=hch@infradead.org \
--cc=iommu@lists.linux-foundation.org \
--cc=joro@8bytes.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=will@kernel.org \
--cc=willy@infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.