From: Robin Murphy <robin.murphy@arm.com> To: John Garry <john.garry@huawei.com>, joro@8bytes.org, will@kernel.org Cc: linux-kernel@vger.kernel.org, willy@infradead.org, linux-mm@kvack.org, iommu@lists.linux-foundation.org Subject: Re: [PATCH v2 10/11] iommu/iova: Move flush queue code to iommu-dma Date: Tue, 14 Dec 2021 17:50:41 +0000 [thread overview] Message-ID: <ddbe509c-8e54-e653-040f-e7edc8774060@arm.com> (raw) In-Reply-To: <f0ec6978-4571-2d7c-f94c-cd92ba167074@huawei.com> On 2021-12-14 17:18, John Garry via iommu wrote: > On 10/12/2021 17:54, Robin Murphy wrote: >> + iovad->fq_domain = fq_domain; >> + iovad->fq = queue; >> + >> + timer_setup(&iovad->fq_timer, fq_flush_timeout, 0); >> + atomic_set(&iovad->fq_timer_on, 0); >> + >> + return 0; >> +} >> + >> + > > nit: a single blank line is standard, I think Hmm, you're right - I've grown fond of leaving an extra little bit of breathing space between logically-independent sections of code, and for some reason I thought this file was already in that style, but indeed it isn't. Joerg - let me know if you feel strongly enough that you'd like me to change that. I'm going to have one last go at fixing tegra-drm, so I'm happy to send a v3 of the whole series later this week if there are any other minor tweaks too. Thanks for all the reviews! Robin. > > Cheers > >> static inline size_t cookie_msi_granule(struct iommu_dma_cookie >> *cookie) >> { > > > _______________________________________________ > iommu mailing list > iommu@lists.linux-foundation.org > https://lists.linuxfoundation.org/mailman/listinfo/iommu
WARNING: multiple messages have this Message-ID (diff)
From: Robin Murphy <robin.murphy@arm.com> To: John Garry <john.garry@huawei.com>, joro@8bytes.org, will@kernel.org Cc: linux-mm@kvack.org, iommu@lists.linux-foundation.org, linux-kernel@vger.kernel.org, willy@infradead.org Subject: Re: [PATCH v2 10/11] iommu/iova: Move flush queue code to iommu-dma Date: Tue, 14 Dec 2021 17:50:41 +0000 [thread overview] Message-ID: <ddbe509c-8e54-e653-040f-e7edc8774060@arm.com> (raw) In-Reply-To: <f0ec6978-4571-2d7c-f94c-cd92ba167074@huawei.com> On 2021-12-14 17:18, John Garry via iommu wrote: > On 10/12/2021 17:54, Robin Murphy wrote: >> + iovad->fq_domain = fq_domain; >> + iovad->fq = queue; >> + >> + timer_setup(&iovad->fq_timer, fq_flush_timeout, 0); >> + atomic_set(&iovad->fq_timer_on, 0); >> + >> + return 0; >> +} >> + >> + > > nit: a single blank line is standard, I think Hmm, you're right - I've grown fond of leaving an extra little bit of breathing space between logically-independent sections of code, and for some reason I thought this file was already in that style, but indeed it isn't. Joerg - let me know if you feel strongly enough that you'd like me to change that. I'm going to have one last go at fixing tegra-drm, so I'm happy to send a v3 of the whole series later this week if there are any other minor tweaks too. Thanks for all the reviews! Robin. > > Cheers > >> static inline size_t cookie_msi_granule(struct iommu_dma_cookie >> *cookie) >> { > > > _______________________________________________ > iommu mailing list > iommu@lists.linux-foundation.org > https://lists.linuxfoundation.org/mailman/listinfo/iommu _______________________________________________ iommu mailing list iommu@lists.linux-foundation.org https://lists.linuxfoundation.org/mailman/listinfo/iommu
next prev parent reply other threads:[~2021-12-14 17:50 UTC|newest] Thread overview: 66+ messages / expand[flat|nested] mbox.gz Atom feed top 2021-12-10 17:54 [PATCH v2 00/11] iommu: refactor flush queues into iommu-dma Robin Murphy 2021-12-10 17:54 ` Robin Murphy 2021-12-10 17:54 ` [PATCH v2 01/11] iommu/iova: Fix race between FQ timeout and teardown Robin Murphy 2021-12-10 17:54 ` Robin Murphy 2021-12-10 18:04 ` John Garry 2021-12-10 18:04 ` John Garry via iommu 2021-12-10 18:13 ` Robin Murphy 2021-12-10 18:13 ` Robin Murphy 2021-12-10 19:19 ` John Garry 2021-12-10 19:19 ` John Garry via iommu 2021-12-10 17:54 ` [PATCH v2 02/11] gpu: host1x: Add missing DMA API include Robin Murphy 2021-12-10 17:54 ` Robin Murphy 2021-12-10 17:54 ` Robin Murphy 2021-12-16 8:53 ` Thierry Reding 2021-12-16 8:53 ` Thierry Reding 2021-12-16 8:53 ` Thierry Reding 2021-12-10 17:54 ` [PATCH v2 03/11] drm/tegra: vic: Fix DMA API misuse Robin Murphy 2021-12-10 17:54 ` Robin Murphy 2021-12-10 17:54 ` Robin Murphy 2021-12-16 8:01 ` Christoph Hellwig 2021-12-16 8:01 ` Christoph Hellwig 2021-12-16 8:55 ` Thierry Reding 2021-12-16 8:55 ` Thierry Reding 2021-12-16 8:55 ` Thierry Reding 2021-12-10 17:54 ` [PATCH v2 04/11] iommu/iova: Squash entry_dtor abstraction Robin Murphy 2021-12-10 17:54 ` Robin Murphy 2021-12-14 16:39 ` John Garry 2021-12-14 16:39 ` John Garry via iommu 2021-12-16 8:02 ` Christoph Hellwig 2021-12-16 8:02 ` Christoph Hellwig 2021-12-10 17:54 ` [PATCH v2 05/11] iommu/iova: Squash flush_cb abstraction Robin Murphy 2021-12-10 17:54 ` Robin Murphy 2021-12-14 16:39 ` John Garry 2021-12-14 16:39 ` John Garry via iommu 2021-12-16 8:02 ` Christoph Hellwig 2021-12-16 8:02 ` Christoph Hellwig 2021-12-17 12:08 ` Robin Murphy 2021-12-17 12:08 ` Robin Murphy 2021-12-10 17:54 ` [PATCH v2 06/11] iommu/amd: Simplify pagetable freeing Robin Murphy 2021-12-10 17:54 ` Robin Murphy 2021-12-10 17:54 ` [PATCH v2 07/11] iommu/amd: Use put_pages_list Robin Murphy 2021-12-10 17:54 ` Robin Murphy 2021-12-10 17:54 ` [PATCH v2 08/11] iommu/vt-d: " Robin Murphy 2021-12-10 17:54 ` Robin Murphy 2021-12-10 17:54 ` [PATCH v2 09/11] iommu/iova: Consolidate flush queue code Robin Murphy 2021-12-10 17:54 ` Robin Murphy 2021-12-14 16:39 ` John Garry 2021-12-14 16:39 ` John Garry via iommu 2021-12-10 17:54 ` [PATCH v2 10/11] iommu/iova: Move flush queue code to iommu-dma Robin Murphy 2021-12-10 17:54 ` Robin Murphy 2021-12-14 16:40 ` John Garry 2021-12-14 16:40 ` John Garry via iommu 2021-12-14 17:18 ` John Garry 2021-12-14 17:18 ` John Garry via iommu 2021-12-14 17:50 ` Robin Murphy [this message] 2021-12-14 17:50 ` Robin Murphy 2021-12-10 17:54 ` [PATCH v2 11/11] iommu: Move flush queue data into iommu_dma_cookie Robin Murphy 2021-12-10 17:54 ` Robin Murphy 2021-12-10 23:30 ` kernel test robot 2021-12-10 23:30 ` kernel test robot 2021-12-10 23:30 ` kernel test robot 2021-12-10 23:50 ` kernel test robot 2021-12-10 23:50 ` kernel test robot 2021-12-10 23:50 ` kernel test robot 2021-12-14 17:16 ` John Garry 2021-12-14 17:16 ` John Garry via iommu
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=ddbe509c-8e54-e653-040f-e7edc8774060@arm.com \ --to=robin.murphy@arm.com \ --cc=iommu@lists.linux-foundation.org \ --cc=john.garry@huawei.com \ --cc=joro@8bytes.org \ --cc=linux-kernel@vger.kernel.org \ --cc=linux-mm@kvack.org \ --cc=will@kernel.org \ --cc=willy@infradead.org \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: linkBe sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.