All of lore.kernel.org
 help / color / mirror / Atom feed
From: Josef Bacik <josef@toxicpanda.com>
To: Nikolay Borisov <nborisov@suse.com>, linux-btrfs@vger.kernel.org
Subject: Re: [PATCH 3/4] btrfs: Handle another split brain scenario with metadata uuid feature
Date: Fri, 10 Jan 2020 10:29:50 -0500	[thread overview]
Message-ID: <cca95582-59e6-d639-e1ca-bc6533374522@toxicpanda.com> (raw)
In-Reply-To: <20200110121135.7386-4-nborisov@suse.com>

On 1/10/20 7:11 AM, Nikolay Borisov wrote:
> There is one more cases which isn't handled by the original metadata
> uuid work. Namely, when a filesystem has METADATA_UUID incompat bit and
> the user decides to change the FSID to the original one e.g. have
> metadata_uuid and fsid match. In case of power failure while this
> operation is in progress we could end up in a situation where some of
> the disks have the incompat bit removed and the other half have both
> METADATA_UUID_INCOMPAT and FSID_CHANGING_IN_PROGRESS flags.
> 
> This patch handles the case where a disk that has successfully changed
> its FSID such that it equals METADATA_UUID is scanned first.
> Subsequently when a disk with both
> METADATA_UUID_INCOMPAT/FSID_CHANGING_IN_PROGRESS flags is scanned
> find_fsid_changed won't be able to find an appropriate btrfs_fs_devices.
> This is done by extending find_fsid_changed to correctly find
> btrfs_fs_devices whose metadata_uuid/fsid are the same and they match
> the metadata_uuid of the currently scanned device.
> 
> Fixes: cc5de4e70256 ("btrfs: Handle final split-brain possibility during fsid change")
> Reported-by: Su Yue <Damenly_Su@gmx.com>
> Signed-off-by: Nikolay Borisov <nborisov@suse.com>

Reviewed-by: Josef Bacik <josef@toxicpanda.com>

Thanks,

Josef

  reply	other threads:[~2020-01-10 15:29 UTC|newest]

Thread overview: 12+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-01-10 12:11 [PATCH 0/4] More split-brain fixes for " Nikolay Borisov
2020-01-10 12:11 ` [PATCH 1/4] btrfs: Call find_fsid from find_fsid_inprogress Nikolay Borisov
2020-01-10 15:24   ` Josef Bacik
2020-01-10 12:11 ` [PATCH 2/4] btrfs: Factor out metadata_uuid code from find_fsid Nikolay Borisov
2020-01-10 15:25   ` Josef Bacik
2020-01-10 12:11 ` [PATCH 3/4] btrfs: Handle another split brain scenario with metadata uuid feature Nikolay Borisov
2020-01-10 15:29   ` Josef Bacik [this message]
2020-01-21 15:16   ` David Sterba
2020-01-10 12:11 ` [PATCH 4/4] btrfs: Fix split-brain handling when changing FSID to metadata uuid Nikolay Borisov
2020-01-10 15:58   ` Josef Bacik
2020-01-14 17:14 ` [PATCH 0/4] More split-brain fixes for metadata uuid feature David Sterba
2020-01-21 15:23   ` David Sterba

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=cca95582-59e6-d639-e1ca-bc6533374522@toxicpanda.com \
    --to=josef@toxicpanda.com \
    --cc=linux-btrfs@vger.kernel.org \
    --cc=nborisov@suse.com \
    --subject='Re: [PATCH 3/4] btrfs: Handle another split brain scenario with metadata uuid feature' \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.