All of lore.kernel.org
 help / color / mirror / Atom feed
* [Buildroot] package/aravis: new package
@ 2022-01-05 15:57 marc.chalain
  2022-01-06  9:24 ` Romain Naour
  0 siblings, 1 reply; 5+ messages in thread
From: marc.chalain @ 2022-01-05 15:57 UTC (permalink / raw)
  To: buildroot; +Cc: Eric Le Bihan, Marc Chalain


[-- Attachment #1.1: Type: text/plain, Size: 3604 bytes --]

Hello and Happy new year,



I propose the integration of a camera capture library:



Aravis is a library to help GigE camera capture.
https://github.com/AravisProject/aravis/releases/tag/0.8.16
This rules install on target:
 libaravis
 arv-camera-test
 arv-fake-gv-camera
 arv-test
 arv-tool
and on staging
 aravis/*.h

Signed-off-by: Marc Chalain <marc.chalain@gmail.com>
---
 DEVELOPERS                 |  3 +++
 package/Config.in          |  1 +
 package/aravis/Config.in   | 16 ++++++++++++++++
 package/aravis/aravis.hash |  1 +
 package/aravis/aravis.mk   | 20 ++++++++++++++++++++
 5 files changed, 41 insertions(+)
 create mode 100644 package/aravis/Config.in
 create mode 100644 package/aravis/aravis.hash
 create mode 100644 package/aravis/aravis.mk

diff --git a/DEVELOPERS b/DEVELOPERS
index 6dc2e68e42..05c1c3c921 100644
--- a/DEVELOPERS
+++ b/DEVELOPERS
@@ -1653,6 +1653,9 @@ N:    Manuel Vögele <develop@manuel-voegele.de>
 F:    package/python-pyqt5/
 F:    package/python-requests-toolbelt/
 
+N:    Marc Chalain <marc.chalain@gmail.com>
+F:    package/aravis
+
 N:    Marcin Bis <marcin@bis.org.pl>
 F:    package/bluez5_utils/
 F:    package/cc-tool/
diff --git a/package/Config.in b/package/Config.in
index 9fed0ab4cb..2a1781afe9 100644
--- a/package/Config.in
+++ b/package/Config.in
@@ -1698,6 +1698,7 @@ menu "Logging"
 endmenu
 
 menu "Multimedia"
+    source "package/aravis/Config.in"
     source "package/bitstream/Config.in"
     source "package/dav1d/Config.in"
     source "package/kvazaar/Config.in"
diff --git a/package/aravis/Config.in b/package/aravis/Config.in
new file mode 100644
index 0000000000..02c71c44da
--- /dev/null
+++ b/package/aravis/Config.in
@@ -0,0 +1,16 @@
+config BR2_PACKAGE_ARAVIS
+    bool "aravis - GigE Camera"
+    depends on BR2_USE_WCHAR
+    depends on BR2_TOOLCHAIN_HAS_THREADS_NPTL
+    depends on BR2_PACKAGE_PCRE_16
+    depends on BR2_PACKAGE_PCRE_32
+    select BR2_PACKAGE_LIBGLIB2
+    select BR2_PACKAGE_LIBXML2
+    help
+      aravis provides the support of GigE camera
+      and USB3Vision camera.
+      https://github.com/AravisProject/aravis
+
+comment "aravis needs a toolchain w/ wchar, NPTL, PCRE 16/32"
+    depends on !BR2_USE_WCHAR || !BR2_TOOLCHAIN_HAS_THREADS_NPTL || \
+    !BR2_PACKAGE_PCRE_16 || !BR2_PACKAGE_PCRE_32
diff --git a/package/aravis/aravis.hash b/package/aravis/aravis.hash
new file mode 100644
index 0000000000..f8512491ec
--- /dev/null
+++ b/package/aravis/aravis.hash
@@ -0,0 +1 @@
+sha256 057166753443acc115259ca1f74bd1b28ed4d48f35261cb248eafb8f86664bc7 aravis-0.8.16.tar.gz
diff --git a/package/aravis/aravis.mk b/package/aravis/aravis.mk
new file mode 100644
index 0000000000..bd783a0374
--- /dev/null
+++ b/package/aravis/aravis.mk
@@ -0,0 +1,20 @@
+################################################################################
+#
+# aravis
+#
+################################################################################
+
+ARAVIS_VERSION = 0.8.16
+ARAVIS_SITE = $(call github,AravisProject,aravis,$(ARAVIS_VERSION))
+ARAVIS_DEPENDENCIES = \
+    host-pkgconf \
+    libglib2 \
+    libxml2
+ARAVIS_INSTALL_STAGING = YES
+ARAVIS_LICENSE = LGPL-2
+ARAVIS_LICENSE_FILES = COPYING
+ARAVIS_LDFLAGS = $(TARGET_LDFLAGS) $(TARGET_NLS_LIBS)
+
+ARAVIS_CONF_OPTS += -Ddocumentation=disabled
+
+$(eval $(meson-package))
-- 
2.30.2




[-- Attachment #1.2: Type: text/html, Size: 4151 bytes --]

[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #2: 0001-package-aravis-new-package.patch --]
[-- Type: text/x-patch; name="0001-package-aravis-new-package.patch", Size: 3369 bytes --]

From 4cdaba5a557cd393802b4e563e6f0c7f6bcc0854 Mon Sep 17 00:00:00 2001
From: mchalain <marc.chalain@scantech.com>
Date: Wed, 5 Jan 2022 16:31:57 +0100
Subject: [PATCH 1/1] package/aravis: new package

Aravis is a library to help GigE camera capture.
https://github.com/AravisProject/aravis/releases/tag/0.8.16
This rules install on target:
 libaravis
 arv-camera-test
 arv-fake-gv-camera
 arv-test
 arv-tool
and on staging
 aravis/*.h

Signed-off-by: Marc Chalain <marc.chalain@gmail.com>
---
 DEVELOPERS                 |  3 +++
 package/Config.in          |  1 +
 package/aravis/Config.in   | 16 ++++++++++++++++
 package/aravis/aravis.hash |  1 +
 package/aravis/aravis.mk   | 20 ++++++++++++++++++++
 5 files changed, 41 insertions(+)
 create mode 100644 package/aravis/Config.in
 create mode 100644 package/aravis/aravis.hash
 create mode 100644 package/aravis/aravis.mk

diff --git a/DEVELOPERS b/DEVELOPERS
index 6dc2e68e42..05c1c3c921 100644
--- a/DEVELOPERS
+++ b/DEVELOPERS
@@ -1653,6 +1653,9 @@ N:	Manuel Vögele <develop@manuel-voegele.de>
 F:	package/python-pyqt5/
 F:	package/python-requests-toolbelt/
 
+N:	Marc Chalain <marc.chalain@gmail.com>
+F:	package/aravis
+
 N:	Marcin Bis <marcin@bis.org.pl>
 F:	package/bluez5_utils/
 F:	package/cc-tool/
diff --git a/package/Config.in b/package/Config.in
index 9fed0ab4cb..2a1781afe9 100644
--- a/package/Config.in
+++ b/package/Config.in
@@ -1698,6 +1698,7 @@ menu "Logging"
 endmenu
 
 menu "Multimedia"
+	source "package/aravis/Config.in"
 	source "package/bitstream/Config.in"
 	source "package/dav1d/Config.in"
 	source "package/kvazaar/Config.in"
diff --git a/package/aravis/Config.in b/package/aravis/Config.in
new file mode 100644
index 0000000000..02c71c44da
--- /dev/null
+++ b/package/aravis/Config.in
@@ -0,0 +1,16 @@
+config BR2_PACKAGE_ARAVIS
+	bool "aravis - GigE Camera"
+	depends on BR2_USE_WCHAR
+	depends on BR2_TOOLCHAIN_HAS_THREADS_NPTL
+	depends on BR2_PACKAGE_PCRE_16
+	depends on BR2_PACKAGE_PCRE_32
+	select BR2_PACKAGE_LIBGLIB2
+	select BR2_PACKAGE_LIBXML2
+	help
+	  aravis provides the support of GigE camera
+	  and USB3Vision camera.
+	  https://github.com/AravisProject/aravis
+
+comment "aravis needs a toolchain w/ wchar, NPTL, PCRE 16/32"
+	depends on !BR2_USE_WCHAR || !BR2_TOOLCHAIN_HAS_THREADS_NPTL || \
+	!BR2_PACKAGE_PCRE_16 || !BR2_PACKAGE_PCRE_32
diff --git a/package/aravis/aravis.hash b/package/aravis/aravis.hash
new file mode 100644
index 0000000000..f8512491ec
--- /dev/null
+++ b/package/aravis/aravis.hash
@@ -0,0 +1 @@
+sha256 057166753443acc115259ca1f74bd1b28ed4d48f35261cb248eafb8f86664bc7 aravis-0.8.16.tar.gz
diff --git a/package/aravis/aravis.mk b/package/aravis/aravis.mk
new file mode 100644
index 0000000000..bd783a0374
--- /dev/null
+++ b/package/aravis/aravis.mk
@@ -0,0 +1,20 @@
+################################################################################
+#
+# aravis
+#
+################################################################################
+
+ARAVIS_VERSION = 0.8.16
+ARAVIS_SITE = $(call github,AravisProject,aravis,$(ARAVIS_VERSION))
+ARAVIS_DEPENDENCIES = \
+	host-pkgconf \
+	libglib2 \
+	libxml2
+ARAVIS_INSTALL_STAGING = YES
+ARAVIS_LICENSE = LGPL-2
+ARAVIS_LICENSE_FILES = COPYING
+ARAVIS_LDFLAGS = $(TARGET_LDFLAGS) $(TARGET_NLS_LIBS)
+
+ARAVIS_CONF_OPTS += -Ddocumentation=disabled
+
+$(eval $(meson-package))
-- 
2.30.2


[-- Attachment #3: Type: text/plain, Size: 150 bytes --]

_______________________________________________
buildroot mailing list
buildroot@buildroot.org
https://lists.buildroot.org/mailman/listinfo/buildroot

^ permalink raw reply related	[flat|nested] 5+ messages in thread
* Re: [Buildroot] package/aravis: new package
  2022-01-05 15:57 [Buildroot] package/aravis: new package marc.chalain
@ 2022-01-06  9:24 ` Romain Naour
  2022-01-06  9:37   ` Thomas Petazzoni
  0 siblings, 1 reply; 5+ messages in thread
From: Romain Naour @ 2022-01-06  9:24 UTC (permalink / raw)
  To: marc.chalain, buildroot; +Cc: Eric Le Bihan, Marc Chalain

Hello Marc,

Le 05/01/2022 à 16:57, marc.chalain@mailoo.org a écrit :
> Hello and Happy new year,
> 
> 
> 
> I propose the integration of a camera capture library:
> 
> 
> 
> Aravis is a library to help GigE camera capture.
> https://github.com/AravisProject/aravis/releases/tag/0.8.16
> This rules install on target:
>  libaravis
>  arv-camera-test
>  arv-fake-gv-camera
>  arv-test
>  arv-tool
> and on staging
>  aravis/*.h
> 
> Signed-off-by: Marc Chalain <marc.chalain@gmail.com>
> ---
>  DEVELOPERS                 |  3 +++
>  package/Config.in          |  1 +
>  package/aravis/Config.in   | 16 ++++++++++++++++
>  package/aravis/aravis.hash |  1 +
>  package/aravis/aravis.mk   | 20 ++++++++++++++++++++
>  5 files changed, 41 insertions(+)
>  create mode 100644 package/aravis/Config.in
>  create mode 100644 package/aravis/aravis.hash
>  create mode 100644 package/aravis/aravis.mk
> 
> diff --git a/DEVELOPERS b/DEVELOPERS
> index 6dc2e68e42..05c1c3c921 100644
> --- a/DEVELOPERS
> +++ b/DEVELOPERS
> @@ -1653,6 +1653,9 @@ N:    Manuel Vögele <develop@manuel-voegele.de>
>  F:    package/python-pyqt5/
>  F:    package/python-requests-toolbelt/
>  
> +N:    Marc Chalain <marc.chalain@gmail.com>
> +F:    package/aravis

Missing '/' at the end of the line

> +
>  N:    Marcin Bis <marcin@bis.org.pl>
>  F:    package/bluez5_utils/
>  F:    package/cc-tool/
> diff --git a/package/Config.in b/package/Config.in
> index 9fed0ab4cb..2a1781afe9 100644
> --- a/package/Config.in
> +++ b/package/Config.in
> @@ -1698,6 +1698,7 @@ menu "Logging"
>  endmenu
>  
>  menu "Multimedia"
> +    source "package/aravis/Config.in"

Probably more related to "Hardware Handling" since it support camera devices.

>      source "package/bitstream/Config.in"
>      source "package/dav1d/Config.in"
>      source "package/kvazaar/Config.in"
> diff --git a/package/aravis/Config.in b/package/aravis/Config.in
> new file mode 100644
> index 0000000000..02c71c44da
> --- /dev/null
> +++ b/package/aravis/Config.in
> @@ -0,0 +1,16 @@
> +config BR2_PACKAGE_ARAVIS
> +    bool "aravis - GigE Camera"
> +    depends on BR2_USE_WCHAR
> +    depends on BR2_TOOLCHAIN_HAS_THREADS_NPTL
> +    depends on BR2_PACKAGE_PCRE_16
> +    depends on BR2_PACKAGE_PCRE_32
> +    select BR2_PACKAGE_LIBGLIB2
> +    select BR2_PACKAGE_LIBXML2
> +    help
> +      aravis provides the support of GigE camera
> +      and USB3Vision camera.

Add an empty line

Also use check-package script to check the coding style.

> +      https://github.com/AravisProject/aravis
> +
> +comment "aravis needs a toolchain w/ wchar, NPTL, PCRE 16/32"
> +    depends on !BR2_USE_WCHAR || !BR2_TOOLCHAIN_HAS_THREADS_NPTL || \
> +    !BR2_PACKAGE_PCRE_16 || !BR2_PACKAGE_PCRE_32
> diff --git a/package/aravis/aravis.hash b/package/aravis/aravis.hash
> new file mode 100644
> index 0000000000..f8512491ec
> --- /dev/null
> +++ b/package/aravis/aravis.hash
> @@ -0,0 +1 @@
> +sha256 057166753443acc115259ca1f74bd1b28ed4d48f35261cb248eafb8f86664bc7 aravis-0.8.16.tar.gz

Add the license file hash here (COPYING)

> diff --git a/package/aravis/aravis.mk b/package/aravis/aravis.mk
> new file mode 100644
> index 0000000000..bd783a0374
> --- /dev/null
> +++ b/package/aravis/aravis.mk
> @@ -0,0 +1,20 @@
> +################################################################################
> +#
> +# aravis
> +#
> +################################################################################
> +
> +ARAVIS_VERSION = 0.8.16

Aravis project is moving fast, there is a new version 0.8.20 already.
I'm fine with this version since it was released recently:
https://github.com/AravisProject/aravis/releases/tag/0.8.16

> +ARAVIS_SITE = $(call github,AravisProject,aravis,$(ARAVIS_VERSION))
> +ARAVIS_DEPENDENCIES = \
> +    host-pkgconf \
> +    libglib2 \
> +    libxml2

There is a list of dependencies in the Readme:

https://github.com/AravisProject/aravis/blob/main/README.md#install-dependencies-on-ubuntu-2004

especially gstreamer and plugins etc..

> +ARAVIS_INSTALL_STAGING = YES
> +ARAVIS_LICENSE = LGPL-2

It's a LGPL-2.1 license.

> +ARAVIS_LICENSE_FILES = COPYING
> +ARAVIS_LDFLAGS = $(TARGET_LDFLAGS) $(TARGET_NLS_LIBS)

Is gettext a mandatory dependency ?
At least gettext should be in ARAVIS_DEPENDENCIES when NLS support is enabled.

I recommend to use test-pkg script to stress the buildsystem.
Thanks to a recent change, you can test your package with test-pkg in gitlab-ci:

https://gitlab.com/buildroot.org/buildroot/-/commit/12c7a05da154f2056d0a2a1a72f5d066b8d7b87e

Can you send an updated version of your patch?

Best regards,
Romain

> +
> +ARAVIS_CONF_OPTS += -Ddocumentation=disabled
> +
> +$(eval $(meson-package))
> 
> 
> _______________________________________________
> buildroot mailing list
> buildroot@buildroot.org
> https://lists.buildroot.org/mailman/listinfo/buildroot
> 

_______________________________________________
buildroot mailing list
buildroot@buildroot.org
https://lists.buildroot.org/mailman/listinfo/buildroot

^ permalink raw reply	[flat|nested] 5+ messages in thread
* Re: [Buildroot] package/aravis: new package
  2022-01-06  9:24 ` Romain Naour
@ 2022-01-06  9:37   ` Thomas Petazzoni
  2022-01-07 20:08     ` marc.chalain
  0 siblings, 1 reply; 5+ messages in thread
From: Thomas Petazzoni @ 2022-01-06  9:37 UTC (permalink / raw)
  To: Romain Naour; +Cc: Eric Le Bihan, marc.chalain, Marc Chalain, buildroot

Hello,

On Thu, 6 Jan 2022 10:24:53 +0100
Romain Naour <romain.naour@smile.fr> wrote:

> > diff --git a/package/aravis/Config.in b/package/aravis/Config.in
> > new file mode 100644
> > index 0000000000..02c71c44da
> > --- /dev/null
> > +++ b/package/aravis/Config.in
> > @@ -0,0 +1,16 @@
> > +config BR2_PACKAGE_ARAVIS
> > +    bool "aravis - GigE Camera"

Just:

	 bool "aravis"

> > +    depends on BR2_USE_WCHAR
> > +    depends on BR2_TOOLCHAIN_HAS_THREADS_NPTL
> > +    depends on BR2_PACKAGE_PCRE_16
> > +    depends on BR2_PACKAGE_PCRE_32

Please use "select" for pcre.

> > +ARAVIS_LICENSE_FILES = COPYING
> > +ARAVIS_LDFLAGS = $(TARGET_LDFLAGS) $(TARGET_NLS_LIBS)  
> 
> Is gettext a mandatory dependency ?
> At least gettext should be in ARAVIS_DEPENDENCIES when NLS support is enabled.

No, don't add gettext directly, use $(TARGET_NLS_DEPENDENCIES), which
will automatically add (or not) host-gettext and/or gettext to the
dependencies, depending on when it's needed or not.

Thomas
-- 
Thomas Petazzoni, co-owner and CEO, Bootlin
Embedded Linux and Kernel engineering and training
https://bootlin.com
_______________________________________________
buildroot mailing list
buildroot@buildroot.org
https://lists.buildroot.org/mailman/listinfo/buildroot

^ permalink raw reply	[flat|nested] 5+ messages in thread
* Re: [Buildroot] package/aravis: new package
  2022-01-06  9:37   ` Thomas Petazzoni
@ 2022-01-07 20:08     ` marc.chalain
  2022-01-08 10:31       ` Romain Naour
  0 siblings, 1 reply; 5+ messages in thread
From: marc.chalain @ 2022-01-07 20:08 UTC (permalink / raw)
  To: Thomas Petazzoni, Romain Naour; +Cc: Eric Le Bihan, Marc Chalain, buildroot


[-- Attachment #1.1: Type: text/plain, Size: 2903 bytes --]

Thank for all,

I will send a new version quickly, but some questions first:



> +ARAVIS_VERSION = 0.8.16

Aravis project is moving fast, there is a new version 0.8.20 already.
I'm fine with this version since it was released recently:
https://github.com/AravisProject/aravis/releases/tag/0.8.16


The 0.8.16 is available from June 2021. I had clearly well tested this version with several kernel configuration. What is it better ? the last version or the most tested version ?

To send 0.8.20 I will need few weeks, to test.



> +ARAVIS_SITE = $(call github,AravisProject,aravis,$(ARAVIS_VERSION))
> +ARAVIS_DEPENDENCIES = \
> +    host-pkgconf \
> +    libglib2 \
> +    libxml2

There is a list of dependencies in the Readme:

https://github.com/AravisProject/aravis/blob/main/README.md#install-dependencies-on-ubuntu-2004

especially gstreamer and plugins etc..


This rules is just for GigE Camera and not USB3Vision. I haven't tested this feature. The gstreamer is not mandator, it is only for the viewer. I am focused on Embeded system without any kind of display.

If the gstreamer or libusb3 are availables, meson is able to detect and add them during the configuration process.

To add as dependencies, forces to build the optionals features.

What's the best ?



Thank you., best regards,

Marc.







De : Thomas Petazzoni <thomas.petazzoni@bootlin.com>
À : Romain Naour <romain.naour@smile.fr>
Sujet : Re: [Buildroot] package/aravis: new package
Date : 06/01/2022 10:37:59 Europe/Paris
Copie à : marc.chalain@mailoo.org;
   buildroot@buildroot.org;
   Eric Le Bihan <eric.le.bihan.dev@free.fr>;
   Marc Chalain <marc.chalain@gmail.com>

Hello,

On Thu, 6 Jan 2022 10:24:53 +0100
Romain Naour <romain.naour@smile.fr> wrote:

> > diff --git a/package/aravis/Config.in b/package/aravis/Config.in
> > new file mode 100644
> > index 0000000000..02c71c44da
> > --- /dev/null
> > +++ b/package/aravis/Config.in
> > @@ -0,0 +1,16 @@
> > +config BR2_PACKAGE_ARAVIS
> > +    bool "aravis - GigE Camera"

Just:

bool "aravis"

> > +    depends on BR2_USE_WCHAR
> > +    depends on BR2_TOOLCHAIN_HAS_THREADS_NPTL
> > +    depends on BR2_PACKAGE_PCRE_16
> > +    depends on BR2_PACKAGE_PCRE_32

Please use "select" for pcre.

> > +ARAVIS_LICENSE_FILES = COPYING
> > +ARAVIS_LDFLAGS = $(TARGET_LDFLAGS) $(TARGET_NLS_LIBS) 
> 
> Is gettext a mandatory dependency ?
> At least gettext should be in ARAVIS_DEPENDENCIES when NLS support is enabled.

No, don't add gettext directly, use $(TARGET_NLS_DEPENDENCIES), which
will automatically add (or not) host-gettext and/or gettext to the
dependencies, depending on when it's needed or not.

Thomas
-- 
Thomas Petazzoni, co-owner and CEO, Bootlin
Embedded Linux and Kernel engineering and training
https://bootlin.com


[-- Attachment #1.2: Type: text/html, Size: 4353 bytes --]

[-- Attachment #2: Type: text/plain, Size: 150 bytes --]

_______________________________________________
buildroot mailing list
buildroot@buildroot.org
https://lists.buildroot.org/mailman/listinfo/buildroot

^ permalink raw reply	[flat|nested] 5+ messages in thread
* Re: [Buildroot] package/aravis: new package
  2022-01-07 20:08     ` marc.chalain
@ 2022-01-08 10:31       ` Romain Naour
  0 siblings, 0 replies; 5+ messages in thread
From: Romain Naour @ 2022-01-08 10:31 UTC (permalink / raw)
  To: marc.chalain, Thomas Petazzoni; +Cc: Eric Le Bihan, Marc Chalain, buildroot

Hello Marc,

Le 07/01/2022 à 21:08, marc.chalain@mailoo.org a écrit :
> Thank for all,
> 
> I will send a new version quickly, but some questions first:
> 
> 
> 
>> +ARAVIS_VERSION = 0.8.16
> 
> Aravis project is moving fast, there is a new version 0.8.20 already.
> I'm fine with this version since it was released recently:
> https://github.com/AravisProject/aravis/releases/tag/0.8.16
> 
> 
> The 0.8.16 is available from June 2021. I had clearly well tested this version with several kernel configuration. What is it better ? the last version or the most tested version ?
> 
> To send 0.8.20 I will need few weeks, to test.

Using a version you are confident with is OK. Maybe add a comment in the commit
log about your choice to use a previous version than the latest one.

> 
> 
> 
>> +ARAVIS_SITE = $(call github,AravisProject,aravis,$(ARAVIS_VERSION))
>> +ARAVIS_DEPENDENCIES = \
>> +    host-pkgconf \
>> +    libglib2 \
>> +    libxml2
> 
> There is a list of dependencies in the Readme:
> 
> https://github.com/AravisProject/aravis/blob/main/README.md#install-dependencies-on-ubuntu-2004
> 
> especially gstreamer and plugins etc..
> 
> 
> This rules is just for GigE Camera and not USB3Vision. I haven't tested this feature. The gstreamer is not mandator, it is only for the viewer. I am focused on Embeded system without any kind of display.
> 
> If the gstreamer or libusb3 are availables, meson is able to detect and add them during the configuration process.
> 
> To add as dependencies, forces to build the optionals features.
> 
> What's the best ?

If you don't use an optional dependency, we recommend to disable it explicitly.
Letting an optional dependency auto detected by a package without any handling
in the Buildroot package is a problem for the build reproducibility.

Best regards,
Romain

> 
> 
> 
> Thank you., best regards,
> 
> Marc.
> 
> 
> 
> 
> 
> 
> 
> De : Thomas Petazzoni <thomas.petazzoni@bootlin.com>
> À : Romain Naour <romain.naour@smile.fr>
> Sujet : Re: [Buildroot] package/aravis: new package
> Date : 06/01/2022 10:37:59 Europe/Paris
> Copie à : marc.chalain@mailoo.org;
>    buildroot@buildroot.org;
>    Eric Le Bihan <eric.le.bihan.dev@free.fr>;
>    Marc Chalain <marc.chalain@gmail.com>
> 
> Hello,
> 
> On Thu, 6 Jan 2022 10:24:53 +0100
> Romain Naour <romain.naour@smile.fr> wrote:
> 
>>> diff --git a/package/aravis/Config.in b/package/aravis/Config.in
>>> new file mode 100644
>>> index 0000000000..02c71c44da
>>> --- /dev/null
>>> +++ b/package/aravis/Config.in
>>> @@ -0,0 +1,16 @@
>>> +config BR2_PACKAGE_ARAVIS
>>> +    bool "aravis - GigE Camera"
> 
> Just:
> 
> bool "aravis"
> 
>>> +    depends on BR2_USE_WCHAR
>>> +    depends on BR2_TOOLCHAIN_HAS_THREADS_NPTL
>>> +    depends on BR2_PACKAGE_PCRE_16
>>> +    depends on BR2_PACKAGE_PCRE_32
> 
> Please use "select" for pcre.
> 
>>> +ARAVIS_LICENSE_FILES = COPYING
>>> +ARAVIS_LDFLAGS = $(TARGET_LDFLAGS) $(TARGET_NLS_LIBS) 
>>
>> Is gettext a mandatory dependency ?
>> At least gettext should be in ARAVIS_DEPENDENCIES when NLS support is enabled.
> 
> No, don't add gettext directly, use $(TARGET_NLS_DEPENDENCIES), which
> will automatically add (or not) host-gettext and/or gettext to the
> dependencies, depending on when it's needed or not.
> 
> Thomas
> 

_______________________________________________
buildroot mailing list
buildroot@buildroot.org
https://lists.buildroot.org/mailman/listinfo/buildroot

^ permalink raw reply	[flat|nested] 5+ messages in thread
end of thread, other threads:[~2022-01-08 10:32 UTC | newest]

Thread overview: 5+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2022-01-05 15:57 [Buildroot] package/aravis: new package marc.chalain
2022-01-06  9:24 ` Romain Naour
2022-01-06  9:37   ` Thomas Petazzoni
2022-01-07 20:08     ` marc.chalain
2022-01-08 10:31       ` Romain Naour

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.