All of lore.kernel.org
 help / color / mirror / Atom feed
From: merez@codeaurora.org
To: "Namjae Jeon" <linkinjeon@gmail.com>
Cc: merez@codeaurora.org, "Seungwon Jeon" <tgih.jun@samsung.com>,
	linux-mmc@vger.kernel.org, "Chris Ball" <cjb@laptop.org>,
	linux-kernel@vger.kernel.org
Subject: Re: [PATCH v5 2/2] mmc: core: Support packed command for eMMC4.5  device
Date: Tue, 6 Mar 2012 06:10:12 -0800 (PST)	[thread overview]
Message-ID: <cf2950fbeb4c500534be670cdd8cf85d.squirrel@www.codeaurora.org> (raw)
In-Reply-To: <CAKYAXd8HMrdB9mzgsz5XmMxkDE+gMce+CTEDFU4J67nusNtLOg@mail.gmail.com>

> Hi. Merez.
>
> Thanks a lot about your performance measurement.
>
> I think that your measurement is enough and correct and the firmware
> of mmc vender should be optimized or change properly rather than
> modifying the current patch.
>
> And currently we can use only write packed cmd by my suggestion.
>
> I would like to add my reviewd-by tag in updated patches also.
>
> Reviewed-by: Namjae Jeon <linkinjeon@gmail.com>
>
> Thanks.

I tend to disagree. Adding a massive amount of code that would be disabled
can be risky. In case this code will not be in use it will not be properly
tested and its reliability will be uncertain.

Thanks,
Maya Erez
Consultant for Qualcomm Innovation Center, Inc.
Qualcomm Innovation Center, Inc. is a member of Code Aurora Forum



WARNING: multiple messages have this Message-ID (diff)
From: merez@codeaurora.org
To: Namjae Jeon <linkinjeon@gmail.com>
Cc: merez@codeaurora.org, Seungwon Jeon <tgih.jun@samsung.com>,
	linux-mmc@vger.kernel.org, Chris Ball <cjb@laptop.org>,
	linux-kernel@vger.kernel.org
Subject: Re: [PATCH v5 2/2] mmc: core: Support packed command for eMMC4.5 device
Date: Tue, 6 Mar 2012 06:10:12 -0800 (PST)	[thread overview]
Message-ID: <cf2950fbeb4c500534be670cdd8cf85d.squirrel@www.codeaurora.org> (raw)
In-Reply-To: <CAKYAXd8HMrdB9mzgsz5XmMxkDE+gMce+CTEDFU4J67nusNtLOg@mail.gmail.com>

> Hi. Merez.
>
> Thanks a lot about your performance measurement.
>
> I think that your measurement is enough and correct and the firmware
> of mmc vender should be optimized or change properly rather than
> modifying the current patch.
>
> And currently we can use only write packed cmd by my suggestion.
>
> I would like to add my reviewd-by tag in updated patches also.
>
> Reviewed-by: Namjae Jeon <linkinjeon@gmail.com>
>
> Thanks.

I tend to disagree. Adding a massive amount of code that would be disabled
can be risky. In case this code will not be in use it will not be properly
tested and its reliability will be uncertain.

Thanks,
Maya Erez
Consultant for Qualcomm Innovation Center, Inc.
Qualcomm Innovation Center, Inc. is a member of Code Aurora Forum

  reply	other threads:[~2012-03-06 14:10 UTC|newest]

Thread overview: 24+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2012-02-29 18:10 [PATCH v5 2/2] mmc: core: Support packed command for eMMC4.5 device merez
2012-03-01  7:47 ` Namjae Jeon
2012-03-02 14:26   ` merez
2012-03-02 14:26     ` merez
2012-03-04  8:09     ` Saugata Das
2012-03-05  5:21       ` merez
2012-03-05  5:21         ` merez
2012-03-04  8:25     ` Namjae Jeon
2012-03-06 14:10       ` merez [this message]
2012-03-06 14:10         ` merez
2012-03-07  0:17         ` Seungwon Jeon
2012-03-11 21:36           ` merez
2012-03-11 21:36             ` merez
2012-03-13  0:47             ` Seungwon Jeon
2012-03-17 14:59               ` merez
2012-03-17 14:59                 ` merez
2012-03-01  9:01 ` Saugata Das
2012-03-02  0:09 ` Seungwon Jeon
  -- strict thread matches above, loose matches on Subject: below --
2012-04-26 12:21 merez
2012-04-30  0:31 ` Seungwon Jeon
2012-05-02 18:35   ` merez
2012-05-02 18:35     ` merez
2012-05-08 23:41     ` Seungwon Jeon
2012-02-27 10:20 Seungwon Jeon

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=cf2950fbeb4c500534be670cdd8cf85d.squirrel@www.codeaurora.org \
    --to=merez@codeaurora.org \
    --cc=cjb@laptop.org \
    --cc=linkinjeon@gmail.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-mmc@vger.kernel.org \
    --cc=tgih.jun@samsung.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.