[PATCH 0/4] Clear some dtbs_check warnings detected by snps-dw-apb-uart.yaml

All of lore.kernel.org
 help / color / mirror / Atom feed

* [PATCH 0/4] Clear some dtbs_check warnings detected by snps-dw-apb-uart.yaml
@ 2021-05-19 14:19 ` Zhen Lei
  0 siblings, 0 replies; 16+ messages in thread
From: Zhen Lei @ 2021-05-19 14:19 UTC (permalink / raw)
  To: Manivannan Sadhasivam, Rob Herring, Ray Jui, Scott Branden,
	Andreas Färber, Jisheng Zhang, Sebastian Hesselbarth,
	linux-realtek-soc, bcm-kernel-feedback-list, linux-arm-kernel,
	devicetree
  Cc: Zhen Lei

The Synopsys DesignWare ABP UART is commonly used. Therefore, it is meaningful
to clear the warnings detected by snps-dw-apb-uart.yaml. I fixed everything I
could. The only problem left is that some serial port nodes do not have the
property 'interrupts'. I don't know their interrupt number, so there's no way
to fix it. By the way, is there a scenario where serial ports do not need to be
interrupted? If it exists, property 'interrupts' should not be defined as required.


Zhen Lei (4):
  arm64: dts: bitmain: normalize the node name of the UART devices
  arm64: dts: broadcom: normalize the node name of the UART devices
  arm64: dts: realtek: rtd16xx: normalize the node name of the UART
    devices
  arm64: dts: synaptics: normalize the node name of the UART devices

 arch/arm64/boot/dts/bitmain/bm1880.dtsi             | 6 +++---
 arch/arm64/boot/dts/broadcom/stingray/stingray.dtsi | 8 ++++----
 arch/arm64/boot/dts/realtek/rtd16xx.dtsi            | 6 +++---
 arch/arm64/boot/dts/synaptics/berlin4ct.dtsi        | 2 +-
 4 files changed, 11 insertions(+), 11 deletions(-)

-- 
2.21.1



^ permalink raw reply	[flat|nested] 16+ messages in thread

* [PATCH 0/4] Clear some dtbs_check warnings detected by snps-dw-apb-uart.yaml
@ 2021-05-19 14:19 ` Zhen Lei
  0 siblings, 0 replies; 16+ messages in thread
From: Zhen Lei @ 2021-05-19 14:19 UTC (permalink / raw)
  To: Manivannan Sadhasivam, Rob Herring, Ray Jui, Scott Branden,
	Andreas Färber, Jisheng Zhang, Sebastian Hesselbarth,
	linux-realtek-soc, bcm-kernel-feedback-list, linux-arm-kernel,
	devicetree
  Cc: Zhen Lei

The Synopsys DesignWare ABP UART is commonly used. Therefore, it is meaningful
to clear the warnings detected by snps-dw-apb-uart.yaml. I fixed everything I
could. The only problem left is that some serial port nodes do not have the
property 'interrupts'. I don't know their interrupt number, so there's no way
to fix it. By the way, is there a scenario where serial ports do not need to be
interrupted? If it exists, property 'interrupts' should not be defined as required.


Zhen Lei (4):
  arm64: dts: bitmain: normalize the node name of the UART devices
  arm64: dts: broadcom: normalize the node name of the UART devices
  arm64: dts: realtek: rtd16xx: normalize the node name of the UART
    devices
  arm64: dts: synaptics: normalize the node name of the UART devices

 arch/arm64/boot/dts/bitmain/bm1880.dtsi             | 6 +++---
 arch/arm64/boot/dts/broadcom/stingray/stingray.dtsi | 8 ++++----
 arch/arm64/boot/dts/realtek/rtd16xx.dtsi            | 6 +++---
 arch/arm64/boot/dts/synaptics/berlin4ct.dtsi        | 2 +-
 4 files changed, 11 insertions(+), 11 deletions(-)

-- 
2.21.1



_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel

^ permalink raw reply	[flat|nested] 16+ messages in thread

* [PATCH 1/4] arm64: dts: bitmain: normalize the node name of the UART devices
  2021-05-19 14:19 ` Zhen Lei
@ 2021-05-19 14:19   ` Zhen Lei
  -1 siblings, 0 replies; 16+ messages in thread
From: Zhen Lei @ 2021-05-19 14:19 UTC (permalink / raw)
  To: Manivannan Sadhasivam, Rob Herring, Ray Jui, Scott Branden,
	Andreas Färber, Jisheng Zhang, Sebastian Hesselbarth,
	linux-realtek-soc, bcm-kernel-feedback-list, linux-arm-kernel,
	devicetree
  Cc: Zhen Lei

Change the node name of the UART devices to match
"^serial(@[0-9a-f,]+)*$".

Signed-off-by: Zhen Lei <thunder.leizhen@huawei.com>
---
 arch/arm64/boot/dts/bitmain/bm1880.dtsi | 6 +++---
 1 file changed, 3 insertions(+), 3 deletions(-)

diff --git a/arch/arm64/boot/dts/bitmain/bm1880.dtsi b/arch/arm64/boot/dts/bitmain/bm1880.dtsi
index 53a9b76057aa..22a200fb07d2 100644
--- a/arch/arm64/boot/dts/bitmain/bm1880.dtsi
+++ b/arch/arm64/boot/dts/bitmain/bm1880.dtsi
@@ -184,7 +184,7 @@
 			status = "disabled";
 		};
 
-		uart1: serial@5801A000 {
+		uart1: serial@5801a000 {
 			compatible = "snps,dw-apb-uart";
 			reg = <0x0 0x5801a000 0x0 0x2000>;
 			clocks = <&clk BM1880_CLK_UART_500M>,
@@ -197,7 +197,7 @@
 			status = "disabled";
 		};
 
-		uart2: serial@5801C000 {
+		uart2: serial@5801c000 {
 			compatible = "snps,dw-apb-uart";
 			reg = <0x0 0x5801c000 0x0 0x2000>;
 			clocks = <&clk BM1880_CLK_UART_500M>,
@@ -210,7 +210,7 @@
 			status = "disabled";
 		};
 
-		uart3: serial@5801E000 {
+		uart3: serial@5801e000 {
 			compatible = "snps,dw-apb-uart";
 			reg = <0x0 0x5801e000 0x0 0x2000>;
 			clocks = <&clk BM1880_CLK_UART_500M>,
-- 
2.21.1



^ permalink raw reply related	[flat|nested] 16+ messages in thread

* [PATCH 1/4] arm64: dts: bitmain: normalize the node name of the UART devices
@ 2021-05-19 14:19   ` Zhen Lei
  0 siblings, 0 replies; 16+ messages in thread
From: Zhen Lei @ 2021-05-19 14:19 UTC (permalink / raw)
  To: Manivannan Sadhasivam, Rob Herring, Ray Jui, Scott Branden,
	Andreas Färber, Jisheng Zhang, Sebastian Hesselbarth,
	linux-realtek-soc, bcm-kernel-feedback-list, linux-arm-kernel,
	devicetree
  Cc: Zhen Lei

Change the node name of the UART devices to match
"^serial(@[0-9a-f,]+)*$".

Signed-off-by: Zhen Lei <thunder.leizhen@huawei.com>
---
 arch/arm64/boot/dts/bitmain/bm1880.dtsi | 6 +++---
 1 file changed, 3 insertions(+), 3 deletions(-)

diff --git a/arch/arm64/boot/dts/bitmain/bm1880.dtsi b/arch/arm64/boot/dts/bitmain/bm1880.dtsi
index 53a9b76057aa..22a200fb07d2 100644
--- a/arch/arm64/boot/dts/bitmain/bm1880.dtsi
+++ b/arch/arm64/boot/dts/bitmain/bm1880.dtsi
@@ -184,7 +184,7 @@
 			status = "disabled";
 		};
 
-		uart1: serial@5801A000 {
+		uart1: serial@5801a000 {
 			compatible = "snps,dw-apb-uart";
 			reg = <0x0 0x5801a000 0x0 0x2000>;
 			clocks = <&clk BM1880_CLK_UART_500M>,
@@ -197,7 +197,7 @@
 			status = "disabled";
 		};
 
-		uart2: serial@5801C000 {
+		uart2: serial@5801c000 {
 			compatible = "snps,dw-apb-uart";
 			reg = <0x0 0x5801c000 0x0 0x2000>;
 			clocks = <&clk BM1880_CLK_UART_500M>,
@@ -210,7 +210,7 @@
 			status = "disabled";
 		};
 
-		uart3: serial@5801E000 {
+		uart3: serial@5801e000 {
 			compatible = "snps,dw-apb-uart";
 			reg = <0x0 0x5801e000 0x0 0x2000>;
 			clocks = <&clk BM1880_CLK_UART_500M>,
-- 
2.21.1



_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel

^ permalink raw reply related	[flat|nested] 16+ messages in thread

* [PATCH 2/4] arm64: dts: broadcom: normalize the node name of the UART devices
  2021-05-19 14:19 ` Zhen Lei
@ 2021-05-19 14:19   ` Zhen Lei
  -1 siblings, 0 replies; 16+ messages in thread
From: Zhen Lei @ 2021-05-19 14:19 UTC (permalink / raw)
  To: Manivannan Sadhasivam, Rob Herring, Ray Jui, Scott Branden,
	Andreas Färber, Jisheng Zhang, Sebastian Hesselbarth,
	linux-realtek-soc, bcm-kernel-feedback-list, linux-arm-kernel,
	devicetree
  Cc: Zhen Lei

Change the node name of the UART devices to match
"^serial(@[0-9a-f,]+)*$".

Signed-off-by: Zhen Lei <thunder.leizhen@huawei.com>
---
 arch/arm64/boot/dts/broadcom/stingray/stingray.dtsi | 8 ++++----
 1 file changed, 4 insertions(+), 4 deletions(-)

diff --git a/arch/arm64/boot/dts/broadcom/stingray/stingray.dtsi b/arch/arm64/boot/dts/broadcom/stingray/stingray.dtsi
index 2ffb2c92182a..7b04dfe67bef 100644
--- a/arch/arm64/boot/dts/broadcom/stingray/stingray.dtsi
+++ b/arch/arm64/boot/dts/broadcom/stingray/stingray.dtsi
@@ -470,7 +470,7 @@
 			status = "disabled";
 		};
 
-		uart0: uart@100000 {
+		uart0: serial@100000 {
 			device_type = "serial";
 			compatible = "snps,dw-apb-uart";
 			reg = <0x00100000 0x1000>;
@@ -481,7 +481,7 @@
 			status = "disabled";
 		};
 
-		uart1: uart@110000 {
+		uart1: serial@110000 {
 			device_type = "serial";
 			compatible = "snps,dw-apb-uart";
 			reg = <0x00110000 0x1000>;
@@ -492,7 +492,7 @@
 			status = "disabled";
 		};
 
-		uart2: uart@120000 {
+		uart2: serial@120000 {
 			device_type = "serial";
 			compatible = "snps,dw-apb-uart";
 			reg = <0x00120000 0x1000>;
@@ -503,7 +503,7 @@
 			status = "disabled";
 		};
 
-		uart3: uart@130000 {
+		uart3: serial@130000 {
 			device_type = "serial";
 			compatible = "snps,dw-apb-uart";
 			reg = <0x00130000 0x1000>;
-- 
2.21.1



^ permalink raw reply related	[flat|nested] 16+ messages in thread

* [PATCH 2/4] arm64: dts: broadcom: normalize the node name of the UART devices
@ 2021-05-19 14:19   ` Zhen Lei
  0 siblings, 0 replies; 16+ messages in thread
From: Zhen Lei @ 2021-05-19 14:19 UTC (permalink / raw)
  To: Manivannan Sadhasivam, Rob Herring, Ray Jui, Scott Branden,
	Andreas Färber, Jisheng Zhang, Sebastian Hesselbarth,
	linux-realtek-soc, bcm-kernel-feedback-list, linux-arm-kernel,
	devicetree
  Cc: Zhen Lei

Change the node name of the UART devices to match
"^serial(@[0-9a-f,]+)*$".

Signed-off-by: Zhen Lei <thunder.leizhen@huawei.com>
---
 arch/arm64/boot/dts/broadcom/stingray/stingray.dtsi | 8 ++++----
 1 file changed, 4 insertions(+), 4 deletions(-)

diff --git a/arch/arm64/boot/dts/broadcom/stingray/stingray.dtsi b/arch/arm64/boot/dts/broadcom/stingray/stingray.dtsi
index 2ffb2c92182a..7b04dfe67bef 100644
--- a/arch/arm64/boot/dts/broadcom/stingray/stingray.dtsi
+++ b/arch/arm64/boot/dts/broadcom/stingray/stingray.dtsi
@@ -470,7 +470,7 @@
 			status = "disabled";
 		};
 
-		uart0: uart@100000 {
+		uart0: serial@100000 {
 			device_type = "serial";
 			compatible = "snps,dw-apb-uart";
 			reg = <0x00100000 0x1000>;
@@ -481,7 +481,7 @@
 			status = "disabled";
 		};
 
-		uart1: uart@110000 {
+		uart1: serial@110000 {
 			device_type = "serial";
 			compatible = "snps,dw-apb-uart";
 			reg = <0x00110000 0x1000>;
@@ -492,7 +492,7 @@
 			status = "disabled";
 		};
 
-		uart2: uart@120000 {
+		uart2: serial@120000 {
 			device_type = "serial";
 			compatible = "snps,dw-apb-uart";
 			reg = <0x00120000 0x1000>;
@@ -503,7 +503,7 @@
 			status = "disabled";
 		};
 
-		uart3: uart@130000 {
+		uart3: serial@130000 {
 			device_type = "serial";
 			compatible = "snps,dw-apb-uart";
 			reg = <0x00130000 0x1000>;
-- 
2.21.1



_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel

^ permalink raw reply related	[flat|nested] 16+ messages in thread

* Re: [PATCH 2/4] arm64: dts: broadcom: normalize the node name of the UART devices
  2021-05-19 14:19   ` Zhen Lei
@ 2021-05-20 18:45     ` Florian Fainelli
  -1 siblings, 0 replies; 16+ messages in thread
From: Florian Fainelli @ 2021-05-20 18:45 UTC (permalink / raw)
  To: bcm-kernel-feedback-list, Zhen Lei, Manivannan Sadhasivam,
	Rob Herring, Ray Jui, Scott Branden, Andreas Färber,
	Jisheng Zhang, Sebastian Hesselbarth, linux-realtek-soc,
	linux-arm-kernel, devicetree

On Wed, 19 May 2021 22:19:12 +0800, Zhen Lei <thunder.leizhen@huawei.com> wrote:
> Change the node name of the UART devices to match
> "^serial(@[0-9a-f,]+)*$".
> 
> Signed-off-by: Zhen Lei <thunder.leizhen@huawei.com>
> ---

Applied to devicetree-arm64/next, thanks!
--
Florian

^ permalink raw reply	[flat|nested] 16+ messages in thread

* Re: [PATCH 2/4] arm64: dts: broadcom: normalize the node name of the UART devices
@ 2021-05-20 18:45     ` Florian Fainelli
  0 siblings, 0 replies; 16+ messages in thread
From: Florian Fainelli @ 2021-05-20 18:45 UTC (permalink / raw)
  To: bcm-kernel-feedback-list, Zhen Lei, Manivannan Sadhasivam,
	Rob Herring, Ray Jui, Scott Branden, Andreas Färber,
	Jisheng Zhang, Sebastian Hesselbarth, linux-realtek-soc,
	linux-arm-kernel, devicetree

On Wed, 19 May 2021 22:19:12 +0800, Zhen Lei <thunder.leizhen@huawei.com> wrote:
> Change the node name of the UART devices to match
> "^serial(@[0-9a-f,]+)*$".
> 
> Signed-off-by: Zhen Lei <thunder.leizhen@huawei.com>
> ---

Applied to devicetree-arm64/next, thanks!
--
Florian

_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel

^ permalink raw reply	[flat|nested] 16+ messages in thread

* [PATCH 3/4] arm64: dts: realtek: rtd16xx: normalize the node name of the UART devices
  2021-05-19 14:19 ` Zhen Lei
@ 2021-05-19 14:19   ` Zhen Lei
  -1 siblings, 0 replies; 16+ messages in thread
From: Zhen Lei @ 2021-05-19 14:19 UTC (permalink / raw)
  To: Manivannan Sadhasivam, Rob Herring, Ray Jui, Scott Branden,
	Andreas Färber, Jisheng Zhang, Sebastian Hesselbarth,
	linux-realtek-soc, bcm-kernel-feedback-list, linux-arm-kernel,
	devicetree
  Cc: Zhen Lei

Change the node name of the UART devices to match
"^serial(@[0-9a-f,]+)*$".

Signed-off-by: Zhen Lei <thunder.leizhen@huawei.com>
---
 arch/arm64/boot/dts/realtek/rtd16xx.dtsi | 6 +++---
 1 file changed, 3 insertions(+), 3 deletions(-)

diff --git a/arch/arm64/boot/dts/realtek/rtd16xx.dtsi b/arch/arm64/boot/dts/realtek/rtd16xx.dtsi
index afba5f04c8ec..bf4d9e917925 100644
--- a/arch/arm64/boot/dts/realtek/rtd16xx.dtsi
+++ b/arch/arm64/boot/dts/realtek/rtd16xx.dtsi
@@ -195,7 +195,7 @@
 };
 
 &iso {
-	uart0: serial0@800 {
+	uart0: serial@800 {
 		compatible = "snps,dw-apb-uart";
 		reg = <0x800 0x400>;
 		reg-shift = <2>;
@@ -207,7 +207,7 @@
 };
 
 &misc {
-	uart1: serial1@200 {
+	uart1: serial@200 {
 		compatible = "snps,dw-apb-uart";
 		reg = <0x200 0x400>;
 		reg-shift = <2>;
@@ -217,7 +217,7 @@
 		status = "disabled";
 	};
 
-	uart2: serial2@400 {
+	uart2: serial@400 {
 		compatible = "snps,dw-apb-uart";
 		reg = <0x400 0x400>;
 		reg-shift = <2>;
-- 
2.21.1



^ permalink raw reply related	[flat|nested] 16+ messages in thread

* [PATCH 3/4] arm64: dts: realtek: rtd16xx: normalize the node name of the UART devices
@ 2021-05-19 14:19   ` Zhen Lei
  0 siblings, 0 replies; 16+ messages in thread
From: Zhen Lei @ 2021-05-19 14:19 UTC (permalink / raw)
  To: Manivannan Sadhasivam, Rob Herring, Ray Jui, Scott Branden,
	Andreas Färber, Jisheng Zhang, Sebastian Hesselbarth,
	linux-realtek-soc, bcm-kernel-feedback-list, linux-arm-kernel,
	devicetree
  Cc: Zhen Lei

Change the node name of the UART devices to match
"^serial(@[0-9a-f,]+)*$".

Signed-off-by: Zhen Lei <thunder.leizhen@huawei.com>
---
 arch/arm64/boot/dts/realtek/rtd16xx.dtsi | 6 +++---
 1 file changed, 3 insertions(+), 3 deletions(-)

diff --git a/arch/arm64/boot/dts/realtek/rtd16xx.dtsi b/arch/arm64/boot/dts/realtek/rtd16xx.dtsi
index afba5f04c8ec..bf4d9e917925 100644
--- a/arch/arm64/boot/dts/realtek/rtd16xx.dtsi
+++ b/arch/arm64/boot/dts/realtek/rtd16xx.dtsi
@@ -195,7 +195,7 @@
 };
 
 &iso {
-	uart0: serial0@800 {
+	uart0: serial@800 {
 		compatible = "snps,dw-apb-uart";
 		reg = <0x800 0x400>;
 		reg-shift = <2>;
@@ -207,7 +207,7 @@
 };
 
 &misc {
-	uart1: serial1@200 {
+	uart1: serial@200 {
 		compatible = "snps,dw-apb-uart";
 		reg = <0x200 0x400>;
 		reg-shift = <2>;
@@ -217,7 +217,7 @@
 		status = "disabled";
 	};
 
-	uart2: serial2@400 {
+	uart2: serial@400 {
 		compatible = "snps,dw-apb-uart";
 		reg = <0x400 0x400>;
 		reg-shift = <2>;
-- 
2.21.1



_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel

^ permalink raw reply related	[flat|nested] 16+ messages in thread

* Re: [PATCH 3/4] arm64: dts: realtek: rtd16xx: normalize the node name of the UART devices
  2021-05-19 14:19   ` Zhen Lei
@ 2021-05-19 14:31     ` Andreas Färber
  -1 siblings, 0 replies; 16+ messages in thread
From: Andreas Färber @ 2021-05-19 14:31 UTC (permalink / raw)
  To: Zhen Lei
  Cc: Manivannan Sadhasivam, Rob Herring, Ray Jui, Scott Branden,
	Jisheng Zhang, Sebastian Hesselbarth, linux-realtek-soc,
	bcm-kernel-feedback-list, linux-arm-kernel, devicetree

Hi,

On 19.05.21 16:19, Zhen Lei wrote:
> Change the node name of the UART devices to match
> "^serial(@[0-9a-f,]+)*$".
> 
> Signed-off-by: Zhen Lei <thunder.leizhen@huawei.com>
> ---
>  arch/arm64/boot/dts/realtek/rtd16xx.dtsi | 6 +++---
>  1 file changed, 3 insertions(+), 3 deletions(-)
> 
> diff --git a/arch/arm64/boot/dts/realtek/rtd16xx.dtsi b/arch/arm64/boot/dts/realtek/rtd16xx.dtsi
> index afba5f04c8ec..bf4d9e917925 100644
> --- a/arch/arm64/boot/dts/realtek/rtd16xx.dtsi
> +++ b/arch/arm64/boot/dts/realtek/rtd16xx.dtsi
> @@ -195,7 +195,7 @@
>  };
>  
>  &iso {
> -	uart0: serial0@800 {
> +	uart0: serial@800 {
[snip]

Ouch, shame on me for not catching this in review...

Reviewed-by: Andreas Färber <afaerber@suse.de>

Are you expecting this to go through the four maintainer trees or
centrally somehow?

Thanks,
Andreas

-- 
SUSE Software Solutions Germany GmbH
Maxfeldstr. 5, 90409 Nürnberg, Germany
GF: Felix Imendörffer
HRB 36809 (AG Nürnberg)

^ permalink raw reply	[flat|nested] 16+ messages in thread

* Re: [PATCH 3/4] arm64: dts: realtek: rtd16xx: normalize the node name of the UART devices
@ 2021-05-19 14:31     ` Andreas Färber
  0 siblings, 0 replies; 16+ messages in thread
From: Andreas Färber @ 2021-05-19 14:31 UTC (permalink / raw)
  To: Zhen Lei
  Cc: Manivannan Sadhasivam, Rob Herring, Ray Jui, Scott Branden,
	Jisheng Zhang, Sebastian Hesselbarth, linux-realtek-soc,
	bcm-kernel-feedback-list, linux-arm-kernel, devicetree

Hi,

On 19.05.21 16:19, Zhen Lei wrote:
> Change the node name of the UART devices to match
> "^serial(@[0-9a-f,]+)*$".
> 
> Signed-off-by: Zhen Lei <thunder.leizhen@huawei.com>
> ---
>  arch/arm64/boot/dts/realtek/rtd16xx.dtsi | 6 +++---
>  1 file changed, 3 insertions(+), 3 deletions(-)
> 
> diff --git a/arch/arm64/boot/dts/realtek/rtd16xx.dtsi b/arch/arm64/boot/dts/realtek/rtd16xx.dtsi
> index afba5f04c8ec..bf4d9e917925 100644
> --- a/arch/arm64/boot/dts/realtek/rtd16xx.dtsi
> +++ b/arch/arm64/boot/dts/realtek/rtd16xx.dtsi
> @@ -195,7 +195,7 @@
>  };
>  
>  &iso {
> -	uart0: serial0@800 {
> +	uart0: serial@800 {
[snip]

Ouch, shame on me for not catching this in review...

Reviewed-by: Andreas Färber <afaerber@suse.de>

Are you expecting this to go through the four maintainer trees or
centrally somehow?

Thanks,
Andreas

-- 
SUSE Software Solutions Germany GmbH
Maxfeldstr. 5, 90409 Nürnberg, Germany
GF: Felix Imendörffer
HRB 36809 (AG Nürnberg)

_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel

^ permalink raw reply	[flat|nested] 16+ messages in thread

* Re: [PATCH 3/4] arm64: dts: realtek: rtd16xx: normalize the node name of the UART devices
  2021-05-19 14:31     ` Andreas Färber
@ 2021-05-19 14:46       ` Leizhen (ThunderTown)
  -1 siblings, 0 replies; 16+ messages in thread
From: Leizhen (ThunderTown) @ 2021-05-19 14:46 UTC (permalink / raw)
  To: Andreas Färber
  Cc: Manivannan Sadhasivam, Rob Herring, Ray Jui, Scott Branden,
	Jisheng Zhang, Sebastian Hesselbarth, linux-realtek-soc,
	bcm-kernel-feedback-list, linux-arm-kernel, devicetree



On 2021/5/19 22:31, Andreas Färber wrote:
> Hi,
> 
> On 19.05.21 16:19, Zhen Lei wrote:
>> Change the node name of the UART devices to match
>> "^serial(@[0-9a-f,]+)*$".
>>
>> Signed-off-by: Zhen Lei <thunder.leizhen@huawei.com>
>> ---
>>  arch/arm64/boot/dts/realtek/rtd16xx.dtsi | 6 +++---
>>  1 file changed, 3 insertions(+), 3 deletions(-)
>>
>> diff --git a/arch/arm64/boot/dts/realtek/rtd16xx.dtsi b/arch/arm64/boot/dts/realtek/rtd16xx.dtsi
>> index afba5f04c8ec..bf4d9e917925 100644
>> --- a/arch/arm64/boot/dts/realtek/rtd16xx.dtsi
>> +++ b/arch/arm64/boot/dts/realtek/rtd16xx.dtsi
>> @@ -195,7 +195,7 @@
>>  };
>>  
>>  &iso {
>> -	uart0: serial0@800 {
>> +	uart0: serial@800 {
> [snip]
> 
> Ouch, shame on me for not catching this in review...
> 
> Reviewed-by: Andreas Färber <afaerber@suse.de>
> 
> Are you expecting this to go through the four maintainer trees or
> centrally somehow?

It would be nice for each maintainer to add its own patch to its own tree.
Each patch is independent, I put these four patches together just for the
convenience of describing 0000-cover-letter

> 
> Thanks,
> Andreas
> 


^ permalink raw reply	[flat|nested] 16+ messages in thread

* Re: [PATCH 3/4] arm64: dts: realtek: rtd16xx: normalize the node name of the UART devices
@ 2021-05-19 14:46       ` Leizhen (ThunderTown)
  0 siblings, 0 replies; 16+ messages in thread
From: Leizhen (ThunderTown) @ 2021-05-19 14:46 UTC (permalink / raw)
  To: Andreas Färber
  Cc: Manivannan Sadhasivam, Rob Herring, Ray Jui, Scott Branden,
	Jisheng Zhang, Sebastian Hesselbarth, linux-realtek-soc,
	bcm-kernel-feedback-list, linux-arm-kernel, devicetree



On 2021/5/19 22:31, Andreas Färber wrote:
> Hi,
> 
> On 19.05.21 16:19, Zhen Lei wrote:
>> Change the node name of the UART devices to match
>> "^serial(@[0-9a-f,]+)*$".
>>
>> Signed-off-by: Zhen Lei <thunder.leizhen@huawei.com>
>> ---
>>  arch/arm64/boot/dts/realtek/rtd16xx.dtsi | 6 +++---
>>  1 file changed, 3 insertions(+), 3 deletions(-)
>>
>> diff --git a/arch/arm64/boot/dts/realtek/rtd16xx.dtsi b/arch/arm64/boot/dts/realtek/rtd16xx.dtsi
>> index afba5f04c8ec..bf4d9e917925 100644
>> --- a/arch/arm64/boot/dts/realtek/rtd16xx.dtsi
>> +++ b/arch/arm64/boot/dts/realtek/rtd16xx.dtsi
>> @@ -195,7 +195,7 @@
>>  };
>>  
>>  &iso {
>> -	uart0: serial0@800 {
>> +	uart0: serial@800 {
> [snip]
> 
> Ouch, shame on me for not catching this in review...
> 
> Reviewed-by: Andreas Färber <afaerber@suse.de>
> 
> Are you expecting this to go through the four maintainer trees or
> centrally somehow?

It would be nice for each maintainer to add its own patch to its own tree.
Each patch is independent, I put these four patches together just for the
convenience of describing 0000-cover-letter

> 
> Thanks,
> Andreas
> 


_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel

^ permalink raw reply	[flat|nested] 16+ messages in thread

* [PATCH 4/4] arm64: dts: synaptics: normalize the node name of the UART devices
  2021-05-19 14:19 ` Zhen Lei
@ 2021-05-19 14:19   ` Zhen Lei
  -1 siblings, 0 replies; 16+ messages in thread
From: Zhen Lei @ 2021-05-19 14:19 UTC (permalink / raw)
  To: Manivannan Sadhasivam, Rob Herring, Ray Jui, Scott Branden,
	Andreas Färber, Jisheng Zhang, Sebastian Hesselbarth,
	linux-realtek-soc, bcm-kernel-feedback-list, linux-arm-kernel,
	devicetree
  Cc: Zhen Lei

Change the node name of the UART devices to match
"^serial(@[0-9a-f,]+)*$".

Signed-off-by: Zhen Lei <thunder.leizhen@huawei.com>
---
 arch/arm64/boot/dts/synaptics/berlin4ct.dtsi | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/arch/arm64/boot/dts/synaptics/berlin4ct.dtsi b/arch/arm64/boot/dts/synaptics/berlin4ct.dtsi
index 0949acee4728..dc12350b9fc8 100644
--- a/arch/arm64/boot/dts/synaptics/berlin4ct.dtsi
+++ b/arch/arm64/boot/dts/synaptics/berlin4ct.dtsi
@@ -289,7 +289,7 @@
 				};
 			};
 
-			uart0: uart@d000 {
+			uart0: serial@d000 {
 				compatible = "snps,dw-apb-uart";
 				reg = <0xd000 0x100>;
 				interrupts = <8>;
-- 
2.21.1



^ permalink raw reply related	[flat|nested] 16+ messages in thread

* [PATCH 4/4] arm64: dts: synaptics: normalize the node name of the UART devices
@ 2021-05-19 14:19   ` Zhen Lei
  0 siblings, 0 replies; 16+ messages in thread
From: Zhen Lei @ 2021-05-19 14:19 UTC (permalink / raw)
  To: Manivannan Sadhasivam, Rob Herring, Ray Jui, Scott Branden,
	Andreas Färber, Jisheng Zhang, Sebastian Hesselbarth,
	linux-realtek-soc, bcm-kernel-feedback-list, linux-arm-kernel,
	devicetree
  Cc: Zhen Lei

Change the node name of the UART devices to match
"^serial(@[0-9a-f,]+)*$".

Signed-off-by: Zhen Lei <thunder.leizhen@huawei.com>
---
 arch/arm64/boot/dts/synaptics/berlin4ct.dtsi | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/arch/arm64/boot/dts/synaptics/berlin4ct.dtsi b/arch/arm64/boot/dts/synaptics/berlin4ct.dtsi
index 0949acee4728..dc12350b9fc8 100644
--- a/arch/arm64/boot/dts/synaptics/berlin4ct.dtsi
+++ b/arch/arm64/boot/dts/synaptics/berlin4ct.dtsi
@@ -289,7 +289,7 @@
 				};
 			};
 
-			uart0: uart@d000 {
+			uart0: serial@d000 {
 				compatible = "snps,dw-apb-uart";
 				reg = <0xd000 0x100>;
 				interrupts = <8>;
-- 
2.21.1



_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel

^ permalink raw reply related	[flat|nested] 16+ messages in thread

end of thread, other threads:[~2021-05-20 18:47 UTC | newest]

Thread overview: 16+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2021-05-19 14:19 [PATCH 0/4] Clear some dtbs_check warnings detected by snps-dw-apb-uart.yaml Zhen Lei
2021-05-19 14:19 ` Zhen Lei
2021-05-19 14:19 ` [PATCH 1/4] arm64: dts: bitmain: normalize the node name of the UART devices Zhen Lei
2021-05-19 14:19   ` Zhen Lei
2021-05-19 14:19 ` [PATCH 2/4] arm64: dts: broadcom: " Zhen Lei
2021-05-19 14:19   ` Zhen Lei
2021-05-20 18:45   ` Florian Fainelli
2021-05-20 18:45     ` Florian Fainelli
2021-05-19 14:19 ` [PATCH 3/4] arm64: dts: realtek: rtd16xx: " Zhen Lei
2021-05-19 14:19   ` Zhen Lei
2021-05-19 14:31   ` Andreas Färber
2021-05-19 14:31     ` Andreas Färber
2021-05-19 14:46     ` Leizhen (ThunderTown)
2021-05-19 14:46       ` Leizhen (ThunderTown)
2021-05-19 14:19 ` [PATCH 4/4] arm64: dts: synaptics: " Zhen Lei
2021-05-19 14:19   ` Zhen Lei

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.