From: Vlastimil Babka <vbabka@suse.cz> To: Michal Hocko <mhocko@kernel.org> Cc: linux-mm@kvack.org, Andrew Morton <akpm@linux-foundation.org>, Mel Gorman <mgorman@suse.de>, Johannes Weiner <hannes@cmpxchg.org>, Rik van Riel <riel@redhat.com>, LKML <linux-kernel@vger.kernel.org> Subject: Re: [PATCH 4/7] mm, vmscan: show LRU name in mm_vmscan_lru_isolate tracepoint Date: Tue, 3 Jan 2017 22:40:23 +0100 [thread overview] Message-ID: <cfc85361-5bd0-7614-e1d6-1a71e0421571@suse.cz> (raw) In-Reply-To: <20170103212411.GA17822@dhcp22.suse.cz> On 01/03/2017 10:24 PM, Michal Hocko wrote: > On Tue 03-01-17 21:52:44, Michal Hocko wrote: >> On Tue 03-01-17 21:47:45, Michal Hocko wrote: >> > On Tue 03-01-17 18:08:58, Vlastimil Babka wrote: >> > > On 12/28/2016 04:30 PM, Michal Hocko wrote: >> > > > From: Michal Hocko <mhocko@suse.com> >> > > > >> > > > mm_vmscan_lru_isolate currently prints only whether the LRU we isolate >> > > > from is file or anonymous but we do not know which LRU this is. It is >> > > > useful to know whether the list is file or anonymous as well. Change >> > > > the tracepoint to show symbolic names of the lru rather. >> > > > >> > > > Signed-off-by: Michal Hocko <mhocko@suse.com> >> > > > --- >> > > > include/trace/events/vmscan.h | 20 ++++++++++++++------ >> > > > mm/vmscan.c | 2 +- >> > > > 2 files changed, 15 insertions(+), 7 deletions(-) >> > > > >> > > > diff --git a/include/trace/events/vmscan.h b/include/trace/events/vmscan.h >> > > > index 6af4dae46db2..cc0b4c456c78 100644 >> > > > --- a/include/trace/events/vmscan.h >> > > > +++ b/include/trace/events/vmscan.h >> > > > @@ -36,6 +36,14 @@ >> > > > (RECLAIM_WB_ASYNC) \ >> > > > ) >> > > > >> > > > +#define show_lru_name(lru) \ >> > > > + __print_symbolic(lru, \ >> > > > + {LRU_INACTIVE_ANON, "LRU_INACTIVE_ANON"}, \ >> > > > + {LRU_ACTIVE_ANON, "LRU_ACTIVE_ANON"}, \ >> > > > + {LRU_INACTIVE_FILE, "LRU_INACTIVE_FILE"}, \ >> > > > + {LRU_ACTIVE_FILE, "LRU_ACTIVE_FILE"}, \ >> > > > + {LRU_UNEVICTABLE, "LRU_UNEVICTABLE"}) >> > > > + >> > > >> > > Does this work with external tools such as trace-cmd, i.e. does it export >> > > the correct format file? >> > >> > How do I find out? You did :) Another way to verify is to use trace-cmd tool instead of manual sysfs operations and see if the output looks as expected. The tool gets the raw records from kernel and does the printing in userspace, unlike "cat trace_pipe". >> Well, I've just checked the format file and it says >> print fmt: "isolate_mode=%d classzone=%d order=%d nr_requested=%lu nr_scanned=%lu nr_skipped=%lu nr_taken=%lu lru=%s", REC->isolate_mode, REC->classzone_idx, REC->order, REC->nr_requested, REC->nr_scanned, REC->nr_skipped, REC->nr_taken, __print_symbolic(REC->lru, {LRU_INACTIVE_ANON, "LRU_INACTIVE_ANON"}, {LRU_ACTIVE_ANON, "LRU_ACTIVE_ANON"}, {LRU_INACTIVE_FILE, "LRU_INACTIVE_FILE"}, {LRU_ACTIVE_FILE, "LRU_ACTIVE_FILE"}, {LRU_UNEVICTABLE, "LRU_UNEVICTABLE"}) >> >> So the tool should be OK as long as it can find values for LRU_* >> constants. Is this what is the problem? Exactly. > OK, I got it. We need enum->value translation and all the EM stuff to do > that, right? Yep. > I will rework the patch and move the definition to the rest of the EM > family... Thanks!
WARNING: multiple messages have this Message-ID (diff)
From: Vlastimil Babka <vbabka@suse.cz> To: Michal Hocko <mhocko@kernel.org> Cc: linux-mm@kvack.org, Andrew Morton <akpm@linux-foundation.org>, Mel Gorman <mgorman@suse.de>, Johannes Weiner <hannes@cmpxchg.org>, Rik van Riel <riel@redhat.com>, LKML <linux-kernel@vger.kernel.org> Subject: Re: [PATCH 4/7] mm, vmscan: show LRU name in mm_vmscan_lru_isolate tracepoint Date: Tue, 3 Jan 2017 22:40:23 +0100 [thread overview] Message-ID: <cfc85361-5bd0-7614-e1d6-1a71e0421571@suse.cz> (raw) In-Reply-To: <20170103212411.GA17822@dhcp22.suse.cz> On 01/03/2017 10:24 PM, Michal Hocko wrote: > On Tue 03-01-17 21:52:44, Michal Hocko wrote: >> On Tue 03-01-17 21:47:45, Michal Hocko wrote: >> > On Tue 03-01-17 18:08:58, Vlastimil Babka wrote: >> > > On 12/28/2016 04:30 PM, Michal Hocko wrote: >> > > > From: Michal Hocko <mhocko@suse.com> >> > > > >> > > > mm_vmscan_lru_isolate currently prints only whether the LRU we isolate >> > > > from is file or anonymous but we do not know which LRU this is. It is >> > > > useful to know whether the list is file or anonymous as well. Change >> > > > the tracepoint to show symbolic names of the lru rather. >> > > > >> > > > Signed-off-by: Michal Hocko <mhocko@suse.com> >> > > > --- >> > > > include/trace/events/vmscan.h | 20 ++++++++++++++------ >> > > > mm/vmscan.c | 2 +- >> > > > 2 files changed, 15 insertions(+), 7 deletions(-) >> > > > >> > > > diff --git a/include/trace/events/vmscan.h b/include/trace/events/vmscan.h >> > > > index 6af4dae46db2..cc0b4c456c78 100644 >> > > > --- a/include/trace/events/vmscan.h >> > > > +++ b/include/trace/events/vmscan.h >> > > > @@ -36,6 +36,14 @@ >> > > > (RECLAIM_WB_ASYNC) \ >> > > > ) >> > > > >> > > > +#define show_lru_name(lru) \ >> > > > + __print_symbolic(lru, \ >> > > > + {LRU_INACTIVE_ANON, "LRU_INACTIVE_ANON"}, \ >> > > > + {LRU_ACTIVE_ANON, "LRU_ACTIVE_ANON"}, \ >> > > > + {LRU_INACTIVE_FILE, "LRU_INACTIVE_FILE"}, \ >> > > > + {LRU_ACTIVE_FILE, "LRU_ACTIVE_FILE"}, \ >> > > > + {LRU_UNEVICTABLE, "LRU_UNEVICTABLE"}) >> > > > + >> > > >> > > Does this work with external tools such as trace-cmd, i.e. does it export >> > > the correct format file? >> > >> > How do I find out? You did :) Another way to verify is to use trace-cmd tool instead of manual sysfs operations and see if the output looks as expected. The tool gets the raw records from kernel and does the printing in userspace, unlike "cat trace_pipe". >> Well, I've just checked the format file and it says >> print fmt: "isolate_mode=%d classzone=%d order=%d nr_requested=%lu nr_scanned=%lu nr_skipped=%lu nr_taken=%lu lru=%s", REC->isolate_mode, REC->classzone_idx, REC->order, REC->nr_requested, REC->nr_scanned, REC->nr_skipped, REC->nr_taken, __print_symbolic(REC->lru, {LRU_INACTIVE_ANON, "LRU_INACTIVE_ANON"}, {LRU_ACTIVE_ANON, "LRU_ACTIVE_ANON"}, {LRU_INACTIVE_FILE, "LRU_INACTIVE_FILE"}, {LRU_ACTIVE_FILE, "LRU_ACTIVE_FILE"}, {LRU_UNEVICTABLE, "LRU_UNEVICTABLE"}) >> >> So the tool should be OK as long as it can find values for LRU_* >> constants. Is this what is the problem? Exactly. > OK, I got it. We need enum->value translation and all the EM stuff to do > that, right? Yep. > I will rework the patch and move the definition to the rest of the EM > family... Thanks! -- To unsubscribe, send a message with 'unsubscribe linux-mm' in the body to majordomo@kvack.org. For more info on Linux MM, see: http://www.linux-mm.org/ . Don't email: <a href=mailto:"dont@kvack.org"> email@kvack.org </a>
next prev parent reply other threads:[~2017-01-03 21:40 UTC|newest] Thread overview: 106+ messages / expand[flat|nested] mbox.gz Atom feed top 2016-12-28 15:30 [PATCH 0/7] vm, vmscan: enahance vmscan tracepoints Michal Hocko 2016-12-28 15:30 ` Michal Hocko 2016-12-28 15:30 ` [PATCH 1/7] mm, vmscan: remove unused mm_vmscan_memcg_isolate Michal Hocko 2016-12-28 15:30 ` Michal Hocko 2016-12-29 7:33 ` Hillf Danton 2016-12-29 7:33 ` Hillf Danton 2016-12-28 15:30 ` [PATCH 2/7] mm, vmscan: add active list aging tracepoint Michal Hocko 2016-12-28 15:30 ` Michal Hocko 2016-12-29 5:33 ` Minchan Kim 2016-12-29 5:33 ` Minchan Kim 2016-12-29 7:52 ` Michal Hocko 2016-12-29 7:52 ` Michal Hocko 2016-12-30 1:48 ` Minchan Kim 2016-12-30 1:48 ` Minchan Kim 2016-12-30 9:26 ` Michal Hocko 2016-12-30 9:26 ` Michal Hocko 2016-12-30 9:38 ` Hillf Danton 2016-12-30 9:38 ` Hillf Danton 2016-12-30 16:04 ` Minchan Kim 2016-12-30 16:04 ` Minchan Kim 2016-12-30 16:37 ` Michal Hocko 2016-12-30 16:37 ` Michal Hocko 2016-12-30 17:30 ` Michal Hocko 2016-12-30 17:30 ` Michal Hocko 2017-01-03 5:03 ` Minchan Kim 2017-01-03 5:03 ` Minchan Kim 2017-01-03 8:21 ` Michal Hocko 2017-01-03 8:21 ` Michal Hocko 2017-01-04 5:07 ` Minchan Kim 2017-01-04 5:07 ` Minchan Kim 2017-01-04 7:28 ` Vlastimil Babka 2017-01-04 7:28 ` Vlastimil Babka 2017-01-04 7:50 ` Michal Hocko 2017-01-04 7:50 ` Michal Hocko 2016-12-29 7:44 ` Hillf Danton 2016-12-29 7:44 ` Hillf Danton 2016-12-28 15:30 ` [PATCH 3/7] mm, vmscan: show the number of skipped pages in mm_vmscan_lru_isolate Michal Hocko 2016-12-28 15:30 ` Michal Hocko 2016-12-29 5:53 ` Minchan Kim 2016-12-29 5:53 ` Minchan Kim 2016-12-29 7:49 ` Hillf Danton 2016-12-29 7:49 ` Hillf Danton 2017-01-03 17:21 ` Vlastimil Babka 2017-01-03 17:21 ` Vlastimil Babka 2017-01-03 20:43 ` Michal Hocko 2017-01-03 20:43 ` Michal Hocko 2016-12-28 15:30 ` [PATCH 4/7] mm, vmscan: show LRU name in mm_vmscan_lru_isolate tracepoint Michal Hocko 2016-12-28 15:30 ` Michal Hocko 2016-12-28 15:50 ` Nikolay Borisov 2016-12-28 15:50 ` Nikolay Borisov 2016-12-28 16:00 ` Michal Hocko 2016-12-28 16:00 ` Michal Hocko 2016-12-28 16:40 ` Nikolay Borisov 2016-12-28 16:40 ` Nikolay Borisov 2016-12-28 16:49 ` Michal Hocko 2016-12-28 16:49 ` Michal Hocko 2016-12-29 6:02 ` Minchan Kim 2016-12-29 6:02 ` Minchan Kim 2016-12-29 7:56 ` Michal Hocko 2016-12-29 7:56 ` Michal Hocko 2016-12-30 1:56 ` Minchan Kim 2016-12-30 1:56 ` Minchan Kim 2016-12-30 9:33 ` Michal Hocko 2016-12-30 9:33 ` Michal Hocko 2016-12-29 7:53 ` Hillf Danton 2016-12-29 7:53 ` Hillf Danton 2017-01-03 17:08 ` Vlastimil Babka 2017-01-03 17:08 ` Vlastimil Babka 2017-01-03 20:47 ` Michal Hocko 2017-01-03 20:47 ` Michal Hocko 2017-01-03 20:52 ` Michal Hocko 2017-01-03 20:52 ` Michal Hocko 2017-01-03 21:24 ` Michal Hocko 2017-01-03 21:24 ` Michal Hocko 2017-01-03 21:40 ` Vlastimil Babka [this message] 2017-01-03 21:40 ` Vlastimil Babka 2017-01-03 21:48 ` Michal Hocko 2017-01-03 21:48 ` Michal Hocko 2016-12-28 15:30 ` [PATCH 5/7] mm, vmscan: extract shrink_page_list reclaim counters into a struct Michal Hocko 2016-12-28 15:30 ` Michal Hocko 2016-12-29 8:00 ` Hillf Danton 2016-12-29 8:00 ` Hillf Danton 2016-12-28 15:30 ` [PATCH 6/7] mm, vmscan: enhance mm_vmscan_lru_shrink_inactive tracepoint Michal Hocko 2016-12-28 15:30 ` Michal Hocko 2016-12-29 8:05 ` Hillf Danton 2016-12-29 8:05 ` Hillf Danton 2016-12-28 15:30 ` [PATCH 7/7] mm, vmscan: add mm_vmscan_inactive_list_is_low tracepoint Michal Hocko 2016-12-28 15:30 ` Michal Hocko 2016-12-29 8:19 ` Hillf Danton 2016-12-29 8:19 ` Hillf Danton 2016-12-30 9:11 ` [PATCH 0/7] vm, vmscan: enahance vmscan tracepoints Mel Gorman 2016-12-30 9:11 ` Mel Gorman 2016-12-30 9:36 ` Michal Hocko 2016-12-30 9:36 ` Michal Hocko 2016-12-30 10:20 ` Mel Gorman 2016-12-30 10:20 ` Mel Gorman 2017-01-04 10:19 [PATCH 0/7 v2] " Michal Hocko 2017-01-04 10:19 ` [PATCH 4/7] mm, vmscan: show LRU name in mm_vmscan_lru_isolate tracepoint Michal Hocko 2017-01-04 10:19 ` Michal Hocko 2017-01-05 6:04 ` Minchan Kim 2017-01-05 6:04 ` Minchan Kim 2017-01-05 10:16 ` Michal Hocko 2017-01-05 10:16 ` Michal Hocko 2017-01-05 14:56 ` Mel Gorman 2017-01-05 14:56 ` Mel Gorman 2017-01-05 15:17 ` Michal Hocko 2017-01-05 15:17 ` Michal Hocko
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=cfc85361-5bd0-7614-e1d6-1a71e0421571@suse.cz \ --to=vbabka@suse.cz \ --cc=akpm@linux-foundation.org \ --cc=hannes@cmpxchg.org \ --cc=linux-kernel@vger.kernel.org \ --cc=linux-mm@kvack.org \ --cc=mgorman@suse.de \ --cc=mhocko@kernel.org \ --cc=riel@redhat.com \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: linkBe sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.