All of lore.kernel.org
 help / color / mirror / Atom feed
* [PATCH 0/5] Remove return variables in multiple functions
@ 2019-03-19 19:57 Nishka Dasgupta
  2019-03-19 19:57 ` [PATCH 1/5] staging: wilc1000: Remove return variable Nishka Dasgupta
                   ` (5 more replies)
  0 siblings, 6 replies; 12+ messages in thread
From: Nishka Dasgupta @ 2019-03-19 19:57 UTC (permalink / raw)
  To: gregkh, outreachy-kernel, ajay.kathat, adham.abozaeid; +Cc: Nishka Dasgupta

The following patches remove the return variable in multiple functions
and return the required values directly. These issues were suggested by
Coccinelle using ret.cocci.

Nishka Dasgupta (5):
  staging: wilc1000: Remove return variable
  staging: wilc1000: Remove return variable
  staging: wilc1000: Remove return variable
  staging: wilc1000: Remove return variable
  staging: wilc1000: Remove return variable

 drivers/staging/wilc1000/host_interface.c | 11 +++--------
 drivers/staging/wilc1000/wilc_spi.c       |  6 ++----
 2 files changed, 5 insertions(+), 12 deletions(-)

-- 
2.19.1



^ permalink raw reply	[flat|nested] 12+ messages in thread
* [PATCH 1/5] staging: wilc1000: Remove return variable
  2019-03-19 19:57 [PATCH 0/5] Remove return variables in multiple functions Nishka Dasgupta
@ 2019-03-19 19:57 ` Nishka Dasgupta
  2019-03-19 20:11   ` [Outreachy kernel] " Julia Lawall
  2019-03-19 19:57 ` [PATCH 2/5] " Nishka Dasgupta
                   ` (4 subsequent siblings)
  5 siblings, 1 reply; 12+ messages in thread
From: Nishka Dasgupta @ 2019-03-19 19:57 UTC (permalink / raw)
  To: gregkh, outreachy-kernel, ajay.kathat, adham.abozaeid; +Cc: Nishka Dasgupta

Remove return variable. Issue found with Coccinelle using ret.cocci.

Signed-off-by: Nishka Dasgupta <nishka.dasgupta@yahoo.com>
---
 drivers/staging/wilc1000/host_interface.c | 4 +---
 1 file changed, 1 insertion(+), 3 deletions(-)

diff --git a/drivers/staging/wilc1000/host_interface.c b/drivers/staging/wilc1000/host_interface.c
index 56d8ed29fff9..cd4d9bd789fd 100644
--- a/drivers/staging/wilc1000/host_interface.c
+++ b/drivers/staging/wilc1000/host_interface.c
@@ -1365,10 +1365,8 @@ int wilc_set_pmkid_info(struct wilc_vif *vif, struct wilc_pmkid_attr *pmkid)
 	wid.size = (pmkid->numpmkid * sizeof(struct wilc_pmkid)) + 1;
 	wid.val = (u8 *)pmkid;
 
-	result = wilc_send_config_pkt(vif, WILC_SET_CFG, &wid, 1,
+	return wilc_send_config_pkt(vif, WILC_SET_CFG, &wid, 1,
 				      wilc_get_vif_idx(vif));
-
-	return result;
 }
 
 int wilc_get_mac_address(struct wilc_vif *vif, u8 *mac_addr)
-- 
2.19.1



^ permalink raw reply related	[flat|nested] 12+ messages in thread
* [PATCH 2/5] staging: wilc1000: Remove return variable
  2019-03-19 19:57 [PATCH 0/5] Remove return variables in multiple functions Nishka Dasgupta
  2019-03-19 19:57 ` [PATCH 1/5] staging: wilc1000: Remove return variable Nishka Dasgupta
@ 2019-03-19 19:57 ` Nishka Dasgupta
  2019-03-19 20:15   ` [Outreachy kernel] " Julia Lawall
  2019-03-19 19:57 ` [PATCH 3/5] " Nishka Dasgupta
                   ` (3 subsequent siblings)
  5 siblings, 1 reply; 12+ messages in thread
From: Nishka Dasgupta @ 2019-03-19 19:57 UTC (permalink / raw)
  To: gregkh, outreachy-kernel, ajay.kathat, adham.abozaeid; +Cc: Nishka Dasgupta

Remove return variable. Issue found with Coccinelle using ret.cocci.

Signed-off-by: Nishka Dasgupta <nishka.dasgupta@yahoo.com>
---
 drivers/staging/wilc1000/host_interface.c | 3 +--
 1 file changed, 1 insertion(+), 2 deletions(-)

diff --git a/drivers/staging/wilc1000/host_interface.c b/drivers/staging/wilc1000/host_interface.c
index cd4d9bd789fd..9b9997e3ecf9 100644
--- a/drivers/staging/wilc1000/host_interface.c
+++ b/drivers/staging/wilc1000/host_interface.c
@@ -1401,8 +1401,7 @@ int wilc_set_join_req(struct wilc_vif *vif, u8 *bssid, const u8 *ies,
 		conn_info->req_ies_len = ies_len;
 		conn_info->req_ies = kmemdup(ies, ies_len, GFP_KERNEL);
 		if (!conn_info->req_ies) {
-			result = -ENOMEM;
-			return result;
+			return -ENOMEM;
 		}
 	}
 
-- 
2.19.1



^ permalink raw reply related	[flat|nested] 12+ messages in thread
* [PATCH 3/5] staging: wilc1000: Remove return variable
  2019-03-19 19:57 [PATCH 0/5] Remove return variables in multiple functions Nishka Dasgupta
  2019-03-19 19:57 ` [PATCH 1/5] staging: wilc1000: Remove return variable Nishka Dasgupta
  2019-03-19 19:57 ` [PATCH 2/5] " Nishka Dasgupta
@ 2019-03-19 19:57 ` Nishka Dasgupta
  2019-03-19 19:57 ` [PATCH 4/5] " Nishka Dasgupta
                   ` (2 subsequent siblings)
  5 siblings, 0 replies; 12+ messages in thread
From: Nishka Dasgupta @ 2019-03-19 19:57 UTC (permalink / raw)
  To: gregkh, outreachy-kernel, ajay.kathat, adham.abozaeid; +Cc: Nishka Dasgupta

Remove return variable. Issue found with Coccinelle using ret.cocci.

Signed-off-by: Nishka Dasgupta <nishka.dasgupta@yahoo.com>
---
 drivers/staging/wilc1000/host_interface.c | 4 +---
 1 file changed, 1 insertion(+), 3 deletions(-)

diff --git a/drivers/staging/wilc1000/host_interface.c b/drivers/staging/wilc1000/host_interface.c
index 9b9997e3ecf9..fdad1928c4f7 100644
--- a/drivers/staging/wilc1000/host_interface.c
+++ b/drivers/staging/wilc1000/host_interface.c
@@ -1598,10 +1598,8 @@ int wilc_hif_set_cfg(struct wilc_vif *vif, struct cfg_param_attr *param)
 		i++;
 	}
 
-	result = wilc_send_config_pkt(vif, WILC_SET_CFG, wid_list,
+	return wilc_send_config_pkt(vif, WILC_SET_CFG, wid_list,
 				      i, wilc_get_vif_idx(vif));
-
-	return result;
 }
 
 static void get_periodic_rssi(struct timer_list *t)
-- 
2.19.1



^ permalink raw reply related	[flat|nested] 12+ messages in thread
* [PATCH 4/5] staging: wilc1000: Remove return variable
  2019-03-19 19:57 [PATCH 0/5] Remove return variables in multiple functions Nishka Dasgupta
                   ` (2 preceding siblings ...)
  2019-03-19 19:57 ` [PATCH 3/5] " Nishka Dasgupta
@ 2019-03-19 19:57 ` Nishka Dasgupta
  2019-03-19 19:57 ` [PATCH 5/5] " Nishka Dasgupta
  2019-03-19 20:04 ` [Outreachy kernel] [PATCH 0/5] Remove return variables in multiple functions Julia Lawall
  5 siblings, 0 replies; 12+ messages in thread
From: Nishka Dasgupta @ 2019-03-19 19:57 UTC (permalink / raw)
  To: gregkh, outreachy-kernel, ajay.kathat, adham.abozaeid; +Cc: Nishka Dasgupta

Remove return variable and return required value directly. Issue found
with Coccinelle using ret.cocci.

Signed-off-by: Nishka Dasgupta <nishka.dasgupta@yahoo.com>
---
 drivers/staging/wilc1000/wilc_spi.c | 3 +--
 1 file changed, 1 insertion(+), 2 deletions(-)

diff --git a/drivers/staging/wilc1000/wilc_spi.c b/drivers/staging/wilc1000/wilc_spi.c
index 4a1be9e60d74..28fdfa269192 100644
--- a/drivers/staging/wilc1000/wilc_spi.c
+++ b/drivers/staging/wilc1000/wilc_spi.c
@@ -934,9 +934,8 @@ static int wilc_spi_read_int(struct wilc *wilc, u32 *int_status)
 	int k = IRG_FLAGS_OFFSET + 5;
 
 	if (spi_priv->has_thrpt_enh) {
-		ret = spi_internal_read(wilc, 0xe840 - WILC_SPI_REG_BASE,
+		return spi_internal_read(wilc, 0xe840 - WILC_SPI_REG_BASE,
 					int_status);
-		return ret;
 	}
 	ret = wilc_spi_read_reg(wilc, WILC_VMM_TO_HOST_SIZE, &byte_cnt);
 	if (!ret) {
-- 
2.19.1



^ permalink raw reply related	[flat|nested] 12+ messages in thread
* [PATCH 5/5] staging: wilc1000: Remove return variable
  2019-03-19 19:57 [PATCH 0/5] Remove return variables in multiple functions Nishka Dasgupta
                   ` (3 preceding siblings ...)
  2019-03-19 19:57 ` [PATCH 4/5] " Nishka Dasgupta
@ 2019-03-19 19:57 ` Nishka Dasgupta
  2019-03-19 20:16   ` [Outreachy kernel] " Julia Lawall
  2019-03-19 20:04 ` [Outreachy kernel] [PATCH 0/5] Remove return variables in multiple functions Julia Lawall
  5 siblings, 1 reply; 12+ messages in thread
From: Nishka Dasgupta @ 2019-03-19 19:57 UTC (permalink / raw)
  To: gregkh, outreachy-kernel, ajay.kathat, adham.abozaeid; +Cc: Nishka Dasgupta

Remove return variable and return required value directly. Issue found
with Coccinelle using ret.cocci.

Signed-off-by: Nishka Dasgupta <nishka.dasgupta@yahoo.com>
---
 drivers/staging/wilc1000/wilc_spi.c | 3 +--
 1 file changed, 1 insertion(+), 2 deletions(-)

diff --git a/drivers/staging/wilc1000/wilc_spi.c b/drivers/staging/wilc1000/wilc_spi.c
index 28fdfa269192..9959a794edc7 100644
--- a/drivers/staging/wilc1000/wilc_spi.c
+++ b/drivers/staging/wilc1000/wilc_spi.c
@@ -981,9 +981,8 @@ static int wilc_spi_clear_int_ext(struct wilc *wilc, u32 val)
 	u32 tbl_ctl;
 
 	if (spi_priv->has_thrpt_enh) {
-		ret = spi_internal_write(wilc, 0xe844 - WILC_SPI_REG_BASE,
+		return spi_internal_write(wilc, 0xe844 - WILC_SPI_REG_BASE,
 					 val);
-		return ret;
 	}
 
 	flags = val & (BIT(MAX_NUM_INT) - 1);
-- 
2.19.1



^ permalink raw reply related	[flat|nested] 12+ messages in thread
* Re: [Outreachy kernel] [PATCH 0/5] Remove return variables in multiple functions
  2019-03-19 19:57 [PATCH 0/5] Remove return variables in multiple functions Nishka Dasgupta
                   ` (4 preceding siblings ...)
  2019-03-19 19:57 ` [PATCH 5/5] " Nishka Dasgupta
@ 2019-03-19 20:04 ` Julia Lawall
  2019-03-20 15:58   ` NIshka Dasgupta
  5 siblings, 1 reply; 12+ messages in thread
From: Julia Lawall @ 2019-03-19 20:04 UTC (permalink / raw)
  To: Nishka Dasgupta; +Cc: gregkh, outreachy-kernel, ajay.kathat, adham.abozaeid



On Wed, 20 Mar 2019, 'Nishka Dasgupta' via outreachy-kernel wrote:

> The following patches remove the return variable in multiple functions
> and return the required values directly. These issues were suggested by
> Coccinelle using ret.cocci.
>
> Nishka Dasgupta (5):
>   staging: wilc1000: Remove return variable
>   staging: wilc1000: Remove return variable
>   staging: wilc1000: Remove return variable
>   staging: wilc1000: Remove return variable
>   staging: wilc1000: Remove return variable

I haven't received the other patches in this series, but just from the
above there is a problem.  Every patch should have a subject line that is
unique.  On solution would be to incorporate the file name, but it seems
that you have only two files.  If the changes are not too voluminous, you
could send a single patch for all of the changes in a given file.

julia

>
>  drivers/staging/wilc1000/host_interface.c | 11 +++--------
>  drivers/staging/wilc1000/wilc_spi.c       |  6 ++----
>  2 files changed, 5 insertions(+), 12 deletions(-)
>
> --
> 2.19.1
>
> --
> You received this message because you are subscribed to the Google Groups "outreachy-kernel" group.
> To unsubscribe from this group and stop receiving emails from it, send an email to outreachy-kernel+unsubscribe@googlegroups.com.
> To post to this group, send email to outreachy-kernel@googlegroups.com.
> To view this discussion on the web visit https://groups.google.com/d/msgid/outreachy-kernel/cover.1553025265.git.nishka.dasgupta%40yahoo.com.
> For more options, visit https://groups.google.com/d/optout.
>


^ permalink raw reply	[flat|nested] 12+ messages in thread
* Re: [Outreachy kernel] [PATCH 1/5] staging: wilc1000: Remove return variable
  2019-03-19 19:57 ` [PATCH 1/5] staging: wilc1000: Remove return variable Nishka Dasgupta
@ 2019-03-19 20:11   ` Julia Lawall
  0 siblings, 0 replies; 12+ messages in thread
From: Julia Lawall @ 2019-03-19 20:11 UTC (permalink / raw)
  To: Nishka Dasgupta; +Cc: gregkh, outreachy-kernel, ajay.kathat, adham.abozaeid



On Wed, 20 Mar 2019, 'Nishka Dasgupta' via outreachy-kernel wrote:

> Remove return variable. Issue found with Coccinelle using ret.cocci.
>
> Signed-off-by: Nishka Dasgupta <nishka.dasgupta@yahoo.com>
> ---
>  drivers/staging/wilc1000/host_interface.c | 4 +---
>  1 file changed, 1 insertion(+), 3 deletions(-)
>
> diff --git a/drivers/staging/wilc1000/host_interface.c b/drivers/staging/wilc1000/host_interface.c
> index 56d8ed29fff9..cd4d9bd789fd 100644
> --- a/drivers/staging/wilc1000/host_interface.c
> +++ b/drivers/staging/wilc1000/host_interface.c
> @@ -1365,10 +1365,8 @@ int wilc_set_pmkid_info(struct wilc_vif *vif, struct wilc_pmkid_attr *pmkid)
>  	wid.size = (pmkid->numpmkid * sizeof(struct wilc_pmkid)) + 1;
>  	wid.val = (u8 *)pmkid;
>
> -	result = wilc_send_config_pkt(vif, WILC_SET_CFG, &wid, 1,
> +	return wilc_send_config_pkt(vif, WILC_SET_CFG, &wid, 1,
>  				      wilc_get_vif_idx(vif));

The last argument should be lined up with the (.  But you can check if it
would now fit on the previous line.

julia

> -
> -	return result;
>  }
>
>  int wilc_get_mac_address(struct wilc_vif *vif, u8 *mac_addr)
> --
> 2.19.1
>
> --
> You received this message because you are subscribed to the Google Groups "outreachy-kernel" group.
> To unsubscribe from this group and stop receiving emails from it, send an email to outreachy-kernel+unsubscribe@googlegroups.com.
> To post to this group, send email to outreachy-kernel@googlegroups.com.
> To view this discussion on the web visit https://groups.google.com/d/msgid/outreachy-kernel/7ee75b6e103796fc5c536be85aa5763c691b885c.1553025265.git.nishka.dasgupta%40yahoo.com.
> For more options, visit https://groups.google.com/d/optout.
>


^ permalink raw reply	[flat|nested] 12+ messages in thread
* Re: [Outreachy kernel] [PATCH 2/5] staging: wilc1000: Remove return variable
  2019-03-19 19:57 ` [PATCH 2/5] " Nishka Dasgupta
@ 2019-03-19 20:15   ` Julia Lawall
  0 siblings, 0 replies; 12+ messages in thread
From: Julia Lawall @ 2019-03-19 20:15 UTC (permalink / raw)
  To: Nishka Dasgupta; +Cc: gregkh, outreachy-kernel, ajay.kathat, adham.abozaeid



On Wed, 20 Mar 2019, 'Nishka Dasgupta' via outreachy-kernel wrote:

> Remove return variable. Issue found with Coccinelle using ret.cocci.
>
> Signed-off-by: Nishka Dasgupta <nishka.dasgupta@yahoo.com>

Acked-by: Julia Lawall <julia.lawall@lip6.fr>

This one is particularly nice :)

> ---
>  drivers/staging/wilc1000/host_interface.c | 3 +--
>  1 file changed, 1 insertion(+), 2 deletions(-)
>
> diff --git a/drivers/staging/wilc1000/host_interface.c b/drivers/staging/wilc1000/host_interface.c
> index cd4d9bd789fd..9b9997e3ecf9 100644
> --- a/drivers/staging/wilc1000/host_interface.c
> +++ b/drivers/staging/wilc1000/host_interface.c
> @@ -1401,8 +1401,7 @@ int wilc_set_join_req(struct wilc_vif *vif, u8 *bssid, const u8 *ies,
>  		conn_info->req_ies_len = ies_len;
>  		conn_info->req_ies = kmemdup(ies, ies_len, GFP_KERNEL);
>  		if (!conn_info->req_ies) {
> -			result = -ENOMEM;
> -			return result;
> +			return -ENOMEM;
>  		}
>  	}
>
> --
> 2.19.1
>
> --
> You received this message because you are subscribed to the Google Groups "outreachy-kernel" group.
> To unsubscribe from this group and stop receiving emails from it, send an email to outreachy-kernel+unsubscribe@googlegroups.com.
> To post to this group, send email to outreachy-kernel@googlegroups.com.
> To view this discussion on the web visit https://groups.google.com/d/msgid/outreachy-kernel/10fe1f5ac83e327337735300199b81a9b1230423.1553025265.git.nishka.dasgupta%40yahoo.com.
> For more options, visit https://groups.google.com/d/optout.
>


^ permalink raw reply	[flat|nested] 12+ messages in thread
* Re: [Outreachy kernel] [PATCH 5/5] staging: wilc1000: Remove return variable
  2019-03-19 19:57 ` [PATCH 5/5] " Nishka Dasgupta
@ 2019-03-19 20:16   ` Julia Lawall
  0 siblings, 0 replies; 12+ messages in thread
From: Julia Lawall @ 2019-03-19 20:16 UTC (permalink / raw)
  To: Nishka Dasgupta; +Cc: gregkh, outreachy-kernel, ajay.kathat, adham.abozaeid



On Wed, 20 Mar 2019, 'Nishka Dasgupta' via outreachy-kernel wrote:

> Remove return variable and return required value directly. Issue found
> with Coccinelle using ret.cocci.
>
> Signed-off-by: Nishka Dasgupta <nishka.dasgupta@yahoo.com>
> ---
>  drivers/staging/wilc1000/wilc_spi.c | 3 +--
>  1 file changed, 1 insertion(+), 2 deletions(-)
>
> diff --git a/drivers/staging/wilc1000/wilc_spi.c b/drivers/staging/wilc1000/wilc_spi.c
> index 28fdfa269192..9959a794edc7 100644
> --- a/drivers/staging/wilc1000/wilc_spi.c
> +++ b/drivers/staging/wilc1000/wilc_spi.c
> @@ -981,9 +981,8 @@ static int wilc_spi_clear_int_ext(struct wilc *wilc, u32 val)
>  	u32 tbl_ctl;
>
>  	if (spi_priv->has_thrpt_enh) {
> -		ret = spi_internal_write(wilc, 0xe844 - WILC_SPI_REG_BASE,
> +		return spi_internal_write(wilc, 0xe844 - WILC_SPI_REG_BASE,
>  					 val);

You need to adjust the position of val.  You can check  if it would fit on
the previous line.

julia

> -		return ret;
>  	}
>
>  	flags = val & (BIT(MAX_NUM_INT) - 1);
> --
> 2.19.1
>
> --
> You received this message because you are subscribed to the Google Groups "outreachy-kernel" group.
> To unsubscribe from this group and stop receiving emails from it, send an email to outreachy-kernel+unsubscribe@googlegroups.com.
> To post to this group, send email to outreachy-kernel@googlegroups.com.
> To view this discussion on the web visit https://groups.google.com/d/msgid/outreachy-kernel/030f11edadf6ee01ffbe7d239f8352b8034427af.1553025265.git.nishka.dasgupta%40yahoo.com.
> For more options, visit https://groups.google.com/d/optout.
>


^ permalink raw reply	[flat|nested] 12+ messages in thread
* Re: [Outreachy kernel] [PATCH 0/5] Remove return variables in multiple functions
  2019-03-19 20:04 ` [Outreachy kernel] [PATCH 0/5] Remove return variables in multiple functions Julia Lawall
@ 2019-03-20 15:58   ` NIshka Dasgupta
  2019-03-20 20:10     ` Julia Lawall
  0 siblings, 1 reply; 12+ messages in thread
From: NIshka Dasgupta @ 2019-03-20 15:58 UTC (permalink / raw)
  To: Julia Lawall; +Cc: gregkh, outreachy-kernel, ajay.kathat, adham.abozaeid



On 20/03/19 1:34 AM, Julia Lawall wrote:
> 
> 
> On Wed, 20 Mar 2019, 'Nishka Dasgupta' via outreachy-kernel wrote:
> 
>> The following patches remove the return variable in multiple functions
>> and return the required values directly. These issues were suggested by
>> Coccinelle using ret.cocci.
>>
>> Nishka Dasgupta (5):
>>    staging: wilc1000: Remove return variable
>>    staging: wilc1000: Remove return variable
>>    staging: wilc1000: Remove return variable
>>    staging: wilc1000: Remove return variable
>>    staging: wilc1000: Remove return variable
> 
> I haven't received the other patches in this series, but just from the
> above there is a problem.  Every patch should have a subject line that is
> unique.  On solution would be to incorporate the file name, but it seems
> that you have only two files.  If the changes are not too voluminous, you
> could send a single patch for all of the changes in a given file.

Since you've acked one or two of them, should I send a version 2 of the 
entire patchset or just the ones that need adjustments?
Thanking you,
Nishka

> julia

>>
>>   drivers/staging/wilc1000/host_interface.c | 11 +++--------
>>   drivers/staging/wilc1000/wilc_spi.c       |  6 ++----
>>   2 files changed, 5 insertions(+), 12 deletions(-)
>>
>> --
>> 2.19.1
>>
>> --
>> You received this message because you are subscribed to the Google Groups "outreachy-kernel" group.
>> To unsubscribe from this group and stop receiving emails from it, send an email to outreachy-kernel+unsubscribe@googlegroups.com.
>> To post to this group, send email to outreachy-kernel@googlegroups.com.
>> To view this discussion on the web visit https://groups.google.com/d/msgid/outreachy-kernel/cover.1553025265.git.nishka.dasgupta%40yahoo.com.
>> For more options, visit https://groups.google.com/d/optout.
>>


^ permalink raw reply	[flat|nested] 12+ messages in thread
* Re: [Outreachy kernel] [PATCH 0/5] Remove return variables in multiple functions
  2019-03-20 15:58   ` NIshka Dasgupta
@ 2019-03-20 20:10     ` Julia Lawall
  0 siblings, 0 replies; 12+ messages in thread
From: Julia Lawall @ 2019-03-20 20:10 UTC (permalink / raw)
  To: NIshka Dasgupta
  Cc: Julia Lawall, gregkh, outreachy-kernel, ajay.kathat, adham.abozaeid



On Wed, 20 Mar 2019, 'NIshka Dasgupta' via outreachy-kernel wrote:

>
>
> On 20/03/19 1:34 AM, Julia Lawall wrote:
> >
> >
> > On Wed, 20 Mar 2019, 'Nishka Dasgupta' via outreachy-kernel wrote:
> >
> > > The following patches remove the return variable in multiple functions
> > > and return the required values directly. These issues were suggested by
> > > Coccinelle using ret.cocci.
> > >
> > > Nishka Dasgupta (5):
> > >    staging: wilc1000: Remove return variable
> > >    staging: wilc1000: Remove return variable
> > >    staging: wilc1000: Remove return variable
> > >    staging: wilc1000: Remove return variable
> > >    staging: wilc1000: Remove return variable
> >
> > I haven't received the other patches in this series, but just from the
> > above there is a problem.  Every patch should have a subject line that is
> > unique.  On solution would be to incorporate the file name, but it seems
> > that you have only two files.  If the changes are not too voluminous, you
> > could send a single patch for all of the changes in a given file.
>
> Since you've acked one or two of them, should I send a version 2 of the entire
> patchset or just the ones that need adjustments?

Send a version 2 of the whole patch set.  If I've acked some, then you can
keep the ack in the v2.

julia


> Thanking you,
> Nishka
>
> > julia
>
> > >
> > >   drivers/staging/wilc1000/host_interface.c | 11 +++--------
> > >   drivers/staging/wilc1000/wilc_spi.c       |  6 ++----
> > >   2 files changed, 5 insertions(+), 12 deletions(-)
> > >
> > > --
> > > 2.19.1
> > >
> > > --
> > > You received this message because you are subscribed to the Google Groups
> > > "outreachy-kernel" group.
> > > To unsubscribe from this group and stop receiving emails from it, send an
> > > email to outreachy-kernel+unsubscribe@googlegroups.com.
> > > To post to this group, send email to outreachy-kernel@googlegroups.com.
> > > To view this discussion on the web visit
> > > https://groups.google.com/d/msgid/outreachy-kernel/cover.1553025265.git.nishka.dasgupta%40yahoo.com.
> > > For more options, visit https://groups.google.com/d/optout.
> > >
>
> --
> You received this message because you are subscribed to the Google Groups
> "outreachy-kernel" group.
> To unsubscribe from this group and stop receiving emails from it, send an
> email to outreachy-kernel+unsubscribe@googlegroups.com.
> To post to this group, send email to outreachy-kernel@googlegroups.com.
> To view this discussion on the web visit
> https://groups.google.com/d/msgid/outreachy-kernel/0310644f-84f3-2aca-1a90-5463b2dc37b3%40yahoo.com.
> For more options, visit https://groups.google.com/d/optout.
>


^ permalink raw reply	[flat|nested] 12+ messages in thread
end of thread, other threads:[~2019-03-20 20:10 UTC | newest]

Thread overview: 12+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2019-03-19 19:57 [PATCH 0/5] Remove return variables in multiple functions Nishka Dasgupta
2019-03-19 19:57 ` [PATCH 1/5] staging: wilc1000: Remove return variable Nishka Dasgupta
2019-03-19 20:11   ` [Outreachy kernel] " Julia Lawall
2019-03-19 19:57 ` [PATCH 2/5] " Nishka Dasgupta
2019-03-19 20:15   ` [Outreachy kernel] " Julia Lawall
2019-03-19 19:57 ` [PATCH 3/5] " Nishka Dasgupta
2019-03-19 19:57 ` [PATCH 4/5] " Nishka Dasgupta
2019-03-19 19:57 ` [PATCH 5/5] " Nishka Dasgupta
2019-03-19 20:16   ` [Outreachy kernel] " Julia Lawall
2019-03-19 20:04 ` [Outreachy kernel] [PATCH 0/5] Remove return variables in multiple functions Julia Lawall
2019-03-20 15:58   ` NIshka Dasgupta
2019-03-20 20:10     ` Julia Lawall

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.