From: Stefan Wahren <stefan.wahren@i2se.com> To: Adrien Thierry <athierry@redhat.com>, linux-kernel@vger.kernel.org Cc: Rob Herring <robh+dt@kernel.org>, Nicolas Saenz Julienne <nsaenz@kernel.org>, Florian Fainelli <f.fainelli@gmail.com>, Ray Jui <rjui@broadcom.com>, Scott Branden <sbranden@broadcom.com>, bcm-kernel-feedback-list@broadcom.com, devicetree@vger.kernel.org, linux-rpi-kernel@lists.infradead.org, linux-arm-kernel@lists.infradead.org, Greg Kroah-Hartman <gregkh@linuxfoundation.org>, Gaston Gonzalez <gascoar@gmail.com>, Ojaswin Mujoo <ojaswin98@gmail.com>, linux-staging@lists.linux.dev, Krzysztof Kozlowski <krzk@kernel.org> Subject: Re: [PATCH v2 0/2] Add support for bcm2711 in vchiq_arm Date: Sat, 26 Mar 2022 10:04:13 +0100 [thread overview] Message-ID: <d20fd8f2-c47a-2f3e-4efa-be705f1517b9@i2se.com> (raw) In-Reply-To: <20220324172647.167617-1-athierry@redhat.com> Hi Adrien, Am 24.03.22 um 18:26 schrieb Adrien Thierry: > The goal of this patch series is to use the bcm2711 compatible string in > vchiq_arm for the Raspberry Pi 4. there was already a patch series to enable VCHIQ on BCM2711, which wasn't accepted: https://lore.kernel.org/linux-arm-kernel/20211014223230.451659-1-mguma@redhat.com/T/ Could you please explain your approach, especially leaving out 36 bit DMA support? > This allows using the downstream device > tree with the upstream kernel. This is a really bad idea and caused a lot of trouble in the past. A lot of the issues in the Fedora or Arch Linux forums or mailing lists results from this idea. It wastes the time of the kernel developer since these DT files has never been reviewed by the devicetree maintainers. Best regards > > --- > Changes since v1: > - Removed duplicate compatible string for bcm2711 in > brcm,bcm2835-vchiq.yaml > > Adrien Thierry (2): > dt-bindings: soc: bcm: bcm2835-vchiq: Add support for bcm2711 > staging: vchiq_arm: Use bcm2711 compatible string for bcm2711-based > RPi > > .../devicetree/bindings/soc/bcm/brcm,bcm2835-vchiq.yaml | 5 +++++ > arch/arm/boot/dts/bcm2711-rpi.dtsi | 1 + > .../staging/vc04_services/interface/vchiq_arm/vchiq_arm.c | 5 +++++ > 3 files changed, 11 insertions(+) > > > base-commit: ed4643521e6af8ab8ed1e467630a85884d2696cf
WARNING: multiple messages have this Message-ID (diff)
From: Stefan Wahren <stefan.wahren@i2se.com> To: Adrien Thierry <athierry@redhat.com>, linux-kernel@vger.kernel.org Cc: Rob Herring <robh+dt@kernel.org>, Nicolas Saenz Julienne <nsaenz@kernel.org>, Florian Fainelli <f.fainelli@gmail.com>, Ray Jui <rjui@broadcom.com>, Scott Branden <sbranden@broadcom.com>, bcm-kernel-feedback-list@broadcom.com, devicetree@vger.kernel.org, linux-rpi-kernel@lists.infradead.org, linux-arm-kernel@lists.infradead.org, Greg Kroah-Hartman <gregkh@linuxfoundation.org>, Gaston Gonzalez <gascoar@gmail.com>, Ojaswin Mujoo <ojaswin98@gmail.com>, linux-staging@lists.linux.dev, Krzysztof Kozlowski <krzk@kernel.org> Subject: Re: [PATCH v2 0/2] Add support for bcm2711 in vchiq_arm Date: Sat, 26 Mar 2022 10:04:13 +0100 [thread overview] Message-ID: <d20fd8f2-c47a-2f3e-4efa-be705f1517b9@i2se.com> (raw) In-Reply-To: <20220324172647.167617-1-athierry@redhat.com> Hi Adrien, Am 24.03.22 um 18:26 schrieb Adrien Thierry: > The goal of this patch series is to use the bcm2711 compatible string in > vchiq_arm for the Raspberry Pi 4. there was already a patch series to enable VCHIQ on BCM2711, which wasn't accepted: https://lore.kernel.org/linux-arm-kernel/20211014223230.451659-1-mguma@redhat.com/T/ Could you please explain your approach, especially leaving out 36 bit DMA support? > This allows using the downstream device > tree with the upstream kernel. This is a really bad idea and caused a lot of trouble in the past. A lot of the issues in the Fedora or Arch Linux forums or mailing lists results from this idea. It wastes the time of the kernel developer since these DT files has never been reviewed by the devicetree maintainers. Best regards > > --- > Changes since v1: > - Removed duplicate compatible string for bcm2711 in > brcm,bcm2835-vchiq.yaml > > Adrien Thierry (2): > dt-bindings: soc: bcm: bcm2835-vchiq: Add support for bcm2711 > staging: vchiq_arm: Use bcm2711 compatible string for bcm2711-based > RPi > > .../devicetree/bindings/soc/bcm/brcm,bcm2835-vchiq.yaml | 5 +++++ > arch/arm/boot/dts/bcm2711-rpi.dtsi | 1 + > .../staging/vc04_services/interface/vchiq_arm/vchiq_arm.c | 5 +++++ > 3 files changed, 11 insertions(+) > > > base-commit: ed4643521e6af8ab8ed1e467630a85884d2696cf _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
next prev parent reply other threads:[~2022-03-26 9:10 UTC|newest] Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top 2022-03-24 17:26 [PATCH v2 0/2] Add support for bcm2711 in vchiq_arm Adrien Thierry 2022-03-24 17:26 ` Adrien Thierry 2022-03-24 17:26 ` [PATCH v2 1/2] dt-bindings: soc: bcm: bcm2835-vchiq: Add support for bcm2711 Adrien Thierry 2022-03-24 17:26 ` Adrien Thierry 2022-03-24 18:47 ` Krzysztof Kozlowski 2022-03-24 18:47 ` Krzysztof Kozlowski 2022-03-25 7:16 ` Krzysztof Kozlowski 2022-03-25 7:16 ` Krzysztof Kozlowski 2022-03-24 17:26 ` [PATCH v2 2/2] staging: vchiq_arm: Use bcm2711 compatible string for bcm2711-based RPi Adrien Thierry 2022-03-24 17:26 ` Adrien Thierry 2022-03-24 18:49 ` Krzysztof Kozlowski 2022-03-24 18:49 ` Krzysztof Kozlowski 2022-03-26 9:04 ` Stefan Wahren [this message] 2022-03-26 9:04 ` [PATCH v2 0/2] Add support for bcm2711 in vchiq_arm Stefan Wahren 2022-04-07 14:03 ` Adrien Thierry 2022-04-07 14:03 ` Adrien Thierry
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=d20fd8f2-c47a-2f3e-4efa-be705f1517b9@i2se.com \ --to=stefan.wahren@i2se.com \ --cc=athierry@redhat.com \ --cc=bcm-kernel-feedback-list@broadcom.com \ --cc=devicetree@vger.kernel.org \ --cc=f.fainelli@gmail.com \ --cc=gascoar@gmail.com \ --cc=gregkh@linuxfoundation.org \ --cc=krzk@kernel.org \ --cc=linux-arm-kernel@lists.infradead.org \ --cc=linux-kernel@vger.kernel.org \ --cc=linux-rpi-kernel@lists.infradead.org \ --cc=linux-staging@lists.linux.dev \ --cc=nsaenz@kernel.org \ --cc=ojaswin98@gmail.com \ --cc=rjui@broadcom.com \ --cc=robh+dt@kernel.org \ --cc=sbranden@broadcom.com \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: linkBe sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.