From: Dan Murphy <dmurphy@ti.com> To: Rob Herring <robh@kernel.org> Cc: mark.rutland@arm.com, rpurdie@rpsys.net, jacek.anaszewski@gmail.com, pavel@ucw.cz, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, linux-leds@vger.kernel.org Subject: Re: [PATCH v3 1/2] dt: bindings: lm3692x: Add bindings for lm3692x LED driver Date: Thu, 16 Nov 2017 09:45:23 -0600 [thread overview] Message-ID: <d3483e49-650d-1d68-bec6-eeb84d8ac48a@ti.com> (raw) In-Reply-To: <20171116154139.wed7qmpmv2ffyzv2@rob-hp-laptop> Rob Thanks for the review On 11/16/2017 09:41 AM, Rob Herring wrote: > On Wed, Nov 15, 2017 at 01:42:02PM -0600, Dan Murphy wrote: >> This adds the devicetree bindings for the LM3692x >> I2C LED string driver. >> >> Acked-by: Pavel Machek <pavel@ucw.cz> >> Signed-off-by: Dan Murphy <dmurphy@ti.com> >> --- >> >> v3 - No changes >> v2 - No changes - https://patchwork.kernel.org/patch/10056677/ >> >> .../devicetree/bindings/leds/leds-lm3692x.txt | 28 ++++++++++++++++++++++ >> 1 file changed, 28 insertions(+) >> create mode 100644 Documentation/devicetree/bindings/leds/leds-lm3692x.txt >> >> diff --git a/Documentation/devicetree/bindings/leds/leds-lm3692x.txt b/Documentation/devicetree/bindings/leds/leds-lm3692x.txt >> new file mode 100644 >> index 000000000000..cfef67bd4100 >> --- /dev/null >> +++ b/Documentation/devicetree/bindings/leds/leds-lm3692x.txt >> @@ -0,0 +1,28 @@ >> +* Texas Instruments - LM3692x Highly Efficient Dual-String White LED Driver >> + >> +The LM36922 is an ultra-compact, highly efficient, >> +two string white-LED driver designed for LCD display >> +backlighting. >> + >> +Required properties: >> + - compatible: >> + "ti,lm3692x" > > Don't use wildcards in compatible strings. Do you mean to remove the x? How do we denote a family of parts then? > >> + - reg - I2C slave address >> + >> +Optional properties: >> + - label - Used for naming LEDs >> + - enable-gpio - gpio pin to enable/disable the device. > > enable-gpios is the preferred form. ack > >> + - supply - "vled" - LED supply > > vled-supply - ... > ack >> + >> +Example: >> + >> +leds: leds@6 { >> + compatible = "ti,lm3692x"; >> + reg = <0x36>; >> + label = "backlight_cluster"; >> + enable-gpio = <&gpio1 28 GPIO_ACTIVE_HIGH>; >> + vled-supply = <&vbatt>; >> +} >> + >> +For more product information please see the link below: >> +http://www.ti.com/lit/ds/snvsa29/snvsa29.pdf >> -- >> 2.15.0.124.g7668cbc60 >> -- ------------------ Dan Murphy
WARNING: multiple messages have this Message-ID (diff)
From: Dan Murphy <dmurphy@ti.com> To: Rob Herring <robh@kernel.org> Cc: <mark.rutland@arm.com>, <rpurdie@rpsys.net>, <jacek.anaszewski@gmail.com>, <pavel@ucw.cz>, <devicetree@vger.kernel.org>, <linux-kernel@vger.kernel.org>, <linux-leds@vger.kernel.org> Subject: Re: [PATCH v3 1/2] dt: bindings: lm3692x: Add bindings for lm3692x LED driver Date: Thu, 16 Nov 2017 09:45:23 -0600 [thread overview] Message-ID: <d3483e49-650d-1d68-bec6-eeb84d8ac48a@ti.com> (raw) In-Reply-To: <20171116154139.wed7qmpmv2ffyzv2@rob-hp-laptop> Rob Thanks for the review On 11/16/2017 09:41 AM, Rob Herring wrote: > On Wed, Nov 15, 2017 at 01:42:02PM -0600, Dan Murphy wrote: >> This adds the devicetree bindings for the LM3692x >> I2C LED string driver. >> >> Acked-by: Pavel Machek <pavel@ucw.cz> >> Signed-off-by: Dan Murphy <dmurphy@ti.com> >> --- >> >> v3 - No changes >> v2 - No changes - https://patchwork.kernel.org/patch/10056677/ >> >> .../devicetree/bindings/leds/leds-lm3692x.txt | 28 ++++++++++++++++++++++ >> 1 file changed, 28 insertions(+) >> create mode 100644 Documentation/devicetree/bindings/leds/leds-lm3692x.txt >> >> diff --git a/Documentation/devicetree/bindings/leds/leds-lm3692x.txt b/Documentation/devicetree/bindings/leds/leds-lm3692x.txt >> new file mode 100644 >> index 000000000000..cfef67bd4100 >> --- /dev/null >> +++ b/Documentation/devicetree/bindings/leds/leds-lm3692x.txt >> @@ -0,0 +1,28 @@ >> +* Texas Instruments - LM3692x Highly Efficient Dual-String White LED Driver >> + >> +The LM36922 is an ultra-compact, highly efficient, >> +two string white-LED driver designed for LCD display >> +backlighting. >> + >> +Required properties: >> + - compatible: >> + "ti,lm3692x" > > Don't use wildcards in compatible strings. Do you mean to remove the x? How do we denote a family of parts then? > >> + - reg - I2C slave address >> + >> +Optional properties: >> + - label - Used for naming LEDs >> + - enable-gpio - gpio pin to enable/disable the device. > > enable-gpios is the preferred form. ack > >> + - supply - "vled" - LED supply > > vled-supply - ... > ack >> + >> +Example: >> + >> +leds: leds@6 { >> + compatible = "ti,lm3692x"; >> + reg = <0x36>; >> + label = "backlight_cluster"; >> + enable-gpio = <&gpio1 28 GPIO_ACTIVE_HIGH>; >> + vled-supply = <&vbatt>; >> +} >> + >> +For more product information please see the link below: >> +http://www.ti.com/lit/ds/snvsa29/snvsa29.pdf >> -- >> 2.15.0.124.g7668cbc60 >> -- ------------------ Dan Murphy
next prev parent reply other threads:[~2017-11-16 15:45 UTC|newest] Thread overview: 42+ messages / expand[flat|nested] mbox.gz Atom feed top 2017-11-15 19:42 [PATCH v3 1/2] dt: bindings: lm3692x: Add bindings for lm3692x LED driver Dan Murphy 2017-11-15 19:42 ` Dan Murphy [not found] ` <20171115194203.13572-1-dmurphy-l0cyMroinI0@public.gmane.org> 2017-11-15 19:42 ` [PATCH v3 2/2] leds: lm3692x: Introduce LM3692x dual string driver Dan Murphy 2017-11-15 19:42 ` Dan Murphy [not found] ` <20171115194203.13572-2-dmurphy-l0cyMroinI0@public.gmane.org> 2017-11-15 21:12 ` Pavel Machek 2017-11-15 21:12 ` Pavel Machek 2017-11-15 21:25 ` Dan Murphy 2017-11-15 21:25 ` Dan Murphy 2017-11-18 14:19 ` Jacek Anaszewski 2017-11-18 14:19 ` Jacek Anaszewski 2017-11-28 12:53 ` Dan Murphy 2017-11-28 12:53 ` Dan Murphy 2017-11-15 20:15 ` [PATCH v3 1/2] dt: bindings: lm3692x: Add bindings for lm3692x LED driver Jacek Anaszewski 2017-11-15 20:15 ` Jacek Anaszewski [not found] ` <cb5c5a65-d5a0-86a3-36b4-cf06baae9ec4-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org> 2017-11-15 20:31 ` Dan Murphy 2017-11-15 20:31 ` Dan Murphy [not found] ` <0a78c883-f074-cc19-3c0c-fc05607400e9-l0cyMroinI0@public.gmane.org> 2017-11-15 22:23 ` Pavel Machek 2017-11-15 22:23 ` Pavel Machek 2017-11-16 20:14 ` Jacek Anaszewski [not found] ` <82336eb7-2b89-d37b-d688-4e4302766346-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org> 2017-11-16 21:42 ` Dan Murphy 2017-11-16 21:42 ` Dan Murphy 2017-11-17 2:19 ` Jingoo Han 2017-11-17 2:19 ` Jingoo Han 2017-11-17 11:20 ` Pavel Machek 2017-11-17 16:30 ` Jingoo Han 2017-11-17 16:30 ` Jingoo Han 2017-11-17 18:02 ` Dan Murphy 2017-11-17 18:02 ` Dan Murphy 2017-11-17 23:58 ` Pavel Machek 2017-11-28 17:27 ` Dan Murphy 2017-11-28 17:27 ` Dan Murphy 2017-11-16 15:41 ` Rob Herring 2017-11-16 15:41 ` Rob Herring 2017-11-16 15:45 ` Dan Murphy [this message] 2017-11-16 15:45 ` Dan Murphy [not found] ` <d3483e49-650d-1d68-bec6-eeb84d8ac48a-l0cyMroinI0@public.gmane.org> 2017-11-16 15:58 ` Rob Herring 2017-11-16 15:58 ` Rob Herring 2017-11-16 20:11 ` dts: fun with chip names " Pavel Machek 2017-11-16 20:36 ` Rob Herring [not found] ` <CAL_Jsq+aysVR9U2Wquwwv7cjjO7wO8EXBg1Ja82u6s5t1yeJUw-JsoAwUIsXosN+BqQ9rBEUg@public.gmane.org> 2017-11-16 21:40 ` Dan Murphy 2017-11-16 21:40 ` Dan Murphy 2017-11-18 14:19 ` Jacek Anaszewski
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=d3483e49-650d-1d68-bec6-eeb84d8ac48a@ti.com \ --to=dmurphy@ti.com \ --cc=devicetree@vger.kernel.org \ --cc=jacek.anaszewski@gmail.com \ --cc=linux-kernel@vger.kernel.org \ --cc=linux-leds@vger.kernel.org \ --cc=mark.rutland@arm.com \ --cc=pavel@ucw.cz \ --cc=robh@kernel.org \ --cc=rpurdie@rpsys.net \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: linkBe sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.