From: Dan Murphy <dmurphy-l0cyMroinI0@public.gmane.org> To: Rob Herring <robh-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org>, Pavel Machek <pavel-+ZI9xUNit7I@public.gmane.org> Cc: Mark Rutland <mark.rutland-5wv7dgnIgG8@public.gmane.org>, Richard Purdie <rpurdie-Fm38FmjxZ/leoWH0uzbU5w@public.gmane.org>, Jacek Anaszewski <jacek.anaszewski-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>, "devicetree-u79uwXL29TY76Z2rM5mHXA@public.gmane.org" <devicetree-u79uwXL29TY76Z2rM5mHXA@public.gmane.org>, "linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org" <linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org>, Linux LED Subsystem <linux-leds-u79uwXL29TY76Z2rM5mHXA@public.gmane.org> Subject: Re: dts: fun with chip names Re: [PATCH v3 1/2] dt: bindings: lm3692x: Add bindings for lm3692x LED driver Date: Thu, 16 Nov 2017 15:40:25 -0600 [thread overview] Message-ID: <ec3f88a4-268b-3e4c-56a1-fe38ee1d3097@ti.com> (raw) In-Reply-To: <CAL_Jsq+aysVR9U2Wquwwv7cjjO7wO8EXBg1Ja82u6s5t1yeJUw-JsoAwUIsXosN+BqQ9rBEUg@public.gmane.org> On 11/16/2017 02:36 PM, Rob Herring wrote: > On Thu, Nov 16, 2017 at 2:11 PM, Pavel Machek <pavel-+ZI9xUNit7I@public.gmane.org> wrote: >> Hi! >> >>>>> +Required properties: >>>>> + - compatible: >>>>> + "ti,lm3692x" >>>> >>>> Don't use wildcards in compatible strings. >>> >>> Do you mean to remove the x? How do we denote a family of parts >>> then? >> >> I guess you should specify the exact chip. >> >> Which will present interesting problem for me on Nokia N9/N950; in one >> case, compatible chip is produced by two companies, and it looks like >> some machines have one and some have the other; but we'd like to share >> the dts as user has no chance telling them apart (and it is not >> important, anyway). >> >> In second case, chip is refered as APDS990X and I don't know where to >> get more exact data. > > There's always exceptions to rules. Just make the case for it. IIRC, > there was the same case for the BT chip. > Not sure how I got looped into the dts fun. But I am going to call out the specific chips out in the compatible strings. There are currently only 2 devices supported by this driver. The delta between the chips is one supports a third string of LEDs. 1 bit in 1 register. Dan > Rob > -- ------------------ Dan Murphy -- To unsubscribe from this list: send the line "unsubscribe devicetree" in the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org More majordomo info at http://vger.kernel.org/majordomo-info.html
WARNING: multiple messages have this Message-ID (diff)
From: Dan Murphy <dmurphy@ti.com> To: Rob Herring <robh@kernel.org>, Pavel Machek <pavel@ucw.cz> Cc: Mark Rutland <mark.rutland@arm.com>, Richard Purdie <rpurdie@rpsys.net>, Jacek Anaszewski <jacek.anaszewski@gmail.com>, "devicetree@vger.kernel.org" <devicetree@vger.kernel.org>, "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>, Linux LED Subsystem <linux-leds@vger.kernel.org> Subject: Re: dts: fun with chip names Re: [PATCH v3 1/2] dt: bindings: lm3692x: Add bindings for lm3692x LED driver Date: Thu, 16 Nov 2017 15:40:25 -0600 [thread overview] Message-ID: <ec3f88a4-268b-3e4c-56a1-fe38ee1d3097@ti.com> (raw) In-Reply-To: <CAL_Jsq+aysVR9U2Wquwwv7cjjO7wO8EXBg1Ja82u6s5t1yeJUw@mail.gmail.com> On 11/16/2017 02:36 PM, Rob Herring wrote: > On Thu, Nov 16, 2017 at 2:11 PM, Pavel Machek <pavel@ucw.cz> wrote: >> Hi! >> >>>>> +Required properties: >>>>> + - compatible: >>>>> + "ti,lm3692x" >>>> >>>> Don't use wildcards in compatible strings. >>> >>> Do you mean to remove the x? How do we denote a family of parts >>> then? >> >> I guess you should specify the exact chip. >> >> Which will present interesting problem for me on Nokia N9/N950; in one >> case, compatible chip is produced by two companies, and it looks like >> some machines have one and some have the other; but we'd like to share >> the dts as user has no chance telling them apart (and it is not >> important, anyway). >> >> In second case, chip is refered as APDS990X and I don't know where to >> get more exact data. > > There's always exceptions to rules. Just make the case for it. IIRC, > there was the same case for the BT chip. > Not sure how I got looped into the dts fun. But I am going to call out the specific chips out in the compatible strings. There are currently only 2 devices supported by this driver. The delta between the chips is one supports a third string of LEDs. 1 bit in 1 register. Dan > Rob > -- ------------------ Dan Murphy
next prev parent reply other threads:[~2017-11-16 21:40 UTC|newest] Thread overview: 42+ messages / expand[flat|nested] mbox.gz Atom feed top 2017-11-15 19:42 [PATCH v3 1/2] dt: bindings: lm3692x: Add bindings for lm3692x LED driver Dan Murphy 2017-11-15 19:42 ` Dan Murphy [not found] ` <20171115194203.13572-1-dmurphy-l0cyMroinI0@public.gmane.org> 2017-11-15 19:42 ` [PATCH v3 2/2] leds: lm3692x: Introduce LM3692x dual string driver Dan Murphy 2017-11-15 19:42 ` Dan Murphy [not found] ` <20171115194203.13572-2-dmurphy-l0cyMroinI0@public.gmane.org> 2017-11-15 21:12 ` Pavel Machek 2017-11-15 21:12 ` Pavel Machek 2017-11-15 21:25 ` Dan Murphy 2017-11-15 21:25 ` Dan Murphy 2017-11-18 14:19 ` Jacek Anaszewski 2017-11-18 14:19 ` Jacek Anaszewski 2017-11-28 12:53 ` Dan Murphy 2017-11-28 12:53 ` Dan Murphy 2017-11-15 20:15 ` [PATCH v3 1/2] dt: bindings: lm3692x: Add bindings for lm3692x LED driver Jacek Anaszewski 2017-11-15 20:15 ` Jacek Anaszewski [not found] ` <cb5c5a65-d5a0-86a3-36b4-cf06baae9ec4-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org> 2017-11-15 20:31 ` Dan Murphy 2017-11-15 20:31 ` Dan Murphy [not found] ` <0a78c883-f074-cc19-3c0c-fc05607400e9-l0cyMroinI0@public.gmane.org> 2017-11-15 22:23 ` Pavel Machek 2017-11-15 22:23 ` Pavel Machek 2017-11-16 20:14 ` Jacek Anaszewski [not found] ` <82336eb7-2b89-d37b-d688-4e4302766346-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org> 2017-11-16 21:42 ` Dan Murphy 2017-11-16 21:42 ` Dan Murphy 2017-11-17 2:19 ` Jingoo Han 2017-11-17 2:19 ` Jingoo Han 2017-11-17 11:20 ` Pavel Machek 2017-11-17 16:30 ` Jingoo Han 2017-11-17 16:30 ` Jingoo Han 2017-11-17 18:02 ` Dan Murphy 2017-11-17 18:02 ` Dan Murphy 2017-11-17 23:58 ` Pavel Machek 2017-11-28 17:27 ` Dan Murphy 2017-11-28 17:27 ` Dan Murphy 2017-11-16 15:41 ` Rob Herring 2017-11-16 15:41 ` Rob Herring 2017-11-16 15:45 ` Dan Murphy 2017-11-16 15:45 ` Dan Murphy [not found] ` <d3483e49-650d-1d68-bec6-eeb84d8ac48a-l0cyMroinI0@public.gmane.org> 2017-11-16 15:58 ` Rob Herring 2017-11-16 15:58 ` Rob Herring 2017-11-16 20:11 ` dts: fun with chip names " Pavel Machek 2017-11-16 20:36 ` Rob Herring [not found] ` <CAL_Jsq+aysVR9U2Wquwwv7cjjO7wO8EXBg1Ja82u6s5t1yeJUw-JsoAwUIsXosN+BqQ9rBEUg@public.gmane.org> 2017-11-16 21:40 ` Dan Murphy [this message] 2017-11-16 21:40 ` Dan Murphy 2017-11-18 14:19 ` Jacek Anaszewski
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=ec3f88a4-268b-3e4c-56a1-fe38ee1d3097@ti.com \ --to=dmurphy-l0cymroini0@public.gmane.org \ --cc=devicetree-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \ --cc=jacek.anaszewski-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org \ --cc=linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \ --cc=linux-leds-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \ --cc=mark.rutland-5wv7dgnIgG8@public.gmane.org \ --cc=pavel-+ZI9xUNit7I@public.gmane.org \ --cc=robh-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org \ --cc=rpurdie-Fm38FmjxZ/leoWH0uzbU5w@public.gmane.org \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: linkBe sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.