From: Matthias Brugger <matthias.bgg@gmail.com>
To: Zhiyong Tao <zhiyong.tao@mediatek.com>,
lee.jones@linaro.org, robh+dt@kernel.org, lgirdwood@gmail.com,
broonie@kernel.org, eddie.huang@mediatek.com,
a.zummo@towertech.it, alexandre.belloni@bootlin.com,
fshao@chromium.org
Cc: srv_heupstream@mediatek.com, hui.liu@mediatek.com,
hsin-hsiung.wang@mediatek.com, sean.wang@mediatek.com,
macpaul.lin@mediatek.com, wen.su@mediatek.com,
devicetree@vger.kernel.org, linux-kernel@vger.kernel.org,
linux-rtc@vger.kernel.org,
Project_Global_Chrome_Upstream_Group@mediatek.com,
linux-arm-kernel@lists.infradead.org,
linux-mediatek@lists.infradead.org
Subject: Re: [PATCH v1 1/1] pwrap: mediatek: fix wait time out issue
Date: Tue, 29 Mar 2022 16:44:00 +0200 [thread overview]
Message-ID: <d3b8f78b-24b0-d0f1-f5cd-c3cb29ee25d7@gmail.com> (raw)
In-Reply-To: <20220329115824.13005-2-zhiyong.tao@mediatek.com>
On 29/03/2022 13:58, Zhiyong Tao wrote:
> From: "Zhiyong.Tao" <zhiyong.tao@mediatek.com>
>
> add sleep delay before read "jiffies"
>
> Signed-off-by: Zhiyong.Tao <zhiyong.tao@mediatek.com>
> ---
> drivers/soc/mediatek/mtk-pmic-wrap.c | 8 ++++++--
> 1 file changed, 6 insertions(+), 2 deletions(-)
> mode change 100644 => 100755 drivers/soc/mediatek/mtk-pmic-wrap.c
>
> diff --git a/drivers/soc/mediatek/mtk-pmic-wrap.c b/drivers/soc/mediatek/mtk-pmic-wrap.c
> old mode 100644
> new mode 100755
> index 952bc554f443..ac7139a67e87
> --- a/drivers/soc/mediatek/mtk-pmic-wrap.c
> +++ b/drivers/soc/mediatek/mtk-pmic-wrap.c
> @@ -12,6 +12,7 @@
> #include <linux/platform_device.h>
> #include <linux/regmap.h>
> #include <linux/reset.h>
> +#include <linux/delay.h>
>
> #define PWRAP_MT8135_BRIDGE_IORD_ARB_EN 0x4
> #define PWRAP_MT8135_BRIDGE_WACS3_EN 0x10
> @@ -1197,10 +1198,13 @@ static int pwrap_wait_for_state(struct pmic_wrapper *wrp,
> timeout = jiffies + usecs_to_jiffies(10000);
>
> do {
> - if (time_after(jiffies, timeout))
> - return fp(wrp) ? 0 : -ETIMEDOUT;
> if (fp(wrp))
> return 0;
> +
> + usleep_range(10, 11);
> +
You need to explain this change. Why is it needed, are you sure it does not
break other platforms etc.
I can guess why you need that patch here. In any case in the code you provide,
it would make sense to move the first if out of the do loop and only after this
wait 10 us before reading again. Right now the code does usleep only after every
other read.
Regards,
Matthias
> + if (time_after(jiffies, timeout))
> + return fp(wrp) ? 0 : -ETIMEDOUT;
> } while (1);
> }
>
WARNING: multiple messages have this Message-ID (diff)
From: Matthias Brugger <matthias.bgg@gmail.com>
To: Zhiyong Tao <zhiyong.tao@mediatek.com>,
lee.jones@linaro.org, robh+dt@kernel.org, lgirdwood@gmail.com,
broonie@kernel.org, eddie.huang@mediatek.com,
a.zummo@towertech.it, alexandre.belloni@bootlin.com,
fshao@chromium.org
Cc: srv_heupstream@mediatek.com, hui.liu@mediatek.com,
hsin-hsiung.wang@mediatek.com, sean.wang@mediatek.com,
macpaul.lin@mediatek.com, wen.su@mediatek.com,
devicetree@vger.kernel.org, linux-kernel@vger.kernel.org,
linux-rtc@vger.kernel.org,
Project_Global_Chrome_Upstream_Group@mediatek.com,
linux-arm-kernel@lists.infradead.org,
linux-mediatek@lists.infradead.org
Subject: Re: [PATCH v1 1/1] pwrap: mediatek: fix wait time out issue
Date: Tue, 29 Mar 2022 16:44:00 +0200 [thread overview]
Message-ID: <d3b8f78b-24b0-d0f1-f5cd-c3cb29ee25d7@gmail.com> (raw)
In-Reply-To: <20220329115824.13005-2-zhiyong.tao@mediatek.com>
On 29/03/2022 13:58, Zhiyong Tao wrote:
> From: "Zhiyong.Tao" <zhiyong.tao@mediatek.com>
>
> add sleep delay before read "jiffies"
>
> Signed-off-by: Zhiyong.Tao <zhiyong.tao@mediatek.com>
> ---
> drivers/soc/mediatek/mtk-pmic-wrap.c | 8 ++++++--
> 1 file changed, 6 insertions(+), 2 deletions(-)
> mode change 100644 => 100755 drivers/soc/mediatek/mtk-pmic-wrap.c
>
> diff --git a/drivers/soc/mediatek/mtk-pmic-wrap.c b/drivers/soc/mediatek/mtk-pmic-wrap.c
> old mode 100644
> new mode 100755
> index 952bc554f443..ac7139a67e87
> --- a/drivers/soc/mediatek/mtk-pmic-wrap.c
> +++ b/drivers/soc/mediatek/mtk-pmic-wrap.c
> @@ -12,6 +12,7 @@
> #include <linux/platform_device.h>
> #include <linux/regmap.h>
> #include <linux/reset.h>
> +#include <linux/delay.h>
>
> #define PWRAP_MT8135_BRIDGE_IORD_ARB_EN 0x4
> #define PWRAP_MT8135_BRIDGE_WACS3_EN 0x10
> @@ -1197,10 +1198,13 @@ static int pwrap_wait_for_state(struct pmic_wrapper *wrp,
> timeout = jiffies + usecs_to_jiffies(10000);
>
> do {
> - if (time_after(jiffies, timeout))
> - return fp(wrp) ? 0 : -ETIMEDOUT;
> if (fp(wrp))
> return 0;
> +
> + usleep_range(10, 11);
> +
You need to explain this change. Why is it needed, are you sure it does not
break other platforms etc.
I can guess why you need that patch here. In any case in the code you provide,
it would make sense to move the first if out of the do loop and only after this
wait 10 us before reading again. Right now the code does usleep only after every
other read.
Regards,
Matthias
> + if (time_after(jiffies, timeout))
> + return fp(wrp) ? 0 : -ETIMEDOUT;
> } while (1);
> }
>
_______________________________________________
Linux-mediatek mailing list
Linux-mediatek@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-mediatek
WARNING: multiple messages have this Message-ID (diff)
From: Matthias Brugger <matthias.bgg@gmail.com>
To: Zhiyong Tao <zhiyong.tao@mediatek.com>,
lee.jones@linaro.org, robh+dt@kernel.org, lgirdwood@gmail.com,
broonie@kernel.org, eddie.huang@mediatek.com,
a.zummo@towertech.it, alexandre.belloni@bootlin.com,
fshao@chromium.org
Cc: srv_heupstream@mediatek.com, hui.liu@mediatek.com,
hsin-hsiung.wang@mediatek.com, sean.wang@mediatek.com,
macpaul.lin@mediatek.com, wen.su@mediatek.com,
devicetree@vger.kernel.org, linux-kernel@vger.kernel.org,
linux-rtc@vger.kernel.org,
Project_Global_Chrome_Upstream_Group@mediatek.com,
linux-arm-kernel@lists.infradead.org,
linux-mediatek@lists.infradead.org
Subject: Re: [PATCH v1 1/1] pwrap: mediatek: fix wait time out issue
Date: Tue, 29 Mar 2022 16:44:00 +0200 [thread overview]
Message-ID: <d3b8f78b-24b0-d0f1-f5cd-c3cb29ee25d7@gmail.com> (raw)
In-Reply-To: <20220329115824.13005-2-zhiyong.tao@mediatek.com>
On 29/03/2022 13:58, Zhiyong Tao wrote:
> From: "Zhiyong.Tao" <zhiyong.tao@mediatek.com>
>
> add sleep delay before read "jiffies"
>
> Signed-off-by: Zhiyong.Tao <zhiyong.tao@mediatek.com>
> ---
> drivers/soc/mediatek/mtk-pmic-wrap.c | 8 ++++++--
> 1 file changed, 6 insertions(+), 2 deletions(-)
> mode change 100644 => 100755 drivers/soc/mediatek/mtk-pmic-wrap.c
>
> diff --git a/drivers/soc/mediatek/mtk-pmic-wrap.c b/drivers/soc/mediatek/mtk-pmic-wrap.c
> old mode 100644
> new mode 100755
> index 952bc554f443..ac7139a67e87
> --- a/drivers/soc/mediatek/mtk-pmic-wrap.c
> +++ b/drivers/soc/mediatek/mtk-pmic-wrap.c
> @@ -12,6 +12,7 @@
> #include <linux/platform_device.h>
> #include <linux/regmap.h>
> #include <linux/reset.h>
> +#include <linux/delay.h>
>
> #define PWRAP_MT8135_BRIDGE_IORD_ARB_EN 0x4
> #define PWRAP_MT8135_BRIDGE_WACS3_EN 0x10
> @@ -1197,10 +1198,13 @@ static int pwrap_wait_for_state(struct pmic_wrapper *wrp,
> timeout = jiffies + usecs_to_jiffies(10000);
>
> do {
> - if (time_after(jiffies, timeout))
> - return fp(wrp) ? 0 : -ETIMEDOUT;
> if (fp(wrp))
> return 0;
> +
> + usleep_range(10, 11);
> +
You need to explain this change. Why is it needed, are you sure it does not
break other platforms etc.
I can guess why you need that patch here. In any case in the code you provide,
it would make sense to move the first if out of the do loop and only after this
wait 10 us before reading again. Right now the code does usleep only after every
other read.
Regards,
Matthias
> + if (time_after(jiffies, timeout))
> + return fp(wrp) ? 0 : -ETIMEDOUT;
> } while (1);
> }
>
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
next prev parent reply other threads:[~2022-03-29 14:44 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-03-29 11:58 [PATCH v1 0/1] Mediatek PMIC patch Zhiyong Tao
2022-03-29 11:58 ` Zhiyong Tao
2022-03-29 11:58 ` Zhiyong Tao
2022-03-29 11:58 ` [PATCH v1 1/1] pwrap: mediatek: fix wait time out issue Zhiyong Tao
2022-03-29 11:58 ` Zhiyong Tao
2022-03-29 11:58 ` Zhiyong Tao
2022-03-29 14:44 ` Matthias Brugger [this message]
2022-03-29 14:44 ` Matthias Brugger
2022-03-29 14:44 ` Matthias Brugger
2022-04-18 1:29 ` zhiyong.tao
2022-04-18 1:29 ` zhiyong.tao
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=d3b8f78b-24b0-d0f1-f5cd-c3cb29ee25d7@gmail.com \
--to=matthias.bgg@gmail.com \
--cc=Project_Global_Chrome_Upstream_Group@mediatek.com \
--cc=a.zummo@towertech.it \
--cc=alexandre.belloni@bootlin.com \
--cc=broonie@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=eddie.huang@mediatek.com \
--cc=fshao@chromium.org \
--cc=hsin-hsiung.wang@mediatek.com \
--cc=hui.liu@mediatek.com \
--cc=lee.jones@linaro.org \
--cc=lgirdwood@gmail.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mediatek@lists.infradead.org \
--cc=linux-rtc@vger.kernel.org \
--cc=macpaul.lin@mediatek.com \
--cc=robh+dt@kernel.org \
--cc=sean.wang@mediatek.com \
--cc=srv_heupstream@mediatek.com \
--cc=wen.su@mediatek.com \
--cc=zhiyong.tao@mediatek.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.