* [PATCH] xen: Move xen_have_vector_callback definition to enlighten.c
@ 2017-05-02 17:23 ` Boris Ostrovsky
0 siblings, 0 replies; 8+ messages in thread
From: Boris Ostrovsky @ 2017-05-02 17:23 UTC (permalink / raw)
To: jgross; +Cc: xen-devel, Boris Ostrovsky, rdunlap, linux-kernel
Commit 84d582d236dc ("xen: Revert commits da72ff5bfcb0 and
72a9b186292d") defined xen_have_vector_callback in enlighten_hvm.c.
Since guest-type-neutral code refers to this variable this causes
build failures when CONFIG_XEN_PVHVM is not defined.
Moving xen_have_vector_callback definition to enlighten.c resolves
this issue.
Signed-off-by: Boris Ostrovsky <boris.ostrovsky@oracle.com>
Reported-by: Randy Dunlap <rdunlap@infradead.org>
---
arch/x86/xen/enlighten.c | 3 +++
arch/x86/xen/enlighten_hvm.c | 3 ---
2 files changed, 3 insertions(+), 3 deletions(-)
diff --git a/arch/x86/xen/enlighten.c b/arch/x86/xen/enlighten.c
index 41d324c..a5ffcbb 100644
--- a/arch/x86/xen/enlighten.c
+++ b/arch/x86/xen/enlighten.c
@@ -57,6 +57,9 @@ EXPORT_SYMBOL_GPL(xen_start_info);
struct shared_info xen_dummy_shared_info;
+__read_mostly int xen_have_vector_callback;
+EXPORT_SYMBOL_GPL(xen_have_vector_callback);
+
/*
* Point at some empty memory to start with. We map the real shared_info
* page as soon as fixmap is up and running.
diff --git a/arch/x86/xen/enlighten_hvm.c b/arch/x86/xen/enlighten_hvm.c
index 078c512..a6d014f 100644
--- a/arch/x86/xen/enlighten_hvm.c
+++ b/arch/x86/xen/enlighten_hvm.c
@@ -18,9 +18,6 @@
#include "mmu.h"
#include "smp.h"
-__read_mostly int xen_have_vector_callback;
-EXPORT_SYMBOL_GPL(xen_have_vector_callback);
-
void __ref xen_hvm_init_shared_info(void)
{
int cpu;
--
2.7.4
_______________________________________________
Xen-devel mailing list
Xen-devel@lists.xen.org
https://lists.xen.org/xen-devel
^ permalink raw reply related [flat|nested] 8+ messages in thread* Re: [PATCH] xen: Move xen_have_vector_callback definition to enlighten.c
2017-05-02 17:23 ` Boris Ostrovsky
(?)
@ 2017-05-03 0:22 ` Randy Dunlap
-1 siblings, 0 replies; 8+ messages in thread
From: Randy Dunlap @ 2017-05-03 0:22 UTC (permalink / raw)
To: Boris Ostrovsky, jgross; +Cc: xen-devel, linux-kernel
On 05/02/17 10:23, Boris Ostrovsky wrote:
> Commit 84d582d236dc ("xen: Revert commits da72ff5bfcb0 and
> 72a9b186292d") defined xen_have_vector_callback in enlighten_hvm.c.
> Since guest-type-neutral code refers to this variable this causes
> build failures when CONFIG_XEN_PVHVM is not defined.
>
> Moving xen_have_vector_callback definition to enlighten.c resolves
> this issue.
>
> Signed-off-by: Boris Ostrovsky <boris.ostrovsky@oracle.com>
> Reported-by: Randy Dunlap <rdunlap@infradead.org>
Works for me. Thanks.
Acked-by: Randy Dunlap <rdunlap@infradead.org>
> ---
> arch/x86/xen/enlighten.c | 3 +++
> arch/x86/xen/enlighten_hvm.c | 3 ---
> 2 files changed, 3 insertions(+), 3 deletions(-)
>
> diff --git a/arch/x86/xen/enlighten.c b/arch/x86/xen/enlighten.c
> index 41d324c..a5ffcbb 100644
> --- a/arch/x86/xen/enlighten.c
> +++ b/arch/x86/xen/enlighten.c
> @@ -57,6 +57,9 @@ EXPORT_SYMBOL_GPL(xen_start_info);
>
> struct shared_info xen_dummy_shared_info;
>
> +__read_mostly int xen_have_vector_callback;
> +EXPORT_SYMBOL_GPL(xen_have_vector_callback);
> +
> /*
> * Point at some empty memory to start with. We map the real shared_info
> * page as soon as fixmap is up and running.
> diff --git a/arch/x86/xen/enlighten_hvm.c b/arch/x86/xen/enlighten_hvm.c
> index 078c512..a6d014f 100644
> --- a/arch/x86/xen/enlighten_hvm.c
> +++ b/arch/x86/xen/enlighten_hvm.c
> @@ -18,9 +18,6 @@
> #include "mmu.h"
> #include "smp.h"
>
> -__read_mostly int xen_have_vector_callback;
> -EXPORT_SYMBOL_GPL(xen_have_vector_callback);
> -
> void __ref xen_hvm_init_shared_info(void)
> {
> int cpu;
>
--
~Randy
_______________________________________________
Xen-devel mailing list
Xen-devel@lists.xen.org
https://lists.xen.org/xen-devel
^ permalink raw reply [flat|nested] 8+ messages in thread* Re: [PATCH] xen: Move xen_have_vector_callback definition to enlighten.c
2017-05-02 17:23 ` Boris Ostrovsky
(?)
(?)
@ 2017-05-03 0:22 ` Randy Dunlap
-1 siblings, 0 replies; 8+ messages in thread
From: Randy Dunlap @ 2017-05-03 0:22 UTC (permalink / raw)
To: Boris Ostrovsky, jgross; +Cc: xen-devel, linux-kernel
On 05/02/17 10:23, Boris Ostrovsky wrote:
> Commit 84d582d236dc ("xen: Revert commits da72ff5bfcb0 and
> 72a9b186292d") defined xen_have_vector_callback in enlighten_hvm.c.
> Since guest-type-neutral code refers to this variable this causes
> build failures when CONFIG_XEN_PVHVM is not defined.
>
> Moving xen_have_vector_callback definition to enlighten.c resolves
> this issue.
>
> Signed-off-by: Boris Ostrovsky <boris.ostrovsky@oracle.com>
> Reported-by: Randy Dunlap <rdunlap@infradead.org>
Works for me. Thanks.
Acked-by: Randy Dunlap <rdunlap@infradead.org>
> ---
> arch/x86/xen/enlighten.c | 3 +++
> arch/x86/xen/enlighten_hvm.c | 3 ---
> 2 files changed, 3 insertions(+), 3 deletions(-)
>
> diff --git a/arch/x86/xen/enlighten.c b/arch/x86/xen/enlighten.c
> index 41d324c..a5ffcbb 100644
> --- a/arch/x86/xen/enlighten.c
> +++ b/arch/x86/xen/enlighten.c
> @@ -57,6 +57,9 @@ EXPORT_SYMBOL_GPL(xen_start_info);
>
> struct shared_info xen_dummy_shared_info;
>
> +__read_mostly int xen_have_vector_callback;
> +EXPORT_SYMBOL_GPL(xen_have_vector_callback);
> +
> /*
> * Point at some empty memory to start with. We map the real shared_info
> * page as soon as fixmap is up and running.
> diff --git a/arch/x86/xen/enlighten_hvm.c b/arch/x86/xen/enlighten_hvm.c
> index 078c512..a6d014f 100644
> --- a/arch/x86/xen/enlighten_hvm.c
> +++ b/arch/x86/xen/enlighten_hvm.c
> @@ -18,9 +18,6 @@
> #include "mmu.h"
> #include "smp.h"
>
> -__read_mostly int xen_have_vector_callback;
> -EXPORT_SYMBOL_GPL(xen_have_vector_callback);
> -
> void __ref xen_hvm_init_shared_info(void)
> {
> int cpu;
>
--
~Randy
^ permalink raw reply [flat|nested] 8+ messages in thread* Re: [PATCH] xen: Move xen_have_vector_callback definition to enlighten.c
2017-05-02 17:23 ` Boris Ostrovsky
` (2 preceding siblings ...)
(?)
@ 2017-05-03 3:59 ` Juergen Gross
-1 siblings, 0 replies; 8+ messages in thread
From: Juergen Gross @ 2017-05-03 3:59 UTC (permalink / raw)
To: Boris Ostrovsky; +Cc: xen-devel, rdunlap, linux-kernel
On 02/05/17 19:23, Boris Ostrovsky wrote:
> Commit 84d582d236dc ("xen: Revert commits da72ff5bfcb0 and
> 72a9b186292d") defined xen_have_vector_callback in enlighten_hvm.c.
> Since guest-type-neutral code refers to this variable this causes
> build failures when CONFIG_XEN_PVHVM is not defined.
>
> Moving xen_have_vector_callback definition to enlighten.c resolves
> this issue.
>
> Signed-off-by: Boris Ostrovsky <boris.ostrovsky@oracle.com>
> Reported-by: Randy Dunlap <rdunlap@infradead.org>
Reviewed-by: Juergen Gross <jgross@suse.com>
Thanks,
Juergen
_______________________________________________
Xen-devel mailing list
Xen-devel@lists.xen.org
https://lists.xen.org/xen-devel
^ permalink raw reply [flat|nested] 8+ messages in thread* Re: [PATCH] xen: Move xen_have_vector_callback definition to enlighten.c
2017-05-02 17:23 ` Boris Ostrovsky
` (3 preceding siblings ...)
(?)
@ 2017-05-03 3:59 ` Juergen Gross
-1 siblings, 0 replies; 8+ messages in thread
From: Juergen Gross @ 2017-05-03 3:59 UTC (permalink / raw)
To: Boris Ostrovsky; +Cc: xen-devel, linux-kernel, rdunlap
On 02/05/17 19:23, Boris Ostrovsky wrote:
> Commit 84d582d236dc ("xen: Revert commits da72ff5bfcb0 and
> 72a9b186292d") defined xen_have_vector_callback in enlighten_hvm.c.
> Since guest-type-neutral code refers to this variable this causes
> build failures when CONFIG_XEN_PVHVM is not defined.
>
> Moving xen_have_vector_callback definition to enlighten.c resolves
> this issue.
>
> Signed-off-by: Boris Ostrovsky <boris.ostrovsky@oracle.com>
> Reported-by: Randy Dunlap <rdunlap@infradead.org>
Reviewed-by: Juergen Gross <jgross@suse.com>
Thanks,
Juergen
^ permalink raw reply [flat|nested] 8+ messages in thread* Re: [PATCH] xen: Move xen_have_vector_callback definition to enlighten.c
2017-05-02 17:23 ` Boris Ostrovsky
` (4 preceding siblings ...)
(?)
@ 2017-05-03 4:47 ` Juergen Gross
-1 siblings, 0 replies; 8+ messages in thread
From: Juergen Gross @ 2017-05-03 4:47 UTC (permalink / raw)
To: Boris Ostrovsky; +Cc: xen-devel, rdunlap, linux-kernel
On 02/05/17 19:23, Boris Ostrovsky wrote:
> Commit 84d582d236dc ("xen: Revert commits da72ff5bfcb0 and
> 72a9b186292d") defined xen_have_vector_callback in enlighten_hvm.c.
> Since guest-type-neutral code refers to this variable this causes
> build failures when CONFIG_XEN_PVHVM is not defined.
>
> Moving xen_have_vector_callback definition to enlighten.c resolves
> this issue.
>
> Signed-off-by: Boris Ostrovsky <boris.ostrovsky@oracle.com>
> Reported-by: Randy Dunlap <rdunlap@infradead.org>
Pushed to xen/tip for-linus-4.12b
Thanks,
Juergen
_______________________________________________
Xen-devel mailing list
Xen-devel@lists.xen.org
https://lists.xen.org/xen-devel
^ permalink raw reply [flat|nested] 8+ messages in thread* Re: [PATCH] xen: Move xen_have_vector_callback definition to enlighten.c
2017-05-02 17:23 ` Boris Ostrovsky
` (5 preceding siblings ...)
(?)
@ 2017-05-03 4:47 ` Juergen Gross
-1 siblings, 0 replies; 8+ messages in thread
From: Juergen Gross @ 2017-05-03 4:47 UTC (permalink / raw)
To: Boris Ostrovsky; +Cc: xen-devel, linux-kernel, rdunlap
On 02/05/17 19:23, Boris Ostrovsky wrote:
> Commit 84d582d236dc ("xen: Revert commits da72ff5bfcb0 and
> 72a9b186292d") defined xen_have_vector_callback in enlighten_hvm.c.
> Since guest-type-neutral code refers to this variable this causes
> build failures when CONFIG_XEN_PVHVM is not defined.
>
> Moving xen_have_vector_callback definition to enlighten.c resolves
> this issue.
>
> Signed-off-by: Boris Ostrovsky <boris.ostrovsky@oracle.com>
> Reported-by: Randy Dunlap <rdunlap@infradead.org>
Pushed to xen/tip for-linus-4.12b
Thanks,
Juergen
^ permalink raw reply [flat|nested] 8+ messages in thread