All of lore.kernel.org
 help / color / mirror / Atom feed
From: Grygorii Strashko <grygorii.strashko@ti.com>
To: Ivan Khoronzhuk <ivan.khoronzhuk@linaro.org>
Cc: <davem@davemloft.net>, <linux-omap@vger.kernel.org>,
	<netdev@vger.kernel.org>, <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH] net: ethernet: ti: cpsw: fix tx vlan priority mapping
Date: Thu, 12 Apr 2018 15:15:23 -0500	[thread overview]
Message-ID: <d4456c5c-6746-dd57-303f-cc2174e5a2e7@ti.com> (raw)
In-Reply-To: <1523543140-20747-1-git-send-email-ivan.khoronzhuk@linaro.org>



On 04/12/2018 09:25 AM, Ivan Khoronzhuk wrote:
> The CPDMA_TX_PRIORITY_MAP in real is vlan pcp field priority mapping
> register and basically replaces vlan pcp field for tagged packets.
> So, set it to be 1:1 mapping.

"Otherwise, it will cause unexpected change of egress vlan tagged packets,
 like prio 2 -> prio 5"


> 
> Signed-off-by: Ivan Khoronzhuk <ivan.khoronzhuk@linaro.org>
> ---
> Based on net/master

Fixes: e05 107 e6b 747 ("net: ethernet: ti: cpsw: add multi queue support")

Reviewed-by: Grygorii Strashko <grygorii.strashko@ti.com> 

> 
>   drivers/net/ethernet/ti/cpsw.c | 2 +-
>   1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/drivers/net/ethernet/ti/cpsw.c b/drivers/net/ethernet/ti/cpsw.c
> index 3037127..74f8284 100644
> --- a/drivers/net/ethernet/ti/cpsw.c
> +++ b/drivers/net/ethernet/ti/cpsw.c
> @@ -129,7 +129,7 @@ do {								\
>   
>   #define RX_PRIORITY_MAPPING	0x76543210
>   #define TX_PRIORITY_MAPPING	0x33221100
> -#define CPDMA_TX_PRIORITY_MAP	0x01234567
> +#define CPDMA_TX_PRIORITY_MAP	0x76543210
>   
>   #define CPSW_VLAN_AWARE		BIT(1)
>   #define CPSW_RX_VLAN_ENCAP	BIT(2)
> 

-- 
regards,
-grygorii

WARNING: multiple messages have this Message-ID (diff)
From: Grygorii Strashko <grygorii.strashko@ti.com>
To: Ivan Khoronzhuk <ivan.khoronzhuk@linaro.org>
Cc: davem@davemloft.net, linux-omap@vger.kernel.org,
	netdev@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] net: ethernet: ti: cpsw: fix tx vlan priority mapping
Date: Thu, 12 Apr 2018 15:15:23 -0500	[thread overview]
Message-ID: <d4456c5c-6746-dd57-303f-cc2174e5a2e7@ti.com> (raw)
In-Reply-To: <1523543140-20747-1-git-send-email-ivan.khoronzhuk@linaro.org>



On 04/12/2018 09:25 AM, Ivan Khoronzhuk wrote:
> The CPDMA_TX_PRIORITY_MAP in real is vlan pcp field priority mapping
> register and basically replaces vlan pcp field for tagged packets.
> So, set it to be 1:1 mapping.

"Otherwise, it will cause unexpected change of egress vlan tagged packets,
 like prio 2 -> prio 5"


> 
> Signed-off-by: Ivan Khoronzhuk <ivan.khoronzhuk@linaro.org>
> ---
> Based on net/master

Fixes: e05 107 e6b 747 ("net: ethernet: ti: cpsw: add multi queue support")

Reviewed-by: Grygorii Strashko <grygorii.strashko@ti.com> 

> 
>   drivers/net/ethernet/ti/cpsw.c | 2 +-
>   1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/drivers/net/ethernet/ti/cpsw.c b/drivers/net/ethernet/ti/cpsw.c
> index 3037127..74f8284 100644
> --- a/drivers/net/ethernet/ti/cpsw.c
> +++ b/drivers/net/ethernet/ti/cpsw.c
> @@ -129,7 +129,7 @@ do {								\
>   
>   #define RX_PRIORITY_MAPPING	0x76543210
>   #define TX_PRIORITY_MAPPING	0x33221100
> -#define CPDMA_TX_PRIORITY_MAP	0x01234567
> +#define CPDMA_TX_PRIORITY_MAP	0x76543210
>   
>   #define CPSW_VLAN_AWARE		BIT(1)
>   #define CPSW_RX_VLAN_ENCAP	BIT(2)
> 

-- 
regards,
-grygorii

  reply	other threads:[~2018-04-12 20:15 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-04-12 14:25 [PATCH] net: ethernet: ti: cpsw: fix tx vlan priority mapping Ivan Khoronzhuk
2018-04-12 20:15 ` Grygorii Strashko [this message]
2018-04-12 20:15   ` Grygorii Strashko

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=d4456c5c-6746-dd57-303f-cc2174e5a2e7@ti.com \
    --to=grygorii.strashko@ti.com \
    --cc=davem@davemloft.net \
    --cc=ivan.khoronzhuk@linaro.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-omap@vger.kernel.org \
    --cc=netdev@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.