* [PATCH] net: ethernet: ti: cpsw: fix tx vlan priority mapping
@ 2018-04-12 14:25 Ivan Khoronzhuk
2018-04-12 20:15 ` Grygorii Strashko
0 siblings, 1 reply; 3+ messages in thread
From: Ivan Khoronzhuk @ 2018-04-12 14:25 UTC (permalink / raw)
To: grygorii.strashko
Cc: davem, linux-omap, netdev, linux-kernel, Ivan Khoronzhuk
The CPDMA_TX_PRIORITY_MAP in real is vlan pcp field priority mapping
register and basically replaces vlan pcp field for tagged packets.
So, set it to be 1:1 mapping.
Signed-off-by: Ivan Khoronzhuk <ivan.khoronzhuk@linaro.org>
---
Based on net/master
drivers/net/ethernet/ti/cpsw.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/net/ethernet/ti/cpsw.c b/drivers/net/ethernet/ti/cpsw.c
index 3037127..74f8284 100644
--- a/drivers/net/ethernet/ti/cpsw.c
+++ b/drivers/net/ethernet/ti/cpsw.c
@@ -129,7 +129,7 @@ do { \
#define RX_PRIORITY_MAPPING 0x76543210
#define TX_PRIORITY_MAPPING 0x33221100
-#define CPDMA_TX_PRIORITY_MAP 0x01234567
+#define CPDMA_TX_PRIORITY_MAP 0x76543210
#define CPSW_VLAN_AWARE BIT(1)
#define CPSW_RX_VLAN_ENCAP BIT(2)
--
2.7.4
^ permalink raw reply related [flat|nested] 3+ messages in thread* Re: [PATCH] net: ethernet: ti: cpsw: fix tx vlan priority mapping
2018-04-12 14:25 [PATCH] net: ethernet: ti: cpsw: fix tx vlan priority mapping Ivan Khoronzhuk
@ 2018-04-12 20:15 ` Grygorii Strashko
0 siblings, 0 replies; 3+ messages in thread
From: Grygorii Strashko @ 2018-04-12 20:15 UTC (permalink / raw)
To: Ivan Khoronzhuk; +Cc: davem, linux-omap, netdev, linux-kernel
On 04/12/2018 09:25 AM, Ivan Khoronzhuk wrote:
> The CPDMA_TX_PRIORITY_MAP in real is vlan pcp field priority mapping
> register and basically replaces vlan pcp field for tagged packets.
> So, set it to be 1:1 mapping.
"Otherwise, it will cause unexpected change of egress vlan tagged packets,
like prio 2 -> prio 5"
>
> Signed-off-by: Ivan Khoronzhuk <ivan.khoronzhuk@linaro.org>
> ---
> Based on net/master
Fixes: e05 107 e6b 747 ("net: ethernet: ti: cpsw: add multi queue support")
Reviewed-by: Grygorii Strashko <grygorii.strashko@ti.com>
>
> drivers/net/ethernet/ti/cpsw.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/net/ethernet/ti/cpsw.c b/drivers/net/ethernet/ti/cpsw.c
> index 3037127..74f8284 100644
> --- a/drivers/net/ethernet/ti/cpsw.c
> +++ b/drivers/net/ethernet/ti/cpsw.c
> @@ -129,7 +129,7 @@ do { \
>
> #define RX_PRIORITY_MAPPING 0x76543210
> #define TX_PRIORITY_MAPPING 0x33221100
> -#define CPDMA_TX_PRIORITY_MAP 0x01234567
> +#define CPDMA_TX_PRIORITY_MAP 0x76543210
>
> #define CPSW_VLAN_AWARE BIT(1)
> #define CPSW_RX_VLAN_ENCAP BIT(2)
>
--
regards,
-grygorii
^ permalink raw reply [flat|nested] 3+ messages in thread* Re: [PATCH] net: ethernet: ti: cpsw: fix tx vlan priority mapping
@ 2018-04-12 20:15 ` Grygorii Strashko
0 siblings, 0 replies; 3+ messages in thread
From: Grygorii Strashko @ 2018-04-12 20:15 UTC (permalink / raw)
To: Ivan Khoronzhuk; +Cc: davem, linux-omap, netdev, linux-kernel
On 04/12/2018 09:25 AM, Ivan Khoronzhuk wrote:
> The CPDMA_TX_PRIORITY_MAP in real is vlan pcp field priority mapping
> register and basically replaces vlan pcp field for tagged packets.
> So, set it to be 1:1 mapping.
"Otherwise, it will cause unexpected change of egress vlan tagged packets,
like prio 2 -> prio 5"
>
> Signed-off-by: Ivan Khoronzhuk <ivan.khoronzhuk@linaro.org>
> ---
> Based on net/master
Fixes: e05 107 e6b 747 ("net: ethernet: ti: cpsw: add multi queue support")
Reviewed-by: Grygorii Strashko <grygorii.strashko@ti.com>
>
> drivers/net/ethernet/ti/cpsw.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/net/ethernet/ti/cpsw.c b/drivers/net/ethernet/ti/cpsw.c
> index 3037127..74f8284 100644
> --- a/drivers/net/ethernet/ti/cpsw.c
> +++ b/drivers/net/ethernet/ti/cpsw.c
> @@ -129,7 +129,7 @@ do { \
>
> #define RX_PRIORITY_MAPPING 0x76543210
> #define TX_PRIORITY_MAPPING 0x33221100
> -#define CPDMA_TX_PRIORITY_MAP 0x01234567
> +#define CPDMA_TX_PRIORITY_MAP 0x76543210
>
> #define CPSW_VLAN_AWARE BIT(1)
> #define CPSW_RX_VLAN_ENCAP BIT(2)
>
--
regards,
-grygorii
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2018-04-12 20:15 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2018-04-12 14:25 [PATCH] net: ethernet: ti: cpsw: fix tx vlan priority mapping Ivan Khoronzhuk
2018-04-12 20:15 ` Grygorii Strashko
2018-04-12 20:15 ` Grygorii Strashko
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.