From: Richard Henderson <richard.henderson@linaro.org>
To: "Frédéric Pétrot" <frederic.petrot@univ-grenoble-alpes.fr>,
qemu-devel@nongnu.org, qemu-riscv@nongnu.org
Cc: Alistair Francis <alistair.francis@wdc.com>,
Bin Meng <bin.meng@windriver.com>,
Palmer Dabbelt <palmer@dabbelt.com>,
Fabien Portas <fabien.portas@grenoble-inp.org>
Subject: Re: [PATCH 3/8] target/riscv: Addition of 128-bit ldu, lq and sq instructions
Date: Mon, 30 Aug 2021 19:24:06 -0700 [thread overview]
Message-ID: <d494ea6e-4eed-7d74-b9f7-130201a8294f@linaro.org> (raw)
In-Reply-To: <20210830171638.126325-3-frederic.petrot@univ-grenoble-alpes.fr>
On 8/30/21 10:16 AM, Frédéric Pétrot wrote:
> +#if defined(TARGET_RISCV128)
> +/*
> + * Accessing signed 64-bit or 128-bit values should be part of MemOp in
> + * include/exec/memop.h
> + * Unfortunately, this requires to change the defines there, as MO_SIGN is 4,
> + * and values 0 to 3 are usual types sizes.
> + * Note that an assert is triggered when MemOp is MO_SIGN|MO_TEQ, this value
> + * being some kind of sentinel.
https://lore.kernel.org/qemu-devel/20210818191920.390759-24-richard.henderson@linaro.org/
r~
WARNING: multiple messages have this Message-ID (diff)
From: Richard Henderson <richard.henderson@linaro.org>
To: "Frédéric Pétrot" <frederic.petrot@univ-grenoble-alpes.fr>,
qemu-devel@nongnu.org, qemu-riscv@nongnu.org
Cc: Fabien Portas <fabien.portas@grenoble-inp.org>,
Palmer Dabbelt <palmer@dabbelt.com>,
Alistair Francis <alistair.francis@wdc.com>,
Bin Meng <bin.meng@windriver.com>
Subject: Re: [PATCH 3/8] target/riscv: Addition of 128-bit ldu, lq and sq instructions
Date: Mon, 30 Aug 2021 19:24:06 -0700 [thread overview]
Message-ID: <d494ea6e-4eed-7d74-b9f7-130201a8294f@linaro.org> (raw)
In-Reply-To: <20210830171638.126325-3-frederic.petrot@univ-grenoble-alpes.fr>
On 8/30/21 10:16 AM, Frédéric Pétrot wrote:
> +#if defined(TARGET_RISCV128)
> +/*
> + * Accessing signed 64-bit or 128-bit values should be part of MemOp in
> + * include/exec/memop.h
> + * Unfortunately, this requires to change the defines there, as MO_SIGN is 4,
> + * and values 0 to 3 are usual types sizes.
> + * Note that an assert is triggered when MemOp is MO_SIGN|MO_TEQ, this value
> + * being some kind of sentinel.
https://lore.kernel.org/qemu-devel/20210818191920.390759-24-richard.henderson@linaro.org/
r~
next prev parent reply other threads:[~2021-08-31 2:25 UTC|newest]
Thread overview: 44+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-08-30 17:16 [PATCH 1/8] target/riscv: Settings for 128-bit extension support Frédéric Pétrot
2021-08-30 17:16 ` Frédéric Pétrot
2021-08-30 17:16 ` [PATCH 2/8] target/riscv: 128-bit registers creation and access Frédéric Pétrot
2021-08-30 17:16 ` Frédéric Pétrot
2021-08-30 21:34 ` Philippe Mathieu-Daudé
2021-08-30 21:34 ` Philippe Mathieu-Daudé
2021-08-30 17:16 ` [PATCH 3/8] target/riscv: Addition of 128-bit ldu, lq and sq instructions Frédéric Pétrot
2021-08-30 17:16 ` Frédéric Pétrot
2021-08-30 21:35 ` Philippe Mathieu-Daudé
2021-08-30 21:35 ` Philippe Mathieu-Daudé
2021-08-31 2:24 ` Richard Henderson [this message]
2021-08-31 2:24 ` Richard Henderson
2021-08-31 16:00 ` Frédéric Pétrot
2021-08-31 16:00 ` Frédéric Pétrot
2021-08-31 2:30 ` Richard Henderson
2021-08-31 2:30 ` Richard Henderson
2021-08-30 17:16 ` [PATCH 4/8] target/riscv: 128-bit arithmetic and logic instructions Frédéric Pétrot
2021-08-30 17:16 ` Frédéric Pétrot
2021-08-30 21:38 ` Philippe Mathieu-Daudé
2021-08-30 21:38 ` Philippe Mathieu-Daudé
2021-08-30 21:40 ` Philippe Mathieu-Daudé
2021-08-30 21:40 ` Philippe Mathieu-Daudé
2021-08-31 15:57 ` Frédéric Pétrot
2021-08-31 15:57 ` Frédéric Pétrot
2021-08-31 3:32 ` Richard Henderson
2021-08-31 3:32 ` Richard Henderson
2021-08-31 3:30 ` Richard Henderson
2021-08-31 3:30 ` Richard Henderson
2021-08-30 17:16 ` [PATCH 5/8] target/riscv: 128-bit multiply and divide Frédéric Pétrot
2021-08-30 17:16 ` Frédéric Pétrot
2021-08-30 17:16 ` [PATCH 6/8] target/riscv: Support of compiler's 128-bit integer types Frédéric Pétrot
2021-08-30 17:16 ` Frédéric Pétrot
2021-08-31 3:38 ` Richard Henderson
2021-08-31 3:38 ` Richard Henderson
2021-08-30 17:16 ` [PATCH 7/8] target/riscv: 128-bit support for some csrs Frédéric Pétrot
2021-08-30 17:16 ` Frédéric Pétrot
2021-08-31 3:43 ` Richard Henderson
2021-08-31 3:43 ` Richard Henderson
2021-08-30 17:16 ` [PATCH 8/8] target/riscv: Support for 128-bit satp Frédéric Pétrot
2021-08-30 17:16 ` Frédéric Pétrot
2021-08-31 3:13 ` [PATCH 1/8] target/riscv: Settings for 128-bit extension support Alistair Francis
2021-08-31 3:13 ` Alistair Francis
2021-08-31 16:20 ` Frédéric Pétrot
2021-08-31 16:20 ` Frédéric Pétrot
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=d494ea6e-4eed-7d74-b9f7-130201a8294f@linaro.org \
--to=richard.henderson@linaro.org \
--cc=alistair.francis@wdc.com \
--cc=bin.meng@windriver.com \
--cc=fabien.portas@grenoble-inp.org \
--cc=frederic.petrot@univ-grenoble-alpes.fr \
--cc=palmer@dabbelt.com \
--cc=qemu-devel@nongnu.org \
--cc=qemu-riscv@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.