From: Sergei Shtylyov <sergei.shtylyov@cogentembedded.com>
To: Vladimir Barinov <vladimir.barinov@cogentembedded.com>,
Simon Horman <horms+renesas@verge.net.au>,
linux-renesas-soc@vger.kernel.org
Cc: linux-arm-kernel@lists.infradead.org,
Magnus Damm <magnus.damm@gmail.com>
Subject: Re: [PATCH 16/18] arm64: dts: h3ulcb: rename SDHI0 pins
Date: Tue, 22 Nov 2016 14:40:25 +0300 [thread overview]
Message-ID: <d4fbb71f-2a4d-2239-faa9-c017c74e1d79@cogentembedded.com> (raw)
In-Reply-To: <f4f57fbc-313c-669f-94c7-073747a20a82@cogentembedded.com>
On 11/22/2016 2:22 PM, Vladimir Barinov wrote:
>>> From: Vladimir Barinov <vladimir.barinov@cogentembedded.com>
>>>
>>> This changes SDHI0 pin names for H3ULCB board
>>>
>>> Signed-off-by: Vladimir Barinov <vladimir.barinov@cogentembedded.com>
>>> Signed-off-by: Simon Horman <horms+renesas@verge.net.au>
>>> ---
>>> arch/arm64/boot/dts/renesas/r8a7795-h3ulcb.dts | 8 ++++----
>>> 1 file changed, 4 insertions(+), 4 deletions(-)
>>>
>>> diff --git a/arch/arm64/boot/dts/renesas/r8a7795-h3ulcb.dts
>>> b/arch/arm64/boot/dts/renesas/r8a7795-h3ulcb.dts
>>> index 8d0ac076d8e2..6ffb0517421a 100644
>>> --- a/arch/arm64/boot/dts/renesas/r8a7795-h3ulcb.dts
>>> +++ b/arch/arm64/boot/dts/renesas/r8a7795-h3ulcb.dts
>>> @@ -163,13 +163,13 @@
>>> function = "avb";
>>> };
>>>
>>> - sdhi0_pins_3v3: sd0_3v3 {
>>> + sdhi0_pins: sd0 {
>>> groups = "sdhi0_data4", "sdhi0_ctrl";
>>> function = "sdhi0";
>>> power-source = <3300>;
>>> };
>>>
>>> - sdhi0_pins_1v8: sd0_1v8 {
>>> + sdhi0_pins_uhs: sd0 {
>>
>> I'm afraid the following will just override the props of the node above
>> which is not what we ant.
> Thank you for pointing to this.
>
> This is my typo.
> I will rework the patch to have different node names.
The patch had been already merged by Simon and was posted a s apart of a
pull request (if I don't mistake), so I guess an incremental patch needed now...
> Regards,
> Vladimir
MBR, Sergei
WARNING: multiple messages have this Message-ID (diff)
From: sergei.shtylyov@cogentembedded.com (Sergei Shtylyov)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH 16/18] arm64: dts: h3ulcb: rename SDHI0 pins
Date: Tue, 22 Nov 2016 14:40:25 +0300 [thread overview]
Message-ID: <d4fbb71f-2a4d-2239-faa9-c017c74e1d79@cogentembedded.com> (raw)
In-Reply-To: <f4f57fbc-313c-669f-94c7-073747a20a82@cogentembedded.com>
On 11/22/2016 2:22 PM, Vladimir Barinov wrote:
>>> From: Vladimir Barinov <vladimir.barinov@cogentembedded.com>
>>>
>>> This changes SDHI0 pin names for H3ULCB board
>>>
>>> Signed-off-by: Vladimir Barinov <vladimir.barinov@cogentembedded.com>
>>> Signed-off-by: Simon Horman <horms+renesas@verge.net.au>
>>> ---
>>> arch/arm64/boot/dts/renesas/r8a7795-h3ulcb.dts | 8 ++++----
>>> 1 file changed, 4 insertions(+), 4 deletions(-)
>>>
>>> diff --git a/arch/arm64/boot/dts/renesas/r8a7795-h3ulcb.dts
>>> b/arch/arm64/boot/dts/renesas/r8a7795-h3ulcb.dts
>>> index 8d0ac076d8e2..6ffb0517421a 100644
>>> --- a/arch/arm64/boot/dts/renesas/r8a7795-h3ulcb.dts
>>> +++ b/arch/arm64/boot/dts/renesas/r8a7795-h3ulcb.dts
>>> @@ -163,13 +163,13 @@
>>> function = "avb";
>>> };
>>>
>>> - sdhi0_pins_3v3: sd0_3v3 {
>>> + sdhi0_pins: sd0 {
>>> groups = "sdhi0_data4", "sdhi0_ctrl";
>>> function = "sdhi0";
>>> power-source = <3300>;
>>> };
>>>
>>> - sdhi0_pins_1v8: sd0_1v8 {
>>> + sdhi0_pins_uhs: sd0 {
>>
>> I'm afraid the following will just override the props of the node above
>> which is not what we ant.
> Thank you for pointing to this.
>
> This is my typo.
> I will rework the patch to have different node names.
The patch had been already merged by Simon and was posted a s apart of a
pull request (if I don't mistake), so I guess an incremental patch needed now...
> Regards,
> Vladimir
MBR, Sergei
next prev parent reply other threads:[~2016-11-22 11:40 UTC|newest]
Thread overview: 52+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-11-21 12:05 [GIT PULL v2] Second Round of Renesas ARM64 Based SoC DT Updates for v4.10 Simon Horman
2016-11-21 12:05 ` Simon Horman
2016-11-21 12:05 ` [PATCH 01/18] arm64: dts: r8a7796: add I2C support Simon Horman
2016-11-21 12:05 ` Simon Horman
2016-11-21 12:05 ` [PATCH 02/18] arm64: dts: r8a7796: Enable I2C DMA Simon Horman
2016-11-21 12:05 ` Simon Horman
2016-11-21 12:05 ` [PATCH 03/18] arm64: dts: r8a7796: salvator-x: enable I2C Simon Horman
2016-11-21 12:05 ` Simon Horman
2016-11-21 12:05 ` [PATCH 04/18] arm64: dts: h3ulcb: update documentation with official board name Simon Horman
2016-11-21 12:05 ` Simon Horman
2016-11-21 12:05 ` [PATCH 05/18] arm64: dts: h3ulcb: update header Simon Horman
2016-11-21 12:05 ` Simon Horman
2016-11-21 12:05 ` [PATCH 06/18] arm64: dts: m3ulcb: add M3ULCB board DT bindings Simon Horman
2016-11-21 12:05 ` Simon Horman
2016-11-21 12:05 ` [PATCH 07/18] arm64: dts: m3ulcb: initial device tree Simon Horman
2016-11-21 12:05 ` Simon Horman
2016-11-21 12:05 ` [PATCH 08/18] arm64: dts: m3ulcb: enable SCIF clk and pins Simon Horman
2016-11-21 12:05 ` Simon Horman
2016-11-21 12:05 ` [PATCH 09/18] arm64: dts: m3ulcb: enable GPIO leds Simon Horman
2016-11-21 12:05 ` Simon Horman
2016-11-21 12:05 ` [PATCH 10/18] arm64: dts: m3ulcb: enable GPIO keys Simon Horman
2016-11-21 12:05 ` Simon Horman
2016-11-21 12:05 ` [PATCH 11/18] arm64: dts: m3ulcb: enable EXTALR clk Simon Horman
2016-11-21 12:05 ` Simon Horman
2016-11-21 12:05 ` [PATCH 12/18] arm64: dts: m3ulcb: enable WDT Simon Horman
2016-11-21 12:05 ` Simon Horman
2016-11-21 12:05 ` [PATCH 13/18] arm64: dts: m3ulcb: enable SDHI0 Simon Horman
2016-11-21 12:05 ` Simon Horman
2016-11-21 12:05 ` [PATCH 14/18] arm64: dts: m3ulcb: enable SDHI2 Simon Horman
2016-11-21 12:05 ` Simon Horman
2016-11-21 12:05 ` [PATCH 15/18] arm64: dts: h3ulcb: " Simon Horman
2016-11-21 12:05 ` Simon Horman
2016-11-21 12:05 ` [PATCH 16/18] arm64: dts: h3ulcb: rename SDHI0 pins Simon Horman
2016-11-21 12:05 ` Simon Horman
2016-11-21 13:13 ` Sergei Shtylyov
2016-11-21 13:13 ` Sergei Shtylyov
2016-11-22 11:22 ` Vladimir Barinov
2016-11-22 11:22 ` Vladimir Barinov
2016-11-22 11:40 ` Sergei Shtylyov [this message]
2016-11-22 11:40 ` Sergei Shtylyov
2016-11-22 12:08 ` Vladimir Barinov
2016-11-22 12:08 ` Vladimir Barinov
2016-11-30 10:07 ` Simon Horman
2016-11-30 10:07 ` Simon Horman
2016-11-21 12:05 ` [PATCH 17/18] arm64: dts: r8a7795: Add device node for PRR Simon Horman
2016-11-21 12:05 ` Simon Horman
2016-11-21 12:05 ` [PATCH 18/18] arm64: dts: r8a7796: " Simon Horman
2016-11-21 12:05 ` Simon Horman
2016-11-30 15:51 ` [GIT PULL v2] Second Round of Renesas ARM64 Based SoC DT Updates for v4.10 Arnd Bergmann
2016-11-30 15:51 ` Arnd Bergmann
-- strict thread matches above, loose matches on Subject: below --
2016-11-17 14:04 [GIT PULL] " Simon Horman
2016-11-17 14:04 ` [PATCH 16/18] arm64: dts: h3ulcb: rename SDHI0 pins Simon Horman
2016-11-17 14:04 ` Simon Horman
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=d4fbb71f-2a4d-2239-faa9-c017c74e1d79@cogentembedded.com \
--to=sergei.shtylyov@cogentembedded.com \
--cc=horms+renesas@verge.net.au \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-renesas-soc@vger.kernel.org \
--cc=magnus.damm@gmail.com \
--cc=vladimir.barinov@cogentembedded.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.