From: Kathiravan Thirumoorthy <quic_kathirav@quicinc.com> To: Dmitry Baryshkov <dmitry.baryshkov@linaro.org> Cc: Andrew Lunn <andrew@lunn.ch>, Bjorn Andersson <andersson@kernel.org>, Konrad Dybcio <konrad.dybcio@linaro.org>, Michael Turquette <mturquette@baylibre.com>, Stephen Boyd <sboyd@kernel.org>, Rob Herring <robh+dt@kernel.org>, Krzysztof Kozlowski <krzysztof.kozlowski+dt@linaro.org>, Conor Dooley <conor+dt@kernel.org>, Richard Cochran <richardcochran@gmail.com>, Catalin Marinas <catalin.marinas@arm.com>, Will Deacon <will@kernel.org>, <linux-arm-msm@vger.kernel.org>, <linux-clk@vger.kernel.org>, <linux-kernel@vger.kernel.org>, <devicetree@vger.kernel.org>, <netdev@vger.kernel.org>, <linux-arm-kernel@lists.infradead.org> Subject: Re: [PATCH v4 2/8] clk: qcom: ipq5332: enable few nssnoc clocks in driver probe Date: Sun, 18 Feb 2024 09:59:03 +0530 [thread overview] Message-ID: <d518dbc1-41aa-46f9-b549-c95a33b06ee0@quicinc.com> (raw) In-Reply-To: <CAA8EJppuNRB9fhjimg4SUR2PydX7-KLWSb9H-nC-oSMYVOME-Q@mail.gmail.com> On 2/17/2024 10:15 PM, Dmitry Baryshkov wrote: > On Sat, 17 Feb 2024 at 17:45, Kathiravan Thirumoorthy > <quic_kathirav@quicinc.com> wrote: >> >> >> <snip> >> >>>> Reason being, to access the NSSCC clocks, these GCC clocks >>>> (gcc_snoc_nssnoc_clk, gcc_snoc_nssnoc_1_clk, gcc_nssnoc_nsscc_clk) >>>> should be turned ON. But CCF disables these clocks as well due to the >>>> lack of consumer. >>> >>> This means that NSSCC is also a consumer of those clocks. Please fix >>> both DT and nsscc driver to handle NSSNOC clocks. >> >> >> Thanks Dmitry. I shall include these clocks in the NSSCC DT node and >> enable the same in the NSSCC driver probe. > > Or use them through pm_clk. This might be better, as the system > doesn't need these clocks if NSSCC is suspended. IPQ53XX SoC doesn't support the PM(suspend / resume) functionality, so that, can I enable these clocks in NSSCC driver probe itself? > >> >>> >>>>> Once you have actual drivers, this should solve itself, the drivers >>>>> will consume the clocks. >>>> >>>> >>>> Given that, NSSCC is being built as module, there is no issue in booting >>>> the kernel. But if you do insmod of the nsscc-ipq5332.ko, system will >>>> reset. >>>> >>>> Without the networking drivers, there is no need to install this module. >>>> And as you stated, once the drivers are available, there will be no issues. >>>> >>>> So can I explain the shortcomings of installing this module without the >>>> networking drivers in cover letter and drop this patch all together? >>> >>> No. Using allyesconfig or allmodconfig and installing the full modules >>> set should work. >>> >> >> >> Okay, Got it. Thanks for the information. >> >> <snip> > > >
WARNING: multiple messages have this Message-ID (diff)
From: Kathiravan Thirumoorthy <quic_kathirav@quicinc.com> To: Dmitry Baryshkov <dmitry.baryshkov@linaro.org> Cc: Andrew Lunn <andrew@lunn.ch>, Bjorn Andersson <andersson@kernel.org>, Konrad Dybcio <konrad.dybcio@linaro.org>, Michael Turquette <mturquette@baylibre.com>, Stephen Boyd <sboyd@kernel.org>, Rob Herring <robh+dt@kernel.org>, Krzysztof Kozlowski <krzysztof.kozlowski+dt@linaro.org>, Conor Dooley <conor+dt@kernel.org>, Richard Cochran <richardcochran@gmail.com>, Catalin Marinas <catalin.marinas@arm.com>, Will Deacon <will@kernel.org>, <linux-arm-msm@vger.kernel.org>, <linux-clk@vger.kernel.org>, <linux-kernel@vger.kernel.org>, <devicetree@vger.kernel.org>, <netdev@vger.kernel.org>, <linux-arm-kernel@lists.infradead.org> Subject: Re: [PATCH v4 2/8] clk: qcom: ipq5332: enable few nssnoc clocks in driver probe Date: Sun, 18 Feb 2024 09:59:03 +0530 [thread overview] Message-ID: <d518dbc1-41aa-46f9-b549-c95a33b06ee0@quicinc.com> (raw) In-Reply-To: <CAA8EJppuNRB9fhjimg4SUR2PydX7-KLWSb9H-nC-oSMYVOME-Q@mail.gmail.com> On 2/17/2024 10:15 PM, Dmitry Baryshkov wrote: > On Sat, 17 Feb 2024 at 17:45, Kathiravan Thirumoorthy > <quic_kathirav@quicinc.com> wrote: >> >> >> <snip> >> >>>> Reason being, to access the NSSCC clocks, these GCC clocks >>>> (gcc_snoc_nssnoc_clk, gcc_snoc_nssnoc_1_clk, gcc_nssnoc_nsscc_clk) >>>> should be turned ON. But CCF disables these clocks as well due to the >>>> lack of consumer. >>> >>> This means that NSSCC is also a consumer of those clocks. Please fix >>> both DT and nsscc driver to handle NSSNOC clocks. >> >> >> Thanks Dmitry. I shall include these clocks in the NSSCC DT node and >> enable the same in the NSSCC driver probe. > > Or use them through pm_clk. This might be better, as the system > doesn't need these clocks if NSSCC is suspended. IPQ53XX SoC doesn't support the PM(suspend / resume) functionality, so that, can I enable these clocks in NSSCC driver probe itself? > >> >>> >>>>> Once you have actual drivers, this should solve itself, the drivers >>>>> will consume the clocks. >>>> >>>> >>>> Given that, NSSCC is being built as module, there is no issue in booting >>>> the kernel. But if you do insmod of the nsscc-ipq5332.ko, system will >>>> reset. >>>> >>>> Without the networking drivers, there is no need to install this module. >>>> And as you stated, once the drivers are available, there will be no issues. >>>> >>>> So can I explain the shortcomings of installing this module without the >>>> networking drivers in cover letter and drop this patch all together? >>> >>> No. Using allyesconfig or allmodconfig and installing the full modules >>> set should work. >>> >> >> >> Okay, Got it. Thanks for the information. >> >> <snip> > > > _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
next prev parent reply other threads:[~2024-02-18 4:29 UTC|newest] Thread overview: 58+ messages / expand[flat|nested] mbox.gz Atom feed top 2024-01-22 5:56 [PATCH v4 0/8] Add NSS clock controller support for Qualcomm IPQ5332 Kathiravan Thirumoorthy 2024-01-22 5:56 ` Kathiravan Thirumoorthy 2024-01-22 5:56 ` [PATCH v4 1/8] clk: qcom: ipq5332: add const qualifier to the clk_init_data structure Kathiravan Thirumoorthy 2024-01-22 5:56 ` Kathiravan Thirumoorthy 2024-01-22 9:02 ` Krzysztof Kozlowski 2024-01-22 9:02 ` Krzysztof Kozlowski 2024-01-22 5:56 ` [PATCH v4 2/8] clk: qcom: ipq5332: enable few nssnoc clocks in driver probe Kathiravan Thirumoorthy 2024-01-22 5:56 ` Kathiravan Thirumoorthy 2024-01-25 20:05 ` Andrew Lunn 2024-01-25 20:05 ` Andrew Lunn 2024-02-14 9:19 ` Kathiravan Thirumoorthy 2024-02-14 9:19 ` Kathiravan Thirumoorthy 2024-02-14 11:45 ` Dmitry Baryshkov 2024-02-14 11:45 ` Dmitry Baryshkov 2024-02-14 14:44 ` Andrew Lunn 2024-02-14 14:44 ` Andrew Lunn 2024-02-16 15:22 ` Kathiravan Thirumoorthy 2024-02-16 15:22 ` Kathiravan Thirumoorthy 2024-02-16 16:26 ` Dmitry Baryshkov 2024-02-16 16:26 ` Dmitry Baryshkov 2024-02-17 15:44 ` Kathiravan Thirumoorthy 2024-02-17 15:44 ` Kathiravan Thirumoorthy 2024-02-17 16:45 ` Dmitry Baryshkov 2024-02-17 16:45 ` Dmitry Baryshkov 2024-02-18 4:29 ` Kathiravan Thirumoorthy [this message] 2024-02-18 4:29 ` Kathiravan Thirumoorthy 2024-02-19 10:16 ` Konrad Dybcio 2024-02-19 10:16 ` Konrad Dybcio 2024-02-19 10:23 ` Dmitry Baryshkov 2024-02-19 10:23 ` Dmitry Baryshkov 2024-02-23 10:18 ` Kathiravan Thirumoorthy 2024-02-23 10:18 ` Kathiravan Thirumoorthy 2024-03-05 6:41 ` Dmitry Baryshkov 2024-03-05 6:41 ` Dmitry Baryshkov 2024-02-16 17:16 ` Andrew Lunn 2024-02-16 17:16 ` Andrew Lunn 2024-02-17 15:41 ` Kathiravan Thirumoorthy 2024-02-17 15:41 ` Kathiravan Thirumoorthy 2024-01-22 5:56 ` [PATCH v4 3/8] dt-bindings: clock: ipq5332: add definition for GPLL0_OUT_AUX clock Kathiravan Thirumoorthy 2024-01-22 5:56 ` Kathiravan Thirumoorthy 2024-01-25 20:07 ` Andrew Lunn 2024-01-25 20:07 ` Andrew Lunn 2024-02-14 9:20 ` Kathiravan Thirumoorthy 2024-02-14 9:20 ` Kathiravan Thirumoorthy 2024-01-22 5:57 ` [PATCH v4 4/8] clk: qcom: ipq5332: add gpll0_out_aux clock Kathiravan Thirumoorthy 2024-01-22 5:57 ` Kathiravan Thirumoorthy 2024-01-25 20:11 ` Andrew Lunn 2024-01-25 20:11 ` Andrew Lunn 2024-02-14 9:28 ` Kathiravan Thirumoorthy 2024-02-14 9:28 ` Kathiravan Thirumoorthy 2024-01-22 5:57 ` [PATCH v4 5/8] dt-bindings: clock: add Qualcomm IPQ5332 NSSCC clock and reset definitions Kathiravan Thirumoorthy 2024-01-22 5:57 ` Kathiravan Thirumoorthy 2024-01-22 5:57 ` [PATCH v4 6/8] clk: qcom: add NSS clock Controller driver for Qualcomm IPQ5332 Kathiravan Thirumoorthy 2024-01-22 5:57 ` Kathiravan Thirumoorthy 2024-01-22 5:57 ` [PATCH v4 7/8] arm64: dts: qcom: ipq5332: add support for the NSSCC Kathiravan Thirumoorthy 2024-01-22 5:57 ` Kathiravan Thirumoorthy 2024-01-22 5:57 ` [PATCH v4 8/8] arm64: defconfig: build NSS Clock Controller driver for Qualcomm IPQ5332 Kathiravan Thirumoorthy 2024-01-22 5:57 ` Kathiravan Thirumoorthy
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=d518dbc1-41aa-46f9-b549-c95a33b06ee0@quicinc.com \ --to=quic_kathirav@quicinc.com \ --cc=andersson@kernel.org \ --cc=andrew@lunn.ch \ --cc=catalin.marinas@arm.com \ --cc=conor+dt@kernel.org \ --cc=devicetree@vger.kernel.org \ --cc=dmitry.baryshkov@linaro.org \ --cc=konrad.dybcio@linaro.org \ --cc=krzysztof.kozlowski+dt@linaro.org \ --cc=linux-arm-kernel@lists.infradead.org \ --cc=linux-arm-msm@vger.kernel.org \ --cc=linux-clk@vger.kernel.org \ --cc=linux-kernel@vger.kernel.org \ --cc=mturquette@baylibre.com \ --cc=netdev@vger.kernel.org \ --cc=richardcochran@gmail.com \ --cc=robh+dt@kernel.org \ --cc=sboyd@kernel.org \ --cc=will@kernel.org \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: linkBe sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.