From: Florian Fainelli <f.fainelli@gmail.com>
To: Jim Quinlan <jim2101024@gmail.com>,
linux-pci@vger.kernel.org,
Nicolas Saenz Julienne <nsaenz@kernel.org>,
Bjorn Helgaas <bhelgaas@google.com>,
Lorenzo Pieralisi <lorenzo.pieralisi@arm.com>,
Cyril Brulebois <kibi@debian.org>,
Phil Elwell <phil@raspberrypi.com>,
bcm-kernel-feedback-list@broadcom.com,
james.quinlan@broadcom.com
Cc: "open list:OPEN FIRMWARE AND FLATTENED DEVICE TREE BINDINGS"
<devicetree@vger.kernel.org>,
"moderated list:BROADCOM BCM2711/BCM2835 ARM ARCHITECTURE"
<linux-arm-kernel@lists.infradead.org>,
open list <linux-kernel@vger.kernel.org>,
"moderated list:BROADCOM BCM2711/BCM2835 ARM ARCHITECTURE"
<linux-rpi-kernel@lists.infradead.org>,
Rob Herring <robh@kernel.org>
Subject: Re: [PATCH v2 0/3] PCI: brcmstb: CLKREQ# accomodations of downstream device
Date: Thu, 13 Apr 2023 11:40:11 -0700 [thread overview]
Message-ID: <d53c10d6-6a9c-c941-a7ff-70d4b4172960@gmail.com> (raw)
In-Reply-To: <20230411165919.23955-1-jim2101024@gmail.com>
On 4/11/23 09:59, Jim Quinlan wrote:
> v2 -- Changed binding property 'brcm,completion-timeout-msec' to
> 'brcm,completion-timeout-us'. (StefanW for standard suffix).
> -- Warn when clamping timeout value, and include clamped
> region in message. Also add min and max in YAML. (StefanW)
> -- Qualify description of "brcm,completion-timeout-us" so that
> it refers to PCIe transactions. (StefanW)
> -- Remvove mention of Linux specifics in binding description. (StefanW)
> -- s/clkreq#/CLKREQ#/g (Bjorn)
> -- Refactor completion-timeout-us code to compare max and min to
> value given by the property (as opposed to the computed value).
>
> v1 -- The current driver assumes the downstream devices can
> provide CLKREQ# for ASPM. These commits accomodate devices
> w/ or w/o clkreq# and also handle L1SS-capable devices.
>
> -- The Raspian Linux folks have already been using a PCIe RC
> property "brcm,enable-l1ss". These commits use the same
> property, in a backward-compatible manner, and the implementaion
> adds more detail and also automatically identifies devices w/o
> a clkreq# signal, i.e. most devices plugged into an RPi CM4
> IO board.
>
> Jim Quinlan (3):
> PCI: brcmstb: CLKREQ# accomodations of downstream device
> PCI: brcmstb: Set PCIe transaction completion timeout
> blah blah
Tested-by: Florian Fainelli <f.fainelli@gmail.com>
On a 7216 system test with:
01:00.0 Network controller: Intel Corporation Wireless 7260 (rev 73)
and on the CM4 I/O board with:
01:00.0 Network controller: Intel Corporation Wireless 7260 (rev 73)
01:00.0 Ethernet controller: Intel Corporation 82574L Gigabit Network
Connection
01:00.0 Network controller: Broadcom Inc. and subsidiaries BCM43224
802.11a/b/g/n (rev 01)
01:00.0 SATA controller: Marvell Technology Group Ltd. 88SE9125 PCIe
SATA 6.0 Gb/s controller (rev 11) (prog-if 01 [AHCI 1.0])
01:00.0 Ethernet controller: Broadcom Inc. and subsidiaries NetXtreme
BCM5751 Gigabit Ethernet PCI Express (rev 21)
01:00.0 PCI bridge: PLX Technology, Inc. PEX8112 x1 Lane PCI
Express-to-PCI Bridge (rev aa)
02:00.0 Multiport serial controller: Pepperl+Fuchs RocketPort EXPRESS
8-port w/Octa Cable
01:00.0 Ethernet controller: Qualcomm Atheros AR5008 Wireless Network
Adapter (rev 01)
01:00.0 Network controller: Broadcom Inc. and subsidiaries BCM4311
802.11a/b/g (rev 01)
01:00.0 Network controller: Broadcom Inc. and subsidiaries BCM4322
802.11a/b/g/n Wireless LAN Controller (rev 01)
01:00.0 Network controller: Broadcom Inc. and subsidiaries BCM43602
802.11ac Wireless LAN SoC (rev 01)
and finally with a 4 port switch:
-[0000:00]---00.0-[01-07]----00.0-[02-07]--+-01.0-[03]----00.0 Intel
Corporation 82574L Gigabit Network Connection
+-03.0-[04-05]----00.0-[05]----00.0 Pepperl+Fuchs RocketPort EXPRESS
8-port w/Octa Cable
+-05.0-[06]----00.0
Broadcom Inc. and subsidiaries NetXtreme BCM5751 Gigabit Ethernet PCI
Express
\-07.0-[07]----00.0 Intel
Corporation 82574L Gigabit Network Connection
And than I ran out of devices that I could plug, the others were x4, x8
or x16.
Most (all?) would previously fail, so definitively an improvement!
Thanks!
--
--
Florian
WARNING: multiple messages have this Message-ID (diff)
From: Florian Fainelli <f.fainelli@gmail.com>
To: Jim Quinlan <jim2101024@gmail.com>,
linux-pci@vger.kernel.org,
Nicolas Saenz Julienne <nsaenz@kernel.org>,
Bjorn Helgaas <bhelgaas@google.com>,
Lorenzo Pieralisi <lorenzo.pieralisi@arm.com>,
Cyril Brulebois <kibi@debian.org>,
Phil Elwell <phil@raspberrypi.com>,
bcm-kernel-feedback-list@broadcom.com,
james.quinlan@broadcom.com
Cc: "open list:OPEN FIRMWARE AND FLATTENED DEVICE TREE BINDINGS"
<devicetree@vger.kernel.org>,
"moderated list:BROADCOM BCM2711/BCM2835 ARM ARCHITECTURE"
<linux-arm-kernel@lists.infradead.org>,
open list <linux-kernel@vger.kernel.org>,
"moderated list:BROADCOM BCM2711/BCM2835 ARM ARCHITECTURE"
<linux-rpi-kernel@lists.infradead.org>,
Rob Herring <robh@kernel.org>
Subject: Re: [PATCH v2 0/3] PCI: brcmstb: CLKREQ# accomodations of downstream device
Date: Thu, 13 Apr 2023 11:40:11 -0700 [thread overview]
Message-ID: <d53c10d6-6a9c-c941-a7ff-70d4b4172960@gmail.com> (raw)
In-Reply-To: <20230411165919.23955-1-jim2101024@gmail.com>
On 4/11/23 09:59, Jim Quinlan wrote:
> v2 -- Changed binding property 'brcm,completion-timeout-msec' to
> 'brcm,completion-timeout-us'. (StefanW for standard suffix).
> -- Warn when clamping timeout value, and include clamped
> region in message. Also add min and max in YAML. (StefanW)
> -- Qualify description of "brcm,completion-timeout-us" so that
> it refers to PCIe transactions. (StefanW)
> -- Remvove mention of Linux specifics in binding description. (StefanW)
> -- s/clkreq#/CLKREQ#/g (Bjorn)
> -- Refactor completion-timeout-us code to compare max and min to
> value given by the property (as opposed to the computed value).
>
> v1 -- The current driver assumes the downstream devices can
> provide CLKREQ# for ASPM. These commits accomodate devices
> w/ or w/o clkreq# and also handle L1SS-capable devices.
>
> -- The Raspian Linux folks have already been using a PCIe RC
> property "brcm,enable-l1ss". These commits use the same
> property, in a backward-compatible manner, and the implementaion
> adds more detail and also automatically identifies devices w/o
> a clkreq# signal, i.e. most devices plugged into an RPi CM4
> IO board.
>
> Jim Quinlan (3):
> PCI: brcmstb: CLKREQ# accomodations of downstream device
> PCI: brcmstb: Set PCIe transaction completion timeout
> blah blah
Tested-by: Florian Fainelli <f.fainelli@gmail.com>
On a 7216 system test with:
01:00.0 Network controller: Intel Corporation Wireless 7260 (rev 73)
and on the CM4 I/O board with:
01:00.0 Network controller: Intel Corporation Wireless 7260 (rev 73)
01:00.0 Ethernet controller: Intel Corporation 82574L Gigabit Network
Connection
01:00.0 Network controller: Broadcom Inc. and subsidiaries BCM43224
802.11a/b/g/n (rev 01)
01:00.0 SATA controller: Marvell Technology Group Ltd. 88SE9125 PCIe
SATA 6.0 Gb/s controller (rev 11) (prog-if 01 [AHCI 1.0])
01:00.0 Ethernet controller: Broadcom Inc. and subsidiaries NetXtreme
BCM5751 Gigabit Ethernet PCI Express (rev 21)
01:00.0 PCI bridge: PLX Technology, Inc. PEX8112 x1 Lane PCI
Express-to-PCI Bridge (rev aa)
02:00.0 Multiport serial controller: Pepperl+Fuchs RocketPort EXPRESS
8-port w/Octa Cable
01:00.0 Ethernet controller: Qualcomm Atheros AR5008 Wireless Network
Adapter (rev 01)
01:00.0 Network controller: Broadcom Inc. and subsidiaries BCM4311
802.11a/b/g (rev 01)
01:00.0 Network controller: Broadcom Inc. and subsidiaries BCM4322
802.11a/b/g/n Wireless LAN Controller (rev 01)
01:00.0 Network controller: Broadcom Inc. and subsidiaries BCM43602
802.11ac Wireless LAN SoC (rev 01)
and finally with a 4 port switch:
-[0000:00]---00.0-[01-07]----00.0-[02-07]--+-01.0-[03]----00.0 Intel
Corporation 82574L Gigabit Network Connection
+-03.0-[04-05]----00.0-[05]----00.0 Pepperl+Fuchs RocketPort EXPRESS
8-port w/Octa Cable
+-05.0-[06]----00.0
Broadcom Inc. and subsidiaries NetXtreme BCM5751 Gigabit Ethernet PCI
Express
\-07.0-[07]----00.0 Intel
Corporation 82574L Gigabit Network Connection
And than I ran out of devices that I could plug, the others were x4, x8
or x16.
Most (all?) would previously fail, so definitively an improvement!
Thanks!
--
--
Florian
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
next prev parent reply other threads:[~2023-04-13 18:40 UTC|newest]
Thread overview: 57+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-04-11 16:59 [PATCH v2 0/3] PCI: brcmstb: CLKREQ# accomodations of downstream device Jim Quinlan
2023-04-11 16:59 ` Jim Quinlan
2023-04-11 16:59 ` [PATCH v2 1/3] dt-bindings: PCI: brcmstb: Add two optional props Jim Quinlan
2023-04-11 16:59 ` Jim Quinlan
2023-04-12 8:09 ` Krzysztof Kozlowski
2023-04-12 8:09 ` Krzysztof Kozlowski
2023-04-12 11:49 ` Florian Fainelli
2023-04-12 11:49 ` Florian Fainelli
2023-04-12 11:56 ` Krzysztof Kozlowski
2023-04-12 11:56 ` Krzysztof Kozlowski
2023-04-12 14:14 ` Jim Quinlan
2023-04-12 14:14 ` Jim Quinlan
2023-04-12 15:37 ` Rob Herring
2023-04-12 15:37 ` Rob Herring
2023-04-12 16:12 ` Florian Fainelli
2023-04-12 16:12 ` Florian Fainelli
2023-04-18 18:35 ` Rob Herring
2023-04-18 18:35 ` Rob Herring
2023-04-21 19:07 ` Konstantin Ryabitsev
2023-04-21 19:07 ` Konstantin Ryabitsev
2023-04-14 20:14 ` Bjorn Helgaas
2023-04-14 20:14 ` Bjorn Helgaas
2023-04-11 16:59 ` [PATCH v2 2/3] PCI: brcmstb: CLKREQ# accomodations of downstream device Jim Quinlan
2023-04-11 16:59 ` Jim Quinlan
2023-04-13 14:39 ` Cyril Brulebois
2023-04-13 14:39 ` Cyril Brulebois
2023-04-13 14:57 ` Jim Quinlan
2023-04-13 14:57 ` Jim Quinlan
2023-04-13 20:06 ` Cyril Brulebois
2023-04-14 12:14 ` Jim Quinlan
2023-04-14 12:14 ` Jim Quinlan
2023-04-14 12:27 ` Florian Fainelli
2023-04-14 12:27 ` Florian Fainelli
2023-04-14 13:31 ` Jim Quinlan
2023-04-14 13:31 ` Jim Quinlan
2023-04-14 16:19 ` Cyril Brulebois
2023-04-14 16:19 ` Cyril Brulebois
2023-04-19 14:23 ` Jim Quinlan
2023-04-19 14:23 ` Jim Quinlan
2023-04-19 15:57 ` Cyril Brulebois
2023-04-19 15:57 ` Cyril Brulebois
2023-04-13 14:58 ` Florian Fainelli
2023-04-13 14:58 ` Florian Fainelli
2023-04-14 20:27 ` Bjorn Helgaas
2023-04-14 20:27 ` Bjorn Helgaas
2023-04-14 20:33 ` Florian Fainelli
2023-04-14 20:33 ` Florian Fainelli
2023-04-17 21:41 ` Bjorn Helgaas
2023-04-17 21:41 ` Bjorn Helgaas
2023-04-14 23:14 ` Jim Quinlan
2023-04-14 23:14 ` Jim Quinlan
2023-04-11 16:59 ` [PATCH v2 3/3] PCI: brcmstb: Set PCIe transaction completion timeout Jim Quinlan
2023-04-11 16:59 ` Jim Quinlan
2023-04-12 0:26 ` Cyril Brulebois
2023-04-12 0:26 ` Cyril Brulebois
2023-04-13 18:40 ` Florian Fainelli [this message]
2023-04-13 18:40 ` [PATCH v2 0/3] PCI: brcmstb: CLKREQ# accomodations of downstream device Florian Fainelli
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=d53c10d6-6a9c-c941-a7ff-70d4b4172960@gmail.com \
--to=f.fainelli@gmail.com \
--cc=bcm-kernel-feedback-list@broadcom.com \
--cc=bhelgaas@google.com \
--cc=devicetree@vger.kernel.org \
--cc=james.quinlan@broadcom.com \
--cc=jim2101024@gmail.com \
--cc=kibi@debian.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-pci@vger.kernel.org \
--cc=linux-rpi-kernel@lists.infradead.org \
--cc=lorenzo.pieralisi@arm.com \
--cc=nsaenz@kernel.org \
--cc=phil@raspberrypi.com \
--cc=robh@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.