All of lore.kernel.org
 help / color / mirror / Atom feed
From: "Konstantin Ryabitsev" <konstantin.ryabitsev@linux.dev>
To: "Rob Herring" <robh@kernel.org>,
	"Florian Fainelli" <f.fainelli@gmail.com>
Cc: "Jim Quinlan" <jim2101024@gmail.com>,
	"Krzysztof Kozlowski" <krzysztof.kozlowski@linaro.org>,
	linux-pci@vger.kernel.org,
	"Nicolas Saenz Julienne" <nsaenz@kernel.org>,
	"Bjorn Helgaas" <bhelgaas@google.com>,
	"Lorenzo Pieralisi" <lorenzo.pieralisi@arm.com>,
	"Cyril Brulebois" <kibi@debian.org>,
	"Phil Elwell" <phil@raspberrypi.com>,
	bcm-kernel-feedback-list@broadcom.com,
	james.quinlan@broadcom.com,
	"Lorenzo Pieralisi" <lpieralisi@kernel.org>,
	"Krzysztof Wilczyński" <kw@linux.com>,
	"Krzysztof Kozlowski" <krzysztof.kozlowski+dt@linaro.org>,
	"moderated list:BROADCOM BCM7XXX ARM ARCHITECTURE"
	<linux-arm-kernel@lists.infradead.org>,
	"moderated list:BROADCOM BCM2711/BCM2835 ARM ARCHITECTURE"
	<linux-rpi-kernel@lists.infradead.org>,
	"open list:OPEN FIRMWARE AND FLATTENED DEVICE TREE BINDINGS"
	<devicetree@vger.kernel.org>,
	"open list" <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH v2 1/3] dt-bindings: PCI: brcmstb: Add two optional props
Date: Fri, 21 Apr 2023 19:07:53 +0000	[thread overview]
Message-ID: <1e4386d3a24bbf4c70880fef2af74928@linux.dev> (raw)
In-Reply-To: <20230418183536.GA2087834-robh@kernel.org>

April 18, 2023 2:35 PM, "Rob Herring" <robh@kernel.org> wrote:
>> Some trees like the networking
>> tree do merge commits of patch sets where the cover letter is used as part
>> of the merge commit message. Other maintainers don't, and some want the
>> change log after the '---' and some do not.
> 
> I'm not aware of anyone except for DRM wanting the changelog in the
> final commits, but that's really a different issue.

I don't think anyone wants changelogs in actual final commits, they usually go under "---" in patch submissions.

> I'm pretty sure no one will complain about a changelog in the patches. I
> guess you just have to duplicate it if you think it should be in both.
> b4 could be taught to do that I suppose. IMO, the cover letter should
> have a higher level changelog than the individual patches.

b4 doesn't really need to manage per-patch changelogs -- they should just go under "---" in the commit. When you send the series either via "b4 send" or via git-send-email, the changelogs will be properly included in the message, but they won't make it into the tree after the maintainer runs "git am", because git will drop anything under the first "---" in the commit message.

The cover letter changelog is supposed to be higher level than individual patch changelogs, so I don't think it makes sense for b4 to collect them from individual patches.

-K

_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel

WARNING: multiple messages have this Message-ID (diff)
From: "Konstantin Ryabitsev" <konstantin.ryabitsev@linux.dev>
To: "Rob Herring" <robh@kernel.org>,
	"Florian Fainelli" <f.fainelli@gmail.com>
Cc: "Jim Quinlan" <jim2101024@gmail.com>,
	"Krzysztof Kozlowski" <krzysztof.kozlowski@linaro.org>,
	linux-pci@vger.kernel.org,
	"Nicolas Saenz Julienne" <nsaenz@kernel.org>,
	"Bjorn Helgaas" <bhelgaas@google.com>,
	"Lorenzo Pieralisi" <lorenzo.pieralisi@arm.com>,
	"Cyril Brulebois" <kibi@debian.org>,
	"Phil Elwell" <phil@raspberrypi.com>,
	bcm-kernel-feedback-list@broadcom.com,
	james.quinlan@broadcom.com,
	"Lorenzo Pieralisi" <lpieralisi@kernel.org>,
	"Krzysztof Wilczyński" <kw@linux.com>,
	"Krzysztof Kozlowski" <krzysztof.kozlowski+dt@linaro.org>,
	"moderated list:BROADCOM BCM7XXX ARM ARCHITECTURE"
	<linux-arm-kernel@lists.infradead.org>,
	"moderated list:BROADCOM BCM2711/BCM2835 ARM ARCHITECTURE"
	<linux-rpi-kernel@lists.infradead.org>,
	"open list:OPEN FIRMWARE AND FLATTENED DEVICE TREE BINDINGS"
	<devicetree@vger.kernel.org>,
	"open list" <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH v2 1/3] dt-bindings: PCI: brcmstb: Add two optional props
Date: Fri, 21 Apr 2023 19:07:53 +0000	[thread overview]
Message-ID: <1e4386d3a24bbf4c70880fef2af74928@linux.dev> (raw)
In-Reply-To: <20230418183536.GA2087834-robh@kernel.org>

April 18, 2023 2:35 PM, "Rob Herring" <robh@kernel.org> wrote:
>> Some trees like the networking
>> tree do merge commits of patch sets where the cover letter is used as part
>> of the merge commit message. Other maintainers don't, and some want the
>> change log after the '---' and some do not.
> 
> I'm not aware of anyone except for DRM wanting the changelog in the
> final commits, but that's really a different issue.

I don't think anyone wants changelogs in actual final commits, they usually go under "---" in patch submissions.

> I'm pretty sure no one will complain about a changelog in the patches. I
> guess you just have to duplicate it if you think it should be in both.
> b4 could be taught to do that I suppose. IMO, the cover letter should
> have a higher level changelog than the individual patches.

b4 doesn't really need to manage per-patch changelogs -- they should just go under "---" in the commit. When you send the series either via "b4 send" or via git-send-email, the changelogs will be properly included in the message, but they won't make it into the tree after the maintainer runs "git am", because git will drop anything under the first "---" in the commit message.

The cover letter changelog is supposed to be higher level than individual patch changelogs, so I don't think it makes sense for b4 to collect them from individual patches.

-K

  parent reply	other threads:[~2023-04-21 19:08 UTC|newest]

Thread overview: 57+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2023-04-11 16:59 [PATCH v2 0/3] PCI: brcmstb: CLKREQ# accomodations of downstream device Jim Quinlan
2023-04-11 16:59 ` Jim Quinlan
2023-04-11 16:59 ` [PATCH v2 1/3] dt-bindings: PCI: brcmstb: Add two optional props Jim Quinlan
2023-04-11 16:59   ` Jim Quinlan
2023-04-12  8:09   ` Krzysztof Kozlowski
2023-04-12  8:09     ` Krzysztof Kozlowski
2023-04-12 11:49     ` Florian Fainelli
2023-04-12 11:49       ` Florian Fainelli
2023-04-12 11:56       ` Krzysztof Kozlowski
2023-04-12 11:56         ` Krzysztof Kozlowski
2023-04-12 14:14         ` Jim Quinlan
2023-04-12 14:14           ` Jim Quinlan
2023-04-12 15:37           ` Rob Herring
2023-04-12 15:37             ` Rob Herring
2023-04-12 16:12             ` Florian Fainelli
2023-04-12 16:12               ` Florian Fainelli
2023-04-18 18:35               ` Rob Herring
2023-04-18 18:35                 ` Rob Herring
2023-04-21 19:07               ` Konstantin Ryabitsev [this message]
2023-04-21 19:07                 ` Konstantin Ryabitsev
2023-04-14 20:14   ` Bjorn Helgaas
2023-04-14 20:14     ` Bjorn Helgaas
2023-04-11 16:59 ` [PATCH v2 2/3] PCI: brcmstb: CLKREQ# accomodations of downstream device Jim Quinlan
2023-04-11 16:59   ` Jim Quinlan
2023-04-13 14:39   ` Cyril Brulebois
2023-04-13 14:39     ` Cyril Brulebois
2023-04-13 14:57     ` Jim Quinlan
2023-04-13 14:57       ` Jim Quinlan
2023-04-13 20:06       ` Cyril Brulebois
2023-04-14 12:14         ` Jim Quinlan
2023-04-14 12:14           ` Jim Quinlan
2023-04-14 12:27           ` Florian Fainelli
2023-04-14 12:27             ` Florian Fainelli
2023-04-14 13:31             ` Jim Quinlan
2023-04-14 13:31               ` Jim Quinlan
2023-04-14 16:19             ` Cyril Brulebois
2023-04-14 16:19               ` Cyril Brulebois
2023-04-19 14:23               ` Jim Quinlan
2023-04-19 14:23                 ` Jim Quinlan
2023-04-19 15:57                 ` Cyril Brulebois
2023-04-19 15:57                   ` Cyril Brulebois
2023-04-13 14:58     ` Florian Fainelli
2023-04-13 14:58       ` Florian Fainelli
2023-04-14 20:27   ` Bjorn Helgaas
2023-04-14 20:27     ` Bjorn Helgaas
2023-04-14 20:33     ` Florian Fainelli
2023-04-14 20:33       ` Florian Fainelli
2023-04-17 21:41       ` Bjorn Helgaas
2023-04-17 21:41         ` Bjorn Helgaas
2023-04-14 23:14     ` Jim Quinlan
2023-04-14 23:14       ` Jim Quinlan
2023-04-11 16:59 ` [PATCH v2 3/3] PCI: brcmstb: Set PCIe transaction completion timeout Jim Quinlan
2023-04-11 16:59   ` Jim Quinlan
2023-04-12  0:26   ` Cyril Brulebois
2023-04-12  0:26     ` Cyril Brulebois
2023-04-13 18:40 ` [PATCH v2 0/3] PCI: brcmstb: CLKREQ# accomodations of downstream device Florian Fainelli
2023-04-13 18:40   ` Florian Fainelli

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1e4386d3a24bbf4c70880fef2af74928@linux.dev \
    --to=konstantin.ryabitsev@linux.dev \
    --cc=bcm-kernel-feedback-list@broadcom.com \
    --cc=bhelgaas@google.com \
    --cc=devicetree@vger.kernel.org \
    --cc=f.fainelli@gmail.com \
    --cc=james.quinlan@broadcom.com \
    --cc=jim2101024@gmail.com \
    --cc=kibi@debian.org \
    --cc=krzysztof.kozlowski+dt@linaro.org \
    --cc=krzysztof.kozlowski@linaro.org \
    --cc=kw@linux.com \
    --cc=linux-arm-kernel@lists.infradead.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-pci@vger.kernel.org \
    --cc=linux-rpi-kernel@lists.infradead.org \
    --cc=lorenzo.pieralisi@arm.com \
    --cc=lpieralisi@kernel.org \
    --cc=nsaenz@kernel.org \
    --cc=phil@raspberrypi.com \
    --cc=robh@kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.