All of lore.kernel.org
 help / color / mirror / Atom feed
From: Michal Simek <michal.simek@xilinx.com>
To: Jia-Ju Bai <baijiaju1990@gmail.com>, <hyun.kwon@xilinx.com>,
	<laurent.pinchart@ideasonboard.com>, <mchehab@kernel.org>,
	<michal.simek@xilinx.com>
Cc: <linux-media@vger.kernel.org>,
	<linux-arm-kernel@lists.infradead.org>,
	<linux-kernel@vger.kernel.org>
Subject: Re: [PATCH] media: platform: xilinx: fix error return code of xvip_graph_init()
Date: Fri, 5 Mar 2021 11:08:15 +0100	[thread overview]
Message-ID: <d5b346cb-5949-ec40-918b-59041d60929b@xilinx.com> (raw)
In-Reply-To: <20210305094819.13685-1-baijiaju1990@gmail.com>



On 3/5/21 10:48 AM, Jia-Ju Bai wrote:
> When the list of xdev->notifier.asd_list is empty, no error return code
> of xvip_graph_init() is assigned.
> To fix this bug, ret is assigned with -ENOENT as error return code.
> 
> Reported-by: TOTE Robot <oslab@tsinghua.edu.cn>
> Signed-off-by: Jia-Ju Bai <baijiaju1990@gmail.com>
> ---
>  drivers/media/platform/xilinx/xilinx-vipp.c | 1 +
>  1 file changed, 1 insertion(+)
> 
> diff --git a/drivers/media/platform/xilinx/xilinx-vipp.c b/drivers/media/platform/xilinx/xilinx-vipp.c
> index bf4015d852e3..2ce31d7ce1a6 100644
> --- a/drivers/media/platform/xilinx/xilinx-vipp.c
> +++ b/drivers/media/platform/xilinx/xilinx-vipp.c
> @@ -525,6 +525,7 @@ static int xvip_graph_init(struct xvip_composite_device *xdev)
>  
>  	if (list_empty(&xdev->notifier.asd_list)) {
>  		dev_err(xdev->dev, "no subdev found in graph\n");
> +		ret = -ENOENT;
>  		goto done;
>  	}
>  
> 

Reviewed-by: Michal Simek <michal.simek@xilinx.com>

Thanks,
Michal

WARNING: multiple messages have this Message-ID (diff)
From: Michal Simek <michal.simek@xilinx.com>
To: Jia-Ju Bai <baijiaju1990@gmail.com>, <hyun.kwon@xilinx.com>,
	<laurent.pinchart@ideasonboard.com>, <mchehab@kernel.org>,
	<michal.simek@xilinx.com>
Cc: <linux-media@vger.kernel.org>,
	<linux-arm-kernel@lists.infradead.org>,
	<linux-kernel@vger.kernel.org>
Subject: Re: [PATCH] media: platform: xilinx: fix error return code of xvip_graph_init()
Date: Fri, 5 Mar 2021 11:08:15 +0100	[thread overview]
Message-ID: <d5b346cb-5949-ec40-918b-59041d60929b@xilinx.com> (raw)
In-Reply-To: <20210305094819.13685-1-baijiaju1990@gmail.com>



On 3/5/21 10:48 AM, Jia-Ju Bai wrote:
> When the list of xdev->notifier.asd_list is empty, no error return code
> of xvip_graph_init() is assigned.
> To fix this bug, ret is assigned with -ENOENT as error return code.
> 
> Reported-by: TOTE Robot <oslab@tsinghua.edu.cn>
> Signed-off-by: Jia-Ju Bai <baijiaju1990@gmail.com>
> ---
>  drivers/media/platform/xilinx/xilinx-vipp.c | 1 +
>  1 file changed, 1 insertion(+)
> 
> diff --git a/drivers/media/platform/xilinx/xilinx-vipp.c b/drivers/media/platform/xilinx/xilinx-vipp.c
> index bf4015d852e3..2ce31d7ce1a6 100644
> --- a/drivers/media/platform/xilinx/xilinx-vipp.c
> +++ b/drivers/media/platform/xilinx/xilinx-vipp.c
> @@ -525,6 +525,7 @@ static int xvip_graph_init(struct xvip_composite_device *xdev)
>  
>  	if (list_empty(&xdev->notifier.asd_list)) {
>  		dev_err(xdev->dev, "no subdev found in graph\n");
> +		ret = -ENOENT;
>  		goto done;
>  	}
>  
> 

Reviewed-by: Michal Simek <michal.simek@xilinx.com>

Thanks,
Michal

_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel

  reply	other threads:[~2021-03-05 10:09 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-03-05  9:48 [PATCH] media: platform: xilinx: fix error return code of xvip_graph_init() Jia-Ju Bai
2021-03-05  9:48 ` Jia-Ju Bai
2021-03-05 10:08 ` Michal Simek [this message]
2021-03-05 10:08   ` Michal Simek

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=d5b346cb-5949-ec40-918b-59041d60929b@xilinx.com \
    --to=michal.simek@xilinx.com \
    --cc=baijiaju1990@gmail.com \
    --cc=hyun.kwon@xilinx.com \
    --cc=laurent.pinchart@ideasonboard.com \
    --cc=linux-arm-kernel@lists.infradead.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-media@vger.kernel.org \
    --cc=mchehab@kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.