All of lore.kernel.org
 help / color / mirror / Atom feed
* [PATCH] media: platform: xilinx: fix error return code of xvip_graph_init()
@ 2021-03-05  9:48 ` Jia-Ju Bai
  0 siblings, 0 replies; 4+ messages in thread
From: Jia-Ju Bai @ 2021-03-05  9:48 UTC (permalink / raw)
  To: hyun.kwon, laurent.pinchart, mchehab, michal.simek
  Cc: linux-media, linux-arm-kernel, linux-kernel, Jia-Ju Bai

When the list of xdev->notifier.asd_list is empty, no error return code
of xvip_graph_init() is assigned.
To fix this bug, ret is assigned with -ENOENT as error return code.

Reported-by: TOTE Robot <oslab@tsinghua.edu.cn>
Signed-off-by: Jia-Ju Bai <baijiaju1990@gmail.com>
---
 drivers/media/platform/xilinx/xilinx-vipp.c | 1 +
 1 file changed, 1 insertion(+)

diff --git a/drivers/media/platform/xilinx/xilinx-vipp.c b/drivers/media/platform/xilinx/xilinx-vipp.c
index bf4015d852e3..2ce31d7ce1a6 100644
--- a/drivers/media/platform/xilinx/xilinx-vipp.c
+++ b/drivers/media/platform/xilinx/xilinx-vipp.c
@@ -525,6 +525,7 @@ static int xvip_graph_init(struct xvip_composite_device *xdev)
 
 	if (list_empty(&xdev->notifier.asd_list)) {
 		dev_err(xdev->dev, "no subdev found in graph\n");
+		ret = -ENOENT;
 		goto done;
 	}
 
-- 
2.17.1


^ permalink raw reply related	[flat|nested] 4+ messages in thread
* [PATCH] media: platform: xilinx: fix error return code of xvip_graph_init()
@ 2021-03-05  9:48 ` Jia-Ju Bai
  0 siblings, 0 replies; 4+ messages in thread
From: Jia-Ju Bai @ 2021-03-05  9:48 UTC (permalink / raw)
  To: hyun.kwon, laurent.pinchart, mchehab, michal.simek
  Cc: linux-media, linux-arm-kernel, linux-kernel, Jia-Ju Bai

When the list of xdev->notifier.asd_list is empty, no error return code
of xvip_graph_init() is assigned.
To fix this bug, ret is assigned with -ENOENT as error return code.

Reported-by: TOTE Robot <oslab@tsinghua.edu.cn>
Signed-off-by: Jia-Ju Bai <baijiaju1990@gmail.com>
---
 drivers/media/platform/xilinx/xilinx-vipp.c | 1 +
 1 file changed, 1 insertion(+)

diff --git a/drivers/media/platform/xilinx/xilinx-vipp.c b/drivers/media/platform/xilinx/xilinx-vipp.c
index bf4015d852e3..2ce31d7ce1a6 100644
--- a/drivers/media/platform/xilinx/xilinx-vipp.c
+++ b/drivers/media/platform/xilinx/xilinx-vipp.c
@@ -525,6 +525,7 @@ static int xvip_graph_init(struct xvip_composite_device *xdev)
 
 	if (list_empty(&xdev->notifier.asd_list)) {
 		dev_err(xdev->dev, "no subdev found in graph\n");
+		ret = -ENOENT;
 		goto done;
 	}
 
-- 
2.17.1


_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel

^ permalink raw reply related	[flat|nested] 4+ messages in thread
* Re: [PATCH] media: platform: xilinx: fix error return code of xvip_graph_init()
  2021-03-05  9:48 ` Jia-Ju Bai
@ 2021-03-05 10:08   ` Michal Simek
  -1 siblings, 0 replies; 4+ messages in thread
From: Michal Simek @ 2021-03-05 10:08 UTC (permalink / raw)
  To: Jia-Ju Bai, hyun.kwon, laurent.pinchart, mchehab, michal.simek
  Cc: linux-media, linux-arm-kernel, linux-kernel



On 3/5/21 10:48 AM, Jia-Ju Bai wrote:
> When the list of xdev->notifier.asd_list is empty, no error return code
> of xvip_graph_init() is assigned.
> To fix this bug, ret is assigned with -ENOENT as error return code.
> 
> Reported-by: TOTE Robot <oslab@tsinghua.edu.cn>
> Signed-off-by: Jia-Ju Bai <baijiaju1990@gmail.com>
> ---
>  drivers/media/platform/xilinx/xilinx-vipp.c | 1 +
>  1 file changed, 1 insertion(+)
> 
> diff --git a/drivers/media/platform/xilinx/xilinx-vipp.c b/drivers/media/platform/xilinx/xilinx-vipp.c
> index bf4015d852e3..2ce31d7ce1a6 100644
> --- a/drivers/media/platform/xilinx/xilinx-vipp.c
> +++ b/drivers/media/platform/xilinx/xilinx-vipp.c
> @@ -525,6 +525,7 @@ static int xvip_graph_init(struct xvip_composite_device *xdev)
>  
>  	if (list_empty(&xdev->notifier.asd_list)) {
>  		dev_err(xdev->dev, "no subdev found in graph\n");
> +		ret = -ENOENT;
>  		goto done;
>  	}
>  
> 

Reviewed-by: Michal Simek <michal.simek@xilinx.com>

Thanks,
Michal

^ permalink raw reply	[flat|nested] 4+ messages in thread
* Re: [PATCH] media: platform: xilinx: fix error return code of xvip_graph_init()
@ 2021-03-05 10:08   ` Michal Simek
  0 siblings, 0 replies; 4+ messages in thread
From: Michal Simek @ 2021-03-05 10:08 UTC (permalink / raw)
  To: Jia-Ju Bai, hyun.kwon, laurent.pinchart, mchehab, michal.simek
  Cc: linux-media, linux-arm-kernel, linux-kernel



On 3/5/21 10:48 AM, Jia-Ju Bai wrote:
> When the list of xdev->notifier.asd_list is empty, no error return code
> of xvip_graph_init() is assigned.
> To fix this bug, ret is assigned with -ENOENT as error return code.
> 
> Reported-by: TOTE Robot <oslab@tsinghua.edu.cn>
> Signed-off-by: Jia-Ju Bai <baijiaju1990@gmail.com>
> ---
>  drivers/media/platform/xilinx/xilinx-vipp.c | 1 +
>  1 file changed, 1 insertion(+)
> 
> diff --git a/drivers/media/platform/xilinx/xilinx-vipp.c b/drivers/media/platform/xilinx/xilinx-vipp.c
> index bf4015d852e3..2ce31d7ce1a6 100644
> --- a/drivers/media/platform/xilinx/xilinx-vipp.c
> +++ b/drivers/media/platform/xilinx/xilinx-vipp.c
> @@ -525,6 +525,7 @@ static int xvip_graph_init(struct xvip_composite_device *xdev)
>  
>  	if (list_empty(&xdev->notifier.asd_list)) {
>  		dev_err(xdev->dev, "no subdev found in graph\n");
> +		ret = -ENOENT;
>  		goto done;
>  	}
>  
> 

Reviewed-by: Michal Simek <michal.simek@xilinx.com>

Thanks,
Michal

_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel

^ permalink raw reply	[flat|nested] 4+ messages in thread
end of thread, other threads:[~2021-03-05 10:11 UTC | newest]

Thread overview: 4+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2021-03-05  9:48 [PATCH] media: platform: xilinx: fix error return code of xvip_graph_init() Jia-Ju Bai
2021-03-05  9:48 ` Jia-Ju Bai
2021-03-05 10:08 ` Michal Simek
2021-03-05 10:08   ` Michal Simek

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.