[PATCH 1/2] drm/omapdrm: drop fb_debug_enter/leave

[PATCH 1/2] drm/omapdrm: drop fb_debug_enter/leave

[Daniel Vetter]

This is a no-op on atomic drivers because with atomic it's simply too
complicated to get all the locking and workers and nonblocking
synchronization correct, from essentially an NMI context. Well, too
complicated = impossible. Also, omapdrm never implemented the
mode_set_base_atomic hook, so I kinda wonder why this was ever added.

Drop the hooks.

Signed-off-by: Daniel Vetter <daniel.vetter@intel.com>
Cc: Tomi Valkeinen <tomi.valkeinen@ti.com>
---
 drivers/gpu/drm/omapdrm/omap_fbdev.c | 2 --
 1 file changed, 2 deletions(-)

diff --git a/drivers/gpu/drm/omapdrm/omap_fbdev.c b/drivers/gpu/drm/omapdrm/omap_fbdev.c
index 50aabd854f4d..0dad42e819ba 100644
--- a/drivers/gpu/drm/omapdrm/omap_fbdev.c
+++ b/drivers/gpu/drm/omapdrm/omap_fbdev.c
@@ -87,8 +87,6 @@ static struct fb_ops omap_fb_ops = {
 	.fb_setcmap	= drm_fb_helper_setcmap,
 	.fb_blank	= drm_fb_helper_blank,
 	.fb_pan_display = omap_fbdev_pan_display,
-	.fb_debug_enter = drm_fb_helper_debug_enter,
-	.fb_debug_leave = drm_fb_helper_debug_leave,
 	.fb_ioctl	= drm_fb_helper_ioctl,
 
 	.fb_read = drm_fb_helper_sys_read,
-- 
2.20.1

_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/dri-devel

[PATCH 2/2] drm/ast: Drop fb_debug_enter/leave

[Daniel Vetter]

ast doesn't implement the mode_set_base_atomic hook this would need,
so this is dead code.

Signed-off-by: Daniel Vetter <daniel.vetter@intel.com>
Cc: Dave Airlie <airlied@redhat.com>
Cc: Daniel Vetter <daniel.vetter@ffwll.ch>
Cc: Gerd Hoffmann <kraxel@redhat.com>
Cc: Thomas Zimmermann <tzimmermann@suse.de>
Cc: Alex Deucher <alexander.deucher@amd.com>
Cc: Sam Bobroff <sbobroff@linux.ibm.com>
Cc: Sam Ravnborg <sam@ravnborg.org>
Cc: YueHaibing <yuehaibing@huawei.com>
---
 drivers/gpu/drm/ast/ast_fb.c | 2 --
 1 file changed, 2 deletions(-)

diff --git a/drivers/gpu/drm/ast/ast_fb.c b/drivers/gpu/drm/ast/ast_fb.c
index 05f45222b702..5480caecde86 100644
--- a/drivers/gpu/drm/ast/ast_fb.c
+++ b/drivers/gpu/drm/ast/ast_fb.c
@@ -166,8 +166,6 @@ static struct fb_ops astfb_ops = {
 	.fb_pan_display = drm_fb_helper_pan_display,
 	.fb_blank = drm_fb_helper_blank,
 	.fb_setcmap = drm_fb_helper_setcmap,
-	.fb_debug_enter = drm_fb_helper_debug_enter,
-	.fb_debug_leave = drm_fb_helper_debug_leave,
 };
 
 static int astfb_create_object(struct ast_fbdev *afbdev,
-- 
2.20.1

_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/dri-devel

Re: [PATCH 1/2] drm/omapdrm: drop fb_debug_enter/leave

[Tomi Valkeinen]

On 12/06/2019 12:12, Daniel Vetter wrote:
> This is a no-op on atomic drivers because with atomic it's simply too
> complicated to get all the locking and workers and nonblocking
> synchronization correct, from essentially an NMI context. Well, too
> complicated = impossible. Also, omapdrm never implemented the
> mode_set_base_atomic hook, so I kinda wonder why this was ever added.
> 
> Drop the hooks.

f9b34a0fa4e25d9c0b72f124680c37c0c38f9934

It was just open coding DRM_FB_HELPER_DEFAULT_OPS, to get rid of 
"Initializer entry defined twice" warning.

Acked-by: Tomi Valkeinen <tomi.valkeinen@ti.com>

Or I can pick it up to my branch if this is not part of a bigger series.

  Tomi

-- 
Texas Instruments Finland Oy, Porkkalankatu 22, 00180 Helsinki.
Y-tunnus/Business ID: 0615521-4. Kotipaikka/Domicile: Helsinki
_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/dri-devel

Re: [PATCH 1/2] drm/omapdrm: drop fb_debug_enter/leave

[Daniel Vetter]

On Wed, Jun 12, 2019 at 11:19 AM Tomi Valkeinen <tomi.valkeinen@ti.com> wrote:
>
> On 12/06/2019 12:12, Daniel Vetter wrote:
> > This is a no-op on atomic drivers because with atomic it's simply too
> > complicated to get all the locking and workers and nonblocking
> > synchronization correct, from essentially an NMI context. Well, too
> > complicated = impossible. Also, omapdrm never implemented the
> > mode_set_base_atomic hook, so I kinda wonder why this was ever added.
> >
> > Drop the hooks.
>
> f9b34a0fa4e25d9c0b72f124680c37c0c38f9934
>
> It was just open coding DRM_FB_HELPER_DEFAULT_OPS, to get rid of
> "Initializer entry defined twice" warning.
>
> Acked-by: Tomi Valkeinen <tomi.valkeinen@ti.com>
>
> Or I can pick it up to my branch if this is not part of a bigger series.

Not part of a bigger series, there's still a bunch of real users of
this in-tree. Although given how absolutely no one seems to care to
make kgdb work on top of atomic drivers I'm hoping I can sunset all
this code soon.
-Daniel
-- 
Daniel Vetter
Software Engineer, Intel Corporation
+41 (0) 79 365 57 48 - http://blog.ffwll.ch
_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/dri-devel

Re: [PATCH 2/2] drm/ast: Drop fb_debug_enter/leave

[Thomas Zimmermann]

[-- Attachment #1.1.1: Type: text/plain, Size: 1442 bytes --]

Acked-by: Thomas Zimmermann <tzimmermann@suse.de>

Am 12.06.19 um 11:12 schrieb Daniel Vetter:
> ast doesn't implement the mode_set_base_atomic hook this would need,
> so this is dead code.
> 
> Signed-off-by: Daniel Vetter <daniel.vetter@intel.com>
> Cc: Dave Airlie <airlied@redhat.com>
> Cc: Daniel Vetter <daniel.vetter@ffwll.ch>
> Cc: Gerd Hoffmann <kraxel@redhat.com>
> Cc: Thomas Zimmermann <tzimmermann@suse.de>
> Cc: Alex Deucher <alexander.deucher@amd.com>
> Cc: Sam Bobroff <sbobroff@linux.ibm.com>
> Cc: Sam Ravnborg <sam@ravnborg.org>
> Cc: YueHaibing <yuehaibing@huawei.com>
> ---
>  drivers/gpu/drm/ast/ast_fb.c | 2 --
>  1 file changed, 2 deletions(-)
> 
> diff --git a/drivers/gpu/drm/ast/ast_fb.c b/drivers/gpu/drm/ast/ast_fb.c
> index 05f45222b702..5480caecde86 100644
> --- a/drivers/gpu/drm/ast/ast_fb.c
> +++ b/drivers/gpu/drm/ast/ast_fb.c
> @@ -166,8 +166,6 @@ static struct fb_ops astfb_ops = {
>  	.fb_pan_display = drm_fb_helper_pan_display,
>  	.fb_blank = drm_fb_helper_blank,
>  	.fb_setcmap = drm_fb_helper_setcmap,
> -	.fb_debug_enter = drm_fb_helper_debug_enter,
> -	.fb_debug_leave = drm_fb_helper_debug_leave,
>  };
>  
>  static int astfb_create_object(struct ast_fbdev *afbdev,
> 

-- 
Thomas Zimmermann
Graphics Driver Developer
SUSE Linux GmbH, Maxfeldstrasse 5, 90409 Nuernberg, Germany
GF: Felix Imendörffer, Mary Higgins, Sri Rasiah
HRB 21284 (AG Nürnberg)


[-- Attachment #1.2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 488 bytes --]

[-- Attachment #2: Type: text/plain, Size: 159 bytes --]

_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/dri-devel

Re: [PATCH 2/2] drm/ast: Drop fb_debug_enter/leave

[Daniel Vetter]

On Thu, Jun 13, 2019 at 08:45:49AM +0200, Thomas Zimmermann wrote:
> Acked-by: Thomas Zimmermann <tzimmermann@suse.de>

Thanks for taking a look, pushed to drm-misc-next.
-Daniel

> 
> Am 12.06.19 um 11:12 schrieb Daniel Vetter:
> > ast doesn't implement the mode_set_base_atomic hook this would need,
> > so this is dead code.
> > 
> > Signed-off-by: Daniel Vetter <daniel.vetter@intel.com>
> > Cc: Dave Airlie <airlied@redhat.com>
> > Cc: Daniel Vetter <daniel.vetter@ffwll.ch>
> > Cc: Gerd Hoffmann <kraxel@redhat.com>
> > Cc: Thomas Zimmermann <tzimmermann@suse.de>
> > Cc: Alex Deucher <alexander.deucher@amd.com>
> > Cc: Sam Bobroff <sbobroff@linux.ibm.com>
> > Cc: Sam Ravnborg <sam@ravnborg.org>
> > Cc: YueHaibing <yuehaibing@huawei.com>
> > ---
> >  drivers/gpu/drm/ast/ast_fb.c | 2 --
> >  1 file changed, 2 deletions(-)
> > 
> > diff --git a/drivers/gpu/drm/ast/ast_fb.c b/drivers/gpu/drm/ast/ast_fb.c
> > index 05f45222b702..5480caecde86 100644
> > --- a/drivers/gpu/drm/ast/ast_fb.c
> > +++ b/drivers/gpu/drm/ast/ast_fb.c
> > @@ -166,8 +166,6 @@ static struct fb_ops astfb_ops = {
> >  	.fb_pan_display = drm_fb_helper_pan_display,
> >  	.fb_blank = drm_fb_helper_blank,
> >  	.fb_setcmap = drm_fb_helper_setcmap,
> > -	.fb_debug_enter = drm_fb_helper_debug_enter,
> > -	.fb_debug_leave = drm_fb_helper_debug_leave,
> >  };
> >  
> >  static int astfb_create_object(struct ast_fbdev *afbdev,
> > 
> 
> -- 
> Thomas Zimmermann
> Graphics Driver Developer
> SUSE Linux GmbH, Maxfeldstrasse 5, 90409 Nuernberg, Germany
> GF: Felix Imendörffer, Mary Higgins, Sri Rasiah
> HRB 21284 (AG Nürnberg)
> 




-- 
Daniel Vetter
Software Engineer, Intel Corporation
http://blog.ffwll.ch
_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/dri-devel