[Buildroot] [PATCH v2] toolchain: remove binutils bug 21464

[Buildroot] [PATCH v2] toolchain: remove binutils bug 21464

[Giulio Benetti]

This bug has been fixed upstream and backported to buildroot binutils
package. So let's remove it from toolchain/Config.in and from packages
that are affected by it:
- libgeos
- postgis
- protobuf

Signed-off-by: Giulio Benetti <giulio.benetti@benettiengineering.com>
---
V1->V2:
* squashed 4 different patches into one
---
 package/libgeos/Config.in  | 4 +---
 package/postgis/Config.in  | 4 +---
 package/protobuf/Config.in | 1 -
 toolchain/Config.in        | 6 ------
 4 files changed, 2 insertions(+), 13 deletions(-)

diff --git a/package/libgeos/Config.in b/package/libgeos/Config.in
index 86a1cddcf3..124e2da661 100644
--- a/package/libgeos/Config.in
+++ b/package/libgeos/Config.in
@@ -2,7 +2,6 @@ config BR2_PACKAGE_LIBGEOS
 	bool "libgeos"
 	depends on BR2_INSTALL_LIBSTDCPP
 	depends on BR2_USE_WCHAR
-	depends on !BR2_TOOLCHAIN_HAS_BINUTILS_BUG_21464
 	depends on !BR2_TOOLCHAIN_HAS_BINUTILS_BUG_27597
 	help
 	  GEOS (Geometry Engine - Open Source) is a C++ port of the
@@ -13,7 +12,6 @@ config BR2_PACKAGE_LIBGEOS
 
 	  https://trac.osgeo.org/geos
 
-comment "libgeos needs a toolchain w/ C++, wchar, not binutils bug 21464, 27597"
+comment "libgeos needs a toolchain w/ C++, wchar, not binutils bug 27597"
 	depends on !BR2_INSTALL_LIBSTDCPP || !BR2_USE_WCHAR || \
-		   BR2_TOOLCHAIN_HAS_BINUTILS_BUG_21464 || \
 		   BR2_TOOLCHAIN_HAS_BINUTILS_BUG_27597
diff --git a/package/postgis/Config.in b/package/postgis/Config.in
index 04705f7e16..78c52ea7b2 100644
--- a/package/postgis/Config.in
+++ b/package/postgis/Config.in
@@ -6,7 +6,6 @@ config BR2_PACKAGE_POSTGIS
 	depends on BR2_TOOLCHAIN_GCC_AT_LEAST_4_7 # C++11, proj
 	depends on BR2_TOOLCHAIN_HAS_THREADS # proj
 	depends on BR2_USE_WCHAR # libgeos, proj
-	depends on !BR2_TOOLCHAIN_HAS_BINUTILS_BUG_21464 # libgeos
 	depends on !BR2_TOOLCHAIN_HAS_BINUTILS_BUG_27597 # libgeos
 	select BR2_PACKAGE_LIBGEOS
 	select BR2_PACKAGE_PROJ
@@ -20,9 +19,8 @@ config BR2_PACKAGE_POSTGIS
 
 	  https://postgis.net/
 
-comment "postgis needs a toolchain w/ C++, threads, wchar, gcc >= 4.7, not binutils bug 21464, 27597"
+comment "postgis needs a toolchain w/ C++, threads, wchar, gcc >= 4.7, not binutils bug 27597"
 	depends on !BR2_microblazeel && !BR2_microblazebe # ICE
 	depends on !BR2_INSTALL_LIBSTDCPP || !BR2_TOOLCHAIN_GCC_AT_LEAST_4_7 || \
 		!BR2_TOOLCHAIN_HAS_THREADS || !BR2_USE_WCHAR || \
-		BR2_TOOLCHAIN_HAS_BINUTILS_BUG_21464 || \
 		BR2_TOOLCHAIN_HAS_BINUTILS_BUG_27597
diff --git a/package/protobuf/Config.in b/package/protobuf/Config.in
index 30050950aa..46c820b9cf 100644
--- a/package/protobuf/Config.in
+++ b/package/protobuf/Config.in
@@ -24,7 +24,6 @@ config BR2_PACKAGE_PROTOBUF_ARCH_SUPPORTS
 	default y if BR2_TOOLCHAIN_HAS_ATOMIC
 	depends on BR2_HOSTARCH = "x86_64" || BR2_HOSTARCH = "x86"
 	depends on BR2_USE_MMU # fork()
-	depends on !BR2_TOOLCHAIN_HAS_BINUTILS_BUG_21464
 
 config BR2_PACKAGE_PROTOBUF
 	bool "protobuf"
diff --git a/toolchain/Config.in b/toolchain/Config.in
index 78444f6130..06c338ee7d 100644
--- a/toolchain/Config.in
+++ b/toolchain/Config.in
@@ -71,12 +71,6 @@ source "package/gdb/Config.in.host"
 
 comment "Toolchain Generic Options"
 
-# https://sourceware.org/bugzilla/show_bug.cgi?id=21464
-# Affect toolchains built with binutils 2.31.1, still not fixed.
-config BR2_TOOLCHAIN_HAS_BINUTILS_BUG_21464
-	bool
-	default y if BR2_or1k
-
 # https://sourceware.org/bugzilla/show_bug.cgi?id=27100
 # Affect toolchains built with binutils 2.33.1 (fixed in binutils 2.36)
 config BR2_TOOLCHAIN_HAS_BINUTILS_BUG_27100
-- 
2.25.1

[Buildroot] [PATCH v2] toolchain: remove binutils bug 21464

[Maxim Kochetkov]

21.05.2021 17:09, Giulio Benetti wrote:
> This bug has been fixed upstream and backported to buildroot binutils
> package. So let's remove it from toolchain/Config.in and from packages
> that are affected by it:
> - libgeos
> - postgis
> - protobuf
> 
> Signed-off-by: Giulio Benetti <giulio.benetti@benettiengineering.com>
> ---
> V1->V2:
> * squashed 4 different patches into one
> ---
>   package/libgeos/Config.in  | 4 +---
>   package/postgis/Config.in  | 4 +---
>   package/protobuf/Config.in | 1 -
>   toolchain/Config.in        | 6 ------
>   4 files changed, 2 insertions(+), 13 deletions(-)

Reviewed-by: Maxim Kochetkov <fido_max@inbox.ru>

Re: [Buildroot] [PATCH v2] toolchain: remove binutils bug 21464

[Thomas Petazzoni]

On Fri, 21 May 2021 16:09:42 +0200
Giulio Benetti <giulio.benetti@benettiengineering.com> wrote:

> This bug has been fixed upstream and backported to buildroot binutils
> package. So let's remove it from toolchain/Config.in and from packages
> that are affected by it:
> - libgeos
> - postgis
> - protobuf
> 
> Signed-off-by: Giulio Benetti <giulio.benetti@benettiengineering.com>
> ---
> V1->V2:
> * squashed 4 different patches into one
> ---
>  package/libgeos/Config.in  | 4 +---
>  package/postgis/Config.in  | 4 +---
>  package/protobuf/Config.in | 1 -
>  toolchain/Config.in        | 6 ------
>  4 files changed, 2 insertions(+), 13 deletions(-)

Applied to master, thanks.

Thomas
-- 
Thomas Petazzoni, CTO, Bootlin
Embedded Linux and Kernel engineering
https://bootlin.com
_______________________________________________
buildroot mailing list
buildroot@busybox.net
http://lists.busybox.net/mailman/listinfo/buildroot

Re: [Buildroot] [PATCH v2] toolchain: remove binutils bug 21464

[Thomas Petazzoni]

On Fri, 21 May 2021 16:09:42 +0200
Giulio Benetti <giulio.benetti@benettiengineering.com> wrote:

> This bug has been fixed upstream and backported to buildroot binutils
> package. So let's remove it from toolchain/Config.in and from packages
> that are affected by it:
> - libgeos
> - postgis
> - protobuf
> 
> Signed-off-by: Giulio Benetti <giulio.benetti@benettiengineering.com>
> ---
> V1->V2:
> * squashed 4 different patches into one
> ---
>  package/libgeos/Config.in  | 4 +---
>  package/postgis/Config.in  | 4 +---
>  package/protobuf/Config.in | 1 -
>  toolchain/Config.in        | 6 ------
>  4 files changed, 2 insertions(+), 13 deletions(-)

In fact, no I reverted this patch. It depends on other patches to be
applied first. This is an illustration of why you should *never* ever
resend just a single patch out of a larger series. Even if only one
patch is changed, please resend the entire series.

Could you update your "Fix binutils bug 21464 and remove it" series and
resend it?

Thanks,

Thomas
-- 
Thomas Petazzoni, CTO, Bootlin
Embedded Linux and Kernel engineering
https://bootlin.com
_______________________________________________
buildroot mailing list
buildroot@busybox.net
http://lists.busybox.net/mailman/listinfo/buildroot

Re: [Buildroot] [PATCH v2] toolchain: remove binutils bug 21464

[Giulio Benetti]

> Il giorno 26 lug 2021, alle ore 23:57, Thomas Petazzoni <thomas.petazzoni@bootlin.com> ha scritto:
> 
> On Fri, 21 May 2021 16:09:42 +0200
> Giulio Benetti <giulio.benetti@benettiengineering.com> wrote:
> 
>> This bug has been fixed upstream and backported to buildroot binutils
>> package. So let's remove it from toolchain/Config.in and from packages
>> that are affected by it:
>> - libgeos
>> - postgis
>> - protobuf
>> 
>> Signed-off-by: Giulio Benetti <giulio.benetti@benettiengineering.com>
>> ---
>> V1->V2:
>> * squashed 4 different patches into one
>> ---
>> package/libgeos/Config.in  | 4 +---
>> package/postgis/Config.in  | 4 +---
>> package/protobuf/Config.in | 1 -
>> toolchain/Config.in        | 6 ------
>> 4 files changed, 2 insertions(+), 13 deletions(-)
> 
> In fact, no I reverted this patch. It depends on other patches to be
> applied first. This is an illustration of why you should *never* ever
> resend just a single patch out of a larger series. Even if only one
> patch is changed, please resend the entire series.

Oh, I see the reason, sorry.

> 
> Could you update your "Fix binutils bug 21464 and remove it" series and
> resend it?

Sure I will.

Best regards
Giulio Benetti

> 
> Thanks,
> 
> Thomas
> -- 
> Thomas Petazzoni, CTO, Bootlin
> Embedded Linux and Kernel engineering
> https://bootlin.com

_______________________________________________
buildroot mailing list
buildroot@busybox.net
http://lists.busybox.net/mailman/listinfo/buildroot

[Buildroot] [PATCH v2 0/3] Fix binutils bug 21464 and remove it

[Giulio Benetti]

This patchset fixes binutils bug 21464 and fixes libgeos and protobuf
packages build failure by introducing the gcc option flag -mcmodel.
This is done by adding upstreamed binutils and gcc patches.

Note:
this way buildroot toolchains can be considered bug binutils 21464 free
and the only other OpenRisc toolchain supported is the external Bootlin
one. So this patchset has to be considered valid once Bootlin updates its
OpenRisc by adding binutils and gcc patches that are added with patches in
this patchset.

V1->V2:
* squashed patches [6..9/9] into one resulting into
"toolchain: remove binutils bug 21464" where binutils bug gets removed all
around buildroot. Note that this patch has been sent as v2 alone but it
shouldn't have been since was part of this patchset and before it the
other 2 patches which add -mcmodel=large to libgeos and protobuf must be
applied.

Giulio Benetti (3):
  package/libgeos: fix build failure due to missing -mcmodel=large
  package/protobuf: fix build failure due to missing -mcmodel=large
  toolchain: remove binutils bug 21464

 package/libgeos/Config.in    | 4 +---
 package/libgeos/libgeos.mk   | 4 ++++
 package/postgis/Config.in    | 4 +---
 package/protobuf/Config.in   | 1 -
 package/protobuf/protobuf.mk | 4 ++++
 toolchain/Config.in          | 6 ------
 6 files changed, 10 insertions(+), 13 deletions(-)

-- 
2.25.1

_______________________________________________
buildroot mailing list
buildroot@busybox.net
http://lists.busybox.net/mailman/listinfo/buildroot

[Buildroot] [PATCH v2 1/3] package/libgeos: fix build failure due to missing -mcmodel=large

[Giulio Benetti]

When building libgeos for or1k -mcmodel=large is needed to link, so let's
add that gcc option in case we're building for or1k.

Signed-off-by: Giulio Benetti <giulio.benetti@benettiengineering.com>
---
 package/libgeos/libgeos.mk | 4 ++++
 1 file changed, 4 insertions(+)

diff --git a/package/libgeos/libgeos.mk b/package/libgeos/libgeos.mk
index a355732af8..43211d0434 100644
--- a/package/libgeos/libgeos.mk
+++ b/package/libgeos/libgeos.mk
@@ -23,6 +23,10 @@ ifeq ($(BR2_arm)$(BR2_armeb),y)
 LIBGEOS_CONF_OPTS += -DDISABLE_GEOS_INLINE=ON
 endif
 
+ifeq ($(BR2_or1k),y)
+LIBGEOS_CXXFLAGS += -mcmodel=large
+endif
+
 LIBGEOS_CONF_OPTS += -DCMAKE_CXX_FLAGS="$(LIBGEOS_CXXFLAGS)"
 
 $(eval $(cmake-package))
-- 
2.25.1

_______________________________________________
buildroot mailing list
buildroot@busybox.net
http://lists.busybox.net/mailman/listinfo/buildroot

[Buildroot] [PATCH v2 2/3] package/protobuf: fix build failure due to missing -mcmodel=large

[Giulio Benetti]

When building protobuf for or1k -mcmodel=large is needed to link, so let's
add that gcc option in case we're building for or1k.

Signed-off-by: Giulio Benetti <giulio.benetti@benettiengineering.com>
---
 package/protobuf/protobuf.mk | 4 ++++
 1 file changed, 4 insertions(+)

diff --git a/package/protobuf/protobuf.mk b/package/protobuf/protobuf.mk
index 492917c5e8..75791fade2 100644
--- a/package/protobuf/protobuf.mk
+++ b/package/protobuf/protobuf.mk
@@ -24,6 +24,10 @@ ifeq ($(BR2_TOOLCHAIN_HAS_GCC_BUG_85180),y)
 PROTOBUF_CXXFLAGS += -O0
 endif
 
+ifeq ($(BR2_or1k),y)
+PROTOBUF_CXXFLAGS += -mcmodel=large
+endif
+
 PROTOBUF_CONF_ENV = CXXFLAGS="$(PROTOBUF_CXXFLAGS)"
 
 ifeq ($(BR2_TOOLCHAIN_HAS_LIBATOMIC),y)
-- 
2.25.1

_______________________________________________
buildroot mailing list
buildroot@busybox.net
http://lists.busybox.net/mailman/listinfo/buildroot

[Buildroot] [PATCH v2 3/3] toolchain: remove binutils bug 21464

[Giulio Benetti]

This bug has been fixed upstream and backported to buildroot binutils
package. So let's remove it from toolchain/Config.in and from packages
that are affected by it:
- libgeos
- postgis
- protobuf

Signed-off-by: Giulio Benetti <giulio.benetti@benettiengineering.com>
Reviewed-by: Maxim Kochetkov <fido_max@inbox.ru>
---
 package/libgeos/Config.in  | 4 +---
 package/postgis/Config.in  | 4 +---
 package/protobuf/Config.in | 1 -
 toolchain/Config.in        | 6 ------
 4 files changed, 2 insertions(+), 13 deletions(-)

diff --git a/package/libgeos/Config.in b/package/libgeos/Config.in
index 86a1cddcf3..124e2da661 100644
--- a/package/libgeos/Config.in
+++ b/package/libgeos/Config.in
@@ -2,7 +2,6 @@ config BR2_PACKAGE_LIBGEOS
 	bool "libgeos"
 	depends on BR2_INSTALL_LIBSTDCPP
 	depends on BR2_USE_WCHAR
-	depends on !BR2_TOOLCHAIN_HAS_BINUTILS_BUG_21464
 	depends on !BR2_TOOLCHAIN_HAS_BINUTILS_BUG_27597
 	help
 	  GEOS (Geometry Engine - Open Source) is a C++ port of the
@@ -13,7 +12,6 @@ config BR2_PACKAGE_LIBGEOS
 
 	  https://trac.osgeo.org/geos
 
-comment "libgeos needs a toolchain w/ C++, wchar, not binutils bug 21464, 27597"
+comment "libgeos needs a toolchain w/ C++, wchar, not binutils bug 27597"
 	depends on !BR2_INSTALL_LIBSTDCPP || !BR2_USE_WCHAR || \
-		   BR2_TOOLCHAIN_HAS_BINUTILS_BUG_21464 || \
 		   BR2_TOOLCHAIN_HAS_BINUTILS_BUG_27597
diff --git a/package/postgis/Config.in b/package/postgis/Config.in
index 04705f7e16..78c52ea7b2 100644
--- a/package/postgis/Config.in
+++ b/package/postgis/Config.in
@@ -6,7 +6,6 @@ config BR2_PACKAGE_POSTGIS
 	depends on BR2_TOOLCHAIN_GCC_AT_LEAST_4_7 # C++11, proj
 	depends on BR2_TOOLCHAIN_HAS_THREADS # proj
 	depends on BR2_USE_WCHAR # libgeos, proj
-	depends on !BR2_TOOLCHAIN_HAS_BINUTILS_BUG_21464 # libgeos
 	depends on !BR2_TOOLCHAIN_HAS_BINUTILS_BUG_27597 # libgeos
 	select BR2_PACKAGE_LIBGEOS
 	select BR2_PACKAGE_PROJ
@@ -20,9 +19,8 @@ config BR2_PACKAGE_POSTGIS
 
 	  https://postgis.net/
 
-comment "postgis needs a toolchain w/ C++, threads, wchar, gcc >= 4.7, not binutils bug 21464, 27597"
+comment "postgis needs a toolchain w/ C++, threads, wchar, gcc >= 4.7, not binutils bug 27597"
 	depends on !BR2_microblazeel && !BR2_microblazebe # ICE
 	depends on !BR2_INSTALL_LIBSTDCPP || !BR2_TOOLCHAIN_GCC_AT_LEAST_4_7 || \
 		!BR2_TOOLCHAIN_HAS_THREADS || !BR2_USE_WCHAR || \
-		BR2_TOOLCHAIN_HAS_BINUTILS_BUG_21464 || \
 		BR2_TOOLCHAIN_HAS_BINUTILS_BUG_27597
diff --git a/package/protobuf/Config.in b/package/protobuf/Config.in
index 30050950aa..46c820b9cf 100644
--- a/package/protobuf/Config.in
+++ b/package/protobuf/Config.in
@@ -24,7 +24,6 @@ config BR2_PACKAGE_PROTOBUF_ARCH_SUPPORTS
 	default y if BR2_TOOLCHAIN_HAS_ATOMIC
 	depends on BR2_HOSTARCH = "x86_64" || BR2_HOSTARCH = "x86"
 	depends on BR2_USE_MMU # fork()
-	depends on !BR2_TOOLCHAIN_HAS_BINUTILS_BUG_21464
 
 config BR2_PACKAGE_PROTOBUF
 	bool "protobuf"
diff --git a/toolchain/Config.in b/toolchain/Config.in
index 8603e2aaff..3598307b20 100644
--- a/toolchain/Config.in
+++ b/toolchain/Config.in
@@ -71,12 +71,6 @@ source "package/gdb/Config.in.host"
 
 comment "Toolchain Generic Options"
 
-# https://sourceware.org/bugzilla/show_bug.cgi?id=21464
-# Affect toolchains built with binutils 2.31.1, still not fixed.
-config BR2_TOOLCHAIN_HAS_BINUTILS_BUG_21464
-	bool
-	default y if BR2_or1k
-
 # https://sourceware.org/bugzilla/show_bug.cgi?id=27597
 # Affect toolchains built with binutils 2.36.1, still not fixed.
 config BR2_TOOLCHAIN_HAS_BINUTILS_BUG_27597
-- 
2.25.1

_______________________________________________
buildroot mailing list
buildroot@busybox.net
http://lists.busybox.net/mailman/listinfo/buildroot

Re: [Buildroot] [PATCH v2 1/3] package/libgeos: fix build failure due to missing -mcmodel=large

[Maxim Kochetkov via buildroot]

27.07.2021 01:34, Giulio Benetti wrote:
> When building libgeos for or1k -mcmodel=large is needed to link, so let's
> add that gcc option in case we're building for or1k.
> 
> Signed-off-by: Giulio Benetti <giulio.benetti@benettiengineering.com>
> ---
>   package/libgeos/libgeos.mk | 4 ++++
>   1 file changed, 4 insertions(+)
> 
> diff --git a/package/libgeos/libgeos.mk b/package/libgeos/libgeos.mk
> index a355732af8..43211d0434 100644
> --- a/package/libgeos/libgeos.mk
> +++ b/package/libgeos/libgeos.mk
> @@ -23,6 +23,10 @@ ifeq ($(BR2_arm)$(BR2_armeb),y)
>   LIBGEOS_CONF_OPTS += -DDISABLE_GEOS_INLINE=ON
>   endif
>   
> +ifeq ($(BR2_or1k),y)
> +LIBGEOS_CXXFLAGS += -mcmodel=large
> +endif
> +
>   LIBGEOS_CONF_OPTS += -DCMAKE_CXX_FLAGS="$(LIBGEOS_CXXFLAGS)"
>   
>   $(eval $(cmake-package))
> 
Reviewed-by: Maxim Kochetkov <fido_max@inbox.ru>
_______________________________________________
buildroot mailing list
buildroot@busybox.net
http://lists.busybox.net/mailman/listinfo/buildroot

Re: [Buildroot] [PATCH v2 2/3] package/protobuf: fix build failure due to missing -mcmodel=large

[Maxim Kochetkov]

27.07.2021 01:34, Giulio Benetti wrote:
> When building protobuf for or1k -mcmodel=large is needed to link, so let's
> add that gcc option in case we're building for or1k.
> 
> Signed-off-by: Giulio Benetti <giulio.benetti@benettiengineering.com>
> ---
>   package/protobuf/protobuf.mk | 4 ++++
>   1 file changed, 4 insertions(+)
> 
> diff --git a/package/protobuf/protobuf.mk b/package/protobuf/protobuf.mk
> index 492917c5e8..75791fade2 100644
> --- a/package/protobuf/protobuf.mk
> +++ b/package/protobuf/protobuf.mk
> @@ -24,6 +24,10 @@ ifeq ($(BR2_TOOLCHAIN_HAS_GCC_BUG_85180),y)
>   PROTOBUF_CXXFLAGS += -O0
>   endif
>   
> +ifeq ($(BR2_or1k),y)
> +PROTOBUF_CXXFLAGS += -mcmodel=large
> +endif
> +
>   PROTOBUF_CONF_ENV = CXXFLAGS="$(PROTOBUF_CXXFLAGS)"
>   
>   ifeq ($(BR2_TOOLCHAIN_HAS_LIBATOMIC),y)
> 
Reviewed-by: Maxim Kochetkov <fido_max@inbox.ru>
_______________________________________________
buildroot mailing list
buildroot@busybox.net
http://lists.busybox.net/mailman/listinfo/buildroot

Re: [Buildroot] [PATCH v2 1/3] package/libgeos: fix build failure due to missing -mcmodel=large

[Arnout Vandecappelle]

On 27/07/2021 00:34, Giulio Benetti wrote:
> When building libgeos for or1k -mcmodel=large is needed to link, so let's
> add that gcc option in case we're building for or1k.
> 
> Signed-off-by: Giulio Benetti <giulio.benetti@benettiengineering.com>
> ---
>  package/libgeos/libgeos.mk | 4 ++++
>  1 file changed, 4 insertions(+)
> 
> diff --git a/package/libgeos/libgeos.mk b/package/libgeos/libgeos.mk
> index a355732af8..43211d0434 100644
> --- a/package/libgeos/libgeos.mk
> +++ b/package/libgeos/libgeos.mk
> @@ -23,6 +23,10 @@ ifeq ($(BR2_arm)$(BR2_armeb),y)
>  LIBGEOS_CONF_OPTS += -DDISABLE_GEOS_INLINE=ON
>  endif
>  
> +ifeq ($(BR2_or1k),y)
> +LIBGEOS_CXXFLAGS += -mcmodel=large

 According to git, -mcmodel was added to GCC after the 11.2.0 release. Are you
sure that this works?

 Oooh, we have a patch that adds it. But that patch is missing for 11.1.0 for
some reason. Romain, you apparently didn't carry any of our patches when you
added GCC 11 in 2ab88dac293aed5adf2504e8b182f9d8a306b935. The commit message
doesn't say anything. Do you remember anything about the patches? The patch was
added to master on May 21 and you only submitted the GCC bump on June 12, but
perhaps you already had it lying around for a while?

 Giulio, maybe you can port the patch to 11.1.0?

 Regards,
 Arnout

> +endif
> +
>  LIBGEOS_CONF_OPTS += -DCMAKE_CXX_FLAGS="$(LIBGEOS_CXXFLAGS)"
>  
>  $(eval $(cmake-package))
> 
_______________________________________________
buildroot mailing list
buildroot@busybox.net
http://lists.busybox.net/mailman/listinfo/buildroot

Re: [Buildroot] [PATCH v2 1/3] package/libgeos: fix build failure due to missing -mcmodel=large

[Giulio Benetti]

Hi Arnout,

On 8/17/21 10:34 PM, Arnout Vandecappelle wrote:
> 
> 
> On 27/07/2021 00:34, Giulio Benetti wrote:
>> When building libgeos for or1k -mcmodel=large is needed to link, so let's
>> add that gcc option in case we're building for or1k.
>>
>> Signed-off-by: Giulio Benetti <giulio.benetti@benettiengineering.com>
>> ---
>>   package/libgeos/libgeos.mk | 4 ++++
>>   1 file changed, 4 insertions(+)
>>
>> diff --git a/package/libgeos/libgeos.mk b/package/libgeos/libgeos.mk
>> index a355732af8..43211d0434 100644
>> --- a/package/libgeos/libgeos.mk
>> +++ b/package/libgeos/libgeos.mk
>> @@ -23,6 +23,10 @@ ifeq ($(BR2_arm)$(BR2_armeb),y)
>>   LIBGEOS_CONF_OPTS += -DDISABLE_GEOS_INLINE=ON
>>   endif
>>   
>> +ifeq ($(BR2_or1k),y)
>> +LIBGEOS_CXXFLAGS += -mcmodel=large
> 
>   According to git, -mcmodel was added to GCC after the 11.2.0 release. Are you
> sure that this works?
> 
>   Oooh, we have a patch that adds it. But that patch is missing for 11.1.0 for
> some reason. Romain, you apparently didn't carry any of our patches when you
> added GCC 11 in 2ab88dac293aed5adf2504e8b182f9d8a306b935. The commit message
> doesn't say anything. Do you remember anything about the patches? The patch was
> added to master on May 21 and you only submitted the GCC bump on June 12, but
> perhaps you already had it lying around for a while?
> 
>   Giulio, maybe you can port the patch to 11.1.0?

You've read into my mind :-), I've sent it yesterday:
https://patchwork.ozlabs.org/project/buildroot/list/?series=258108

and that is valid for both libgeos and profobuf.

Best regards!
-- 
Giulio Benetti
Benetti Engineering sas

>   Regards,
>   Arnout
> 
>> +endif
>> +
>>   LIBGEOS_CONF_OPTS += -DCMAKE_CXX_FLAGS="$(LIBGEOS_CXXFLAGS)"
>>   
>>   $(eval $(cmake-package))
>>
> _______________________________________________
> buildroot mailing list
> buildroot@busybox.net
> http://lists.busybox.net/mailman/listinfo/buildroot
> 

_______________________________________________
buildroot mailing list
buildroot@busybox.net
http://lists.busybox.net/mailman/listinfo/buildroot

Re: [Buildroot] [PATCH v2 1/3] package/libgeos: fix build failure due to missing -mcmodel=large

[Arnout Vandecappelle]

On 17/08/2021 22:34, Arnout Vandecappelle wrote:
> 
> 
> On 27/07/2021 00:34, Giulio Benetti wrote:
>> When building libgeos for or1k -mcmodel=large is needed to link, so let's
>> add that gcc option in case we're building for or1k.
>>
>> Signed-off-by: Giulio Benetti <giulio.benetti@benettiengineering.com>
>> ---
>>  package/libgeos/libgeos.mk | 4 ++++
>>  1 file changed, 4 insertions(+)
>>
>> diff --git a/package/libgeos/libgeos.mk b/package/libgeos/libgeos.mk
>> index a355732af8..43211d0434 100644
>> --- a/package/libgeos/libgeos.mk
>> +++ b/package/libgeos/libgeos.mk
>> @@ -23,6 +23,10 @@ ifeq ($(BR2_arm)$(BR2_armeb),y)
>>  LIBGEOS_CONF_OPTS += -DDISABLE_GEOS_INLINE=ON
>>  endif
>>  
>> +ifeq ($(BR2_or1k),y)
>> +LIBGEOS_CXXFLAGS += -mcmodel=large
> 
>  According to git, -mcmodel was added to GCC after the 11.2.0 release. Are you
> sure that this works?
> 
>  Oooh, we have a patch that adds it. But that patch is missing for 11.1.0 for
> some reason. Romain, you apparently didn't carry any of our patches when you
> added GCC 11 in 2ab88dac293aed5adf2504e8b182f9d8a306b935. The commit message
> doesn't say anything. Do you remember anything about the patches? The patch was
> added to master on May 21 and you only submitted the GCC bump on June 12, but
> perhaps you already had it lying around for a while?
> 
>  Giulio, maybe you can port the patch to 11.1.0?

 ... and now I see you already did that in [1]. Thanks!

 Regards,
 Arnout

[1]
https://patchwork.ozlabs.org/project/buildroot/patch/20210815180359.1575824-1-giulio.benetti@benettiengineering.com/


> 
>  Regards,
>  Arnout
> 
>> +endif
>> +
>>  LIBGEOS_CONF_OPTS += -DCMAKE_CXX_FLAGS="$(LIBGEOS_CXXFLAGS)"
>>  
>>  $(eval $(cmake-package))
>>
_______________________________________________
buildroot mailing list
buildroot@busybox.net
http://lists.busybox.net/mailman/listinfo/buildroot

Re: [Buildroot] [PATCH v2 1/3] package/libgeos: fix build failure due to missing -mcmodel=large

[Arnout Vandecappelle]

On 27/07/2021 00:34, Giulio Benetti wrote:
> When building libgeos for or1k -mcmodel=large is needed to link, so let's
> add that gcc option in case we're building for or1k.
> 
> Signed-off-by: Giulio Benetti <giulio.benetti@benettiengineering.com>

 Applied to master, thanks.

 I've added a comment to the commit message to explain that this option is from
a Buildroot patch.

 I've also applied the second patch with the same comment.

 Regards,
 Arnout

> ---
>  package/libgeos/libgeos.mk | 4 ++++
>  1 file changed, 4 insertions(+)
> 
> diff --git a/package/libgeos/libgeos.mk b/package/libgeos/libgeos.mk
> index a355732af8..43211d0434 100644
> --- a/package/libgeos/libgeos.mk
> +++ b/package/libgeos/libgeos.mk
> @@ -23,6 +23,10 @@ ifeq ($(BR2_arm)$(BR2_armeb),y)
>  LIBGEOS_CONF_OPTS += -DDISABLE_GEOS_INLINE=ON
>  endif
>  
> +ifeq ($(BR2_or1k),y)
> +LIBGEOS_CXXFLAGS += -mcmodel=large
> +endif
> +
>  LIBGEOS_CONF_OPTS += -DCMAKE_CXX_FLAGS="$(LIBGEOS_CXXFLAGS)"
>  
>  $(eval $(cmake-package))
> 
_______________________________________________
buildroot mailing list
buildroot@busybox.net
http://lists.busybox.net/mailman/listinfo/buildroot

Re: [Buildroot] [PATCH v2 3/3] toolchain: remove binutils bug 21464

[Arnout Vandecappelle]

On 27/07/2021 00:34, Giulio Benetti wrote:
> This bug has been fixed upstream and backported to buildroot binutils
> package. So let's remove it from toolchain/Config.in and from packages
> that are affected by it:
> - libgeos
> - postgis
> - protobuf

 It's not clear to me if all the external toolchains that we use also have this
patch already. Basically that boils down to the stable and bleeding edge bootlin
toolchains.

 Well, I'm pretty sure they're not yet updated, since they're still  2020.08-1...


 Regards,
 Arnout

> 
> Signed-off-by: Giulio Benetti <giulio.benetti@benettiengineering.com>
> Reviewed-by: Maxim Kochetkov <fido_max@inbox.ru>
> ---
>  package/libgeos/Config.in  | 4 +---
>  package/postgis/Config.in  | 4 +---
>  package/protobuf/Config.in | 1 -
>  toolchain/Config.in        | 6 ------
>  4 files changed, 2 insertions(+), 13 deletions(-)
> 
> diff --git a/package/libgeos/Config.in b/package/libgeos/Config.in
> index 86a1cddcf3..124e2da661 100644
> --- a/package/libgeos/Config.in
> +++ b/package/libgeos/Config.in
> @@ -2,7 +2,6 @@ config BR2_PACKAGE_LIBGEOS
>  	bool "libgeos"
>  	depends on BR2_INSTALL_LIBSTDCPP
>  	depends on BR2_USE_WCHAR
> -	depends on !BR2_TOOLCHAIN_HAS_BINUTILS_BUG_21464
>  	depends on !BR2_TOOLCHAIN_HAS_BINUTILS_BUG_27597
>  	help
>  	  GEOS (Geometry Engine - Open Source) is a C++ port of the
> @@ -13,7 +12,6 @@ config BR2_PACKAGE_LIBGEOS
>  
>  	  https://trac.osgeo.org/geos
>  
> -comment "libgeos needs a toolchain w/ C++, wchar, not binutils bug 21464, 27597"
> +comment "libgeos needs a toolchain w/ C++, wchar, not binutils bug 27597"
>  	depends on !BR2_INSTALL_LIBSTDCPP || !BR2_USE_WCHAR || \
> -		   BR2_TOOLCHAIN_HAS_BINUTILS_BUG_21464 || \
>  		   BR2_TOOLCHAIN_HAS_BINUTILS_BUG_27597
> diff --git a/package/postgis/Config.in b/package/postgis/Config.in
> index 04705f7e16..78c52ea7b2 100644
> --- a/package/postgis/Config.in
> +++ b/package/postgis/Config.in
> @@ -6,7 +6,6 @@ config BR2_PACKAGE_POSTGIS
>  	depends on BR2_TOOLCHAIN_GCC_AT_LEAST_4_7 # C++11, proj
>  	depends on BR2_TOOLCHAIN_HAS_THREADS # proj
>  	depends on BR2_USE_WCHAR # libgeos, proj
> -	depends on !BR2_TOOLCHAIN_HAS_BINUTILS_BUG_21464 # libgeos
>  	depends on !BR2_TOOLCHAIN_HAS_BINUTILS_BUG_27597 # libgeos
>  	select BR2_PACKAGE_LIBGEOS
>  	select BR2_PACKAGE_PROJ
> @@ -20,9 +19,8 @@ config BR2_PACKAGE_POSTGIS
>  
>  	  https://postgis.net/
>  
> -comment "postgis needs a toolchain w/ C++, threads, wchar, gcc >= 4.7, not binutils bug 21464, 27597"
> +comment "postgis needs a toolchain w/ C++, threads, wchar, gcc >= 4.7, not binutils bug 27597"
>  	depends on !BR2_microblazeel && !BR2_microblazebe # ICE
>  	depends on !BR2_INSTALL_LIBSTDCPP || !BR2_TOOLCHAIN_GCC_AT_LEAST_4_7 || \
>  		!BR2_TOOLCHAIN_HAS_THREADS || !BR2_USE_WCHAR || \
> -		BR2_TOOLCHAIN_HAS_BINUTILS_BUG_21464 || \
>  		BR2_TOOLCHAIN_HAS_BINUTILS_BUG_27597
> diff --git a/package/protobuf/Config.in b/package/protobuf/Config.in
> index 30050950aa..46c820b9cf 100644
> --- a/package/protobuf/Config.in
> +++ b/package/protobuf/Config.in
> @@ -24,7 +24,6 @@ config BR2_PACKAGE_PROTOBUF_ARCH_SUPPORTS
>  	default y if BR2_TOOLCHAIN_HAS_ATOMIC
>  	depends on BR2_HOSTARCH = "x86_64" || BR2_HOSTARCH = "x86"
>  	depends on BR2_USE_MMU # fork()
> -	depends on !BR2_TOOLCHAIN_HAS_BINUTILS_BUG_21464
>  
>  config BR2_PACKAGE_PROTOBUF
>  	bool "protobuf"
> diff --git a/toolchain/Config.in b/toolchain/Config.in
> index 8603e2aaff..3598307b20 100644
> --- a/toolchain/Config.in
> +++ b/toolchain/Config.in
> @@ -71,12 +71,6 @@ source "package/gdb/Config.in.host"
>  
>  comment "Toolchain Generic Options"
>  
> -# https://sourceware.org/bugzilla/show_bug.cgi?id=21464
> -# Affect toolchains built with binutils 2.31.1, still not fixed.
> -config BR2_TOOLCHAIN_HAS_BINUTILS_BUG_21464
> -	bool
> -	default y if BR2_or1k
> -
>  # https://sourceware.org/bugzilla/show_bug.cgi?id=27597
>  # Affect toolchains built with binutils 2.36.1, still not fixed.
>  config BR2_TOOLCHAIN_HAS_BINUTILS_BUG_27597
> 
_______________________________________________
buildroot mailing list
buildroot@busybox.net
http://lists.busybox.net/mailman/listinfo/buildroot

Re: [Buildroot] [PATCH v2 3/3] toolchain: remove binutils bug 21464

[Giulio Benetti]

Hi Arnout,

On 8/17/21 11:11 PM, Arnout Vandecappelle wrote:
> 
> 
> On 27/07/2021 00:34, Giulio Benetti wrote:
>> This bug has been fixed upstream and backported to buildroot binutils
>> package. So let's remove it from toolchain/Config.in and from packages
>> that are affected by it:
>> - libgeos
>> - postgis
>> - protobuf
> 
>   It's not clear to me if all the external toolchains that we use also have this
> patch already. Basically that boils down to the stable and bleeding edge bootlin
> toolchains.
> 
>   Well, I'm pretty sure they're not yet updated, since they're still  2020.08-1...

For this patch we have to wait until all or1k patches have been applied 
to Bootlin toolchain and they got rebuilt and bumped.
Then we can apply it since Buildroot will become OpenRisc bug free. But 
this depends on external OpenRisc toolchains that only Bootlin provide

Kind regards
-- 
Giulio Benetti
Benetti Engineering sas

> 
>   Regards,
>   Arnout
> 
>>
>> Signed-off-by: Giulio Benetti <giulio.benetti@benettiengineering.com>
>> Reviewed-by: Maxim Kochetkov <fido_max@inbox.ru>
>> ---
>>   package/libgeos/Config.in  | 4 +---
>>   package/postgis/Config.in  | 4 +---
>>   package/protobuf/Config.in | 1 -
>>   toolchain/Config.in        | 6 ------
>>   4 files changed, 2 insertions(+), 13 deletions(-)
>>
>> diff --git a/package/libgeos/Config.in b/package/libgeos/Config.in
>> index 86a1cddcf3..124e2da661 100644
>> --- a/package/libgeos/Config.in
>> +++ b/package/libgeos/Config.in
>> @@ -2,7 +2,6 @@ config BR2_PACKAGE_LIBGEOS
>>   	bool "libgeos"
>>   	depends on BR2_INSTALL_LIBSTDCPP
>>   	depends on BR2_USE_WCHAR
>> -	depends on !BR2_TOOLCHAIN_HAS_BINUTILS_BUG_21464
>>   	depends on !BR2_TOOLCHAIN_HAS_BINUTILS_BUG_27597
>>   	help
>>   	  GEOS (Geometry Engine - Open Source) is a C++ port of the
>> @@ -13,7 +12,6 @@ config BR2_PACKAGE_LIBGEOS
>>   
>>   	  https://trac.osgeo.org/geos
>>   
>> -comment "libgeos needs a toolchain w/ C++, wchar, not binutils bug 21464, 27597"
>> +comment "libgeos needs a toolchain w/ C++, wchar, not binutils bug 27597"
>>   	depends on !BR2_INSTALL_LIBSTDCPP || !BR2_USE_WCHAR || \
>> -		   BR2_TOOLCHAIN_HAS_BINUTILS_BUG_21464 || \
>>   		   BR2_TOOLCHAIN_HAS_BINUTILS_BUG_27597
>> diff --git a/package/postgis/Config.in b/package/postgis/Config.in
>> index 04705f7e16..78c52ea7b2 100644
>> --- a/package/postgis/Config.in
>> +++ b/package/postgis/Config.in
>> @@ -6,7 +6,6 @@ config BR2_PACKAGE_POSTGIS
>>   	depends on BR2_TOOLCHAIN_GCC_AT_LEAST_4_7 # C++11, proj
>>   	depends on BR2_TOOLCHAIN_HAS_THREADS # proj
>>   	depends on BR2_USE_WCHAR # libgeos, proj
>> -	depends on !BR2_TOOLCHAIN_HAS_BINUTILS_BUG_21464 # libgeos
>>   	depends on !BR2_TOOLCHAIN_HAS_BINUTILS_BUG_27597 # libgeos
>>   	select BR2_PACKAGE_LIBGEOS
>>   	select BR2_PACKAGE_PROJ
>> @@ -20,9 +19,8 @@ config BR2_PACKAGE_POSTGIS
>>   
>>   	  https://postgis.net/
>>   
>> -comment "postgis needs a toolchain w/ C++, threads, wchar, gcc >= 4.7, not binutils bug 21464, 27597"
>> +comment "postgis needs a toolchain w/ C++, threads, wchar, gcc >= 4.7, not binutils bug 27597"
>>   	depends on !BR2_microblazeel && !BR2_microblazebe # ICE
>>   	depends on !BR2_INSTALL_LIBSTDCPP || !BR2_TOOLCHAIN_GCC_AT_LEAST_4_7 || \
>>   		!BR2_TOOLCHAIN_HAS_THREADS || !BR2_USE_WCHAR || \
>> -		BR2_TOOLCHAIN_HAS_BINUTILS_BUG_21464 || \
>>   		BR2_TOOLCHAIN_HAS_BINUTILS_BUG_27597
>> diff --git a/package/protobuf/Config.in b/package/protobuf/Config.in
>> index 30050950aa..46c820b9cf 100644
>> --- a/package/protobuf/Config.in
>> +++ b/package/protobuf/Config.in
>> @@ -24,7 +24,6 @@ config BR2_PACKAGE_PROTOBUF_ARCH_SUPPORTS
>>   	default y if BR2_TOOLCHAIN_HAS_ATOMIC
>>   	depends on BR2_HOSTARCH = "x86_64" || BR2_HOSTARCH = "x86"
>>   	depends on BR2_USE_MMU # fork()
>> -	depends on !BR2_TOOLCHAIN_HAS_BINUTILS_BUG_21464
>>   
>>   config BR2_PACKAGE_PROTOBUF
>>   	bool "protobuf"
>> diff --git a/toolchain/Config.in b/toolchain/Config.in
>> index 8603e2aaff..3598307b20 100644
>> --- a/toolchain/Config.in
>> +++ b/toolchain/Config.in
>> @@ -71,12 +71,6 @@ source "package/gdb/Config.in.host"
>>   
>>   comment "Toolchain Generic Options"
>>   
>> -# https://sourceware.org/bugzilla/show_bug.cgi?id=21464
>> -# Affect toolchains built with binutils 2.31.1, still not fixed.
>> -config BR2_TOOLCHAIN_HAS_BINUTILS_BUG_21464
>> -	bool
>> -	default y if BR2_or1k
>> -
>>   # https://sourceware.org/bugzilla/show_bug.cgi?id=27597
>>   # Affect toolchains built with binutils 2.36.1, still not fixed.
>>   config BR2_TOOLCHAIN_HAS_BINUTILS_BUG_27597
>>

_______________________________________________
buildroot mailing list
buildroot@busybox.net
http://lists.busybox.net/mailman/listinfo/buildroot

Re: [Buildroot] [PATCH v2 1/3] package/libgeos: fix build failure due to missing -mcmodel=large

[Romain Naour]

Hello Arnout,

Le 17/08/2021 à 22:34, Arnout Vandecappelle a écrit :
> 
> 
> On 27/07/2021 00:34, Giulio Benetti wrote:
>> When building libgeos for or1k -mcmodel=large is needed to link, so let's
>> add that gcc option in case we're building for or1k.
>>
>> Signed-off-by: Giulio Benetti <giulio.benetti@benettiengineering.com>
>> ---
>>  package/libgeos/libgeos.mk | 4 ++++
>>  1 file changed, 4 insertions(+)
>>
>> diff --git a/package/libgeos/libgeos.mk b/package/libgeos/libgeos.mk
>> index a355732af8..43211d0434 100644
>> --- a/package/libgeos/libgeos.mk
>> +++ b/package/libgeos/libgeos.mk
>> @@ -23,6 +23,10 @@ ifeq ($(BR2_arm)$(BR2_armeb),y)
>>  LIBGEOS_CONF_OPTS += -DDISABLE_GEOS_INLINE=ON
>>  endif
>>  
>> +ifeq ($(BR2_or1k),y)
>> +LIBGEOS_CXXFLAGS += -mcmodel=large
> 
>  According to git, -mcmodel was added to GCC after the 11.2.0 release. Are you
> sure that this works?
> 
>  Oooh, we have a patch that adds it. But that patch is missing for 11.1.0 for
> some reason. Romain, you apparently didn't carry any of our patches when you
> added GCC 11 in 2ab88dac293aed5adf2504e8b182f9d8a306b935. The commit message
> doesn't say anything. Do you remember anything about the patches? The patch was
> added to master on May 21 and you only submitted the GCC bump on June 12, but
> perhaps you already had it lying around for a while?

Indeed, I missed this patch.

> 
>  Giulio, maybe you can port the patch to 11.1.0?

Yes please.

Best regards,
Romain


> 
>  Regards,
>  Arnout
> 
>> +endif
>> +
>>  LIBGEOS_CONF_OPTS += -DCMAKE_CXX_FLAGS="$(LIBGEOS_CXXFLAGS)"
>>  
>>  $(eval $(cmake-package))
>>

_______________________________________________
buildroot mailing list
buildroot@busybox.net
http://lists.busybox.net/mailman/listinfo/buildroot

Re: [Buildroot] [PATCH v2 1/3] package/libgeos: fix build failure due to missing -mcmodel=large

[Giulio Benetti]

Hi Romain,

On 8/18/21 10:01 PM, Romain Naour wrote:
> Hello Arnout,
> 
> Le 17/08/2021 à 22:34, Arnout Vandecappelle a écrit :
>>
>>
>> On 27/07/2021 00:34, Giulio Benetti wrote:
>>> When building libgeos for or1k -mcmodel=large is needed to link, so let's
>>> add that gcc option in case we're building for or1k.
>>>
>>> Signed-off-by: Giulio Benetti <giulio.benetti@benettiengineering.com>
>>> ---
>>>   package/libgeos/libgeos.mk | 4 ++++
>>>   1 file changed, 4 insertions(+)
>>>
>>> diff --git a/package/libgeos/libgeos.mk b/package/libgeos/libgeos.mk
>>> index a355732af8..43211d0434 100644
>>> --- a/package/libgeos/libgeos.mk
>>> +++ b/package/libgeos/libgeos.mk
>>> @@ -23,6 +23,10 @@ ifeq ($(BR2_arm)$(BR2_armeb),y)
>>>   LIBGEOS_CONF_OPTS += -DDISABLE_GEOS_INLINE=ON
>>>   endif
>>>   
>>> +ifeq ($(BR2_or1k),y)
>>> +LIBGEOS_CXXFLAGS += -mcmodel=large
>>
>>   According to git, -mcmodel was added to GCC after the 11.2.0 release. Are you
>> sure that this works?
>>
>>   Oooh, we have a patch that adds it. But that patch is missing for 11.1.0 for
>> some reason. Romain, you apparently didn't carry any of our patches when you
>> added GCC 11 in 2ab88dac293aed5adf2504e8b182f9d8a306b935. The commit message
>> doesn't say anything. Do you remember anything about the patches? The patch was
>> added to master on May 21 and you only submitted the GCC bump on June 12, but
>> perhaps you already had it lying around for a while?
> 
> Indeed, I missed this patch.
> 
>>
>>   Giulio, maybe you can port the patch to 11.1.0?
> 
> Yes please.

Already sent and applied here :-):
https://git.buildroot.net/buildroot/commit/?id=137225cef423ccbebc31d0c562bf3f37192739ac

I'm going to add myself to toolchain as maintainer too, so I keep up to 
date on toolchain movement and also I've added a bunch of binutils/gcc
bugs. So it's time for it :-)

Best regards
-- 
Giulio Benetti
Benetti Engineering sas

> Best regards,
> Romain
> 
> 
>>
>>   Regards,
>>   Arnout
>>
>>> +endif
>>> +
>>>   LIBGEOS_CONF_OPTS += -DCMAKE_CXX_FLAGS="$(LIBGEOS_CXXFLAGS)"
>>>   
>>>   $(eval $(cmake-package))
>>>
> 
> _______________________________________________
> buildroot mailing list
> buildroot@busybox.net
> http://lists.busybox.net/mailman/listinfo/buildroot
> 

_______________________________________________
buildroot mailing list
buildroot@busybox.net
http://lists.busybox.net/mailman/listinfo/buildroot

Re: [Buildroot] [PATCH v2 3/3] toolchain: remove binutils bug 21464

[Giulio Benetti]

Hi Arnout, Thomas, All,

On 17/08/21 23:27, Giulio Benetti wrote:
> Hi Arnout,
> 
> On 8/17/21 11:11 PM, Arnout Vandecappelle wrote:
>>
>>
>> On 27/07/2021 00:34, Giulio Benetti wrote:
>>> This bug has been fixed upstream and backported to buildroot binutils
>>> package. So let's remove it from toolchain/Config.in and from packages
>>> that are affected by it:
>>> - libgeos
>>> - postgis
>>> - protobuf
>>
>>    It's not clear to me if all the external toolchains that we use also have this
>> patch already. Basically that boils down to the stable and bleeding edge bootlin
>> toolchains.
>>
>>    Well, I'm pretty sure they're not yet updated, since they're still  2020.08-1...
> 
> For this patch we have to wait until all or1k patches have been applied
> to Bootlin toolchain and they got rebuilt and bumped.
> Then we can apply it since Buildroot will become OpenRisc bug free. But
> this depends on external OpenRisc toolchains that only Bootlin provide

Unfortunately libgeos is still affected by this bug and postgis too 
because it's its dependency. The reason is that libgeos has been bumped 
and I've never given a build after that.

Only protobuf has been fixed after rebuilding all Bootlin toolchains.
So I will report upstream that is usually very responsive and ask to fix 
this binutils again, hopefully once for all.

So please drop this patch. I'll send a patch for protobuf package only.

Best regards
-- 
Giulio Benetti
Benetti Engineering sas
_______________________________________________
buildroot mailing list
buildroot@buildroot.org
https://lists.buildroot.org/mailman/listinfo/buildroot

[Buildroot] [PATCH] package/protobuf: drop dependency on binutils bug 21464

[Giulio Benetti]

This package build failure has been fixed by using -mcmodel=large that is
now available in external toolchains as well as buildroot toolchains. So
we can drop its dependency on binutils 21464.

Signed-off-by: Giulio Benetti <giulio.benetti@benettiengineering.com>
---
 package/protobuf/Config.in | 1 -
 1 file changed, 1 deletion(-)

diff --git a/package/protobuf/Config.in b/package/protobuf/Config.in
index 30050950aa..46c820b9cf 100644
--- a/package/protobuf/Config.in
+++ b/package/protobuf/Config.in
@@ -24,7 +24,6 @@ config BR2_PACKAGE_PROTOBUF_ARCH_SUPPORTS
 	default y if BR2_TOOLCHAIN_HAS_ATOMIC
 	depends on BR2_HOSTARCH = "x86_64" || BR2_HOSTARCH = "x86"
 	depends on BR2_USE_MMU # fork()
-	depends on !BR2_TOOLCHAIN_HAS_BINUTILS_BUG_21464
 
 config BR2_PACKAGE_PROTOBUF
 	bool "protobuf"
-- 
2.25.1

_______________________________________________
buildroot mailing list
buildroot@buildroot.org
https://lists.buildroot.org/mailman/listinfo/buildroot

Re: [Buildroot] [PATCH] package/protobuf: drop dependency on binutils bug 21464

[Thomas Petazzoni]

On Thu, 30 Dec 2021 21:12:30 +0100
Giulio Benetti <giulio.benetti@benettiengineering.com> wrote:

> This package build failure has been fixed by using -mcmodel=large that is
> now available in external toolchains as well as buildroot toolchains. So
> we can drop its dependency on binutils 21464.
> 
> Signed-off-by: Giulio Benetti <giulio.benetti@benettiengineering.com>
> ---
>  package/protobuf/Config.in | 1 -
>  1 file changed, 1 deletion(-)

Applied to master, thanks.

Thomas
-- 
Thomas Petazzoni, CTO, Bootlin
Embedded Linux and Kernel engineering
https://bootlin.com
_______________________________________________
buildroot mailing list
buildroot@buildroot.org
https://lists.buildroot.org/mailman/listinfo/buildroot

Re: [Buildroot] [PATCH v2 3/3] toolchain: remove binutils bug 21464

[Giulio Benetti]

On 30/12/21 21:05, Giulio Benetti wrote:
> Hi Arnout, Thomas, All,
> 
> On 17/08/21 23:27, Giulio Benetti wrote:
>> Hi Arnout,
>>
>> On 8/17/21 11:11 PM, Arnout Vandecappelle wrote:
>>>
>>>
>>> On 27/07/2021 00:34, Giulio Benetti wrote:
>>>> This bug has been fixed upstream and backported to buildroot binutils
>>>> package. So let's remove it from toolchain/Config.in and from packages
>>>> that are affected by it:
>>>> - libgeos
>>>> - postgis
>>>> - protobuf
>>>
>>>     It's not clear to me if all the external toolchains that we use also have this
>>> patch already. Basically that boils down to the stable and bleeding edge bootlin
>>> toolchains.
>>>
>>>     Well, I'm pretty sure they're not yet updated, since they're still  2020.08-1...
>>
>> For this patch we have to wait until all or1k patches have been applied
>> to Bootlin toolchain and they got rebuilt and bumped.
>> Then we can apply it since Buildroot will become OpenRisc bug free. But
>> this depends on external OpenRisc toolchains that only Bootlin provide
> 
> Unfortunately libgeos is still affected by this bug and postgis too
> because it's its dependency. The reason is that libgeos has been bumped
> and I've never given a build after that.
> 
> Only protobuf has been fixed after rebuilding all Bootlin toolchains.
> So I will report upstream that is usually very responsive and ask to fix
> this binutils again, hopefully once for all.

I've updated the bug on the gcc side that works together with binutils 
on the fix:
https://gcc.gnu.org/bugzilla/show_bug.cgi?id=99783

Best regards
-- 
Giulio Benetti
Benetti Engineering sas
_______________________________________________
buildroot mailing list
buildroot@buildroot.org
https://lists.buildroot.org/mailman/listinfo/buildroot