* [PATCH 0/3] S390-DASD: Fine-tuning for some function implementations
@ 2017-05-10 18:00 ` SF Markus Elfring
0 siblings, 0 replies; 16+ messages in thread
From: SF Markus Elfring @ 2017-05-10 18:00 UTC (permalink / raw)
To: linux-s390, Heiko Carstens, Jan Höppner, Martin Schwidefsky,
Stefan Haberland
Cc: LKML, kernel-janitors
From: Markus Elfring <elfring@users.sourceforge.net>
Date: Wed, 10 May 2017 19:43:21 +0200
A few update suggestions were taken into account
from static source code analysis.
Markus Elfring (3):
Adjust buffer output in dasd_hosts_print()
Fix typos in two comment lines
Adjust six checks for null pointers
drivers/s390/block/dasd_eckd.c | 24 +++++++++++-------------
1 file changed, 11 insertions(+), 13 deletions(-)
--
2.12.3
^ permalink raw reply [flat|nested] 16+ messages in thread
* [PATCH 1/3] s390/dasd: Adjust buffer output in dasd_hosts_print()
2017-05-10 18:00 ` SF Markus Elfring
@ 2017-05-10 18:01 ` SF Markus Elfring
-1 siblings, 0 replies; 16+ messages in thread
From: SF Markus Elfring @ 2017-05-10 18:01 UTC (permalink / raw)
To: linux-s390, Heiko Carstens, Jan Höppner, Martin Schwidefsky,
Stefan Haberland
Cc: LKML, kernel-janitors
From: Markus Elfring <elfring@users.sourceforge.net>
Date: Wed, 10 May 2017 18:52:28 +0200
* Use a special format string specification for the desired output of the
array "pgid" into a sequence.
This issue was detected by using the Coccinelle software.
* Delete the local variable "j" and a call of the function "seq_puts"
wich became unnecessary with this refactoring.
Fixes: 5a3b7b112884f80ff19b18028fabeb4f9c035518 ("s390/dasd: add query host access to volume support")
Signed-off-by: Markus Elfring <elfring@users.sourceforge.net>
---
drivers/s390/block/dasd_eckd.c | 8 +++-----
1 file changed, 3 insertions(+), 5 deletions(-)
diff --git a/drivers/s390/block/dasd_eckd.c b/drivers/s390/block/dasd_eckd.c
index 122456e4db89..b3709d3cba54 100644
--- a/drivers/s390/block/dasd_eckd.c
+++ b/drivers/s390/block/dasd_eckd.c
@@ -5288,7 +5288,7 @@ static int dasd_hosts_print(struct dasd_device *device, struct seq_file *m)
struct dasd_ckd_path_group_entry *entry;
struct dasd_ckd_host_information *info;
char sysplex[9] = "";
- int rc, i, j;
+ int rc, i;
access = kzalloc(sizeof(*access), GFP_NOIO);
if (!access) {
@@ -5308,10 +5308,8 @@ static int dasd_hosts_print(struct dasd_device *device, struct seq_file *m)
entry = (struct dasd_ckd_path_group_entry *)
(info->entry + i * info->entry_size);
/* PGID */
- seq_puts(m, "pgid ");
- for (j = 0; j < 11; j++)
- seq_printf(m, "%02x", entry->pgid[j]);
- seq_putc(m, '\n');
+ seq_printf(m, "pgid %*phN\n",
+ ARRAY_SIZE(entry->pgid), entry->pgid);
/* FLAGS */
seq_printf(m, "status_flags %02x\n", entry->status_flags);
/* SYSPLEX NAME */
--
2.12.3
^ permalink raw reply related [flat|nested] 16+ messages in thread* [PATCH 1/3] s390/dasd: Adjust buffer output in dasd_hosts_print()
@ 2017-05-10 18:01 ` SF Markus Elfring
0 siblings, 0 replies; 16+ messages in thread
From: SF Markus Elfring @ 2017-05-10 18:01 UTC (permalink / raw)
To: linux-s390, Heiko Carstens, Jan Höppner, Martin Schwidefsky,
Stefan Haberland
Cc: LKML, kernel-janitors
From: Markus Elfring <elfring@users.sourceforge.net>
Date: Wed, 10 May 2017 18:52:28 +0200
* Use a special format string specification for the desired output of the
array "pgid" into a sequence.
This issue was detected by using the Coccinelle software.
* Delete the local variable "j" and a call of the function "seq_puts"
wich became unnecessary with this refactoring.
Fixes: 5a3b7b112884f80ff19b18028fabeb4f9c035518 ("s390/dasd: add query host access to volume support")
Signed-off-by: Markus Elfring <elfring@users.sourceforge.net>
---
drivers/s390/block/dasd_eckd.c | 8 +++-----
1 file changed, 3 insertions(+), 5 deletions(-)
diff --git a/drivers/s390/block/dasd_eckd.c b/drivers/s390/block/dasd_eckd.c
index 122456e4db89..b3709d3cba54 100644
--- a/drivers/s390/block/dasd_eckd.c
+++ b/drivers/s390/block/dasd_eckd.c
@@ -5288,7 +5288,7 @@ static int dasd_hosts_print(struct dasd_device *device, struct seq_file *m)
struct dasd_ckd_path_group_entry *entry;
struct dasd_ckd_host_information *info;
char sysplex[9] = "";
- int rc, i, j;
+ int rc, i;
access = kzalloc(sizeof(*access), GFP_NOIO);
if (!access) {
@@ -5308,10 +5308,8 @@ static int dasd_hosts_print(struct dasd_device *device, struct seq_file *m)
entry = (struct dasd_ckd_path_group_entry *)
(info->entry + i * info->entry_size);
/* PGID */
- seq_puts(m, "pgid ");
- for (j = 0; j < 11; j++)
- seq_printf(m, "%02x", entry->pgid[j]);
- seq_putc(m, '\n');
+ seq_printf(m, "pgid %*phN\n",
+ ARRAY_SIZE(entry->pgid), entry->pgid);
/* FLAGS */
seq_printf(m, "status_flags %02x\n", entry->status_flags);
/* SYSPLEX NAME */
--
2.12.3
^ permalink raw reply related [flat|nested] 16+ messages in thread* Re: [PATCH 1/3] s390/dasd: Adjust buffer output in dasd_hosts_print()
2017-05-10 18:01 ` SF Markus Elfring
@ 2017-05-10 19:28 ` Dan Carpenter
-1 siblings, 0 replies; 16+ messages in thread
From: Dan Carpenter @ 2017-05-10 19:28 UTC (permalink / raw)
To: SF Markus Elfring
Cc: linux-s390, Heiko Carstens, Jan Höppner, Martin Schwidefsky,
Stefan Haberland, LKML, kernel-janitors
On Wed, May 10, 2017 at 08:01:17PM +0200, SF Markus Elfring wrote:
> From: Markus Elfring <elfring@users.sourceforge.net>
> Date: Wed, 10 May 2017 18:52:28 +0200
>
> * Use a special format string specification for the desired output of the
> array "pgid" into a sequence.
>
> This issue was detected by using the Coccinelle software.
>
> * Delete the local variable "j" and a call of the function "seq_puts"
> wich became unnecessary with this refactoring.
>
> Fixes: 5a3b7b112884f80ff19b18028fabeb4f9c035518 ("s390/dasd: add query host access to volume support")
Stop using the fixes tag when you are not fixing bugs.
regards,
dan carpenter
^ permalink raw reply [flat|nested] 16+ messages in thread* Re: [PATCH 1/3] s390/dasd: Adjust buffer output in dasd_hosts_print()
@ 2017-05-10 19:28 ` Dan Carpenter
0 siblings, 0 replies; 16+ messages in thread
From: Dan Carpenter @ 2017-05-10 19:28 UTC (permalink / raw)
To: SF Markus Elfring
Cc: linux-s390, Heiko Carstens, Jan Höppner, Martin Schwidefsky,
Stefan Haberland, LKML, kernel-janitors
On Wed, May 10, 2017 at 08:01:17PM +0200, SF Markus Elfring wrote:
> From: Markus Elfring <elfring@users.sourceforge.net>
> Date: Wed, 10 May 2017 18:52:28 +0200
>
> * Use a special format string specification for the desired output of the
> array "pgid" into a sequence.
>
> This issue was detected by using the Coccinelle software.
>
> * Delete the local variable "j" and a call of the function "seq_puts"
> wich became unnecessary with this refactoring.
>
> Fixes: 5a3b7b112884f80ff19b18028fabeb4f9c035518 ("s390/dasd: add query host access to volume support")
Stop using the fixes tag when you are not fixing bugs.
regards,
dan carpenter
^ permalink raw reply [flat|nested] 16+ messages in thread
* Re: [PATCH 1/3] s390/dasd: Adjust buffer output in dasd_hosts_print()
2017-05-10 18:01 ` SF Markus Elfring
@ 2017-05-10 22:30 ` kbuild test robot
-1 siblings, 0 replies; 16+ messages in thread
From: kbuild test robot @ 2017-05-10 22:30 UTC (permalink / raw)
To: SF Markus Elfring
Cc: kbuild-all, linux-s390, Heiko Carstens, Jan Höppner,
Martin Schwidefsky, Stefan Haberland, LKML, kernel-janitors
[-- Attachment #1: Type: text/plain, Size: 2274 bytes --]
Hi Markus,
[auto build test WARNING on s390/features]
[also build test WARNING on v4.11 next-20170510]
[if your patch is applied to the wrong git tree, please drop us a note to help improve the system]
url: https://github.com/0day-ci/linux/commits/SF-Markus-Elfring/S390-DASD-Fine-tuning-for-some-function-implementations/20170511-022121
base: https://git.kernel.org/pub/scm/linux/kernel/git/s390/linux.git features
config: s390-default_defconfig (attached as .config)
compiler: s390x-linux-gnu-gcc (Debian 6.1.1-9) 6.1.1 20160705
reproduce:
wget https://raw.githubusercontent.com/01org/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross
chmod +x ~/bin/make.cross
# save the attached .config to linux build tree
make.cross ARCH=s390
All warnings (new ones prefixed by >>):
drivers/s390/block/dasd_eckd.c: In function 'dasd_hosts_print':
>> drivers/s390/block/dasd_eckd.c:5311:24: warning: field width specifier '*' expects argument of type 'int', but argument 3 has type 'long unsigned int' [-Wformat=]
seq_printf(m, "pgid %*phN\n",
^
vim +5311 drivers/s390/block/dasd_eckd.c
5295 DBF_EVENT_DEVID(DBF_WARNING, device->cdev, "%s",
5296 "Could not allocate access buffer");
5297 return -ENOMEM;
5298 }
5299 rc = dasd_eckd_query_host_access(device, access);
5300 if (rc) {
5301 kfree(access);
5302 return rc;
5303 }
5304
5305 info = (struct dasd_ckd_host_information *)
5306 access->host_access_information;
5307 for (i = 0; i < info->entry_count; i++) {
5308 entry = (struct dasd_ckd_path_group_entry *)
5309 (info->entry + i * info->entry_size);
5310 /* PGID */
> 5311 seq_printf(m, "pgid %*phN\n",
5312 ARRAY_SIZE(entry->pgid), entry->pgid);
5313 /* FLAGS */
5314 seq_printf(m, "status_flags %02x\n", entry->status_flags);
5315 /* SYSPLEX NAME */
5316 memcpy(&sysplex, &entry->sysplex_name, sizeof(sysplex) - 1);
5317 EBCASC(sysplex, sizeof(sysplex));
5318 seq_printf(m, "sysplex_name %8s\n", sysplex);
5319 /* SUPPORTED CYLINDER */
---
0-DAY kernel test infrastructure Open Source Technology Center
https://lists.01.org/pipermail/kbuild-all Intel Corporation
[-- Attachment #2: .config.gz --]
[-- Type: application/gzip, Size: 17057 bytes --]
^ permalink raw reply [flat|nested] 16+ messages in thread* Re: [PATCH 1/3] s390/dasd: Adjust buffer output in dasd_hosts_print()
@ 2017-05-10 22:30 ` kbuild test robot
0 siblings, 0 replies; 16+ messages in thread
From: kbuild test robot @ 2017-05-10 22:30 UTC (permalink / raw)
To: kernel-janitors
[-- Attachment #1: Type: text/plain, Size: 2274 bytes --]
Hi Markus,
[auto build test WARNING on s390/features]
[also build test WARNING on v4.11 next-20170510]
[if your patch is applied to the wrong git tree, please drop us a note to help improve the system]
url: https://github.com/0day-ci/linux/commits/SF-Markus-Elfring/S390-DASD-Fine-tuning-for-some-function-implementations/20170511-022121
base: https://git.kernel.org/pub/scm/linux/kernel/git/s390/linux.git features
config: s390-default_defconfig (attached as .config)
compiler: s390x-linux-gnu-gcc (Debian 6.1.1-9) 6.1.1 20160705
reproduce:
wget https://raw.githubusercontent.com/01org/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross
chmod +x ~/bin/make.cross
# save the attached .config to linux build tree
make.cross ARCH=s390
All warnings (new ones prefixed by >>):
drivers/s390/block/dasd_eckd.c: In function 'dasd_hosts_print':
>> drivers/s390/block/dasd_eckd.c:5311:24: warning: field width specifier '*' expects argument of type 'int', but argument 3 has type 'long unsigned int' [-Wformat=]
seq_printf(m, "pgid %*phN\n",
^
vim +5311 drivers/s390/block/dasd_eckd.c
5295 DBF_EVENT_DEVID(DBF_WARNING, device->cdev, "%s",
5296 "Could not allocate access buffer");
5297 return -ENOMEM;
5298 }
5299 rc = dasd_eckd_query_host_access(device, access);
5300 if (rc) {
5301 kfree(access);
5302 return rc;
5303 }
5304
5305 info = (struct dasd_ckd_host_information *)
5306 access->host_access_information;
5307 for (i = 0; i < info->entry_count; i++) {
5308 entry = (struct dasd_ckd_path_group_entry *)
5309 (info->entry + i * info->entry_size);
5310 /* PGID */
> 5311 seq_printf(m, "pgid %*phN\n",
5312 ARRAY_SIZE(entry->pgid), entry->pgid);
5313 /* FLAGS */
5314 seq_printf(m, "status_flags %02x\n", entry->status_flags);
5315 /* SYSPLEX NAME */
5316 memcpy(&sysplex, &entry->sysplex_name, sizeof(sysplex) - 1);
5317 EBCASC(sysplex, sizeof(sysplex));
5318 seq_printf(m, "sysplex_name %8s\n", sysplex);
5319 /* SUPPORTED CYLINDER */
---
0-DAY kernel test infrastructure Open Source Technology Center
https://lists.01.org/pipermail/kbuild-all Intel Corporation
[-- Attachment #2: .config.gz --]
[-- Type: application/gzip, Size: 17057 bytes --]
^ permalink raw reply [flat|nested] 16+ messages in thread
* [PATCH 2/3] s390/dasd: Fix typos in two comment lines
2017-05-10 18:00 ` SF Markus Elfring
@ 2017-05-10 18:02 ` SF Markus Elfring
-1 siblings, 0 replies; 16+ messages in thread
From: SF Markus Elfring @ 2017-05-10 18:02 UTC (permalink / raw)
To: linux-s390, Heiko Carstens, Jan Höppner, Martin Schwidefsky,
Stefan Haberland
Cc: LKML, kernel-janitors
From: Markus Elfring <elfring@users.sourceforge.net>
Date: Wed, 10 May 2017 19:19:19 +0200
MIME-Version: 1.0
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 8bit
The script “checkpatch.pl” pointed information out like the following.
CHECK: '…' may be misspelled - perhaps '…'?
Thus fix two descriptions.
Signed-off-by: Markus Elfring <elfring@users.sourceforge.net>
---
drivers/s390/block/dasd_eckd.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/drivers/s390/block/dasd_eckd.c b/drivers/s390/block/dasd_eckd.c
index b3709d3cba54..e78601d97a67 100644
--- a/drivers/s390/block/dasd_eckd.c
+++ b/drivers/s390/block/dasd_eckd.c
@@ -3863,7 +3863,7 @@ static struct dasd_ccw_req *dasd_raw_build_cp(struct dasd_device *startdev,
unsigned int pfx_datasize;
/*
- * raw track access needs to be mutiple of 64k and on 64k boundary
+ * Raw track access needs to be multiple of 64k and on 64k boundary.
* For read requests we can fix an incorrect alignment by padding
* the request with dummy pages.
*/
@@ -4143,7 +4143,7 @@ dasd_eckd_fill_info(struct dasd_device * device,
/*
* Release device ioctl.
- * Buils a channel programm to releases a prior reserved
+ * Builds a channel program to release a prior reserved
* (see dasd_eckd_reserve) device.
*/
static int
--
2.12.3
^ permalink raw reply related [flat|nested] 16+ messages in thread
* [PATCH 2/3] s390/dasd: Fix typos in two comment lines
@ 2017-05-10 18:02 ` SF Markus Elfring
0 siblings, 0 replies; 16+ messages in thread
From: SF Markus Elfring @ 2017-05-10 18:02 UTC (permalink / raw)
To: linux-s390, Heiko Carstens, Jan Höppner, Martin Schwidefsky,
Stefan Haberland
Cc: LKML, kernel-janitors
From: Markus Elfring <elfring@users.sourceforge.net>
Date: Wed, 10 May 2017 19:19:19 +0200
MIME-Version: 1.0
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 8bit
The script “checkpatch.pl” pointed information out like the following.
CHECK: '…' may be misspelled - perhaps '…'?
Thus fix two descriptions.
Signed-off-by: Markus Elfring <elfring@users.sourceforge.net>
---
drivers/s390/block/dasd_eckd.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/drivers/s390/block/dasd_eckd.c b/drivers/s390/block/dasd_eckd.c
index b3709d3cba54..e78601d97a67 100644
--- a/drivers/s390/block/dasd_eckd.c
+++ b/drivers/s390/block/dasd_eckd.c
@@ -3863,7 +3863,7 @@ static struct dasd_ccw_req *dasd_raw_build_cp(struct dasd_device *startdev,
unsigned int pfx_datasize;
/*
- * raw track access needs to be mutiple of 64k and on 64k boundary
+ * Raw track access needs to be multiple of 64k and on 64k boundary.
* For read requests we can fix an incorrect alignment by padding
* the request with dummy pages.
*/
@@ -4143,7 +4143,7 @@ dasd_eckd_fill_info(struct dasd_device * device,
/*
* Release device ioctl.
- * Buils a channel programm to releases a prior reserved
+ * Builds a channel program to release a prior reserved
* (see dasd_eckd_reserve) device.
*/
static int
--
2.12.3
^ permalink raw reply related [flat|nested] 16+ messages in thread
* [PATCH 3/3] s390/dasd: Adjust six checks for null pointers
2017-05-10 18:00 ` SF Markus Elfring
@ 2017-05-10 18:03 ` SF Markus Elfring
-1 siblings, 0 replies; 16+ messages in thread
From: SF Markus Elfring @ 2017-05-10 18:03 UTC (permalink / raw)
To: linux-s390, Heiko Carstens, Jan Höppner, Martin Schwidefsky,
Stefan Haberland
Cc: LKML, kernel-janitors
From: Markus Elfring <elfring@users.sourceforge.net>
Date: Wed, 10 May 2017 19:29:17 +0200
MIME-Version: 1.0
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 8bit
The script “checkpatch.pl” pointed information out like the following.
Comparison to NULL could be written …
Thus fix the affected source code places.
Signed-off-by: Markus Elfring <elfring@users.sourceforge.net>
---
drivers/s390/block/dasd_eckd.c | 12 ++++++------
1 file changed, 6 insertions(+), 6 deletions(-)
diff --git a/drivers/s390/block/dasd_eckd.c b/drivers/s390/block/dasd_eckd.c
index e78601d97a67..d02f3bbbd552 100644
--- a/drivers/s390/block/dasd_eckd.c
+++ b/drivers/s390/block/dasd_eckd.c
@@ -1080,7 +1080,7 @@ static int dasd_eckd_read_conf(struct dasd_device *device)
"error %d", rc);
return rc;
}
- if (conf_data == NULL) {
+ if (!conf_data) {
DBF_EVENT_DEVID(DBF_WARNING, device->cdev, "%s",
"No configuration data "
"retrieved");
@@ -2049,7 +2049,7 @@ static int dasd_eckd_end_analysis(struct dasd_block *block)
"Track 0 has no records following the VTOC\n");
}
- if (count_area != NULL && count_area->kl == 0) {
+ if (count_area && count_area->kl == 0) {
/* we found notthing violating our disk layout */
if (dasd_check_blocksize(count_area->dl) == 0)
block->bp_block = count_area->dl;
@@ -2649,10 +2649,10 @@ static int dasd_eckd_format_process_data(struct dasd_device *base,
old_start = fdata->start_unit;
old_stop = fdata->stop_unit;
- if (!tpm && fmt_buffer != NULL) {
+ if (!tpm && fmt_buffer) {
/* Command Mode / Format Check */
format_step = 1;
- } else if (tpm && fmt_buffer != NULL) {
+ } else if (tpm && fmt_buffer) {
/* Transport Mode / Format Check */
format_step = DASD_CQR_MAX_CCW / rpt;
} else {
@@ -4681,7 +4681,7 @@ static void dasd_eckd_dump_sense_ccw(struct dasd_device *device,
int len, sl, sct;
page = (char *) get_zeroed_page(GFP_ATOMIC);
- if (page == NULL) {
+ if (!page) {
DBF_DEV_EVENT(DBF_WARNING, device, "%s",
"No memory to dump sense data\n");
return;
@@ -4785,7 +4785,7 @@ static void dasd_eckd_dump_sense_tcw(struct dasd_device *device,
u8 *sense, *rcq;
page = (char *) get_zeroed_page(GFP_ATOMIC);
- if (page == NULL) {
+ if (!page) {
DBF_DEV_EVENT(DBF_WARNING, device, " %s",
"No memory to dump sense data");
return;
--
2.12.3
^ permalink raw reply related [flat|nested] 16+ messages in thread* [PATCH 3/3] s390/dasd: Adjust six checks for null pointers
@ 2017-05-10 18:03 ` SF Markus Elfring
0 siblings, 0 replies; 16+ messages in thread
From: SF Markus Elfring @ 2017-05-10 18:03 UTC (permalink / raw)
To: linux-s390, Heiko Carstens, Jan Höppner, Martin Schwidefsky,
Stefan Haberland
Cc: LKML, kernel-janitors
From: Markus Elfring <elfring@users.sourceforge.net>
Date: Wed, 10 May 2017 19:29:17 +0200
MIME-Version: 1.0
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 8bit
The script “checkpatch.pl” pointed information out like the following.
Comparison to NULL could be written …
Thus fix the affected source code places.
Signed-off-by: Markus Elfring <elfring@users.sourceforge.net>
---
drivers/s390/block/dasd_eckd.c | 12 ++++++------
1 file changed, 6 insertions(+), 6 deletions(-)
diff --git a/drivers/s390/block/dasd_eckd.c b/drivers/s390/block/dasd_eckd.c
index e78601d97a67..d02f3bbbd552 100644
--- a/drivers/s390/block/dasd_eckd.c
+++ b/drivers/s390/block/dasd_eckd.c
@@ -1080,7 +1080,7 @@ static int dasd_eckd_read_conf(struct dasd_device *device)
"error %d", rc);
return rc;
}
- if (conf_data = NULL) {
+ if (!conf_data) {
DBF_EVENT_DEVID(DBF_WARNING, device->cdev, "%s",
"No configuration data "
"retrieved");
@@ -2049,7 +2049,7 @@ static int dasd_eckd_end_analysis(struct dasd_block *block)
"Track 0 has no records following the VTOC\n");
}
- if (count_area != NULL && count_area->kl = 0) {
+ if (count_area && count_area->kl = 0) {
/* we found notthing violating our disk layout */
if (dasd_check_blocksize(count_area->dl) = 0)
block->bp_block = count_area->dl;
@@ -2649,10 +2649,10 @@ static int dasd_eckd_format_process_data(struct dasd_device *base,
old_start = fdata->start_unit;
old_stop = fdata->stop_unit;
- if (!tpm && fmt_buffer != NULL) {
+ if (!tpm && fmt_buffer) {
/* Command Mode / Format Check */
format_step = 1;
- } else if (tpm && fmt_buffer != NULL) {
+ } else if (tpm && fmt_buffer) {
/* Transport Mode / Format Check */
format_step = DASD_CQR_MAX_CCW / rpt;
} else {
@@ -4681,7 +4681,7 @@ static void dasd_eckd_dump_sense_ccw(struct dasd_device *device,
int len, sl, sct;
page = (char *) get_zeroed_page(GFP_ATOMIC);
- if (page = NULL) {
+ if (!page) {
DBF_DEV_EVENT(DBF_WARNING, device, "%s",
"No memory to dump sense data\n");
return;
@@ -4785,7 +4785,7 @@ static void dasd_eckd_dump_sense_tcw(struct dasd_device *device,
u8 *sense, *rcq;
page = (char *) get_zeroed_page(GFP_ATOMIC);
- if (page = NULL) {
+ if (!page) {
DBF_DEV_EVENT(DBF_WARNING, device, " %s",
"No memory to dump sense data");
return;
--
2.12.3
^ permalink raw reply related [flat|nested] 16+ messages in thread
* Re: [PATCH 0/3] S390-DASD: Fine-tuning for some function implementations
2017-05-10 18:00 ` SF Markus Elfring
@ 2017-12-14 10:34 ` SF Markus Elfring
-1 siblings, 0 replies; 16+ messages in thread
From: SF Markus Elfring @ 2017-12-14 10:34 UTC (permalink / raw)
To: linux-s390, Heiko Carstens, Jan Höppner, Martin Schwidefsky,
Stefan Haberland
Cc: LKML, kernel-janitors
> Date: Wed, 10 May 2017 19:43:21 +0200
>
> A few update suggestions were taken into account
> from static source code analysis.
>
> Markus Elfring (3):
> Adjust buffer output in dasd_hosts_print()
> Fix typos in two comment lines
> Adjust six checks for null pointers
>
> drivers/s390/block/dasd_eckd.c | 24 +++++++++++-------------
> 1 file changed, 11 insertions(+), 13 deletions(-)
Are there any chances that such change possibilities (and further adjustments)
will be integrated in this software area?
Regards,
Markus
^ permalink raw reply [flat|nested] 16+ messages in thread
* Re: [PATCH 0/3] S390-DASD: Fine-tuning for some function implementations
@ 2017-12-14 10:34 ` SF Markus Elfring
0 siblings, 0 replies; 16+ messages in thread
From: SF Markus Elfring @ 2017-12-14 10:34 UTC (permalink / raw)
To: linux-s390, Heiko Carstens, Jan Höppner, Martin Schwidefsky,
Stefan Haberland
Cc: LKML, kernel-janitors
> Date: Wed, 10 May 2017 19:43:21 +0200
>
> A few update suggestions were taken into account
> from static source code analysis.
>
> Markus Elfring (3):
> Adjust buffer output in dasd_hosts_print()
> Fix typos in two comment lines
> Adjust six checks for null pointers
>
> drivers/s390/block/dasd_eckd.c | 24 +++++++++++-------------
> 1 file changed, 11 insertions(+), 13 deletions(-)
Are there any chances that such change possibilities (and further adjustments)
will be integrated in this software area?
Regards,
Markus
^ permalink raw reply [flat|nested] 16+ messages in thread
* Re: [PATCH 0/3] S390-DASD: Fine-tuning for some function implementations
2017-12-14 10:34 ` SF Markus Elfring
@ 2017-12-14 11:07 ` Heiko Carstens
-1 siblings, 0 replies; 16+ messages in thread
From: Heiko Carstens @ 2017-12-14 11:07 UTC (permalink / raw)
To: SF Markus Elfring
Cc: linux-s390, Jan Höppner, Martin Schwidefsky,
Stefan Haberland, LKML, kernel-janitors
On Thu, Dec 14, 2017 at 11:34:01AM +0100, SF Markus Elfring wrote:
> > Date: Wed, 10 May 2017 19:43:21 +0200
> >
> > A few update suggestions were taken into account
> > from static source code analysis.
> >
> > Markus Elfring (3):
> > Adjust buffer output in dasd_hosts_print()
> > Fix typos in two comment lines
> > Adjust six checks for null pointers
> >
> > drivers/s390/block/dasd_eckd.c | 24 +++++++++++-------------
> > 1 file changed, 11 insertions(+), 13 deletions(-)
>
>
> Are there any chances that such change possibilities (and further adjustments)
> will be integrated in this software area?
No.
^ permalink raw reply [flat|nested] 16+ messages in thread
* Re: [PATCH 0/3] S390-DASD: Fine-tuning for some function implementations
@ 2017-12-14 11:07 ` Heiko Carstens
0 siblings, 0 replies; 16+ messages in thread
From: Heiko Carstens @ 2017-12-14 11:07 UTC (permalink / raw)
To: SF Markus Elfring
Cc: linux-s390, Jan Höppner, Martin Schwidefsky,
Stefan Haberland, LKML, kernel-janitors
On Thu, Dec 14, 2017 at 11:34:01AM +0100, SF Markus Elfring wrote:
> > Date: Wed, 10 May 2017 19:43:21 +0200
> >
> > A few update suggestions were taken into account
> > from static source code analysis.
> >
> > Markus Elfring (3):
> > Adjust buffer output in dasd_hosts_print()
> > Fix typos in two comment lines
> > Adjust six checks for null pointers
> >
> > drivers/s390/block/dasd_eckd.c | 24 +++++++++++-------------
> > 1 file changed, 11 insertions(+), 13 deletions(-)
>
>
> Are there any chances that such change possibilities (and further adjustments)
> will be integrated in this software area?
No.
^ permalink raw reply [flat|nested] 16+ messages in thread