* [igt-dev] [PATCH i-g-t] tests/kms_plane_lowres: Test only with one plane
@ 2020-01-17 9:17 Mika Kahola
2020-01-17 10:00 ` [igt-dev] ✓ Fi.CI.BAT: success for " Patchwork
` (2 more replies)
0 siblings, 3 replies; 10+ messages in thread
From: Mika Kahola @ 2020-01-17 9:17 UTC (permalink / raw)
To: igt-dev
The test is intended to test resolution changes from higher to
lower and back. We can test this with only one plane and we don't
need to run through all planes. This will save significant amount
of test execution time.
Fix for
Bugzilla: https://gitlab.freedesktop.org/drm/intel/issues/899
Signed-off-by: Mika Kahola <mika.kahola@intel.com>
---
tests/kms_plane_lowres.c | 3 ++-
1 file changed, 2 insertions(+), 1 deletion(-)
diff --git a/tests/kms_plane_lowres.c b/tests/kms_plane_lowres.c
index 4c3f5636..ee6fb1fb 100644
--- a/tests/kms_plane_lowres.c
+++ b/tests/kms_plane_lowres.c
@@ -208,7 +208,8 @@ test_planes_on_pipe_with_output(data_t *data, enum pipe pipe,
igt_assert_crc_equal(&data->ref_lowres.crc, &crc_lowres);
igt_plane_set_fb(plane, NULL);
- tested++;
+ if (tested++)
+ break;
}
igt_pipe_crc_free(pipe_crc);
--
2.17.1
_______________________________________________
igt-dev mailing list
igt-dev@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/igt-dev
^ permalink raw reply related [flat|nested] 10+ messages in thread
* [igt-dev] ✓ Fi.CI.BAT: success for tests/kms_plane_lowres: Test only with one plane
2020-01-17 9:17 [igt-dev] [PATCH i-g-t] tests/kms_plane_lowres: Test only with one plane Mika Kahola
@ 2020-01-17 10:00 ` Patchwork
2020-01-17 12:13 ` [igt-dev] [PATCH i-g-t] " Petri Latvala
2020-01-20 11:39 ` [igt-dev] ✓ Fi.CI.IGT: success for " Patchwork
2 siblings, 0 replies; 10+ messages in thread
From: Patchwork @ 2020-01-17 10:00 UTC (permalink / raw)
To: Mika Kahola; +Cc: igt-dev
== Series Details ==
Series: tests/kms_plane_lowres: Test only with one plane
URL : https://patchwork.freedesktop.org/series/72177/
State : success
== Summary ==
CI Bug Log - changes from CI_DRM_7758 -> IGTPW_3933
====================================================
Summary
-------
**SUCCESS**
No regressions found.
External URL: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_3933/index.html
Known issues
------------
Here are the changes found in IGTPW_3933 that come from known issues:
### IGT changes ###
#### Issues hit ####
* igt@kms_chamelium@dp-edid-read:
- fi-icl-u2: [PASS][1] -> [FAIL][2] ([fdo#109635] / [i915#217])
[1]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7758/fi-icl-u2/igt@kms_chamelium@dp-edid-read.html
[2]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_3933/fi-icl-u2/igt@kms_chamelium@dp-edid-read.html
#### Possible fixes ####
* igt@gem_exec_create@basic:
- fi-icl-dsi: [DMESG-WARN][3] ([i915#109]) -> [PASS][4]
[3]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7758/fi-icl-dsi/igt@gem_exec_create@basic.html
[4]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_3933/fi-icl-dsi/igt@gem_exec_create@basic.html
* igt@gem_exec_suspend@basic-s0:
- {fi-ehl-1}: [INCOMPLETE][5] ([i915#937]) -> [PASS][6]
[5]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7758/fi-ehl-1/igt@gem_exec_suspend@basic-s0.html
[6]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_3933/fi-ehl-1/igt@gem_exec_suspend@basic-s0.html
* igt@i915_pm_rpm@module-reload:
- fi-skl-6770hq: [FAIL][7] ([i915#178]) -> [PASS][8]
[7]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7758/fi-skl-6770hq/igt@i915_pm_rpm@module-reload.html
[8]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_3933/fi-skl-6770hq/igt@i915_pm_rpm@module-reload.html
#### Warnings ####
* igt@i915_selftest@live_blt:
- fi-hsw-4770: [DMESG-FAIL][9] ([i915#553] / [i915#725]) -> [DMESG-FAIL][10] ([i915#725])
[9]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7758/fi-hsw-4770/igt@i915_selftest@live_blt.html
[10]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_3933/fi-hsw-4770/igt@i915_selftest@live_blt.html
* igt@kms_chamelium@hdmi-hpd-fast:
- fi-kbl-7500u: [FAIL][11] ([fdo#111096] / [i915#323]) -> [FAIL][12] ([fdo#111407])
[11]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7758/fi-kbl-7500u/igt@kms_chamelium@hdmi-hpd-fast.html
[12]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_3933/fi-kbl-7500u/igt@kms_chamelium@hdmi-hpd-fast.html
* igt@runner@aborted:
- fi-kbl-8809g: [FAIL][13] ([i915#858]) -> [FAIL][14] ([i915#192] / [i915#193] / [i915#194])
[13]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7758/fi-kbl-8809g/igt@runner@aborted.html
[14]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_3933/fi-kbl-8809g/igt@runner@aborted.html
{name}: This element is suppressed. This means it is ignored when computing
the status of the difference (SUCCESS, WARNING, or FAILURE).
[fdo#109635]: https://bugs.freedesktop.org/show_bug.cgi?id=109635
[fdo#111096]: https://bugs.freedesktop.org/show_bug.cgi?id=111096
[fdo#111407]: https://bugs.freedesktop.org/show_bug.cgi?id=111407
[i915#109]: https://gitlab.freedesktop.org/drm/intel/issues/109
[i915#178]: https://gitlab.freedesktop.org/drm/intel/issues/178
[i915#192]: https://gitlab.freedesktop.org/drm/intel/issues/192
[i915#193]: https://gitlab.freedesktop.org/drm/intel/issues/193
[i915#194]: https://gitlab.freedesktop.org/drm/intel/issues/194
[i915#217]: https://gitlab.freedesktop.org/drm/intel/issues/217
[i915#323]: https://gitlab.freedesktop.org/drm/intel/issues/323
[i915#553]: https://gitlab.freedesktop.org/drm/intel/issues/553
[i915#725]: https://gitlab.freedesktop.org/drm/intel/issues/725
[i915#858]: https://gitlab.freedesktop.org/drm/intel/issues/858
[i915#937]: https://gitlab.freedesktop.org/drm/intel/issues/937
Participating hosts (47 -> 42)
------------------------------
Additional (2): fi-byt-j1900 fi-byt-n2820
Missing (7): fi-ilk-m540 fi-hsw-4200u fi-hsw-peppy fi-byt-squawks fi-bsw-cyan fi-bwr-2160 fi-kbl-r
Build changes
-------------
* CI: CI-20190529 -> None
* IGT: IGT_5371 -> IGTPW_3933
CI-20190529: 20190529
CI_DRM_7758: d19270ce1f367fbfc1ff3b539bcb50e11ded181f @ git://anongit.freedesktop.org/gfx-ci/linux
IGTPW_3933: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_3933/index.html
IGT_5371: 1b2816124ec3dbd53b81725d39292f45d41d895b @ git://anongit.freedesktop.org/xorg/app/intel-gpu-tools
== Logs ==
For more details see: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_3933/index.html
_______________________________________________
igt-dev mailing list
igt-dev@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/igt-dev
^ permalink raw reply [flat|nested] 10+ messages in thread
* Re: [igt-dev] [PATCH i-g-t] tests/kms_plane_lowres: Test only with one plane
2020-01-17 9:17 [igt-dev] [PATCH i-g-t] tests/kms_plane_lowres: Test only with one plane Mika Kahola
2020-01-17 10:00 ` [igt-dev] ✓ Fi.CI.BAT: success for " Patchwork
@ 2020-01-17 12:13 ` Petri Latvala
2020-01-17 12:44 ` Kahola, Mika
2020-01-20 11:39 ` [igt-dev] ✓ Fi.CI.IGT: success for " Patchwork
2 siblings, 1 reply; 10+ messages in thread
From: Petri Latvala @ 2020-01-17 12:13 UTC (permalink / raw)
To: Mika Kahola; +Cc: igt-dev
On Fri, Jan 17, 2020 at 11:17:49AM +0200, Mika Kahola wrote:
> The test is intended to test resolution changes from higher to
> lower and back. We can test this with only one plane and we don't
> need to run through all planes. This will save significant amount
> of test execution time.
>
> Fix for
> Bugzilla: https://gitlab.freedesktop.org/drm/intel/issues/899
I'm having a hard time understanding how this change fixes this issue.
>
> Signed-off-by: Mika Kahola <mika.kahola@intel.com>
> ---
> tests/kms_plane_lowres.c | 3 ++-
> 1 file changed, 2 insertions(+), 1 deletion(-)
>
> diff --git a/tests/kms_plane_lowres.c b/tests/kms_plane_lowres.c
> index 4c3f5636..ee6fb1fb 100644
> --- a/tests/kms_plane_lowres.c
> +++ b/tests/kms_plane_lowres.c
> @@ -208,7 +208,8 @@ test_planes_on_pipe_with_output(data_t *data, enum pipe pipe,
> igt_assert_crc_equal(&data->ref_lowres.crc, &crc_lowres);
>
> igt_plane_set_fb(plane, NULL);
> - tested++;
> + if (tested++)
> + break;
At this point one must ask: Why have the count variable anymore?
--
Petri Latvala
_______________________________________________
igt-dev mailing list
igt-dev@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/igt-dev
^ permalink raw reply [flat|nested] 10+ messages in thread
* Re: [igt-dev] [PATCH i-g-t] tests/kms_plane_lowres: Test only with one plane
2020-01-17 12:13 ` [igt-dev] [PATCH i-g-t] " Petri Latvala
@ 2020-01-17 12:44 ` Kahola, Mika
2020-01-17 13:15 ` Petri Latvala
0 siblings, 1 reply; 10+ messages in thread
From: Kahola, Mika @ 2020-01-17 12:44 UTC (permalink / raw)
To: Latvala, Petri; +Cc: igt-dev
On Fri, 2020-01-17 at 14:13 +0200, Petri Latvala wrote:
> On Fri, Jan 17, 2020 at 11:17:49AM +0200, Mika Kahola wrote:
> > The test is intended to test resolution changes from higher to
> > lower and back. We can test this with only one plane and we don't
> > need to run through all planes. This will save significant amount
> > of test execution time.
> >
> > Fix for
> > Bugzilla: https://gitlab.freedesktop.org/drm/intel/issues/899
>
> I'm having a hard time understanding how this change fixes this
> issue.
For some reason crc's don't match if we loop through multiple overlay
planes. The reference image has primary, first overlay and cursors
plane. Crc already fails if we compare the reference with the image
having primary, second overlay and cursor plane. This I have been
testing with TGL.
>
>
> >
> > Signed-off-by: Mika Kahola <mika.kahola@intel.com>
> > ---
> > tests/kms_plane_lowres.c | 3 ++-
> > 1 file changed, 2 insertions(+), 1 deletion(-)
> >
> > diff --git a/tests/kms_plane_lowres.c b/tests/kms_plane_lowres.c
> > index 4c3f5636..ee6fb1fb 100644
> > --- a/tests/kms_plane_lowres.c
> > +++ b/tests/kms_plane_lowres.c
> > @@ -208,7 +208,8 @@ test_planes_on_pipe_with_output(data_t *data,
> > enum pipe pipe,
> > igt_assert_crc_equal(&data->ref_lowres.crc,
> > &crc_lowres);
> >
> > igt_plane_set_fb(plane, NULL);
> > - tested++;
> > + if (tested++)
> > + break;
>
> At this point one must ask: Why have the count variable anymore?
>
>
_______________________________________________
igt-dev mailing list
igt-dev@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/igt-dev
^ permalink raw reply [flat|nested] 10+ messages in thread
* Re: [igt-dev] [PATCH i-g-t] tests/kms_plane_lowres: Test only with one plane
2020-01-17 12:44 ` Kahola, Mika
@ 2020-01-17 13:15 ` Petri Latvala
2020-01-17 14:35 ` Kahola, Mika
0 siblings, 1 reply; 10+ messages in thread
From: Petri Latvala @ 2020-01-17 13:15 UTC (permalink / raw)
To: Kahola, Mika; +Cc: igt-dev
On Fri, Jan 17, 2020 at 02:44:40PM +0200, Kahola, Mika wrote:
> On Fri, 2020-01-17 at 14:13 +0200, Petri Latvala wrote:
> > On Fri, Jan 17, 2020 at 11:17:49AM +0200, Mika Kahola wrote:
> > > The test is intended to test resolution changes from higher to
> > > lower and back. We can test this with only one plane and we don't
> > > need to run through all planes. This will save significant amount
> > > of test execution time.
> > >
> > > Fix for
> > > Bugzilla: https://gitlab.freedesktop.org/drm/intel/issues/899
> >
> > I'm having a hard time understanding how this change fixes this
> > issue.
> For some reason crc's don't match if we loop through multiple overlay
> planes. The reference image has primary, first overlay and cursors
> plane. Crc already fails if we compare the reference with the image
> having primary, second overlay and cursor plane. This I have been
> testing with TGL.
Commit message talks about saving test execution time but this
explanation is about working around failures.
What is actually broken and is this working around an issue or hiding
it? Is it always the same plane combination failing, every test round?
(Am I reading the test wrong though, as far as I can see there's just
two planes in use at a time, primary and one other...)
At the very least one plane of each type should be tested instead of
just the first non-primary.
--
Petri Latvala
_______________________________________________
igt-dev mailing list
igt-dev@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/igt-dev
^ permalink raw reply [flat|nested] 10+ messages in thread
* Re: [igt-dev] [PATCH i-g-t] tests/kms_plane_lowres: Test only with one plane
2020-01-17 13:15 ` Petri Latvala
@ 2020-01-17 14:35 ` Kahola, Mika
2020-01-20 12:02 ` Petri Latvala
0 siblings, 1 reply; 10+ messages in thread
From: Kahola, Mika @ 2020-01-17 14:35 UTC (permalink / raw)
To: Latvala, Petri; +Cc: igt-dev
On Fri, 2020-01-17 at 15:15 +0200, Petri Latvala wrote:
> On Fri, Jan 17, 2020 at 02:44:40PM +0200, Kahola, Mika wrote:
> > On Fri, 2020-01-17 at 14:13 +0200, Petri Latvala wrote:
> > > On Fri, Jan 17, 2020 at 11:17:49AM +0200, Mika Kahola wrote:
> > > > The test is intended to test resolution changes from higher to
> > > > lower and back. We can test this with only one plane and we
> > > > don't
> > > > need to run through all planes. This will save significant
> > > > amount
> > > > of test execution time.
> > > >
> > > > Fix for
> > > > Bugzilla: https://gitlab.freedesktop.org/drm/intel/issues/899
> > >
> > > I'm having a hard time understanding how this change fixes this
> > > issue.
> >
> > For some reason crc's don't match if we loop through multiple
> > overlay
> > planes. The reference image has primary, first overlay and cursors
> > plane. Crc already fails if we compare the reference with the image
> > having primary, second overlay and cursor plane. This I have been
> > testing with TGL.
>
>
> Commit message talks about saving test execution time but this
> explanation is about working around failures.
Right. I should have been more verbal about the commit message. On TGL
running a single subtest takes ~15s with one plane of each type. If we
loop through all planes, it takes ~55s.
>
> What is actually broken and is this working around an issue or hiding
> it? Is it always the same plane combination failing, every test
> round?
>
> (Am I reading the test wrong though, as far as I can see there's just
> two planes in use at a time, primary and one other...)
That's true. The crc's are ok with overlay plane[0] but has a mismatch
on the round plane[1]. Should we draw references too with all the
overlay planes instead? Any suggestions how to handle this?
Originally, we tested only with the first overlay plane. This is not
about testing the plane but more on testing resolution changes. That's
why I suggested to take a step back and test only with one plane.
> At the very least one plane of each type should be tested instead of
> just the first non-primary.
>
>
_______________________________________________
igt-dev mailing list
igt-dev@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/igt-dev
^ permalink raw reply [flat|nested] 10+ messages in thread
* [igt-dev] ✓ Fi.CI.IGT: success for tests/kms_plane_lowres: Test only with one plane
2020-01-17 9:17 [igt-dev] [PATCH i-g-t] tests/kms_plane_lowres: Test only with one plane Mika Kahola
2020-01-17 10:00 ` [igt-dev] ✓ Fi.CI.BAT: success for " Patchwork
2020-01-17 12:13 ` [igt-dev] [PATCH i-g-t] " Petri Latvala
@ 2020-01-20 11:39 ` Patchwork
2 siblings, 0 replies; 10+ messages in thread
From: Patchwork @ 2020-01-20 11:39 UTC (permalink / raw)
To: Kahola, Mika; +Cc: igt-dev
== Series Details ==
Series: tests/kms_plane_lowres: Test only with one plane
URL : https://patchwork.freedesktop.org/series/72177/
State : success
== Summary ==
CI Bug Log - changes from CI_DRM_7758_full -> IGTPW_3933_full
====================================================
Summary
-------
**SUCCESS**
No regressions found.
External URL: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_3933/index.html
Known issues
------------
Here are the changes found in IGTPW_3933_full that come from known issues:
### IGT changes ###
#### Issues hit ####
* igt@gem_busy@busy-vcs1:
- shard-iclb: [PASS][1] -> [SKIP][2] ([fdo#112080]) +9 similar issues
[1]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7758/shard-iclb4/igt@gem_busy@busy-vcs1.html
[2]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_3933/shard-iclb8/igt@gem_busy@busy-vcs1.html
* igt@gem_ctx_persistence@vcs1-hostile-preempt:
- shard-iclb: [PASS][3] -> [SKIP][4] ([fdo#109276] / [fdo#112080]) +2 similar issues
[3]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7758/shard-iclb2/igt@gem_ctx_persistence@vcs1-hostile-preempt.html
[4]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_3933/shard-iclb5/igt@gem_ctx_persistence@vcs1-hostile-preempt.html
* igt@gem_ctx_persistence@vecs0-mixed-process:
- shard-glk: [PASS][5] -> [FAIL][6] ([i915#679])
[5]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7758/shard-glk9/igt@gem_ctx_persistence@vecs0-mixed-process.html
[6]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_3933/shard-glk4/igt@gem_ctx_persistence@vecs0-mixed-process.html
* igt@gem_exec_schedule@reorder-wide-bsd:
- shard-iclb: [PASS][7] -> [SKIP][8] ([fdo#112146]) +2 similar issues
[7]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7758/shard-iclb6/igt@gem_exec_schedule@reorder-wide-bsd.html
[8]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_3933/shard-iclb1/igt@gem_exec_schedule@reorder-wide-bsd.html
* igt@gem_persistent_relocs@forked-interruptible-faulting-reloc-thrashing:
- shard-glk: [PASS][9] -> [INCOMPLETE][10] ([CI#80] / [i915#58] / [k.org#198133])
[9]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7758/shard-glk3/igt@gem_persistent_relocs@forked-interruptible-faulting-reloc-thrashing.html
[10]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_3933/shard-glk7/igt@gem_persistent_relocs@forked-interruptible-faulting-reloc-thrashing.html
* igt@gem_persistent_relocs@forked-interruptible-thrashing:
- shard-snb: [PASS][11] -> [FAIL][12] ([i915#520])
[11]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7758/shard-snb5/igt@gem_persistent_relocs@forked-interruptible-thrashing.html
[12]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_3933/shard-snb1/igt@gem_persistent_relocs@forked-interruptible-thrashing.html
- shard-iclb: [PASS][13] -> [FAIL][14] ([i915#520])
[13]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7758/shard-iclb1/igt@gem_persistent_relocs@forked-interruptible-thrashing.html
[14]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_3933/shard-iclb1/igt@gem_persistent_relocs@forked-interruptible-thrashing.html
* igt@gem_persistent_relocs@forked-thrashing:
- shard-hsw: [PASS][15] -> [INCOMPLETE][16] ([i915#530] / [i915#61])
[15]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7758/shard-hsw5/igt@gem_persistent_relocs@forked-thrashing.html
[16]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_3933/shard-hsw7/igt@gem_persistent_relocs@forked-thrashing.html
* igt@kms_cursor_crc@pipe-b-cursor-128x42-onscreen:
- shard-apl: [PASS][17] -> [FAIL][18] ([i915#54]) +1 similar issue
[17]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7758/shard-apl7/igt@kms_cursor_crc@pipe-b-cursor-128x42-onscreen.html
[18]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_3933/shard-apl1/igt@kms_cursor_crc@pipe-b-cursor-128x42-onscreen.html
* igt@kms_cursor_crc@pipe-c-cursor-256x85-random:
- shard-kbl: [PASS][19] -> [FAIL][20] ([i915#54]) +1 similar issue
[19]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7758/shard-kbl2/igt@kms_cursor_crc@pipe-c-cursor-256x85-random.html
[20]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_3933/shard-kbl1/igt@kms_cursor_crc@pipe-c-cursor-256x85-random.html
- shard-glk: [PASS][21] -> [FAIL][22] ([i915#54])
[21]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7758/shard-glk8/igt@kms_cursor_crc@pipe-c-cursor-256x85-random.html
[22]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_3933/shard-glk9/igt@kms_cursor_crc@pipe-c-cursor-256x85-random.html
* igt@kms_flip@flip-vs-suspend-interruptible:
- shard-apl: [PASS][23] -> [DMESG-WARN][24] ([i915#180]) +3 similar issues
[23]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7758/shard-apl7/igt@kms_flip@flip-vs-suspend-interruptible.html
[24]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_3933/shard-apl1/igt@kms_flip@flip-vs-suspend-interruptible.html
* igt@kms_pipe_crc_basic@suspend-read-crc-pipe-a:
- shard-kbl: [PASS][25] -> [DMESG-WARN][26] ([i915#180]) +5 similar issues
[25]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7758/shard-kbl4/igt@kms_pipe_crc_basic@suspend-read-crc-pipe-a.html
[26]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_3933/shard-kbl1/igt@kms_pipe_crc_basic@suspend-read-crc-pipe-a.html
* igt@kms_psr2_su@frontbuffer:
- shard-iclb: [PASS][27] -> [SKIP][28] ([fdo#109642] / [fdo#111068])
[27]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7758/shard-iclb2/igt@kms_psr2_su@frontbuffer.html
[28]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_3933/shard-iclb8/igt@kms_psr2_su@frontbuffer.html
* igt@kms_psr@no_drrs:
- shard-iclb: [PASS][29] -> [FAIL][30] ([i915#173])
[29]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7758/shard-iclb8/igt@kms_psr@no_drrs.html
[30]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_3933/shard-iclb1/igt@kms_psr@no_drrs.html
* igt@kms_psr@psr2_primary_page_flip:
- shard-iclb: [PASS][31] -> [SKIP][32] ([fdo#109441])
[31]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7758/shard-iclb2/igt@kms_psr@psr2_primary_page_flip.html
[32]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_3933/shard-iclb4/igt@kms_psr@psr2_primary_page_flip.html
* igt@prime_busy@hang-bsd2:
- shard-iclb: [PASS][33] -> [SKIP][34] ([fdo#109276]) +15 similar issues
[33]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7758/shard-iclb2/igt@prime_busy@hang-bsd2.html
[34]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_3933/shard-iclb5/igt@prime_busy@hang-bsd2.html
#### Possible fixes ####
* igt@gem_ctx_persistence@processes:
- shard-iclb: [FAIL][35] ([i915#570]) -> [PASS][36]
[35]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7758/shard-iclb4/igt@gem_ctx_persistence@processes.html
[36]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_3933/shard-iclb1/igt@gem_ctx_persistence@processes.html
* igt@gem_ctx_persistence@vcs1-queued:
- shard-iclb: [SKIP][37] ([fdo#109276] / [fdo#112080]) -> [PASS][38] +3 similar issues
[37]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7758/shard-iclb5/igt@gem_ctx_persistence@vcs1-queued.html
[38]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_3933/shard-iclb2/igt@gem_ctx_persistence@vcs1-queued.html
* igt@gem_exec_balancer@smoke:
- shard-iclb: [SKIP][39] ([fdo#110854]) -> [PASS][40]
[39]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7758/shard-iclb5/igt@gem_exec_balancer@smoke.html
[40]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_3933/shard-iclb2/igt@gem_exec_balancer@smoke.html
* igt@gem_exec_schedule@out-order-bsd2:
- shard-iclb: [SKIP][41] ([fdo#109276]) -> [PASS][42] +17 similar issues
[41]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7758/shard-iclb8/igt@gem_exec_schedule@out-order-bsd2.html
[42]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_3933/shard-iclb1/igt@gem_exec_schedule@out-order-bsd2.html
* igt@gem_exec_schedule@preemptive-hang-bsd:
- shard-iclb: [SKIP][43] ([fdo#112146]) -> [PASS][44] +5 similar issues
[43]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7758/shard-iclb4/igt@gem_exec_schedule@preemptive-hang-bsd.html
[44]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_3933/shard-iclb6/igt@gem_exec_schedule@preemptive-hang-bsd.html
* igt@gem_persistent_relocs@forked-interruptible-thrash-inactive:
- shard-kbl: [TIMEOUT][45] ([fdo#112271] / [i915#530]) -> [PASS][46]
[45]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7758/shard-kbl4/igt@gem_persistent_relocs@forked-interruptible-thrash-inactive.html
[46]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_3933/shard-kbl7/igt@gem_persistent_relocs@forked-interruptible-thrash-inactive.html
* {igt@i915_pm_rc6_residency@rc6-idle}:
- shard-apl: [FAIL][47] ([i915#973]) -> [PASS][48]
[47]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7758/shard-apl3/igt@i915_pm_rc6_residency@rc6-idle.html
[48]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_3933/shard-apl2/igt@i915_pm_rc6_residency@rc6-idle.html
* igt@i915_pm_rps@reset:
- shard-iclb: [FAIL][49] ([i915#413]) -> [PASS][50]
[49]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7758/shard-iclb4/igt@i915_pm_rps@reset.html
[50]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_3933/shard-iclb1/igt@i915_pm_rps@reset.html
* igt@i915_selftest@live_execlists:
- shard-kbl: [INCOMPLETE][51] ([fdo#103665] / [fdo#112175] / [fdo#112259]) -> [PASS][52]
[51]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7758/shard-kbl6/igt@i915_selftest@live_execlists.html
[52]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_3933/shard-kbl4/igt@i915_selftest@live_execlists.html
* igt@kms_cursor_crc@pipe-a-cursor-suspend:
- shard-apl: [DMESG-WARN][53] ([i915#180]) -> [PASS][54]
[53]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7758/shard-apl3/igt@kms_cursor_crc@pipe-a-cursor-suspend.html
[54]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_3933/shard-apl7/igt@kms_cursor_crc@pipe-a-cursor-suspend.html
* igt@kms_frontbuffer_tracking@fbc-2p-primscrn-shrfb-msflip-blt:
- shard-glk: [FAIL][55] ([i915#49]) -> [PASS][56]
[55]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7758/shard-glk8/igt@kms_frontbuffer_tracking@fbc-2p-primscrn-shrfb-msflip-blt.html
[56]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_3933/shard-glk5/igt@kms_frontbuffer_tracking@fbc-2p-primscrn-shrfb-msflip-blt.html
* igt@kms_plane@plane-panning-bottom-right-suspend-pipe-a-planes:
- shard-iclb: [INCOMPLETE][57] ([i915#140] / [i915#250]) -> [PASS][58]
[57]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7758/shard-iclb8/igt@kms_plane@plane-panning-bottom-right-suspend-pipe-a-planes.html
[58]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_3933/shard-iclb6/igt@kms_plane@plane-panning-bottom-right-suspend-pipe-a-planes.html
* igt@kms_plane@plane-panning-bottom-right-suspend-pipe-b-planes:
- shard-kbl: [DMESG-WARN][59] ([i915#180]) -> [PASS][60] +1 similar issue
[59]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7758/shard-kbl3/igt@kms_plane@plane-panning-bottom-right-suspend-pipe-b-planes.html
[60]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_3933/shard-kbl6/igt@kms_plane@plane-panning-bottom-right-suspend-pipe-b-planes.html
* igt@kms_plane_lowres@pipe-b-tiling-x:
- shard-glk: [FAIL][61] ([i915#899]) -> [PASS][62] +10 similar issues
[61]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7758/shard-glk2/igt@kms_plane_lowres@pipe-b-tiling-x.html
[62]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_3933/shard-glk9/igt@kms_plane_lowres@pipe-b-tiling-x.html
* igt@kms_plane_lowres@pipe-c-tiling-none:
- shard-iclb: [FAIL][63] ([i915#899]) -> [PASS][64] +11 similar issues
[63]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7758/shard-iclb8/igt@kms_plane_lowres@pipe-c-tiling-none.html
[64]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_3933/shard-iclb1/igt@kms_plane_lowres@pipe-c-tiling-none.html
* igt@kms_psr@psr2_no_drrs:
- shard-iclb: [SKIP][65] ([fdo#109441]) -> [PASS][66] +2 similar issues
[65]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7758/shard-iclb6/igt@kms_psr@psr2_no_drrs.html
[66]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_3933/shard-iclb2/igt@kms_psr@psr2_no_drrs.html
* igt@kms_setmode@basic:
- shard-apl: [FAIL][67] ([i915#31]) -> [PASS][68]
[67]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7758/shard-apl3/igt@kms_setmode@basic.html
[68]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_3933/shard-apl1/igt@kms_setmode@basic.html
* igt@perf_pmu@busy-vcs1:
- shard-iclb: [SKIP][69] ([fdo#112080]) -> [PASS][70] +7 similar issues
[69]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7758/shard-iclb6/igt@perf_pmu@busy-vcs1.html
[70]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_3933/shard-iclb2/igt@perf_pmu@busy-vcs1.html
#### Warnings ####
* igt@gem_ctx_isolation@vcs1-nonpriv:
- shard-iclb: [FAIL][71] ([IGT#28]) -> [SKIP][72] ([fdo#109276] / [fdo#112080])
[71]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7758/shard-iclb4/igt@gem_ctx_isolation@vcs1-nonpriv.html
[72]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_3933/shard-iclb6/igt@gem_ctx_isolation@vcs1-nonpriv.html
* igt@gem_ctx_isolation@vcs1-nonpriv-switch:
- shard-iclb: [SKIP][73] ([fdo#109276] / [fdo#112080]) -> [FAIL][74] ([IGT#28])
[73]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7758/shard-iclb6/igt@gem_ctx_isolation@vcs1-nonpriv-switch.html
[74]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_3933/shard-iclb2/igt@gem_ctx_isolation@vcs1-nonpriv-switch.html
* igt@gem_userptr_blits@dmabuf-sync:
- shard-snb: [DMESG-WARN][75] ([fdo#111870] / [i915#478]) -> [DMESG-WARN][76] ([fdo#110789] / [fdo#111870] / [i915#478]) +1 similar issue
[75]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7758/shard-snb6/igt@gem_userptr_blits@dmabuf-sync.html
[76]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_3933/shard-snb5/igt@gem_userptr_blits@dmabuf-sync.html
{name}: This element is suppressed. This means it is ignored when computing
the status of the difference (SUCCESS, WARNING, or FAILURE).
[CI#80]: https://gitlab.freedesktop.org/gfx-ci/i915-infra/issues/80
[IGT#28]: https://gitlab.freedesktop.org/drm/igt-gpu-tools/issues/28
[fdo#103665]: https://bugs.freedesktop.org/show_bug.cgi?id=103665
[fdo#109276]: https://bugs.freedesktop.org/show_bug.cgi?id=109276
[fdo#109441]: https://bugs.freedesktop.org/show_bug.cgi?id=109441
[fdo#109642]: https://bugs.freedesktop.org/show_bug.cgi?id=109642
[fdo#110789]: https://bugs.freedesktop.org/show_bug.cgi?id=110789
[fdo#110854]: https://bugs.freedesktop.org/show_bug.cgi?id=110854
[fdo#111068]: https://bugs.freedesktop.org/show_bug.cgi?id=111068
[fdo#111870]: https://bugs.freedesktop.org/show_bug.cgi?id=111870
[fdo#112080]: https://bugs.freedesktop.org/show_bug.cgi?id=112080
[fdo#112146]: https://bugs.freedesktop.org/show_bug.cgi?id=112146
[fdo#112175]: https://bugs.freedesktop.org/show_bug.cgi?id=112175
[fdo#112259]: https://bugs.freedesktop.org/show_bug.cgi?id=112259
[fdo#112271]: https://bugs.freedesktop.org/show_bug.cgi?id=112271
[i915#140]: https://gitlab.freedesktop.org/drm/intel/issues/140
[i915#173]: https://gitlab.freedesktop.org/drm/intel/issues/173
[i915#180]: https://gitlab.freedesktop.org/drm/intel/issues/180
[i915#250]: https://gitlab.freedesktop.org/drm/intel/issues/250
[i915#31]: https://gitlab.freedesktop.org/drm/intel/issues/31
[i915#413]: https://gitlab.freedesktop.org/drm/intel/issues/413
[i915#478]: https://gitlab.freedesktop.org/drm/intel/issues/478
[i915#49]: https://gitlab.freedesktop.org/drm/intel/issues/49
[i915#520]: https://gitlab.freedesktop.org/drm/intel/issues/520
[i915#530]: https://gitlab.freedesktop.org/drm/intel/issues/530
[i915#54]: https://gitlab.freedesktop.org/drm/intel/issues/54
[i915#570]: https://gitlab.freedesktop.org/drm/intel/issues/570
[i915#58]: https://gitlab.freedesktop.org/drm/intel/issues/58
[i915#61]: https://gitlab.freedesktop.org/drm/intel/issues/61
[i915#679]: https://gitlab.freedesktop.org/drm/intel/issues/679
[i915#899]: https://gitlab.freedesktop.org/drm/intel/issues/899
[i915#973]: https://gitlab.freedesktop.org/drm/intel/issues/973
[k.org#198133]: https://bugzilla.kernel.org/show_bug.cgi?id=198133
Participating hosts (10 -> 8)
------------------------------
Missing (2): pig-skl-6260u pig-glk-j5005
Build changes
-------------
* CI: CI-20190529 -> None
* IGT: IGT_5371 -> IGTPW_3933
* Piglit: piglit_4509 -> None
CI-20190529: 20190529
CI_DRM_7758: d19270ce1f367fbfc1ff3b539bcb50e11ded181f @ git://anongit.freedesktop.org/gfx-ci/linux
IGTPW_3933: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_3933/index.html
IGT_5371: 1b2816124ec3dbd53b81725d39292f45d41d895b @ git://anongit.freedesktop.org/xorg/app/intel-gpu-tools
piglit_4509: fdc5a4ca11124ab8413c7988896eec4c97336694 @ git://anongit.freedesktop.org/piglit
== Logs ==
For more details see: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_3933/index.html
_______________________________________________
igt-dev mailing list
igt-dev@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/igt-dev
^ permalink raw reply [flat|nested] 10+ messages in thread
* Re: [igt-dev] [PATCH i-g-t] tests/kms_plane_lowres: Test only with one plane
2020-01-17 14:35 ` Kahola, Mika
@ 2020-01-20 12:02 ` Petri Latvala
2020-01-20 17:19 ` Ville Syrjälä
0 siblings, 1 reply; 10+ messages in thread
From: Petri Latvala @ 2020-01-20 12:02 UTC (permalink / raw)
To: Kahola, Mika; +Cc: igt-dev
On Fri, Jan 17, 2020 at 04:35:37PM +0200, Kahola, Mika wrote:
> On Fri, 2020-01-17 at 15:15 +0200, Petri Latvala wrote:
> > On Fri, Jan 17, 2020 at 02:44:40PM +0200, Kahola, Mika wrote:
> > > On Fri, 2020-01-17 at 14:13 +0200, Petri Latvala wrote:
> > > > On Fri, Jan 17, 2020 at 11:17:49AM +0200, Mika Kahola wrote:
> > > > > The test is intended to test resolution changes from higher to
> > > > > lower and back. We can test this with only one plane and we
> > > > > don't
> > > > > need to run through all planes. This will save significant
> > > > > amount
> > > > > of test execution time.
> > > > >
> > > > > Fix for
> > > > > Bugzilla: https://gitlab.freedesktop.org/drm/intel/issues/899
> > > >
> > > > I'm having a hard time understanding how this change fixes this
> > > > issue.
> > >
> > > For some reason crc's don't match if we loop through multiple
> > > overlay
> > > planes. The reference image has primary, first overlay and cursors
> > > plane. Crc already fails if we compare the reference with the image
> > > having primary, second overlay and cursor plane. This I have been
> > > testing with TGL.
> >
> >
> > Commit message talks about saving test execution time but this
> > explanation is about working around failures.
> Right. I should have been more verbal about the commit message. On TGL
> running a single subtest takes ~15s with one plane of each type. If we
> loop through all planes, it takes ~55s.
Ok fair enough.
> > What is actually broken and is this working around an issue or hiding
> > it? Is it always the same plane combination failing, every test
> > round?
> >
> > (Am I reading the test wrong though, as far as I can see there's just
> > two planes in use at a time, primary and one other...)
> That's true. The crc's are ok with overlay plane[0] but has a mismatch
> on the round plane[1]. Should we draw references too with all the
> overlay planes instead? Any suggestions how to handle this?
>
> Originally, we tested only with the first overlay plane. This is not
> about testing the plane but more on testing resolution changes. That's
> why I suggested to take a step back and test only with one plane.
The thumb rule is that we have a test case for all different
behaviours of the driver, and incidentally for different behaviours of
the hardware because the kernel is supposed to handle the
differences. I suppose the pertinent question here is: Does the driver
have different code paths for resolution changes for different plane
usage?
--
Petri Latvala
_______________________________________________
igt-dev mailing list
igt-dev@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/igt-dev
^ permalink raw reply [flat|nested] 10+ messages in thread
* Re: [igt-dev] [PATCH i-g-t] tests/kms_plane_lowres: Test only with one plane
2020-01-20 12:02 ` Petri Latvala
@ 2020-01-20 17:19 ` Ville Syrjälä
2020-01-22 8:55 ` Kahola, Mika
0 siblings, 1 reply; 10+ messages in thread
From: Ville Syrjälä @ 2020-01-20 17:19 UTC (permalink / raw)
To: Petri Latvala; +Cc: igt-dev
On Mon, Jan 20, 2020 at 02:02:08PM +0200, Petri Latvala wrote:
> On Fri, Jan 17, 2020 at 04:35:37PM +0200, Kahola, Mika wrote:
> > On Fri, 2020-01-17 at 15:15 +0200, Petri Latvala wrote:
> > > On Fri, Jan 17, 2020 at 02:44:40PM +0200, Kahola, Mika wrote:
> > > > On Fri, 2020-01-17 at 14:13 +0200, Petri Latvala wrote:
> > > > > On Fri, Jan 17, 2020 at 11:17:49AM +0200, Mika Kahola wrote:
> > > > > > The test is intended to test resolution changes from higher to
> > > > > > lower and back. We can test this with only one plane and we
> > > > > > don't
> > > > > > need to run through all planes. This will save significant
> > > > > > amount
> > > > > > of test execution time.
> > > > > >
> > > > > > Fix for
> > > > > > Bugzilla: https://gitlab.freedesktop.org/drm/intel/issues/899
> > > > >
> > > > > I'm having a hard time understanding how this change fixes this
> > > > > issue.
> > > >
> > > > For some reason crc's don't match if we loop through multiple
> > > > overlay
> > > > planes. The reference image has primary, first overlay and cursors
> > > > plane. Crc already fails if we compare the reference with the image
> > > > having primary, second overlay and cursor plane. This I have been
> > > > testing with TGL.
> > >
> > >
> > > Commit message talks about saving test execution time but this
> > > explanation is about working around failures.
> > Right. I should have been more verbal about the commit message. On TGL
> > running a single subtest takes ~15s with one plane of each type. If we
> > loop through all planes, it takes ~55s.
>
> Ok fair enough.
>
> > > What is actually broken and is this working around an issue or hiding
> > > it? Is it always the same plane combination failing, every test
> > > round?
> > >
> > > (Am I reading the test wrong though, as far as I can see there's just
> > > two planes in use at a time, primary and one other...)
> > That's true. The crc's are ok with overlay plane[0] but has a mismatch
> > on the round plane[1]. Should we draw references too with all the
> > overlay planes instead? Any suggestions how to handle this?
> >
> > Originally, we tested only with the first overlay plane. This is not
> > about testing the plane but more on testing resolution changes. That's
> > why I suggested to take a step back and test only with one plane.
>
>
> The thumb rule is that we have a test case for all different
> behaviours of the driver, and incidentally for different behaviours of
> the hardware because the kernel is supposed to handle the
> differences. I suppose the pertinent question here is: Does the driver
> have different code paths for resolution changes for different plane
> usage?
I would expect that using any subset of HDR planes (first three
planes) + cursor to produce the same crc. The crc could be different
if any SDR planes are used since we have to instruct the hw to go
through the non-HDR blending path. If the test already fails with
some HDR planes then feels like there is an actual problem somewhere.
--
Ville Syrjälä
Intel
_______________________________________________
igt-dev mailing list
igt-dev@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/igt-dev
^ permalink raw reply [flat|nested] 10+ messages in thread
* Re: [igt-dev] [PATCH i-g-t] tests/kms_plane_lowres: Test only with one plane
2020-01-20 17:19 ` Ville Syrjälä
@ 2020-01-22 8:55 ` Kahola, Mika
0 siblings, 0 replies; 10+ messages in thread
From: Kahola, Mika @ 2020-01-22 8:55 UTC (permalink / raw)
To: ville.syrjala, Latvala, Petri; +Cc: igt-dev
On Mon, 2020-01-20 at 19:19 +0200, Ville Syrjälä wrote:
> On Mon, Jan 20, 2020 at 02:02:08PM +0200, Petri Latvala wrote:
> > On Fri, Jan 17, 2020 at 04:35:37PM +0200, Kahola, Mika wrote:
> > > On Fri, 2020-01-17 at 15:15 +0200, Petri Latvala wrote:
> > > > On Fri, Jan 17, 2020 at 02:44:40PM +0200, Kahola, Mika wrote:
> > > > > On Fri, 2020-01-17 at 14:13 +0200, Petri Latvala wrote:
> > > > > > On Fri, Jan 17, 2020 at 11:17:49AM +0200, Mika Kahola
> > > > > > wrote:
> > > > > > > The test is intended to test resolution changes from
> > > > > > > higher to
> > > > > > > lower and back. We can test this with only one plane and
> > > > > > > we
> > > > > > > don't
> > > > > > > need to run through all planes. This will save
> > > > > > > significant
> > > > > > > amount
> > > > > > > of test execution time.
> > > > > > >
> > > > > > > Fix for
> > > > > > > Bugzilla:
> > > > > > > https://gitlab.freedesktop.org/drm/intel/issues/899
> > > > > >
> > > > > > I'm having a hard time understanding how this change fixes
> > > > > > this
> > > > > > issue.
> > > > >
> > > > > For some reason crc's don't match if we loop through multiple
> > > > > overlay
> > > > > planes. The reference image has primary, first overlay and
> > > > > cursors
> > > > > plane. Crc already fails if we compare the reference with the
> > > > > image
> > > > > having primary, second overlay and cursor plane. This I have
> > > > > been
> > > > > testing with TGL.
> > > >
> > > >
> > > > Commit message talks about saving test execution time but this
> > > > explanation is about working around failures.
> > >
> > > Right. I should have been more verbal about the commit message.
> > > On TGL
> > > running a single subtest takes ~15s with one plane of each type.
> > > If we
> > > loop through all planes, it takes ~55s.
> >
> > Ok fair enough.
> >
> > > > What is actually broken and is this working around an issue or
> > > > hiding
> > > > it? Is it always the same plane combination failing, every test
> > > > round?
> > > >
> > > > (Am I reading the test wrong though, as far as I can see
> > > > there's just
> > > > two planes in use at a time, primary and one other...)
> > >
> > > That's true. The crc's are ok with overlay plane[0] but has a
> > > mismatch
> > > on the round plane[1]. Should we draw references too with all the
> > > overlay planes instead? Any suggestions how to handle this?
> > >
> > > Originally, we tested only with the first overlay plane. This is
> > > not
> > > about testing the plane but more on testing resolution changes.
> > > That's
> > > why I suggested to take a step back and test only with one plane.
> >
> >
> > The thumb rule is that we have a test case for all different
> > behaviours of the driver, and incidentally for different behaviours
> > of
> > the hardware because the kernel is supposed to handle the
> > differences. I suppose the pertinent question here is: Does the
> > driver
> > have different code paths for resolution changes for different
> > plane
> > usage?
>
> I would expect that using any subset of HDR planes (first three
> planes) + cursor to produce the same crc. The crc could be different
> if any SDR planes are used since we have to instruct the hw to go
> through the non-HDR blending path. If the test already fails with
> some HDR planes then feels like there is an actual problem somewhere.
Maybe we could run a test which takes reference for each and every
plane separately and check how crc's compare with that. It would be
quickly checked and verified.
>
_______________________________________________
igt-dev mailing list
igt-dev@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/igt-dev
^ permalink raw reply [flat|nested] 10+ messages in thread
end of thread, other threads:[~2020-01-22 8:55 UTC | newest]
Thread overview: 10+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2020-01-17 9:17 [igt-dev] [PATCH i-g-t] tests/kms_plane_lowres: Test only with one plane Mika Kahola
2020-01-17 10:00 ` [igt-dev] ✓ Fi.CI.BAT: success for " Patchwork
2020-01-17 12:13 ` [igt-dev] [PATCH i-g-t] " Petri Latvala
2020-01-17 12:44 ` Kahola, Mika
2020-01-17 13:15 ` Petri Latvala
2020-01-17 14:35 ` Kahola, Mika
2020-01-20 12:02 ` Petri Latvala
2020-01-20 17:19 ` Ville Syrjälä
2020-01-22 8:55 ` Kahola, Mika
2020-01-20 11:39 ` [igt-dev] ✓ Fi.CI.IGT: success for " Patchwork
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.