* [PATCH] media-ioc-enum-links.rst: fix incorrect reserved field documentation
@ 2019-05-27 9:11 Hans Verkuil
2019-05-28 8:47 ` Sakari Ailus
0 siblings, 1 reply; 2+ messages in thread
From: Hans Verkuil @ 2019-05-27 9:11 UTC (permalink / raw)
To: Linux Media Mailing List
The reserved field array for struct media_link_desc has length 2, not 4.
And the reserved field array of struct media_links_enum was never documented
at all.
Signed-off-by: Hans Verkuil <hverkuil-cisco@xs4all.nl>
---
diff --git a/Documentation/media/uapi/mediactl/media-ioc-enum-links.rst b/Documentation/media/uapi/mediactl/media-ioc-enum-links.rst
index a982f16e55a4..b827ebc398f8 100644
--- a/Documentation/media/uapi/mediactl/media-ioc-enum-links.rst
+++ b/Documentation/media/uapi/mediactl/media-ioc-enum-links.rst
@@ -84,6 +84,11 @@ returned during the enumeration process.
- Pointer to a links array allocated by the application. Ignored if
NULL.
+ * - __u32
+ - ``reserved[4]``
+ - Reserved for future extensions. Drivers and applications must set
+ the array to zero.
+
.. c:type:: media_pad_desc
@@ -135,7 +140,7 @@ returned during the enumeration process.
- Link flags, see :ref:`media-link-flag` for more details.
* - __u32
- - ``reserved[4]``
+ - ``reserved[2]``
- Reserved for future extensions. Drivers and applications must set
the array to zero.
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH] media-ioc-enum-links.rst: fix incorrect reserved field documentation
2019-05-27 9:11 [PATCH] media-ioc-enum-links.rst: fix incorrect reserved field documentation Hans Verkuil
@ 2019-05-28 8:47 ` Sakari Ailus
0 siblings, 0 replies; 2+ messages in thread
From: Sakari Ailus @ 2019-05-28 8:47 UTC (permalink / raw)
To: Hans Verkuil; +Cc: Linux Media Mailing List
On Mon, May 27, 2019 at 11:11:32AM +0200, Hans Verkuil wrote:
> The reserved field array for struct media_link_desc has length 2, not 4.
>
> And the reserved field array of struct media_links_enum was never documented
> at all.
>
> Signed-off-by: Hans Verkuil <hverkuil-cisco@xs4all.nl>
Acked-by: Sakari Ailus <sakari.ailus@linux.intel.com>
> ---
> diff --git a/Documentation/media/uapi/mediactl/media-ioc-enum-links.rst b/Documentation/media/uapi/mediactl/media-ioc-enum-links.rst
> index a982f16e55a4..b827ebc398f8 100644
> --- a/Documentation/media/uapi/mediactl/media-ioc-enum-links.rst
> +++ b/Documentation/media/uapi/mediactl/media-ioc-enum-links.rst
> @@ -84,6 +84,11 @@ returned during the enumeration process.
> - Pointer to a links array allocated by the application. Ignored if
> NULL.
>
> + * - __u32
> + - ``reserved[4]``
> + - Reserved for future extensions. Drivers and applications must set
> + the array to zero.
> +
>
> .. c:type:: media_pad_desc
>
> @@ -135,7 +140,7 @@ returned during the enumeration process.
> - Link flags, see :ref:`media-link-flag` for more details.
>
> * - __u32
> - - ``reserved[4]``
> + - ``reserved[2]``
> - Reserved for future extensions. Drivers and applications must set
> the array to zero.
>
--
Sakari Ailus
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2019-05-28 8:47 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2019-05-27 9:11 [PATCH] media-ioc-enum-links.rst: fix incorrect reserved field documentation Hans Verkuil
2019-05-28 8:47 ` Sakari Ailus
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.