* [PATCH -next] drm/amd/display: remove set but not used variable 'core_freesync'
@ 2019-10-06 10:57 ` YueHaibing
0 siblings, 0 replies; 6+ messages in thread
From: YueHaibing @ 2019-10-06 10:57 UTC (permalink / raw)
To: harry.wentland, sunpeng.li, alexander.deucher, christian.koenig,
David1.Zhou, airlied, daniel, Bhawanpreet.Lakha, Anthony.Koo,
aric.cyr, Harmanprit.Tatla, bayan.zabihiyan, ahmad.othman,
Reza.Amini
Cc: amd-gfx, dri-devel, linux-kernel, YueHaibing
Fixes gcc '-Wunused-but-set-variable' warning:
rivers/gpu/drm/amd/amdgpu/../display/modules/freesync/freesync.c:
In function mod_freesync_get_settings:
drivers/gpu/drm/amd/amdgpu/../display/modules/freesync/freesync.c:984:24:
warning: variable core_freesync set but not used [-Wunused-but-set-variable]
It is not used since commit 98e6436d3af5 ("drm/amd/display: Refactor FreeSync module")
Reported-by: Hulk Robot <hulkci@huawei.com>
Signed-off-by: YueHaibing <yuehaibing@huawei.com>
---
drivers/gpu/drm/amd/display/modules/freesync/freesync.c | 4 ----
1 file changed, 4 deletions(-)
diff --git a/drivers/gpu/drm/amd/display/modules/freesync/freesync.c b/drivers/gpu/drm/amd/display/modules/freesync/freesync.c
index 9ce56a8..237dda7 100644
--- a/drivers/gpu/drm/amd/display/modules/freesync/freesync.c
+++ b/drivers/gpu/drm/amd/display/modules/freesync/freesync.c
@@ -981,13 +981,9 @@ void mod_freesync_get_settings(struct mod_freesync *mod_freesync,
unsigned int *inserted_frames,
unsigned int *inserted_duration_in_us)
{
- struct core_freesync *core_freesync = NULL;
-
if (mod_freesync == NULL)
return;
- core_freesync = MOD_FREESYNC_TO_CORE(mod_freesync);
-
if (vrr->supported) {
*v_total_min = vrr->adjust.v_total_min;
*v_total_max = vrr->adjust.v_total_max;
--
2.7.4
^ permalink raw reply related [flat|nested] 6+ messages in thread* [PATCH -next] drm/amd/display: remove set but not used variable 'core_freesync' @ 2019-10-06 10:57 ` YueHaibing 0 siblings, 0 replies; 6+ messages in thread From: YueHaibing @ 2019-10-06 10:57 UTC (permalink / raw) To: harry.wentland, sunpeng.li, alexander.deucher, christian.koenig, David1.Zhou, airlied, daniel, Bhawanpreet.Lakha, Anthony.Koo, aric.cyr, Harmanprit.Tatla, bayan.zabihiyan, ahmad.othman, Reza.Amini Cc: amd-gfx, dri-devel, linux-kernel, YueHaibing Fixes gcc '-Wunused-but-set-variable' warning: rivers/gpu/drm/amd/amdgpu/../display/modules/freesync/freesync.c: In function mod_freesync_get_settings: drivers/gpu/drm/amd/amdgpu/../display/modules/freesync/freesync.c:984:24: warning: variable core_freesync set but not used [-Wunused-but-set-variable] It is not used since commit 98e6436d3af5 ("drm/amd/display: Refactor FreeSync module") Reported-by: Hulk Robot <hulkci@huawei.com> Signed-off-by: YueHaibing <yuehaibing@huawei.com> --- drivers/gpu/drm/amd/display/modules/freesync/freesync.c | 4 ---- 1 file changed, 4 deletions(-) diff --git a/drivers/gpu/drm/amd/display/modules/freesync/freesync.c b/drivers/gpu/drm/amd/display/modules/freesync/freesync.c index 9ce56a8..237dda7 100644 --- a/drivers/gpu/drm/amd/display/modules/freesync/freesync.c +++ b/drivers/gpu/drm/amd/display/modules/freesync/freesync.c @@ -981,13 +981,9 @@ void mod_freesync_get_settings(struct mod_freesync *mod_freesync, unsigned int *inserted_frames, unsigned int *inserted_duration_in_us) { - struct core_freesync *core_freesync = NULL; - if (mod_freesync == NULL) return; - core_freesync = MOD_FREESYNC_TO_CORE(mod_freesync); - if (vrr->supported) { *v_total_min = vrr->adjust.v_total_min; *v_total_max = vrr->adjust.v_total_max; -- 2.7.4 ^ permalink raw reply related [flat|nested] 6+ messages in thread
* Re: [PATCH -next] drm/amd/display: remove set but not used variable 'core_freesync' @ 2019-10-07 14:06 ` Harry Wentland 0 siblings, 0 replies; 6+ messages in thread From: Harry Wentland @ 2019-10-07 14:06 UTC (permalink / raw) To: YueHaibing, Wentland, Harry, Li, Sun peng (Leo), Deucher, Alexander, Koenig, Christian, Zhou, David(ChunMing), airlied, daniel, Lakha, Bhawanpreet, Koo, Anthony, Cyr, Aric, Harmanprit.Tatla, bayan.zabihiyan, Othman, Ahmad, Amini, Reza Cc: amd-gfx, dri-devel, linux-kernel On 2019-10-06 6:57 a.m., YueHaibing wrote: > Fixes gcc '-Wunused-but-set-variable' warning: > > rivers/gpu/drm/amd/amdgpu/../display/modules/freesync/freesync.c: > In function mod_freesync_get_settings: > drivers/gpu/drm/amd/amdgpu/../display/modules/freesync/freesync.c:984:24: > warning: variable core_freesync set but not used [-Wunused-but-set-variable] > > It is not used since commit 98e6436d3af5 ("drm/amd/display: Refactor FreeSync module") > > Reported-by: Hulk Robot <hulkci@huawei.com> > Signed-off-by: YueHaibing <yuehaibing@huawei.com> Reviewed-by: Harry Wentland <harry.wentland@amd.com> Harry > --- > drivers/gpu/drm/amd/display/modules/freesync/freesync.c | 4 ---- > 1 file changed, 4 deletions(-) > > diff --git a/drivers/gpu/drm/amd/display/modules/freesync/freesync.c b/drivers/gpu/drm/amd/display/modules/freesync/freesync.c > index 9ce56a8..237dda7 100644 > --- a/drivers/gpu/drm/amd/display/modules/freesync/freesync.c > +++ b/drivers/gpu/drm/amd/display/modules/freesync/freesync.c > @@ -981,13 +981,9 @@ void mod_freesync_get_settings(struct mod_freesync *mod_freesync, > unsigned int *inserted_frames, > unsigned int *inserted_duration_in_us) > { > - struct core_freesync *core_freesync = NULL; > - > if (mod_freesync == NULL) > return; > > - core_freesync = MOD_FREESYNC_TO_CORE(mod_freesync); > - > if (vrr->supported) { > *v_total_min = vrr->adjust.v_total_min; > *v_total_max = vrr->adjust.v_total_max; > ^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [PATCH -next] drm/amd/display: remove set but not used variable 'core_freesync' @ 2019-10-07 14:06 ` Harry Wentland 0 siblings, 0 replies; 6+ messages in thread From: Harry Wentland @ 2019-10-07 14:06 UTC (permalink / raw) To: YueHaibing, Wentland, Harry, Li, Sun peng (Leo), Deucher, Alexander, Koenig, Christian, Zhou, David(ChunMing), airlied-cv59FeDIM0c, daniel-/w4YWyX8dFk, Lakha, Bhawanpreet, Koo, Anthony, Cyr, Aric, Harmanprit.Tatla-5C7GfCeVMHo, bayan.zabihiyan-5C7GfCeVMHo, Othman, Ahmad, Amini, Reza Cc: dri-devel-PD4FTy7X32lNgt0PjOBp9y5qC8QIuHrW, amd-gfx-PD4FTy7X32lNgt0PjOBp9y5qC8QIuHrW, linux-kernel-u79uwXL29TY76Z2rM5mHXA On 2019-10-06 6:57 a.m., YueHaibing wrote: > Fixes gcc '-Wunused-but-set-variable' warning: > > rivers/gpu/drm/amd/amdgpu/../display/modules/freesync/freesync.c: > In function mod_freesync_get_settings: > drivers/gpu/drm/amd/amdgpu/../display/modules/freesync/freesync.c:984:24: > warning: variable core_freesync set but not used [-Wunused-but-set-variable] > > It is not used since commit 98e6436d3af5 ("drm/amd/display: Refactor FreeSync module") > > Reported-by: Hulk Robot <hulkci@huawei.com> > Signed-off-by: YueHaibing <yuehaibing@huawei.com> Reviewed-by: Harry Wentland <harry.wentland@amd.com> Harry > --- > drivers/gpu/drm/amd/display/modules/freesync/freesync.c | 4 ---- > 1 file changed, 4 deletions(-) > > diff --git a/drivers/gpu/drm/amd/display/modules/freesync/freesync.c b/drivers/gpu/drm/amd/display/modules/freesync/freesync.c > index 9ce56a8..237dda7 100644 > --- a/drivers/gpu/drm/amd/display/modules/freesync/freesync.c > +++ b/drivers/gpu/drm/amd/display/modules/freesync/freesync.c > @@ -981,13 +981,9 @@ void mod_freesync_get_settings(struct mod_freesync *mod_freesync, > unsigned int *inserted_frames, > unsigned int *inserted_duration_in_us) > { > - struct core_freesync *core_freesync = NULL; > - > if (mod_freesync == NULL) > return; > > - core_freesync = MOD_FREESYNC_TO_CORE(mod_freesync); > - > if (vrr->supported) { > *v_total_min = vrr->adjust.v_total_min; > *v_total_max = vrr->adjust.v_total_max; > _______________________________________________ amd-gfx mailing list amd-gfx@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/amd-gfx ^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [PATCH -next] drm/amd/display: remove set but not used variable 'core_freesync' @ 2019-10-07 15:57 ` Alex Deucher 0 siblings, 0 replies; 6+ messages in thread From: Alex Deucher @ 2019-10-07 15:57 UTC (permalink / raw) To: Harry Wentland Cc: YueHaibing, Wentland, Harry, Li, Sun peng (Leo), Deucher, Alexander, Koenig, Christian, Zhou, David(ChunMing), airlied, daniel, Lakha, Bhawanpreet, Koo, Anthony, Cyr, Aric, Harmanprit.Tatla, bayan.zabihiyan, Othman, Ahmad, Amini, Reza, dri-devel, amd-gfx, linux-kernel On Mon, Oct 7, 2019 at 10:06 AM Harry Wentland <hwentlan@amd.com> wrote: > > On 2019-10-06 6:57 a.m., YueHaibing wrote: > > Fixes gcc '-Wunused-but-set-variable' warning: > > > > rivers/gpu/drm/amd/amdgpu/../display/modules/freesync/freesync.c: > > In function mod_freesync_get_settings: > > drivers/gpu/drm/amd/amdgpu/../display/modules/freesync/freesync.c:984:24: > > warning: variable core_freesync set but not used [-Wunused-but-set-variable] > > > > It is not used since commit 98e6436d3af5 ("drm/amd/display: Refactor FreeSync module") > > > > Reported-by: Hulk Robot <hulkci@huawei.com> > > Signed-off-by: YueHaibing <yuehaibing@huawei.com> > > Reviewed-by: Harry Wentland <harry.wentland@amd.com> > Applied. Thanks! Alex > Harry > > > --- > > drivers/gpu/drm/amd/display/modules/freesync/freesync.c | 4 ---- > > 1 file changed, 4 deletions(-) > > > > diff --git a/drivers/gpu/drm/amd/display/modules/freesync/freesync.c b/drivers/gpu/drm/amd/display/modules/freesync/freesync.c > > index 9ce56a8..237dda7 100644 > > --- a/drivers/gpu/drm/amd/display/modules/freesync/freesync.c > > +++ b/drivers/gpu/drm/amd/display/modules/freesync/freesync.c > > @@ -981,13 +981,9 @@ void mod_freesync_get_settings(struct mod_freesync *mod_freesync, > > unsigned int *inserted_frames, > > unsigned int *inserted_duration_in_us) > > { > > - struct core_freesync *core_freesync = NULL; > > - > > if (mod_freesync == NULL) > > return; > > > > - core_freesync = MOD_FREESYNC_TO_CORE(mod_freesync); > > - > > if (vrr->supported) { > > *v_total_min = vrr->adjust.v_total_min; > > *v_total_max = vrr->adjust.v_total_max; > > > _______________________________________________ > amd-gfx mailing list > amd-gfx@lists.freedesktop.org > https://lists.freedesktop.org/mailman/listinfo/amd-gfx ^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [PATCH -next] drm/amd/display: remove set but not used variable 'core_freesync' @ 2019-10-07 15:57 ` Alex Deucher 0 siblings, 0 replies; 6+ messages in thread From: Alex Deucher @ 2019-10-07 15:57 UTC (permalink / raw) To: Harry Wentland Cc: Zhou, David(ChunMing), Cyr, Aric, Harmanprit.Tatla-5C7GfCeVMHo, Li, Sun peng (Leo), Lakha, Bhawanpreet, YueHaibing, Othman, Ahmad, dri-devel-PD4FTy7X32lNgt0PjOBp9y5qC8QIuHrW, linux-kernel-u79uwXL29TY76Z2rM5mHXA, airlied-cv59FeDIM0c, Amini, Reza, amd-gfx-PD4FTy7X32lNgt0PjOBp9y5qC8QIuHrW, daniel-/w4YWyX8dFk, bayan.zabihiyan-5C7GfCeVMHo, Deucher, Alexander, Wentland, Harry, Koenig, Christian, Koo, Anthony On Mon, Oct 7, 2019 at 10:06 AM Harry Wentland <hwentlan@amd.com> wrote: > > On 2019-10-06 6:57 a.m., YueHaibing wrote: > > Fixes gcc '-Wunused-but-set-variable' warning: > > > > rivers/gpu/drm/amd/amdgpu/../display/modules/freesync/freesync.c: > > In function mod_freesync_get_settings: > > drivers/gpu/drm/amd/amdgpu/../display/modules/freesync/freesync.c:984:24: > > warning: variable core_freesync set but not used [-Wunused-but-set-variable] > > > > It is not used since commit 98e6436d3af5 ("drm/amd/display: Refactor FreeSync module") > > > > Reported-by: Hulk Robot <hulkci@huawei.com> > > Signed-off-by: YueHaibing <yuehaibing@huawei.com> > > Reviewed-by: Harry Wentland <harry.wentland@amd.com> > Applied. Thanks! Alex > Harry > > > --- > > drivers/gpu/drm/amd/display/modules/freesync/freesync.c | 4 ---- > > 1 file changed, 4 deletions(-) > > > > diff --git a/drivers/gpu/drm/amd/display/modules/freesync/freesync.c b/drivers/gpu/drm/amd/display/modules/freesync/freesync.c > > index 9ce56a8..237dda7 100644 > > --- a/drivers/gpu/drm/amd/display/modules/freesync/freesync.c > > +++ b/drivers/gpu/drm/amd/display/modules/freesync/freesync.c > > @@ -981,13 +981,9 @@ void mod_freesync_get_settings(struct mod_freesync *mod_freesync, > > unsigned int *inserted_frames, > > unsigned int *inserted_duration_in_us) > > { > > - struct core_freesync *core_freesync = NULL; > > - > > if (mod_freesync == NULL) > > return; > > > > - core_freesync = MOD_FREESYNC_TO_CORE(mod_freesync); > > - > > if (vrr->supported) { > > *v_total_min = vrr->adjust.v_total_min; > > *v_total_max = vrr->adjust.v_total_max; > > > _______________________________________________ > amd-gfx mailing list > amd-gfx@lists.freedesktop.org > https://lists.freedesktop.org/mailman/listinfo/amd-gfx _______________________________________________ amd-gfx mailing list amd-gfx@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/amd-gfx ^ permalink raw reply [flat|nested] 6+ messages in thread
end of thread, other threads:[~2019-10-07 15:57 UTC | newest] Thread overview: 6+ messages (download: mbox.gz / follow: Atom feed) -- links below jump to the message on this page -- 2019-10-06 10:57 [PATCH -next] drm/amd/display: remove set but not used variable 'core_freesync' YueHaibing 2019-10-06 10:57 ` YueHaibing 2019-10-07 14:06 ` Harry Wentland 2019-10-07 14:06 ` Harry Wentland 2019-10-07 15:57 ` Alex Deucher 2019-10-07 15:57 ` Alex Deucher
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.