From: Grant Coady <grant_lkml@dodo.com.au> To: Yani Ioannou <yani.ioannou@gmail.com> Cc: Greg KH <greg@kroah.com>, LKML <linux-kernel@vger.kernel.org>, LM Sensors <lm-sensors@lm-sensors.org> Subject: Re: [lm-sensors] [PATCH 2.6.12-rc4 15/15] drivers/i2c/chips/adm1026.c: use dynamic sysfs callbacks Date: Wed, 18 May 2005 11:58:01 +1000 [thread overview] Message-ID: <db7l81l06afri8aficf4oopmvu632f7cv3@4ax.com> (raw) In-Reply-To: <25381867050517162126d18704@mail.gmail.com> Hi Yani, On Tue, 17 May 2005 19:21:41 -0400, Yani Ioannou <yani.ioannou@gmail.com> wrote: >Ah..OK, that is probably why, I've put the macros which would be >expanded in the first level in a separate header because it will >probably be shared amongst many drivers. Although I still don't see >where SENSOR_blah is coming from at all at the moment, if you can >track that down I'd be interested to know if its just something to do >with the script or a problem with the patch. Oops, my script, sorry. I'll fix that. >> Not singletons, 3 of each (from an intermediate file): . . . > >Well I said mainly singletons :-), some of the attributes don't >benefit from the dynamic sysfs callbacks simply because they already >only use one callback for a few different attributes, I believe that's >the case with the non-singletons in this case. Not quite that, one sysfs name, one value. The multiple sysfs names that were 'missed' by your changes don't use the usual macro. Three instances of each attribute in the source, instead. --Grant.
WARNING: multiple messages have this Message-ID (diff)
From: grant_lkml@dodo.com.au (Grant Coady) To: Yani Ioannou <yani.ioannou@gmail.com> Cc: Greg KH <greg@kroah.com>, LKML <linux-kernel@vger.kernel.org>, LM Sensors <lm-sensors@lm-sensors.org> Subject: [lm-sensors] [PATCH 2.6.12-rc4 15/15] Date: Thu, 19 May 2005 06:25:59 +0000 [thread overview] Message-ID: <db7l81l06afri8aficf4oopmvu632f7cv3@4ax.com> (raw) In-Reply-To: <25381867050517162126d18704@mail.gmail.com> Hi Yani, On Tue, 17 May 2005 19:21:41 -0400, Yani Ioannou <yani.ioannou@gmail.com> wrote: >Ah..OK, that is probably why, I've put the macros which would be >expanded in the first level in a separate header because it will >probably be shared amongst many drivers. Although I still don't see >where SENSOR_blah is coming from at all at the moment, if you can >track that down I'd be interested to know if its just something to do >with the script or a problem with the patch. Oops, my script, sorry. I'll fix that. >> Not singletons, 3 of each (from an intermediate file): . . . > >Well I said mainly singletons :-), some of the attributes don't >benefit from the dynamic sysfs callbacks simply because they already >only use one callback for a few different attributes, I believe that's >the case with the non-singletons in this case. Not quite that, one sysfs name, one value. The multiple sysfs names that were 'missed' by your changes don't use the usual macro. Three instances of each attribute in the source, instead. --Grant. _______________________________________________ lm-sensors mailing list lm-sensors@lm-sensors.org http://lists.lm-sensors.org/mailman/listinfo/lm-sensors
next prev parent reply other threads:[~2005-05-18 1:58 UTC|newest] Thread overview: 50+ messages / expand[flat|nested] mbox.gz Atom feed top 2005-05-17 10:47 [PATCH 2.6.12-rc4 15/15] drivers/i2c/chips/adm1026.c: use dynamic sysfs callbacks Yani Ioannou 2005-05-19 6:25 ` [lm-sensors] [PATCH 2.6.12-rc4 15/15] drivers/i2c/chips/adm1026.c: Yani Ioannou 2005-05-17 11:04 ` [lm-sensors] [PATCH 2.6.12-rc4 15/15] drivers/i2c/chips/adm1026.c: use dynamic sysfs callbacks Jean Delvare 2005-05-19 6:25 ` [lm-sensors] [PATCH 2.6.12-rc4 15/15] Jean Delvare 2005-05-17 11:18 ` [lm-sensors] [PATCH 2.6.12-rc4 15/15] drivers/i2c/chips/adm1026.c: use dynamic sysfs callbacks Yani Ioannou 2005-05-19 6:25 ` [lm-sensors] [PATCH 2.6.12-rc4 15/15] Yani Ioannou 2005-05-17 20:23 ` [lm-sensors] [PATCH 2.6.12-rc4 15/15] drivers/i2c/chips/adm1026.c: use dynamic sysfs callbacks Grant Coady 2005-05-19 6:25 ` [lm-sensors] [PATCH 2.6.12-rc4 15/15] Grant Coady 2005-05-17 20:56 ` [lm-sensors] [PATCH 2.6.12-rc4 15/15] drivers/i2c/chips/adm1026.c: use dynamic sysfs callbacks Yani Ioannou 2005-05-19 6:25 ` [lm-sensors] [PATCH 2.6.12-rc4 15/15] Yani Ioannou 2005-05-17 23:13 ` [lm-sensors] [PATCH 2.6.12-rc4 15/15] drivers/i2c/chips/adm1026.c: use dynamic sysfs callbacks Grant Coady 2005-05-19 6:25 ` [lm-sensors] [PATCH 2.6.12-rc4 15/15] Grant Coady 2005-05-17 23:21 ` [lm-sensors] [PATCH 2.6.12-rc4 15/15] drivers/i2c/chips/adm1026.c: use dynamic sysfs callbacks Yani Ioannou 2005-05-19 6:25 ` [lm-sensors] [PATCH 2.6.12-rc4 15/15] Yani Ioannou 2005-05-18 1:58 ` Grant Coady [this message] 2005-05-19 6:25 ` Grant Coady 2005-05-19 6:25 ` Yani Ioannou 2005-05-19 20:02 ` [lm-sensors] [PATCH 2.6.12-rc4 15/15] drivers/i2c/chips/adm1026.c: use dynamic sysfs callbacks Jean Delvare 2005-05-19 22:03 ` [lm-sensors] [PATCH 2.6.12-rc4 15/15] Jean Delvare 2005-05-19 20:52 ` [lm-sensors] [PATCH 2.6.12-rc4 15/15] drivers/i2c/chips/adm1026.c: use dynamic sysfs callbacks Greg KH 2005-05-19 22:47 ` [lm-sensors] [PATCH 2.6.12-rc4 15/15] Greg KH 2005-05-19 20:57 ` [lm-sensors] [PATCH 2.6.12-rc4 15/15] drivers/i2c/chips/adm1026.c: use dynamic sysfs callbacks Jean Delvare 2005-05-19 22:57 ` [lm-sensors] [PATCH 2.6.12-rc4 15/15] Jean Delvare 2005-05-19 21:35 ` [lm-sensors] [PATCH 2.6.12-rc4 15/15] drivers/i2c/chips/adm1026.c: use dynamic sysfs callbacks Greg KH 2005-05-19 23:30 ` [lm-sensors] [PATCH 2.6.12-rc4 15/15] Greg KH 2005-05-20 7:46 ` [lm-sensors] [PATCH 2.6.12-rc4 15/15] drivers/i2c/chips/adm1026.c: use dynamic sysfs callbacks Jean Delvare 2005-05-20 9:54 ` [lm-sensors] [PATCH 2.6.12-rc4 15/15] Jean Delvare 2005-05-20 8:53 ` [lm-sensors] [PATCH 2.6.12-rc4 15/15] drivers/i2c/chips/adm1026.c: use dynamic sysfs callbacks Yani Ioannou 2005-05-20 10:53 ` [lm-sensors] [PATCH 2.6.12-rc4 15/15] Yani Ioannou 2005-05-22 1:58 ` [lm-sensors] [PATCH 2.6.12-rc4 15/15] drivers/i2c/chips/adm1026.c: use dynamic sysfs callbacks Dmitry Torokhov 2005-05-22 3:59 ` [lm-sensors] [PATCH 2.6.12-rc4 15/15] Dmitry Torokhov 2005-05-22 6:50 ` [lm-sensors] [PATCH 2.6.12-rc4 15/15] drivers/i2c/chips/adm1026.c: use dynamic sysfs callbacks Jean Delvare 2005-05-22 8:51 ` [lm-sensors] [PATCH 2.6.12-rc4 15/15] Jean Delvare 2005-05-22 7:04 ` [lm-sensors] [PATCH 2.6.12-rc4 15/15] drivers/i2c/chips/adm1026.c: use dynamic sysfs callbacks Dmitry Torokhov 2005-05-22 9:05 ` [lm-sensors] [PATCH 2.6.12-rc4 15/15] Dmitry Torokhov 2005-05-22 12:15 ` [lm-sensors] [PATCH 2.6.12-rc4 15/15] drivers/i2c/chips/adm1026.c: use dynamic sysfs callbacks Yani Ioannou 2005-05-22 14:17 ` [lm-sensors] [PATCH 2.6.12-rc4 15/15] Yani Ioannou 2005-05-22 12:32 ` [lm-sensors] [PATCH 2.6.12-rc4 15/15] drivers/i2c/chips/adm1026.c: use dynamic sysfs callbacks Jean Delvare 2005-05-22 14:33 ` [lm-sensors] [PATCH 2.6.12-rc4 15/15] Jean Delvare 2005-05-22 13:05 ` [lm-sensors] [PATCH 2.6.12-rc4 15/15] drivers/i2c/chips/adm1026.c: use dynamic sysfs callbacks Yani Ioannou 2005-05-22 15:05 ` [lm-sensors] [PATCH 2.6.12-rc4 15/15] Yani Ioannou 2005-05-22 13:39 ` [lm-sensors] [PATCH 2.6.12-rc4 15/15] drivers/i2c/chips/adm1026.c: use dynamic sysfs callbacks Jean Delvare 2005-05-22 15:39 ` [lm-sensors] [PATCH 2.6.12-rc4 15/15] Jean Delvare 2005-05-19 21:14 ` [lm-sensors] [PATCH 2.6.12-rc4 15/15] drivers/i2c/chips/adm1026.c: use dynamic sysfs callbacks Yani Ioannou 2005-05-19 23:15 ` [lm-sensors] [PATCH 2.6.12-rc4 15/15] Yani Ioannou 2005-05-20 8:01 ` Grant Coady 2005-06-05 8:51 ` [lm-sensors] [PATCH 2.6.12-rc4 15/15] drivers/i2c/chips/adm1026.c: use dynamic sysfs callbacks Jean Delvare 2005-06-05 10:51 ` [lm-sensors] [PATCH 2.6.12-rc4 15/15] Jean Delvare 2005-06-06 6:14 ` [lm-sensors] [PATCH 2.6.12-rc4 15/15] drivers/i2c/chips/adm1026.c: use dynamic sysfs callbacks Greg KH 2005-06-06 9:17 ` [lm-sensors] [PATCH 2.6.12-rc4 15/15] Greg KH
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=db7l81l06afri8aficf4oopmvu632f7cv3@4ax.com \ --to=grant_lkml@dodo.com.au \ --cc=greg@kroah.com \ --cc=linux-kernel@vger.kernel.org \ --cc=lm-sensors@lm-sensors.org \ --cc=yani.ioannou@gmail.com \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: linkBe sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.