All of lore.kernel.org
 help / color / mirror / Atom feed
From: Peter Oh <peter.oh@eero.com>
To: Karthikeyan periyasamy <periyasa@codeaurora.org>
Cc: ath11k@lists.infradead.org, linux-wireless@vger.kernel.org
Subject: Re: [PATCH] ath11k: Update tx descriptor search index properly
Date: Wed, 3 Feb 2021 19:08:49 -0800	[thread overview]
Message-ID: <dc8f531f-2ab5-f690-2b94-917880682fcc@eero.com> (raw)
In-Reply-To: <ea757176a6438f1b0cf9bee41f8a9f8c@codeaurora.org>


On 2/3/21 5:08 PM, Karthikeyan periyasamy wrote:
> On 2021-02-04 00:59, Peter Oh wrote:
>> On 1/26/21 6:46 PM, Karthikeyan periyasamy wrote:
>>> On 2020-12-19 00:53, Peter Oh wrote:
>>>> On 12/18/20 7:24 AM, Karthikeyan Periyasamy wrote:
>>>>> Tx descriptor search index field should be updated with hw peer id
>>>>> and not by AST Hash. Incorrect search index causes throughput 
>>>>> degradation
>>>>> in all the platforms. so updated the search index field with hw 
>>>>> peer id,
>>>>> which is a common change applicable for all the platforms.
>>>>>
>>>>> Tested-on: IPQ8074 hw2.0 AHB 
>>>>> WLAN.HK.2.4.0.1-01492-QCAHKSWPL_SILICONZ-1
>>>>>
>>>>> diff --git a/drivers/net/wireless/ath/ath11k/peer.c 
>>>>> b/drivers/net/wireless/ath/ath11k/peer.c
>>>>> index b69e7eb..f49abefa 100644
>>>>> --- a/drivers/net/wireless/ath/ath11k/peer.c
>>>>> +++ b/drivers/net/wireless/ath/ath11k/peer.c
>>>>>
>>>>> @@ -309,7 +310,11 @@ int ath11k_peer_create(struct ath11k *ar, 
>>>>> struct ath11k_vif *arvif,
>>>>>         peer->pdev_idx = ar->pdev_idx;
>>>>>       peer->sta = sta;
>>>>> -    arvif->ast_hash = peer->ast_hash;
>>>>> +
>>>>> +    if (arvif->vif->type == NL80211_IFTYPE_STATION) {
>>>>> +        arvif->ast_hash = peer->ast_hash;
>>>>> +        arvif->ast_idx = peer->hw_peer_id;
>>>>> +    }
>>>>
>>>> How about non STATION type?
>>>>
>>>
>>> no need of configuring the ast_idx, ast_hash field for non station 
>>> type. Its recommended by HW/FW team.
>>>
>> Can you add this comment in commit message?
>>
>
> sure
>
>> Also could you include the answer to "what conditions you observed the
>> throughput degradation?" in commit message too?
>
> In all the scenario will see degradation. Its a general improvement.
>
It sounds good and it will better if you share the number before and 
after the patch.


Thanks,

Peter


WARNING: multiple messages have this Message-ID (diff)
From: Peter Oh <peter.oh@eero.com>
To: Karthikeyan periyasamy <periyasa@codeaurora.org>
Cc: linux-wireless@vger.kernel.org, ath11k@lists.infradead.org
Subject: Re: [PATCH] ath11k: Update tx descriptor search index properly
Date: Wed, 3 Feb 2021 19:08:49 -0800	[thread overview]
Message-ID: <dc8f531f-2ab5-f690-2b94-917880682fcc@eero.com> (raw)
In-Reply-To: <ea757176a6438f1b0cf9bee41f8a9f8c@codeaurora.org>


On 2/3/21 5:08 PM, Karthikeyan periyasamy wrote:
> On 2021-02-04 00:59, Peter Oh wrote:
>> On 1/26/21 6:46 PM, Karthikeyan periyasamy wrote:
>>> On 2020-12-19 00:53, Peter Oh wrote:
>>>> On 12/18/20 7:24 AM, Karthikeyan Periyasamy wrote:
>>>>> Tx descriptor search index field should be updated with hw peer id
>>>>> and not by AST Hash. Incorrect search index causes throughput 
>>>>> degradation
>>>>> in all the platforms. so updated the search index field with hw 
>>>>> peer id,
>>>>> which is a common change applicable for all the platforms.
>>>>>
>>>>> Tested-on: IPQ8074 hw2.0 AHB 
>>>>> WLAN.HK.2.4.0.1-01492-QCAHKSWPL_SILICONZ-1
>>>>>
>>>>> diff --git a/drivers/net/wireless/ath/ath11k/peer.c 
>>>>> b/drivers/net/wireless/ath/ath11k/peer.c
>>>>> index b69e7eb..f49abefa 100644
>>>>> --- a/drivers/net/wireless/ath/ath11k/peer.c
>>>>> +++ b/drivers/net/wireless/ath/ath11k/peer.c
>>>>>
>>>>> @@ -309,7 +310,11 @@ int ath11k_peer_create(struct ath11k *ar, 
>>>>> struct ath11k_vif *arvif,
>>>>>         peer->pdev_idx = ar->pdev_idx;
>>>>>       peer->sta = sta;
>>>>> -    arvif->ast_hash = peer->ast_hash;
>>>>> +
>>>>> +    if (arvif->vif->type == NL80211_IFTYPE_STATION) {
>>>>> +        arvif->ast_hash = peer->ast_hash;
>>>>> +        arvif->ast_idx = peer->hw_peer_id;
>>>>> +    }
>>>>
>>>> How about non STATION type?
>>>>
>>>
>>> no need of configuring the ast_idx, ast_hash field for non station 
>>> type. Its recommended by HW/FW team.
>>>
>> Can you add this comment in commit message?
>>
>
> sure
>
>> Also could you include the answer to "what conditions you observed the
>> throughput degradation?" in commit message too?
>
> In all the scenario will see degradation. Its a general improvement.
>
It sounds good and it will better if you share the number before and 
after the patch.


Thanks,

Peter


-- 
ath11k mailing list
ath11k@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/ath11k

  reply	other threads:[~2021-02-04  3:09 UTC|newest]

Thread overview: 22+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-12-18 15:24 [PATCH] ath11k: Update tx descriptor search index properly Karthikeyan Periyasamy
2020-12-18 15:24 ` Karthikeyan Periyasamy
2020-12-18 19:23 ` Peter Oh
2020-12-18 19:23   ` Peter Oh
2021-01-27  2:46   ` Karthikeyan periyasamy
2021-01-27  2:46     ` Karthikeyan periyasamy
2021-02-03 19:29     ` Peter Oh
2021-02-03 19:29       ` Peter Oh
2021-02-04  1:08       ` Karthikeyan periyasamy
2021-02-04  1:08         ` Karthikeyan periyasamy
2021-02-04  3:08         ` Peter Oh [this message]
2021-02-04  3:08           ` Peter Oh
2021-02-04  3:17           ` Karthikeyan periyasamy
2021-02-04  3:17             ` Karthikeyan periyasamy
2021-02-04  3:37             ` Peter Oh
2021-02-04  3:37               ` Peter Oh
2021-02-04  3:40               ` Karthikeyan periyasamy
2021-02-04  3:40                 ` Karthikeyan periyasamy
2020-12-18 19:41 ` Peter Oh
2020-12-18 19:41   ` Peter Oh
2021-01-26 15:59 ` Kalle Valo
2021-01-26 15:59 ` Kalle Valo

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=dc8f531f-2ab5-f690-2b94-917880682fcc@eero.com \
    --to=peter.oh@eero.com \
    --cc=ath11k@lists.infradead.org \
    --cc=linux-wireless@vger.kernel.org \
    --cc=periyasa@codeaurora.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.