* [PATCH] openssl_1.0: drop unnecessary dependency on makedepend-native @ 2018-07-31 1:28 Andre McCurdy 2018-07-31 10:08 ` Richard Purdie 0 siblings, 1 reply; 7+ messages in thread From: Andre McCurdy @ 2018-07-31 1:28 UTC (permalink / raw) To: openembedded-core The openssl Configure script will only select standalone makedepend (vs running "$CC -M") when building with gcc < 3.x or with an Apple Xcode version which predates the switch to clang (in approx 2010?). Neither of these cases are possible when building under OE, therefore the dependency on makedepend-native can be dropped (ie align the openssl 1.0 recipe with the 1.1 recipe, which has dropped the makedepend-native dependency already). Signed-off-by: Andre McCurdy <armccurdy@gmail.com> --- meta/recipes-connectivity/openssl/openssl_1.0.2o.bb | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/meta/recipes-connectivity/openssl/openssl_1.0.2o.bb b/meta/recipes-connectivity/openssl/openssl_1.0.2o.bb index f5d3274..78c8552 100644 --- a/meta/recipes-connectivity/openssl/openssl_1.0.2o.bb +++ b/meta/recipes-connectivity/openssl/openssl_1.0.2o.bb @@ -8,7 +8,7 @@ SECTION = "libs/network" LICENSE = "openssl" LIC_FILES_CHKSUM = "file://LICENSE;md5=f475368924827d06d4b416111c8bdb77" -DEPENDS = "makedepend-native hostperl-runtime-native" +DEPENDS = "hostperl-runtime-native" DEPENDS_append_class-target = " openssl-native" PROVIDES += "openssl10" -- 1.9.1 ^ permalink raw reply related [flat|nested] 7+ messages in thread
* Re: [PATCH] openssl_1.0: drop unnecessary dependency on makedepend-native 2018-07-31 1:28 [PATCH] openssl_1.0: drop unnecessary dependency on makedepend-native Andre McCurdy @ 2018-07-31 10:08 ` Richard Purdie 2018-07-31 10:24 ` Andrej Valek 0 siblings, 1 reply; 7+ messages in thread From: Richard Purdie @ 2018-07-31 10:08 UTC (permalink / raw) To: Andre McCurdy, openembedded-core On Mon, 2018-07-30 at 18:28 -0700, Andre McCurdy wrote: > The openssl Configure script will only select standalone makedepend > (vs running "$CC -M") when building with gcc < 3.x or with an Apple > Xcode version which predates the switch to clang (in approx 2010?). > Neither of these cases are possible when building under OE, therefore > the dependency on makedepend-native can be dropped (ie align the > openssl 1.0 recipe with the 1.1 recipe, which has dropped the > makedepend-native dependency already). > > Signed-off-by: Andre McCurdy <armccurdy@gmail.com> > --- > meta/recipes-connectivity/openssl/openssl_1.0.2o.bb | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/meta/recipes-connectivity/openssl/openssl_1.0.2o.bb > b/meta/recipes-connectivity/openssl/openssl_1.0.2o.bb > index f5d3274..78c8552 100644 > --- a/meta/recipes-connectivity/openssl/openssl_1.0.2o.bb > +++ b/meta/recipes-connectivity/openssl/openssl_1.0.2o.bb > @@ -8,7 +8,7 @@ SECTION = "libs/network" > LICENSE = "openssl" > LIC_FILES_CHKSUM = > "file://LICENSE;md5=f475368924827d06d4b416111c8bdb77" > > -DEPENDS = "makedepend-native hostperl-runtime-native" > +DEPENDS = "hostperl-runtime-native" > DEPENDS_append_class-target = " openssl-native" > > PROVIDES += "openssl10" This was added quite 'recently' in: http://git.yoctoproject.org/cgit.cgi/poky/commit/?id=50c23e6c26a64b0c04e99abacb61ec00d1abace9 I've cc'd Andrej in case he can tell us why that was needed? Cheers, Richard ^ permalink raw reply [flat|nested] 7+ messages in thread
* Re: [PATCH] openssl_1.0: drop unnecessary dependency on makedepend-native 2018-07-31 10:08 ` Richard Purdie @ 2018-07-31 10:24 ` Andrej Valek 2018-07-31 13:34 ` Andre McCurdy 0 siblings, 1 reply; 7+ messages in thread From: Andrej Valek @ 2018-07-31 10:24 UTC (permalink / raw) To: Richard Purdie; +Cc: openembedded-core This program is required for "oe_runmake depend" command. It runs command in MAKEDEPPROG variable, which is set to makedepend. Makedepend consists from makedepend-native package. Cheers, Andrej On 07/31/18 12:08, Richard Purdie wrote: > On Mon, 2018-07-30 at 18:28 -0700, Andre McCurdy wrote: >> The openssl Configure script will only select standalone makedepend >> (vs running "$CC -M") when building with gcc < 3.x or with an Apple >> Xcode version which predates the switch to clang (in approx 2010?). >> Neither of these cases are possible when building under OE, therefore >> the dependency on makedepend-native can be dropped (ie align the >> openssl 1.0 recipe with the 1.1 recipe, which has dropped the >> makedepend-native dependency already). >> >> Signed-off-by: Andre McCurdy <armccurdy@gmail.com> >> --- >> meta/recipes-connectivity/openssl/openssl_1.0.2o.bb | 2 +- >> 1 file changed, 1 insertion(+), 1 deletion(-) >> >> diff --git a/meta/recipes-connectivity/openssl/openssl_1.0.2o.bb >> b/meta/recipes-connectivity/openssl/openssl_1.0.2o.bb >> index f5d3274..78c8552 100644 >> --- a/meta/recipes-connectivity/openssl/openssl_1.0.2o.bb >> +++ b/meta/recipes-connectivity/openssl/openssl_1.0.2o.bb >> @@ -8,7 +8,7 @@ SECTION = "libs/network" >> LICENSE = "openssl" >> LIC_FILES_CHKSUM = >> "file://LICENSE;md5=f475368924827d06d4b416111c8bdb77" >> >> -DEPENDS = "makedepend-native hostperl-runtime-native" >> +DEPENDS = "hostperl-runtime-native" >> DEPENDS_append_class-target = " openssl-native" >> >> PROVIDES += "openssl10" > > This was added quite 'recently' in: > > http://git.yoctoproject.org/cgit.cgi/poky/commit/?id=50c23e6c26a64b0c04e99abacb61ec00d1abace9 > > I've cc'd Andrej in case he can tell us why that was needed? > > Cheers, > > Richard > ^ permalink raw reply [flat|nested] 7+ messages in thread
* Re: [PATCH] openssl_1.0: drop unnecessary dependency on makedepend-native 2018-07-31 10:24 ` Andrej Valek @ 2018-07-31 13:34 ` Andre McCurdy 2018-08-01 7:44 ` Andrej Valek 0 siblings, 1 reply; 7+ messages in thread From: Andre McCurdy @ 2018-07-31 13:34 UTC (permalink / raw) To: Andrej Valek; +Cc: openembedded-core On Tue, Jul 31, 2018 at 3:24 AM, Andrej Valek <andrej.valek@siemens.com> wrote: > This program is required for "oe_runmake depend" command. It runs > command in MAKEDEPPROG variable, which is set to makedepend. Makedepend > consists from makedepend-native package. That's what you might guess from casually reading the Makefile. It's not what actually happens. > Cheers, > Andrej > > On 07/31/18 12:08, Richard Purdie wrote: >> On Mon, 2018-07-30 at 18:28 -0700, Andre McCurdy wrote: >>> The openssl Configure script will only select standalone makedepend >>> (vs running "$CC -M") when building with gcc < 3.x or with an Apple >>> Xcode version which predates the switch to clang (in approx 2010?). >>> Neither of these cases are possible when building under OE, therefore >>> the dependency on makedepend-native can be dropped (ie align the >>> openssl 1.0 recipe with the 1.1 recipe, which has dropped the >>> makedepend-native dependency already). >>> >>> Signed-off-by: Andre McCurdy <armccurdy@gmail.com> >>> --- >>> meta/recipes-connectivity/openssl/openssl_1.0.2o.bb | 2 +- >>> 1 file changed, 1 insertion(+), 1 deletion(-) >>> >>> diff --git a/meta/recipes-connectivity/openssl/openssl_1.0.2o.bb >>> b/meta/recipes-connectivity/openssl/openssl_1.0.2o.bb >>> index f5d3274..78c8552 100644 >>> --- a/meta/recipes-connectivity/openssl/openssl_1.0.2o.bb >>> +++ b/meta/recipes-connectivity/openssl/openssl_1.0.2o.bb >>> @@ -8,7 +8,7 @@ SECTION = "libs/network" >>> LICENSE = "openssl" >>> LIC_FILES_CHKSUM = >>> "file://LICENSE;md5=f475368924827d06d4b416111c8bdb77" >>> >>> -DEPENDS = "makedepend-native hostperl-runtime-native" >>> +DEPENDS = "hostperl-runtime-native" >>> DEPENDS_append_class-target = " openssl-native" >>> >>> PROVIDES += "openssl10" >> >> This was added quite 'recently' in: >> >> http://git.yoctoproject.org/cgit.cgi/poky/commit/?id=50c23e6c26a64b0c04e99abacb61ec00d1abace9 >> >> I've cc'd Andrej in case he can tell us why that was needed? >> >> Cheers, >> >> Richard >> ^ permalink raw reply [flat|nested] 7+ messages in thread
* Re: [PATCH] openssl_1.0: drop unnecessary dependency on makedepend-native 2018-07-31 13:34 ` Andre McCurdy @ 2018-08-01 7:44 ` Andrej Valek 2018-08-01 21:11 ` Andre McCurdy 0 siblings, 1 reply; 7+ messages in thread From: Andrej Valek @ 2018-08-01 7:44 UTC (permalink / raw) To: Andre McCurdy; +Cc: openembedded-core If you are pretty sure, that makedepend command will available after makedepend-native package dropping, I am fine with that. Cheers, Andrej On 07/31/18 15:34, Andre McCurdy wrote: > On Tue, Jul 31, 2018 at 3:24 AM, Andrej Valek <andrej.valek@siemens.com> wrote: >> This program is required for "oe_runmake depend" command. It runs >> command in MAKEDEPPROG variable, which is set to makedepend. Makedepend >> consists from makedepend-native package. > > That's what you might guess from casually reading the Makefile. It's > not what actually happens. > >> Cheers, >> Andrej >> >> On 07/31/18 12:08, Richard Purdie wrote: >>> On Mon, 2018-07-30 at 18:28 -0700, Andre McCurdy wrote: >>>> The openssl Configure script will only select standalone makedepend >>>> (vs running "$CC -M") when building with gcc < 3.x or with an Apple >>>> Xcode version which predates the switch to clang (in approx 2010?). >>>> Neither of these cases are possible when building under OE, therefore >>>> the dependency on makedepend-native can be dropped (ie align the >>>> openssl 1.0 recipe with the 1.1 recipe, which has dropped the >>>> makedepend-native dependency already). >>>> >>>> Signed-off-by: Andre McCurdy <armccurdy@gmail.com> >>>> --- >>>> meta/recipes-connectivity/openssl/openssl_1.0.2o.bb | 2 +- >>>> 1 file changed, 1 insertion(+), 1 deletion(-) >>>> >>>> diff --git a/meta/recipes-connectivity/openssl/openssl_1.0.2o.bb >>>> b/meta/recipes-connectivity/openssl/openssl_1.0.2o.bb >>>> index f5d3274..78c8552 100644 >>>> --- a/meta/recipes-connectivity/openssl/openssl_1.0.2o.bb >>>> +++ b/meta/recipes-connectivity/openssl/openssl_1.0.2o.bb >>>> @@ -8,7 +8,7 @@ SECTION = "libs/network" >>>> LICENSE = "openssl" >>>> LIC_FILES_CHKSUM = >>>> "file://LICENSE;md5=f475368924827d06d4b416111c8bdb77" >>>> >>>> -DEPENDS = "makedepend-native hostperl-runtime-native" >>>> +DEPENDS = "hostperl-runtime-native" >>>> DEPENDS_append_class-target = " openssl-native" >>>> >>>> PROVIDES += "openssl10" >>> >>> This was added quite 'recently' in: >>> >>> http://git.yoctoproject.org/cgit.cgi/poky/commit/?id=50c23e6c26a64b0c04e99abacb61ec00d1abace9 >>> >>> I've cc'd Andrej in case he can tell us why that was needed? >>> >>> Cheers, >>> >>> Richard >>> ^ permalink raw reply [flat|nested] 7+ messages in thread
* Re: [PATCH] openssl_1.0: drop unnecessary dependency on makedepend-native 2018-08-01 7:44 ` Andrej Valek @ 2018-08-01 21:11 ` Andre McCurdy 2018-08-02 7:54 ` Andrej Valek 0 siblings, 1 reply; 7+ messages in thread From: Andre McCurdy @ 2018-08-01 21:11 UTC (permalink / raw) To: Andrej Valek; +Cc: openembedded-core On Wed, Aug 1, 2018 at 12:44 AM, Andrej Valek <andrej.valek@siemens.com> wrote: > If you are pretty sure, that makedepend command will available after > makedepend-native package dropping, I am fine with that. I am sure that the makedepend command will NOT be available after removing the makedepend-native dependency. Perhaps the explanation I tried to give in the git commit wasn't as clear as I thought... could you please read it and let me know which part doesn't make sense? > Cheers, > Andrej > > On 07/31/18 15:34, Andre McCurdy wrote: >> On Tue, Jul 31, 2018 at 3:24 AM, Andrej Valek <andrej.valek@siemens.com> wrote: >>> This program is required for "oe_runmake depend" command. It runs >>> command in MAKEDEPPROG variable, which is set to makedepend. Makedepend >>> consists from makedepend-native package. >> >> That's what you might guess from casually reading the Makefile. It's >> not what actually happens. >> >>> Cheers, >>> Andrej >>> >>> On 07/31/18 12:08, Richard Purdie wrote: >>>> On Mon, 2018-07-30 at 18:28 -0700, Andre McCurdy wrote: >>>>> The openssl Configure script will only select standalone makedepend >>>>> (vs running "$CC -M") when building with gcc < 3.x or with an Apple >>>>> Xcode version which predates the switch to clang (in approx 2010?). >>>>> Neither of these cases are possible when building under OE, therefore >>>>> the dependency on makedepend-native can be dropped (ie align the >>>>> openssl 1.0 recipe with the 1.1 recipe, which has dropped the >>>>> makedepend-native dependency already). >>>>> >>>>> Signed-off-by: Andre McCurdy <armccurdy@gmail.com> >>>>> --- >>>>> meta/recipes-connectivity/openssl/openssl_1.0.2o.bb | 2 +- >>>>> 1 file changed, 1 insertion(+), 1 deletion(-) >>>>> >>>>> diff --git a/meta/recipes-connectivity/openssl/openssl_1.0.2o.bb >>>>> b/meta/recipes-connectivity/openssl/openssl_1.0.2o.bb >>>>> index f5d3274..78c8552 100644 >>>>> --- a/meta/recipes-connectivity/openssl/openssl_1.0.2o.bb >>>>> +++ b/meta/recipes-connectivity/openssl/openssl_1.0.2o.bb >>>>> @@ -8,7 +8,7 @@ SECTION = "libs/network" >>>>> LICENSE = "openssl" >>>>> LIC_FILES_CHKSUM = >>>>> "file://LICENSE;md5=f475368924827d06d4b416111c8bdb77" >>>>> >>>>> -DEPENDS = "makedepend-native hostperl-runtime-native" >>>>> +DEPENDS = "hostperl-runtime-native" >>>>> DEPENDS_append_class-target = " openssl-native" >>>>> >>>>> PROVIDES += "openssl10" >>>> >>>> This was added quite 'recently' in: >>>> >>>> http://git.yoctoproject.org/cgit.cgi/poky/commit/?id=50c23e6c26a64b0c04e99abacb61ec00d1abace9 >>>> >>>> I've cc'd Andrej in case he can tell us why that was needed? >>>> >>>> Cheers, >>>> >>>> Richard >>>> ^ permalink raw reply [flat|nested] 7+ messages in thread
* Re: [PATCH] openssl_1.0: drop unnecessary dependency on makedepend-native 2018-08-01 21:11 ` Andre McCurdy @ 2018-08-02 7:54 ` Andrej Valek 0 siblings, 0 replies; 7+ messages in thread From: Andrej Valek @ 2018-08-02 7:54 UTC (permalink / raw) To: Andre McCurdy; +Cc: openembedded-core I have checked it, and it works. MAKEDEPPROG was set to cross-tool and on native site it's set to gcc. So it looks like, that the dependency to makedepend-native package is unneeded. On 08/01/18 23:11, Andre McCurdy wrote: > On Wed, Aug 1, 2018 at 12:44 AM, Andrej Valek <andrej.valek@siemens.com> wrote: >> If you are pretty sure, that makedepend command will available after >> makedepend-native package dropping, I am fine with that. > > I am sure that the makedepend command will NOT be available after > removing the makedepend-native dependency. > > Perhaps the explanation I tried to give in the git commit wasn't as > clear as I thought... could you please read it and let me know which > part doesn't make sense? > >> Cheers, >> Andrej >> >> On 07/31/18 15:34, Andre McCurdy wrote: >>> On Tue, Jul 31, 2018 at 3:24 AM, Andrej Valek <andrej.valek@siemens.com> wrote: >>>> This program is required for "oe_runmake depend" command. It runs >>>> command in MAKEDEPPROG variable, which is set to makedepend. Makedepend >>>> consists from makedepend-native package. >>> >>> That's what you might guess from casually reading the Makefile. It's >>> not what actually happens. >>> >>>> Cheers, >>>> Andrej >>>> >>>> On 07/31/18 12:08, Richard Purdie wrote: >>>>> On Mon, 2018-07-30 at 18:28 -0700, Andre McCurdy wrote: >>>>>> The openssl Configure script will only select standalone makedepend >>>>>> (vs running "$CC -M") when building with gcc < 3.x or with an Apple >>>>>> Xcode version which predates the switch to clang (in approx 2010?). >>>>>> Neither of these cases are possible when building under OE, therefore >>>>>> the dependency on makedepend-native can be dropped (ie align the >>>>>> openssl 1.0 recipe with the 1.1 recipe, which has dropped the >>>>>> makedepend-native dependency already). >>>>>> >>>>>> Signed-off-by: Andre McCurdy <armccurdy@gmail.com> >>>>>> --- >>>>>> meta/recipes-connectivity/openssl/openssl_1.0.2o.bb | 2 +- >>>>>> 1 file changed, 1 insertion(+), 1 deletion(-) >>>>>> >>>>>> diff --git a/meta/recipes-connectivity/openssl/openssl_1.0.2o.bb >>>>>> b/meta/recipes-connectivity/openssl/openssl_1.0.2o.bb >>>>>> index f5d3274..78c8552 100644 >>>>>> --- a/meta/recipes-connectivity/openssl/openssl_1.0.2o.bb >>>>>> +++ b/meta/recipes-connectivity/openssl/openssl_1.0.2o.bb >>>>>> @@ -8,7 +8,7 @@ SECTION = "libs/network" >>>>>> LICENSE = "openssl" >>>>>> LIC_FILES_CHKSUM = >>>>>> "file://LICENSE;md5=f475368924827d06d4b416111c8bdb77" >>>>>> >>>>>> -DEPENDS = "makedepend-native hostperl-runtime-native" >>>>>> +DEPENDS = "hostperl-runtime-native" >>>>>> DEPENDS_append_class-target = " openssl-native" >>>>>> >>>>>> PROVIDES += "openssl10" >>>>> >>>>> This was added quite 'recently' in: >>>>> >>>>> http://git.yoctoproject.org/cgit.cgi/poky/commit/?id=50c23e6c26a64b0c04e99abacb61ec00d1abace9 >>>>> >>>>> I've cc'd Andrej in case he can tell us why that was needed? >>>>> >>>>> Cheers, >>>>> >>>>> Richard >>>>> ^ permalink raw reply [flat|nested] 7+ messages in thread
end of thread, other threads:[~2018-08-02 7:54 UTC | newest] Thread overview: 7+ messages (download: mbox.gz / follow: Atom feed) -- links below jump to the message on this page -- 2018-07-31 1:28 [PATCH] openssl_1.0: drop unnecessary dependency on makedepend-native Andre McCurdy 2018-07-31 10:08 ` Richard Purdie 2018-07-31 10:24 ` Andrej Valek 2018-07-31 13:34 ` Andre McCurdy 2018-08-01 7:44 ` Andrej Valek 2018-08-01 21:11 ` Andre McCurdy 2018-08-02 7:54 ` Andrej Valek
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.