From: Rasmus Villemoes <linux@rasmusvillemoes.dk> To: Nick Desaulniers <ndesaulniers@google.com>, Rasmus Villemoes <linux@rasmusvillemoes.dk>, Andrew Morton <akpm@linux-foundation.org> Cc: Linux ARM <linux-arm-kernel@lists.infradead.org>, Will Deacon <will.deacon@arm.com>, Jason Baron <jbaron@akamai.com>, Nathan Chancellor <natechancellor@gmail.com>, Arnd Bergmann <arnd@arndb.de>, LKML <linux-kernel@vger.kernel.org>, Dan Rue <dan.rue@linaro.org> Subject: Re: [PATCH 11/10] arm64: unbreak DYNAMIC_DEBUG=y build with clang Date: Thu, 2 May 2019 10:57:22 +0200 [thread overview] Message-ID: <dec53053-fa42-7b9d-14c1-61357e1ecc66@rasmusvillemoes.dk> (raw) In-Reply-To: <CAKwvOdkg=Xo_C_hQrnHt-t-RfcDrBYsrBZUwsKjfXSPhkynOHQ@mail.gmail.com> On 30/04/2019 20.22, Nick Desaulniers wrote: > On Mon, Apr 29, 2019 at 10:32 AM Nick Desaulniers > <ndesaulniers@google.com> wrote: >> >> On Fri, Apr 26, 2019 at 12:06 PM Rasmus Villemoes >> <linux@rasmusvillemoes.dk> wrote: >>> >>> Current versions of clang does not like the %c modifier in inline >>> assembly for targets other than x86, so any DYNAMIC_DEBUG=y build >>> fails on arm64. A fix is likely to land in 9.0 (see >>> https://github.com/ClangBuiltLinux/linux/issues/456), but unbreak the >>> build for older versions. >>> >>> Fixes: arm64: select DYNAMIC_DEBUG_RELATIVE_POINTERS >>> Reported-by: Nathan Chancellor <natechancellor@gmail.com> >>> Reported-by: Arnd Bergmann <arnd@arndb.de> >>> Signed-off-by: Rasmus Villemoes <linux@rasmusvillemoes.dk> >>> --- >>> Andrew, please apply and/or fold into 9/10. Andrew, friendly ping. >>> arch/arm64/Kconfig | 2 +- >>> 1 file changed, 1 insertion(+), 1 deletion(-) >>> >>> diff --git a/arch/arm64/Kconfig b/arch/arm64/Kconfig >>> index d0871d523d5d..315992e33b17 100644 >>> --- a/arch/arm64/Kconfig >>> +++ b/arch/arm64/Kconfig >>> @@ -83,7 +83,7 @@ config ARM64 >>> select CRC32 >>> select DCACHE_WORD_ACCESS >>> select DMA_DIRECT_REMAP >>> - select DYNAMIC_DEBUG_RELATIVE_POINTERS >>> + select DYNAMIC_DEBUG_RELATIVE_POINTERS if CC_IS_GCC || CLANG_VERSION >= 90000 >> >> I just landed the fix for this in Clang, I think around the time you >> sent the patch. Should ship in Clang 9. Thanks for unbreaking our >> build. Sorry for breaking it in the first place :-/ Rasmus
WARNING: multiple messages have this Message-ID (diff)
From: Rasmus Villemoes <linux@rasmusvillemoes.dk> To: Nick Desaulniers <ndesaulniers@google.com>, Rasmus Villemoes <linux@rasmusvillemoes.dk>, Andrew Morton <akpm@linux-foundation.org> Cc: Dan Rue <dan.rue@linaro.org>, Arnd Bergmann <arnd@arndb.de>, Will Deacon <will.deacon@arm.com>, LKML <linux-kernel@vger.kernel.org>, Jason Baron <jbaron@akamai.com>, Nathan Chancellor <natechancellor@gmail.com>, Linux ARM <linux-arm-kernel@lists.infradead.org> Subject: Re: [PATCH 11/10] arm64: unbreak DYNAMIC_DEBUG=y build with clang Date: Thu, 2 May 2019 10:57:22 +0200 [thread overview] Message-ID: <dec53053-fa42-7b9d-14c1-61357e1ecc66@rasmusvillemoes.dk> (raw) In-Reply-To: <CAKwvOdkg=Xo_C_hQrnHt-t-RfcDrBYsrBZUwsKjfXSPhkynOHQ@mail.gmail.com> On 30/04/2019 20.22, Nick Desaulniers wrote: > On Mon, Apr 29, 2019 at 10:32 AM Nick Desaulniers > <ndesaulniers@google.com> wrote: >> >> On Fri, Apr 26, 2019 at 12:06 PM Rasmus Villemoes >> <linux@rasmusvillemoes.dk> wrote: >>> >>> Current versions of clang does not like the %c modifier in inline >>> assembly for targets other than x86, so any DYNAMIC_DEBUG=y build >>> fails on arm64. A fix is likely to land in 9.0 (see >>> https://github.com/ClangBuiltLinux/linux/issues/456), but unbreak the >>> build for older versions. >>> >>> Fixes: arm64: select DYNAMIC_DEBUG_RELATIVE_POINTERS >>> Reported-by: Nathan Chancellor <natechancellor@gmail.com> >>> Reported-by: Arnd Bergmann <arnd@arndb.de> >>> Signed-off-by: Rasmus Villemoes <linux@rasmusvillemoes.dk> >>> --- >>> Andrew, please apply and/or fold into 9/10. Andrew, friendly ping. >>> arch/arm64/Kconfig | 2 +- >>> 1 file changed, 1 insertion(+), 1 deletion(-) >>> >>> diff --git a/arch/arm64/Kconfig b/arch/arm64/Kconfig >>> index d0871d523d5d..315992e33b17 100644 >>> --- a/arch/arm64/Kconfig >>> +++ b/arch/arm64/Kconfig >>> @@ -83,7 +83,7 @@ config ARM64 >>> select CRC32 >>> select DCACHE_WORD_ACCESS >>> select DMA_DIRECT_REMAP >>> - select DYNAMIC_DEBUG_RELATIVE_POINTERS >>> + select DYNAMIC_DEBUG_RELATIVE_POINTERS if CC_IS_GCC || CLANG_VERSION >= 90000 >> >> I just landed the fix for this in Clang, I think around the time you >> sent the patch. Should ship in Clang 9. Thanks for unbreaking our >> build. Sorry for breaking it in the first place :-/ Rasmus _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
next prev parent reply other threads:[~2019-05-02 8:57 UTC|newest] Thread overview: 62+ messages / expand[flat|nested] mbox.gz Atom feed top 2019-04-09 21:25 [PATCH 00/10] implement DYNAMIC_DEBUG_RELATIVE_POINTERS Rasmus Villemoes 2019-04-09 21:25 ` Rasmus Villemoes 2019-04-09 21:25 ` Rasmus Villemoes 2019-04-09 21:25 ` [PATCH 01/10] linux/device.h: use unique identifier for each struct _ddebug Rasmus Villemoes 2019-04-09 21:25 ` [PATCH 02/10] linux/net.h: " Rasmus Villemoes 2019-04-09 21:25 ` [PATCH 03/10] linux/printk.h: " Rasmus Villemoes 2019-04-09 21:25 ` [PATCH 04/10] dynamic_debug: introduce accessors for string members of " Rasmus Villemoes 2019-04-09 21:25 ` [PATCH 05/10] dynamic_debug: drop use of bitfields in " Rasmus Villemoes 2019-04-09 21:25 ` [PATCH 06/10] dynamic_debug: introduce CONFIG_DYNAMIC_DEBUG_RELATIVE_POINTERS Rasmus Villemoes 2019-04-09 21:25 ` [PATCH 07/10] dynamic_debug: add asm-generic implementation for DYNAMIC_DEBUG_RELATIVE_POINTERS Rasmus Villemoes 2019-04-09 21:25 ` Rasmus Villemoes 2019-04-09 21:25 ` Rasmus Villemoes 2019-04-09 21:25 ` [PATCH 08/10] x86-64: select DYNAMIC_DEBUG_RELATIVE_POINTERS Rasmus Villemoes 2019-04-10 7:31 ` Ingo Molnar 2019-04-09 21:25 ` [PATCH 09/10] arm64: " Rasmus Villemoes 2019-04-09 21:25 ` Rasmus Villemoes 2019-04-26 9:39 ` Arnd Bergmann 2019-04-26 9:39 ` Arnd Bergmann 2019-04-26 10:05 ` Rasmus Villemoes 2019-04-26 10:05 ` Rasmus Villemoes 2019-04-26 13:00 ` Nathan Chancellor 2019-04-26 13:00 ` Nathan Chancellor 2019-04-26 19:06 ` [PATCH 11/10] arm64: unbreak DYNAMIC_DEBUG=y build with clang Rasmus Villemoes 2019-04-26 19:06 ` Rasmus Villemoes 2019-04-26 19:06 ` [PATCH 12/10] powerpc: " Rasmus Villemoes 2019-04-26 19:06 ` Rasmus Villemoes 2019-04-29 17:34 ` Nick Desaulniers 2019-04-29 17:34 ` Nick Desaulniers 2019-04-26 19:27 ` [PATCH 11/10] arm64: " Rasmus Villemoes 2019-04-26 19:27 ` Rasmus Villemoes 2019-04-26 21:58 ` Konstantin Ryabitsev 2019-04-26 21:58 ` Konstantin Ryabitsev 2019-04-26 22:07 ` Konstantin Ryabitsev 2019-04-26 22:07 ` Konstantin Ryabitsev 2019-04-29 17:32 ` Nick Desaulniers 2019-04-29 17:32 ` Nick Desaulniers 2019-04-30 18:22 ` Nick Desaulniers 2019-04-30 18:22 ` Nick Desaulniers 2019-05-02 8:57 ` Rasmus Villemoes [this message] 2019-05-02 8:57 ` Rasmus Villemoes 2019-04-09 21:25 ` [PATCH 10/10] powerpc: select DYNAMIC_DEBUG_RELATIVE_POINTERS for PPC64 Rasmus Villemoes 2019-04-09 21:25 ` Rasmus Villemoes 2019-04-23 15:37 ` Christophe Leroy 2019-04-23 19:36 ` Andrew Morton 2019-04-23 19:36 ` Andrew Morton 2019-04-24 6:46 ` Rasmus Villemoes 2019-04-24 6:46 ` Rasmus Villemoes 2019-05-06 6:48 ` [PATCH 00/10] implement DYNAMIC_DEBUG_RELATIVE_POINTERS Rasmus Villemoes 2019-05-06 6:48 ` Rasmus Villemoes 2019-05-06 6:48 ` Rasmus Villemoes 2019-05-06 7:05 ` Ingo Molnar 2019-05-06 7:05 ` Ingo Molnar 2019-05-06 7:05 ` Ingo Molnar 2019-05-06 7:34 ` Rasmus Villemoes 2019-05-06 7:34 ` Rasmus Villemoes 2019-05-06 7:34 ` Rasmus Villemoes 2019-05-06 7:48 ` Ingo Molnar 2019-05-06 7:48 ` Ingo Molnar 2019-05-06 7:48 ` Ingo Molnar 2019-05-06 14:48 ` Segher Boessenkool 2019-05-06 14:48 ` Segher Boessenkool 2019-05-06 14:48 ` Segher Boessenkool
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=dec53053-fa42-7b9d-14c1-61357e1ecc66@rasmusvillemoes.dk \ --to=linux@rasmusvillemoes.dk \ --cc=akpm@linux-foundation.org \ --cc=arnd@arndb.de \ --cc=dan.rue@linaro.org \ --cc=jbaron@akamai.com \ --cc=linux-arm-kernel@lists.infradead.org \ --cc=linux-kernel@vger.kernel.org \ --cc=natechancellor@gmail.com \ --cc=ndesaulniers@google.com \ --cc=will.deacon@arm.com \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: linkBe sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.