From: Adrian Hunter <adrian.hunter@intel.com>
To: Kishon Vijay Abraham I <kishon@ti.com>,
Ulf Hansson <ulf.hansson@linaro.org>
Cc: Rob Herring <robh+dt@kernel.org>,
Tony Lindgren <tony@atomide.com>, Sekhar Nori <nsekhar@ti.com>,
Russell King <linux@armlinux.org.uk>,
Ravikumar Kattekola <rk@ti.com>,
linux-mmc@vger.kernel.org, devicetree@vger.kernel.org,
linux-kernel@vger.kernel.org, linux-omap@vger.kernel.org,
linux-arm-kernel@lists.infradead.org
Subject: Re: [PATCH 4/5] mmc: sdhci-omap: Add OMAP SDHCI driver
Date: Thu, 31 Aug 2017 16:02:23 +0300 [thread overview]
Message-ID: <dfe1b4e2-bcb5-c969-efe6-7cddd0eb0bf9@intel.com> (raw)
In-Reply-To: <c7972f00-ef62-1736-822f-ebf6822b6d33@ti.com>
On 30/08/17 16:53, Kishon Vijay Abraham I wrote:
> On Monday 28 August 2017 02:36 PM, Adrian Hunter wrote:
>> On 21/08/17 10:41, Kishon Vijay Abraham I wrote:
>>> +
>>> +static void sdhci_omap_set_clock(struct sdhci_host *host, unsigned int clock)
>>> +{
>>> + struct sdhci_pltfm_host *pltfm_host = sdhci_priv(host);
>>> + struct sdhci_omap_host *omap_host = sdhci_pltfm_priv(pltfm_host);
>>> + unsigned long clkdiv;
>>> +
>>> + if (!clock)
>>> + return;
>>
>> Are you sure you don't want to stop the clock.
>
> There is never a case where the MMC core sends a request to stop the clock.
> Maybe this check is not required at all.
It does when voltage switching e.g. mmc_set_uhs_voltage(), but host drivers
should support the possibility anyway.
WARNING: multiple messages have this Message-ID (diff)
From: adrian.hunter@intel.com (Adrian Hunter)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH 4/5] mmc: sdhci-omap: Add OMAP SDHCI driver
Date: Thu, 31 Aug 2017 16:02:23 +0300 [thread overview]
Message-ID: <dfe1b4e2-bcb5-c969-efe6-7cddd0eb0bf9@intel.com> (raw)
In-Reply-To: <c7972f00-ef62-1736-822f-ebf6822b6d33@ti.com>
On 30/08/17 16:53, Kishon Vijay Abraham I wrote:
> On Monday 28 August 2017 02:36 PM, Adrian Hunter wrote:
>> On 21/08/17 10:41, Kishon Vijay Abraham I wrote:
>>> +
>>> +static void sdhci_omap_set_clock(struct sdhci_host *host, unsigned int clock)
>>> +{
>>> + struct sdhci_pltfm_host *pltfm_host = sdhci_priv(host);
>>> + struct sdhci_omap_host *omap_host = sdhci_pltfm_priv(pltfm_host);
>>> + unsigned long clkdiv;
>>> +
>>> + if (!clock)
>>> + return;
>>
>> Are you sure you don't want to stop the clock.
>
> There is never a case where the MMC core sends a request to stop the clock.
> Maybe this check is not required at all.
It does when voltage switching e.g. mmc_set_uhs_voltage(), but host drivers
should support the possibility anyway.
next prev parent reply other threads:[~2017-08-31 13:09 UTC|newest]
Thread overview: 86+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-08-21 7:41 [PATCH 0/5] mmc: Add OMAP SDHCI driver Kishon Vijay Abraham I
2017-08-21 7:41 ` Kishon Vijay Abraham I
2017-08-21 7:41 ` Kishon Vijay Abraham I
2017-08-21 7:41 ` [PATCH 1/5] mmc: sdhci: Tidy reading 136-bit responses Kishon Vijay Abraham I
2017-08-21 7:41 ` Kishon Vijay Abraham I
2017-08-21 7:41 ` Kishon Vijay Abraham I
2017-08-30 13:13 ` Ulf Hansson
2017-08-30 13:13 ` Ulf Hansson
2017-08-30 13:13 ` Ulf Hansson
2017-08-21 7:41 ` [PATCH 2/5] mmc: sdhci: Add quirk to indicate MMC_RSP_136 has CRC Kishon Vijay Abraham I
2017-08-21 7:41 ` Kishon Vijay Abraham I
2017-08-21 7:41 ` Kishon Vijay Abraham I
2017-08-28 7:57 ` Adrian Hunter
2017-08-28 7:57 ` Adrian Hunter
2017-08-30 13:13 ` Ulf Hansson
2017-08-30 13:13 ` Ulf Hansson
2017-08-30 13:13 ` Ulf Hansson
2017-08-21 7:41 ` [PATCH 3/5] dt-bindings: ti-omap-hsmmc: Document new compatible for sdhci omap Kishon Vijay Abraham I
2017-08-21 7:41 ` Kishon Vijay Abraham I
2017-08-21 7:41 ` Kishon Vijay Abraham I
2017-08-21 14:21 ` Tony Lindgren
2017-08-21 14:21 ` Tony Lindgren
2017-08-22 13:39 ` [PATCH v2 3/5] dt-bindings: sdhci-omap: Add bindings for the sdhci-omap controller Kishon Vijay Abraham I
2017-08-22 13:39 ` Kishon Vijay Abraham I
2017-08-22 13:39 ` Kishon Vijay Abraham I
2017-08-22 17:39 ` Tony Lindgren
2017-08-22 17:39 ` Tony Lindgren
2017-08-23 5:42 ` [PATCH v3 " Kishon Vijay Abraham I
2017-08-23 5:42 ` Kishon Vijay Abraham I
2017-08-23 5:42 ` Kishon Vijay Abraham I
2017-08-23 13:07 ` Ulf Hansson
2017-08-23 13:07 ` Ulf Hansson
2017-08-23 13:07 ` Ulf Hansson
2017-08-23 13:56 ` Kishon Vijay Abraham I
2017-08-23 13:56 ` Kishon Vijay Abraham I
2017-08-23 13:56 ` Kishon Vijay Abraham I
2017-08-24 11:29 ` Ulf Hansson
2017-08-24 11:29 ` Ulf Hansson
2017-08-24 11:29 ` Ulf Hansson
2017-08-29 11:20 ` Kishon Vijay Abraham I
2017-08-29 11:20 ` Kishon Vijay Abraham I
2017-08-29 11:20 ` Kishon Vijay Abraham I
2017-08-29 11:50 ` Sebastian Reichel
2017-08-29 11:50 ` Sebastian Reichel
2017-08-29 11:50 ` Sebastian Reichel
2017-08-29 13:58 ` Tony Lindgren
2017-08-29 13:58 ` Tony Lindgren
2017-08-29 13:58 ` Tony Lindgren
2017-08-29 14:43 ` Tony Lindgren
2017-08-29 14:43 ` Tony Lindgren
2017-08-29 14:43 ` Tony Lindgren
2017-08-29 17:09 ` Rob Herring
2017-08-29 17:09 ` Rob Herring
2017-08-29 17:09 ` Rob Herring
2017-08-29 17:39 ` Tony Lindgren
2017-08-29 17:39 ` Tony Lindgren
2017-08-29 17:39 ` Tony Lindgren
2017-09-05 8:52 ` Kishon Vijay Abraham I
2017-09-05 8:52 ` Kishon Vijay Abraham I
2017-09-05 8:52 ` Kishon Vijay Abraham I
2017-09-05 16:51 ` Tony Lindgren
2017-09-05 16:51 ` Tony Lindgren
2017-09-05 16:51 ` Tony Lindgren
2017-08-29 17:11 ` Rob Herring
2017-08-29 17:11 ` Rob Herring
2017-09-05 8:53 ` Kishon Vijay Abraham I
2017-09-05 8:53 ` Kishon Vijay Abraham I
2017-09-05 8:53 ` Kishon Vijay Abraham I
2017-08-21 7:41 ` [PATCH 4/5] mmc: sdhci-omap: Add OMAP SDHCI driver Kishon Vijay Abraham I
2017-08-21 7:41 ` Kishon Vijay Abraham I
2017-08-21 7:41 ` Kishon Vijay Abraham I
2017-08-28 9:06 ` Adrian Hunter
2017-08-28 9:06 ` Adrian Hunter
2017-08-30 13:53 ` Kishon Vijay Abraham I
2017-08-30 13:53 ` Kishon Vijay Abraham I
2017-08-30 13:53 ` Kishon Vijay Abraham I
2017-08-31 13:02 ` Adrian Hunter [this message]
2017-08-31 13:02 ` Adrian Hunter
2017-09-05 8:57 ` Kishon Vijay Abraham I
2017-09-05 8:57 ` Kishon Vijay Abraham I
2017-09-05 8:57 ` Kishon Vijay Abraham I
2017-08-21 7:41 ` [PATCH 5/5] MAINTAINERS: Add TI OMAP SDHCI Maintainer Kishon Vijay Abraham I
2017-08-21 7:41 ` Kishon Vijay Abraham I
2017-08-21 7:41 ` Kishon Vijay Abraham I
2017-08-28 9:07 ` Adrian Hunter
2017-08-28 9:07 ` Adrian Hunter
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=dfe1b4e2-bcb5-c969-efe6-7cddd0eb0bf9@intel.com \
--to=adrian.hunter@intel.com \
--cc=devicetree@vger.kernel.org \
--cc=kishon@ti.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mmc@vger.kernel.org \
--cc=linux-omap@vger.kernel.org \
--cc=linux@armlinux.org.uk \
--cc=nsekhar@ti.com \
--cc=rk@ti.com \
--cc=robh+dt@kernel.org \
--cc=tony@atomide.com \
--cc=ulf.hansson@linaro.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.