All of lore.kernel.org
 help / color / mirror / Atom feed
From: Jacek Anaszewski <jacek.anaszewski@gmail.com>
To: "Nícolas F. R. A. Prado" <nfraprado@protonmail.com>,
	"Pavel Machek" <pavel@ucw.cz>, "Dan Murphy" <dmurphy@ti.com>,
	"Bjorn Andersson" <bjorn.andersson@linaro.org>,
	"Andy Gross" <agross@kernel.org>,
	"Rob Herring" <robh+dt@kernel.org>
Cc: linux-leds@vger.kernel.org, linux-arm-kernel@lists.infradead.org,
	linux-arm-msm@vger.kernel.org, devicetree@vger.kernel.org,
	Brian Masney <masneyb@onstation.org>, Luca Weiss <luca@z3ntu.xyz>,
	Russell King <linux@armlinux.org.uk>,
	Georgi Djakov <georgi.djakov@linaro.org>,
	linux-kernel@vger.kernel.org, lkcamp@lists.libreplanetbr.org,
	andrealmeid@collabora.com
Subject: Re: [RFC PATCH 1/3] leds: Add driver for QPNP flash led
Date: Sun, 8 Nov 2020 17:52:56 +0100	[thread overview]
Message-ID: <e132bb75-66fb-0cbb-c636-5ef5f279d161@gmail.com> (raw)
In-Reply-To: <20201106165737.1029106-2-nfraprado@protonmail.com>

Hi Nicolas,

We have LED flash class framework since 2015. Please refer to the
following files:

Documentation/leds/leds-class-flash.rst
Documentation/ABI/testing/sysfs-class-led-flash
Documentation/devicetree/bindings/leds/common.yaml
drivers/leds/led-class-flash.c

Thare are also few LED flash drivers in the tree. Since there seems to
be boost feature present on the the device then you might want to
compare drivers/leds/leds-max77693.c with its bindings
Documentation/devicetree/bindings/mfd/max77693.txt (refer to LED part).

Please also remember to include DT bindings patch to your series.

On 11/6/20 5:58 PM, Nícolas F. R. A. Prado wrote:
> Add driver for the QPNP flash LED. It works over SPMI and is part of the
> PM8941 PMIC.
> 
> Signed-off-by: Nícolas F. R. A. Prado <nfraprado@protonmail.com>
> ---
>   drivers/leds/Kconfig     |    9 +
>   drivers/leds/Makefile    |    1 +
>   drivers/leds/leds-qpnp.c | 1351 ++++++++++++++++++++++++++++++++++++++
>   3 files changed, 1361 insertions(+)
>   create mode 100644 drivers/leds/leds-qpnp.c
> 

-- 
Best regards,
Jacek Anaszewski

WARNING: multiple messages have this Message-ID (diff)
From: Jacek Anaszewski <jacek.anaszewski@gmail.com>
To: "Nícolas F. R. A. Prado" <nfraprado@protonmail.com>,
	"Pavel Machek" <pavel@ucw.cz>, "Dan Murphy" <dmurphy@ti.com>,
	"Bjorn Andersson" <bjorn.andersson@linaro.org>,
	"Andy Gross" <agross@kernel.org>,
	"Rob Herring" <robh+dt@kernel.org>
Cc: devicetree@vger.kernel.org, linux-arm-msm@vger.kernel.org,
	Russell King <linux@armlinux.org.uk>,
	linux-kernel@vger.kernel.org, Luca Weiss <luca@z3ntu.xyz>,
	lkcamp@lists.libreplanetbr.org, linux-leds@vger.kernel.org,
	andrealmeid@collabora.com,
	Georgi Djakov <georgi.djakov@linaro.org>,
	linux-arm-kernel@lists.infradead.org,
	Brian Masney <masneyb@onstation.org>
Subject: Re: [RFC PATCH 1/3] leds: Add driver for QPNP flash led
Date: Sun, 8 Nov 2020 17:52:56 +0100	[thread overview]
Message-ID: <e132bb75-66fb-0cbb-c636-5ef5f279d161@gmail.com> (raw)
In-Reply-To: <20201106165737.1029106-2-nfraprado@protonmail.com>

Hi Nicolas,

We have LED flash class framework since 2015. Please refer to the
following files:

Documentation/leds/leds-class-flash.rst
Documentation/ABI/testing/sysfs-class-led-flash
Documentation/devicetree/bindings/leds/common.yaml
drivers/leds/led-class-flash.c

Thare are also few LED flash drivers in the tree. Since there seems to
be boost feature present on the the device then you might want to
compare drivers/leds/leds-max77693.c with its bindings
Documentation/devicetree/bindings/mfd/max77693.txt (refer to LED part).

Please also remember to include DT bindings patch to your series.

On 11/6/20 5:58 PM, Nícolas F. R. A. Prado wrote:
> Add driver for the QPNP flash LED. It works over SPMI and is part of the
> PM8941 PMIC.
> 
> Signed-off-by: Nícolas F. R. A. Prado <nfraprado@protonmail.com>
> ---
>   drivers/leds/Kconfig     |    9 +
>   drivers/leds/Makefile    |    1 +
>   drivers/leds/leds-qpnp.c | 1351 ++++++++++++++++++++++++++++++++++++++
>   3 files changed, 1361 insertions(+)
>   create mode 100644 drivers/leds/leds-qpnp.c
> 

-- 
Best regards,
Jacek Anaszewski

_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel

  reply	other threads:[~2020-11-08 16:53 UTC|newest]

Thread overview: 13+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-11-06 16:58 [RFC PATCH 0/3] Add support for the flash LED on Nexus 5 Nícolas F. R. A. Prado
2020-11-06 16:58 ` Nícolas F. R. A. Prado
2020-11-06 16:58 ` [RFC PATCH 1/3] leds: Add driver for QPNP flash led Nícolas F. R. A. Prado
2020-11-06 16:58   ` Nícolas F. R. A. Prado
2020-11-08 16:52   ` Jacek Anaszewski [this message]
2020-11-08 16:52     ` Jacek Anaszewski
2020-11-14 15:28   ` kernel test robot
2020-11-22  4:44   ` Bjorn Andersson
2020-11-22  4:44     ` Bjorn Andersson
2020-11-06 16:59 ` [RFC PATCH 2/3] ARM: qcom_defconfig: Add QPNP flash LED support Nícolas F. R. A. Prado
2020-11-06 16:59   ` Nícolas F. R. A. Prado
2020-11-06 16:59 ` [RFC PATCH 3/3] ARM: dts: qcom: msm8974-hammerhead: Add support for the flash LED Nícolas F. R. A. Prado
2020-11-06 16:59   ` Nícolas F. R. A. Prado

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=e132bb75-66fb-0cbb-c636-5ef5f279d161@gmail.com \
    --to=jacek.anaszewski@gmail.com \
    --cc=agross@kernel.org \
    --cc=andrealmeid@collabora.com \
    --cc=bjorn.andersson@linaro.org \
    --cc=devicetree@vger.kernel.org \
    --cc=dmurphy@ti.com \
    --cc=georgi.djakov@linaro.org \
    --cc=linux-arm-kernel@lists.infradead.org \
    --cc=linux-arm-msm@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-leds@vger.kernel.org \
    --cc=linux@armlinux.org.uk \
    --cc=lkcamp@lists.libreplanetbr.org \
    --cc=luca@z3ntu.xyz \
    --cc=masneyb@onstation.org \
    --cc=nfraprado@protonmail.com \
    --cc=pavel@ucw.cz \
    --cc=robh+dt@kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.