All of lore.kernel.org
 help / color / mirror / Atom feed
From: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
To: Souradeep Chowdhury <quic_schowdhu@quicinc.com>,
	Andy Gross <agross@kernel.org>,
	Konrad Dybcio <konrad.dybcio@somainline.org>,
	Krzysztof Kozlowski <krzysztof.kozlowski+dt@linaro.org>,
	Bjorn Andersson <andersson@kernel.org>,
	Rob Herring <robh+dt@kernel.org>
Cc: linux-arm-kernel@lists.infradead.org,
	linux-kernel@vger.kernel.org, linux-arm-msm@vger.kernel.org,
	devicetree@vger.kernel.org, Sibi Sankar <quic_sibis@quicinc.com>,
	Rajendra Nayak <quic_rjendra@quicinc.com>
Subject: Re: [PATCH V1 1/4] dt-bindings: sram: qcom,imem: Add Boot Stat region within IMEM
Date: Wed, 22 Mar 2023 17:27:21 +0100	[thread overview]
Message-ID: <e1d53083-82b6-d193-517e-02af281a066a@linaro.org> (raw)
In-Reply-To: <260cf3ae-1acd-c4ac-a42d-4ca848ec5664@quicinc.com>

On 22/03/2023 14:34, Souradeep Chowdhury wrote:
>>
>>> +          - const: qcom,imem-boot_stats
>>
>> No underscores in compatibles. Why this is not SoC specific compatible?
> 
> Ack. The boot_stats module is not specific to a device. It is written to
> read some values from this imem region which is present for almost all 
> QCOM SoCs. So SoC specific compatible is not given in this case.

Yeah, but the generic rule is that we always want SoC specific
compatibles. If this is not specific to a device, then you do not need
anything in DT and just instantiate it from some soc-driver...

Best regards,
Krzysztof


WARNING: multiple messages have this Message-ID (diff)
From: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
To: Souradeep Chowdhury <quic_schowdhu@quicinc.com>,
	Andy Gross <agross@kernel.org>,
	Konrad Dybcio <konrad.dybcio@somainline.org>,
	Krzysztof Kozlowski <krzysztof.kozlowski+dt@linaro.org>,
	Bjorn Andersson <andersson@kernel.org>,
	Rob Herring <robh+dt@kernel.org>
Cc: linux-arm-kernel@lists.infradead.org,
	linux-kernel@vger.kernel.org, linux-arm-msm@vger.kernel.org,
	devicetree@vger.kernel.org, Sibi Sankar <quic_sibis@quicinc.com>,
	Rajendra Nayak <quic_rjendra@quicinc.com>
Subject: Re: [PATCH V1 1/4] dt-bindings: sram: qcom,imem: Add Boot Stat region within IMEM
Date: Wed, 22 Mar 2023 17:27:21 +0100	[thread overview]
Message-ID: <e1d53083-82b6-d193-517e-02af281a066a@linaro.org> (raw)
In-Reply-To: <260cf3ae-1acd-c4ac-a42d-4ca848ec5664@quicinc.com>

On 22/03/2023 14:34, Souradeep Chowdhury wrote:
>>
>>> +          - const: qcom,imem-boot_stats
>>
>> No underscores in compatibles. Why this is not SoC specific compatible?
> 
> Ack. The boot_stats module is not specific to a device. It is written to
> read some values from this imem region which is present for almost all 
> QCOM SoCs. So SoC specific compatible is not given in this case.

Yeah, but the generic rule is that we always want SoC specific
compatibles. If this is not specific to a device, then you do not need
anything in DT and just instantiate it from some soc-driver...

Best regards,
Krzysztof


_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel

  reply	other threads:[~2023-03-22 16:27 UTC|newest]

Thread overview: 44+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2023-03-21 13:51 [PATCH V1 0/4] soc: qcom: boot_stats: Add driver support for boot_stats Souradeep Chowdhury
2023-03-21 13:51 ` Souradeep Chowdhury
2023-03-21 13:51 ` [PATCH V1 1/4] dt-bindings: sram: qcom,imem: Add Boot Stat region within IMEM Souradeep Chowdhury
2023-03-21 13:51   ` Souradeep Chowdhury
2023-03-21 17:31   ` Krzysztof Kozlowski
2023-03-21 17:31     ` Krzysztof Kozlowski
2023-03-22 13:34     ` Souradeep Chowdhury
2023-03-22 13:34       ` Souradeep Chowdhury
2023-03-22 16:27       ` Krzysztof Kozlowski [this message]
2023-03-22 16:27         ` Krzysztof Kozlowski
2023-03-23 13:46         ` Souradeep Chowdhury
2023-03-23 13:46           ` Souradeep Chowdhury
2023-03-21 13:51 ` [PATCH V1 2/4] dt-bindings: soc: qcom,mpm-sleep-counter: Add the dtschema Souradeep Chowdhury
2023-03-21 13:51   ` Souradeep Chowdhury
2023-03-21 17:33   ` Krzysztof Kozlowski
2023-03-21 17:33     ` Krzysztof Kozlowski
2023-03-22 13:46     ` Souradeep Chowdhury
2023-03-22 13:46       ` Souradeep Chowdhury
2023-03-22 16:29       ` Krzysztof Kozlowski
2023-03-22 16:29         ` Krzysztof Kozlowski
2023-03-23 13:49         ` Souradeep Chowdhury
2023-03-23 13:49           ` Souradeep Chowdhury
2023-03-21 17:39   ` Krzysztof Kozlowski
2023-03-21 17:39     ` Krzysztof Kozlowski
2023-03-22 14:02     ` Souradeep Chowdhury
2023-03-22 14:02       ` Souradeep Chowdhury
2023-03-22 16:31       ` Krzysztof Kozlowski
2023-03-22 16:31         ` Krzysztof Kozlowski
2023-03-23 13:51         ` Souradeep Chowdhury
2023-03-23 13:51           ` Souradeep Chowdhury
2023-03-21 13:51 ` [PATCH V1 3/4] soc: qcom: boot_stat: Add Driver Support for Boot Stats Souradeep Chowdhury
2023-03-21 13:51   ` Souradeep Chowdhury
2023-03-21 17:37   ` Krzysztof Kozlowski
2023-03-21 17:37     ` Krzysztof Kozlowski
2023-03-22 13:54     ` Souradeep Chowdhury
2023-03-22 13:54       ` Souradeep Chowdhury
2023-03-22 14:53       ` Krzysztof Kozlowski
2023-03-22 14:53         ` Krzysztof Kozlowski
2023-03-23 13:45         ` Souradeep Chowdhury
2023-03-23 13:45           ` Souradeep Chowdhury
2023-03-24  8:56           ` Krzysztof Kozlowski
2023-03-24  8:56             ` Krzysztof Kozlowski
2023-03-21 13:51 ` [PATCH V1 4/4] MAINTAINERS: Add the entry for boot_stats driver support Souradeep Chowdhury
2023-03-21 13:51   ` Souradeep Chowdhury

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=e1d53083-82b6-d193-517e-02af281a066a@linaro.org \
    --to=krzysztof.kozlowski@linaro.org \
    --cc=agross@kernel.org \
    --cc=andersson@kernel.org \
    --cc=devicetree@vger.kernel.org \
    --cc=konrad.dybcio@somainline.org \
    --cc=krzysztof.kozlowski+dt@linaro.org \
    --cc=linux-arm-kernel@lists.infradead.org \
    --cc=linux-arm-msm@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=quic_rjendra@quicinc.com \
    --cc=quic_schowdhu@quicinc.com \
    --cc=quic_sibis@quicinc.com \
    --cc=robh+dt@kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.